summaryrefslogtreecommitdiffstats
path: root/gin/converter_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Re-land: gin: Use V8 Maybe APIsbashi2015-06-021-10/+7
| | | | | | | | | | | | | | | The previous CL was reverted because it broke layout tests. Cause: GetKeyModifiersFromV8() in test_runner/event_sender.cc passes NULL as v8::Isolate*, which is cleary wrong. Pass blink::mainThreadIsolate() as the other callsites do. BUG=479439 Review URL: https://codereview.chromium.org/1152653004 Cr-Commit-Position: refs/heads/master@{#332312}
* Revert of gin: Use V8 Maybe APIs (patchset #7 id:160001 of ↵bashi2015-05-291-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1106393002/) Reason for revert: Broke layout tests Original issue's description: > gin: Use V8 Maybe APIs > > TEST=gin_unittests > BUG=479439 > > Committed: https://crrev.com/7a6acf6c7d45e24f07781c69249d90967013bbe4 > Cr-Commit-Position: refs/heads/master@{#331923} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479439 Review URL: https://codereview.chromium.org/1161053002 Cr-Commit-Position: refs/heads/master@{#331930}
* gin: Use V8 Maybe APIsbashi2015-05-291-10/+7
| | | | | | | | | TEST=gin_unittests BUG=479439 Review URL: https://codereview.chromium.org/1106393002 Cr-Commit-Position: refs/heads/master@{#331923}
* Reland of "Adding task runner/ message loop to tests that use IsolateHolder."ssid2015-05-071-2/+2
| | | | | | | | | | | | | | | | Reason for reland: Fixed mac build. Original CL: crrev.com/1130433002 For adding v8 heap memory dump provider, the gin::IsolateHolder needs to have a task runner at initialization. The tests which don't initiallize task runner when initialization are changed in this CL to have either the message loop initializaed earlier or a dummy task runner. Refer crrev.com/1088683003 for the dump provider. BUG=476013 TBR=jochen@chromium.org,skyostil@chromium.org Review URL: https://codereview.chromium.org/1129873002 Cr-Commit-Position: refs/heads/master@{#328747}
* gin: Use v8::Local instead of v8::Handle.tfarina2015-05-041-4/+4
| | | | | | | | | | | | | Turns out, Handle is just an alias for Local: https://chromium.googlesource.com/v8/v8.git/+/master/include/v8.h#334 BUG=424445 TEST=gin_unittests R=jochen@chromium.org Review URL: https://codereview.chromium.org/1115273003 Cr-Commit-Position: refs/heads/master@{#328120}
* Replace Handle<> with Local in remaining gin/*deepak.s2015-04-301-1/+1
| | | | | | | | | | Handle is an alias for Local BUG=424445 Review URL: https://codereview.chromium.org/1112923003 Cr-Commit-Position: refs/heads/master@{#327672}
* Convert the few remaining ARRAYSIZE_UNSAFE -> arraysize.viettrungluu2014-10-171-3/+3
| | | | | | | | | | | | | | | | | | | There are still ARRAYSIZE_UNSAFEs in ppapi/tests/test_audio.cc, but it defines it itself, and it might be compiled by some older NaCl toolchain that doesn't support C++11. third_party/npapi/npspy/common/format.cpp also has its own ARRAYSIZE_UNSAFE, but I'm hoping to delete npspy completely.) I'll remove ARRAYSIZE_UNSAFE from base/macro.h separately, since it's quite likely we have deps that use our base (and those deps may use it). R=ben@chromium.org TBR=armansito@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/663673002 Cr-Commit-Position: refs/heads/master@{#300034}
* gin: Stop converting float values into integers implicitlyhajimehoshi@chromium.org2014-04-161-1/+1
| | | | | | | | | | This CL is basically revert of https://codereview.chromium.org/195893017/. TEST=layout tests, gin_unittests Review URL: https://codereview.chromium.org/236883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264170 0039d316-1c4b-4281-b951-d872f2087c98
* gin: Automatic conversion from JS number to intgerhajimehoshi@chromium.org2014-03-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Now gin doesn't convert JavaScript double to an integer. This means that gin::Arguments::GetNext() with a pointer of an integer fails when the next arguments is double, and nothing is set to the vairable. IMO this can cause bugs which are hard to understand. It is because on JavaScript side we can't distinguish integer and double, and GetNext() with an integer variable and JS number produces unstable results. For example, In [1], EventSender's mouseMoveTo is called with arguments which can be doubles, not integers, but EventSender::mouseToMove excepts integers. Now EventSender is implemented by CppBoundClass and toInt32 is used explicitly, but now EventSender is being moved to gin, and using GetNext with integer vairables simply will fail. [1] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/fast/events/5056619.html&sq=package:chromium BUG=331301 TEST=gin_unittests --gtest_filter=ConverterTest.Int32 Review URL: https://codereview.chromium.org/195893017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257105 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of deprecate v8::Number constructors from ginjochen@chromium.org2014-01-031-2/+3
| | | | | | | | | TBR=dcarney@chromium.org BUG=none Review URL: https://codereview.chromium.org/109563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242884 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of deprecagted V8 API from gin/jochen@chromium.org2013-11-281-28/+28
| | | | | | | | | | R=mkwst@chromium.org TBR=abarth@chromium.org BUG=324225 Review URL: https://codereview.chromium.org/94413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237750 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the rest of the functions in core.cc to use CreateFunctionTemplate.aa@chromium.org2013-11-271-4/+8
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/89723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237492 0039d316-1c4b-4281-b951-d872f2087c98
* [gin] add support for non-gin managed isolates in gin.jochen@chromium.org2013-11-221-1/+1
| | | | | | | | | BUG=317398 R=abarth@chromium.org,aa@chromium.org Review URL: https://codereview.chromium.org/82963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236766 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a Gin class instead of using global functions to control ginjochen@chromium.org2013-11-191-7/+8
| | | | | | | | | | | | | | | | | | The Gin class holds and controls a v8::Isolate. The isolate is not entered by default, i.e. before you can use gin for a given Gin instance, you need to enter the isolate first, e.g. by using a v8::Isolate::Scope. This has the advantage that we don't rely on the deprecate default isolate, and also support having multiple isolates in one process. BUG=317398 R=abarth@chromium.org TEST=gin_unittests and mojo_js_bindings_unittests pass Review URL: https://codereview.chromium.org/76353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236029 0039d316-1c4b-4281-b951-d872f2087c98
* This CL introduces a lightweight bindings system for V8 called ginabarth@chromium.org2013-11-101-0/+128
Unlike the extensions V8 bindings, gin is based on ObjectTemplates rather than on evaluating script. Unlike the Blink V8 bindings, gin isn't tightly coupled to Blink. In fact, gin's only link-time dependency is V8. We plan to use gin to build the V8 bindings for Mojo (see https://codereview.chromium.org/59153005/ for an example of how they will be used). In the long term, gin could serve as a basis for both the Blink and the extension system bindings, but we don't have any immediate plans to pursue that use of this code. This code is largely inspired by a lightweight bindings system designed by Aaron Boodman. Review URL: https://codereview.chromium.org/67763002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234160 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 10:34:56 +0000