summaryrefslogtreecommitdiffstats
path: root/gin
Commit message (Collapse)AuthorAgeFilesLines
* Replace hidden values with private symbols in mojo and ginjochen2015-11-061-5/+10
| | | | | | | | | | | | Private symbols are ES6 symbols that can't be observed from JavaScript. We will soon remove support for hidden values. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/1418513021 Cr-Commit-Position: refs/heads/master@{#358408}
* [tracing] Fix the total size of V8 for debug modessid2015-11-051-0/+12
| | | | | | | | | | | | | V8 makes resident all the memory it mmaps, filling it with 0xdeadbeef for debug. But the dump provider only displays the live memory as total, while it is supposed to display the resident size. This CL fixes this to display correct resident size depending on the zapping. BUG=546492 Review URL: https://codereview.chromium.org/1427513002 Cr-Commit-Position: refs/heads/master@{#357989}
* Reland Reland Reland Switch Chrome Android using v8 arch specific external ↵michaelbai2015-11-031-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | data name This patch changed all android GN target which use v8 snapshot files as of it being prepared. origin patch https://codereview.chromium.org/1422793004/ This patch also fix package_resource.py issue that asset's renaming didn't trigger the packaging. origin patch https://codereview.chromium.org/1417753004/ Switch Chrome Android using v8 arch specific external data name For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. This patch also removed the existing v8 startup data in destination directory by using copy_ex to remove directory first. BUG=540788, 547235 TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/1411283009 Cr-Commit-Position: refs/heads/master@{#357577}
* Revert of Reland Reland Switch Chrome Android using v8 arch specific ↵sammc2015-11-031-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | external data name (patchset #9 id:180001 of https://codereview.chromium.org/1422793004/ ) Reason for revert: Looks like it caused Android GN net_unittests to crash: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/31886/steps/net_unittests/logs/stdio; suspect it's crashing a ProxyResolverV8 test. Original issue's description: > Reland Reland Switch Chrome Android using v8 arch specific external data name > > This patch also fix package_resource.py issue that asset's > renaming didn't trigger the packaging. > > origin patch > https://codereview.chromium.org/1417753004/ > > Switch Chrome Android using v8 arch specific external data name > > For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. > For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. > > This patch also removed the existing v8 startup data in > destination directory by using copy_ex to remove directory > first. > > BUG=540788,547235 > > TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org > > Committed: https://crrev.com/02d6496adfb377afc0708e53cd0c8118c0591f99 > Cr-Commit-Position: refs/heads/master@{#357480} TBR=jbudorick@chromium.org,miguelg@chromium.org,michaelbai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540788,547235 Review URL: https://codereview.chromium.org/1432553003 Cr-Commit-Position: refs/heads/master@{#357523}
* Reland Reland Switch Chrome Android using v8 arch specific external data namemichaelbai2015-11-031-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | This patch also fix package_resource.py issue that asset's renaming didn't trigger the packaging. origin patch https://codereview.chromium.org/1417753004/ Switch Chrome Android using v8 arch specific external data name For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. This patch also removed the existing v8 startup data in destination directory by using copy_ex to remove directory first. BUG=540788,547235 TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/1422793004 Cr-Commit-Position: refs/heads/master@{#357480}
* [tracing] Add names to memory-infra dumpers for debuggingprimiano2015-10-301-1/+1
| | | | | | | | | | | | | | | | | Follow-up CL to crrev.com/1425793002. Adds an extra |name| argument to the memory-infra RegisterDumpProvider methods. This allow to see the names of the dump providers in the trace and diagnose dump providers getting stuck or taking more time than usual. No further behavioral change is introduced by this CL. BUG=547764 TBR=xhwang@chromium.org,simonhatch@chromium.org,jochen@chromium.org,shess@chromium.org,piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1406213005 Cr-Commit-Position: refs/heads/master@{#357089}
* Revert of Reland Switch Chrome Android using v8 arch specific external data ↵jbudorick2015-10-231-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | name (patchset #3 id:40001 of https://codereview.chromium.org/1417753004/ ) Reason for revert: broke gpu bots: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/3712 Original issue's description: > Orignal patch > https://codereview.chromium.org/1400953002/ > > Switch Chrome Android using v8 arch specific external data name > > For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. > For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. > > This patch also removed the existing v8 startup data in > destination directory by using copy_ex to remove directory > first. > > BUG=540788 > TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org > > Committed: https://crrev.com/ed31140dee44c06e6398e92e1afb9c047c9137e6 > Cr-Commit-Position: refs/heads/master@{#355843} TBR=michaelbai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540788 Review URL: https://codereview.chromium.org/1421893002 Cr-Commit-Position: refs/heads/master@{#355877}
* Orignal patchmichaelbai2015-10-231-0/+11
| | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1400953002/ Switch Chrome Android using v8 arch specific external data name For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. This patch also removed the existing v8 startup data in destination directory by using copy_ex to remove directory first. BUG=540788 TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/1417753004 Cr-Commit-Position: refs/heads/master@{#355843}
* GN: Fix references to $root_build_dir/natives_blob.bin -> $root_out_diragrieve2015-10-231-2/+2
| | | | | | | | | | | root_build_dir == root_out_dir in all of these contexts anyways, but this is more correct. BUG= Review URL: https://codereview.chromium.org/1410643013 Cr-Commit-Position: refs/heads/master@{#355725}
* Revert of Switch Chrome Android using v8 arch specific external data name ↵dalecurtis2015-10-231-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #5 id:80001 of https://codereview.chromium.org/1400953002/ ) Reason for revert: Looks to have broken various Android Mojo tests: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=31621 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20GN&number=31622 Original issue's description: > Switch Chrome Android using v8 arch specific external data name > > For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. > For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. > > This patch also removed the existing v8 startup data in > destination directory by using copy_ex to remove directory > first. > > BUG=540788 > > Committed: https://crrev.com/979b03a19f63b1cbe02fa3df99707c3f93f7c9cf > Cr-Commit-Position: refs/heads/master@{#355680} TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org,jam@chromium.org,michaelbai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540788 Review URL: https://codereview.chromium.org/1419673008 Cr-Commit-Position: refs/heads/master@{#355697}
* Switch Chrome Android using v8 arch specific external data namemichaelbai2015-10-221-0/+11
| | | | | | | | | | | | | | | For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. This patch also removed the existing v8 startup data in destination directory by using copy_ex to remove directory first. BUG=540788 Review URL: https://codereview.chromium.org/1400953002 Cr-Commit-Position: refs/heads/master@{#355680}
* Move v8_use_external_startup_data out of //build/config:feature_flags.dpranke2015-10-211-0/+2
| | | | | | | | | | | | | | | | | | This CL removes the global define of V8_USE_EXTERNAL_STARTUP_DATA from the list in //build/config:feature_flags, and updates the individual call sites to use the definition as appropriate. By making this change, //build/config will not need to import //build_overrides/v8.gni, and that will make it easier for other projects that use GN to use //build without needing to create a v8 overrides file. R=brettw@chromium.org BUG=541791 Review URL: https://codereview.chromium.org/1413893003 Cr-Commit-Position: refs/heads/master@{#355401}
* Move //build/module_args/v8.gni to //build_overrides.dpranke2015-10-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | The original intent of the build/module_args directory was to provide a place where different repos could customize settings as needed depending on their dependencies and needs. However, given that you can't really yet embed GN by just deps-ing in //build/config and //build/toolchain, you end up needing to deps-in all of build, and so there was no good way to have different settings per-repo in //build/module_args. This CL changes the approach such that we will have an additional top-level directory called //build_overrides, which is therefore separate from //build and can be properly customized. It is unfortunate that we need to use two top-level directories for GN, but we don't have a good alternative at this time. Once we can remove the GYP build and further clean up the structure and dependencies of //build we will hopefully be able to do better. R=brettw@chromium.org BUG=541791 Review URL: https://codereview.chromium.org/1397493004 Cr-Commit-Position: refs/heads/master@{#353690}
* [tracing] Non-functional refactor of memory dump arg namesprimiano2015-09-142-3/+2
| | | | | | | | | | | | | | | | This CL is just cleaning up the inconsistencies accumulated w.r.t. of names used in the TraceConfig vs enum names in the codebase. Also this simplifies the complex and unnecessary wrapping in of the level of details argument in the RequestGlobalMemoryDump() API. BUG= TBR=jochen@chromium.org,reed@google.com Review URL: https://codereview.chromium.org/1337943003 Cr-Commit-Position: refs/heads/master@{#348715}
* Memory-infra: Change "objects_count" to "object_count" in category name.bratell2015-09-101-1/+1
| | | | | | | | | TBR=thakis@chromium.org BUG= Review URL: https://codereview.chromium.org/1334673004 Cr-Commit-Position: refs/heads/master@{#348166}
* [tracing] Consolidate v8 reporting in memory-infraprimiano2015-09-091-12/+23
| | | | | | | | | | | | | | | | | | The overall plan is to make it so that all the memory-infra dumpers report, in the "size" column, an estimation of amount of resident memory that is causing pressure to the system. Before this CL the v8 dumper was reporting the virtual memory size, which is generally higher that the actual resident memory. This CL normalizes the situation. Also, the detailed dump about the heap objects at last GC is renamed to reflect the information, in lack of a better solution (see crbug.com/498779). BUG=481504,476013 Review URL: https://codereview.chromium.org/1307173008 Cr-Commit-Position: refs/heads/master@{#347947}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-0/+1
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* [Android WebView] Make loading of V8 data compatible with child servicesmnaganov2015-08-251-0/+6
| | | | | | | | | | | | | | | | 1. Check for the process type when registering apk assets. 2. Fix Gin V8 initializer to allow retrieving of fd & region of the mapped V8 files inside child_process_launcher. 3. There is no need to map icudtl specifically from WebView code since http://crrev.com/335261 BUG=522205 Review URL: https://codereview.chromium.org/1301003002 Cr-Commit-Position: refs/heads/master@{#345362}
* Remove remaining legacy SplitString calls.brettw2015-08-121-2/+2
| | | | | | | | TBR=zelidrag@chromium.org (chromeos) Review URL: https://codereview.chromium.org/1284833004 Cr-Commit-Position: refs/heads/master@{#342983}
* [tracing] Add light dumps in the V8 dump providerssid2015-08-072-2/+9
| | | | | | | | | | | This CL updates the V8 dump provider to dump only totals of the heap when a light dump is requested. BUG=499731 Review URL: https://codereview.chromium.org/1266003003 Cr-Commit-Position: refs/heads/master@{#342471}
* [tracing] Mechanical rename of LevelOfDetail enum to enum class.ssid2015-08-071-1/+1
| | | | | | | | | | | | This CL changes the LevelOfDetail enum to enum class to make it easier to read the code. TBR=jochen@chromium.org BUG=499731 Review URL: https://codereview.chromium.org/1273413002 Cr-Commit-Position: refs/heads/master@{#342404}
* [tracing] Introduce MemoryDumpArgs to enable light and heavy dumpsssid2015-08-063-1/+8
| | | | | | | | | | | | | | | | The memory dump providers dump a lot of details at each dump which causes the trace size to be huge. So, this CL introduces MemoryDumpArgs that will be passed to each DumpProvider as an argument of OnMemoryDump. The args specify a high or low level of detail. This provides a means to request a light or heavy dump from the providers when necessary. TBR=reed@google.com, jam@chromium.org BUG=499731 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1262333005 Cr-Commit-Position: refs/heads/master@{#342103}
* Add more isolates to the GN build:dpranke2015-07-241-0/+7
| | | | | | | | | | | | | | | | | | | | This patches adds the right data and data_deps annotations, and the buildbot mappings needed for: - app_list_unittests - app_shell_unittests (partially, there are issues still) - aura_unittests - cast_unittests - ui_touch_selection_unittests - wm_unittests R=brettw@chromium.org BUG=504079 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel Review URL: https://codereview.chromium.org/1246843003 Cr-Commit-Position: refs/heads/master@{#340341}
* Implement posting idle tasks in gin.ulan2015-07-208-1/+64
| | | | | | | | | | This CL depends on "Add IdleTask API to v8::Platform." (https://codereview.chromium.org/1225713003/) BUG=chromium:490559 Review URL: https://codereview.chromium.org/1241633002 Cr-Commit-Position: refs/heads/master@{#339433}
* Roll PDFium d1b0a8d:acf0647jochen2015-07-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | cc8b4d8 Make v8 embedder data slot configurable 281d1d2 Flip the shut down order in tests. 5b4f57c Make ContentStreamParser members private, fix constructor bf45988 Add a null pointer check to CPDF_CalRGB::v_Load(). e3db14f Kill Func_Renderpage global function pointer, it never changes. 97dd3fe Revert "Add test case for parsing endobj keywords." by Tom Sepez - 14 hours ago 5bd88ec Add test case for parsing endobj keywords. by Tom Sepez - 15 hours ago acf0647 Add missing reinterpret_cast from void to v8::Isolate 8ccc206 Revert "Pump the v8 message loop in tests" 1c79928 Plumb in an externally created v8::Isolate 3045780 Pump the v8 message loop in tests 7592479 Move extern cmap declarations from .cpp files into new .h files. dacc22c Move FPDFAPI_FlateInit() prototype and friends to .h file 0c96176 Tighten up DEPS include rules. BUG=none R=tsepez@chromium.org,ulan@chromium.org Review URL: https://codereview.chromium.org/1229403003 Cr-Commit-Position: refs/heads/master@{#339014}
* Move JoinString to the base namespace.brettw2015-07-151-1/+1
| | | | | | | | | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 Cr-Commit-Position: refs/heads/master@{#338762} patch from issue 1223153003 at patchset 160001 (http://crrev.com/1223153003#ps160001) BUG= Review URL: https://codereview.chromium.org/1230243005 Cr-Commit-Position: refs/heads/master@{#338819}
* Revert of Move JoinString to the base namespace (patchset #9 id:160001 of ↵hongchan2015-07-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1223153003/) Reason for revert: The compilation failure with the following error message: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common.chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=241602-3 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_LEGACY_SKPOINT3_CTORS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DLIBXML_STATIC -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../net/third_party/nss/ssl -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -Igen/ui/resources -Igen/extensions -Igen/extensions/strings -I../../third_party/re2 -Igen/policy -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wexit-time-destructors -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common.chrome_content_client.o ../../chrome/common/chrome_content_client.cc:193:34: error: no matching function for call to 'JoinString' std::string codec_string = base::JoinString( ^~~~~~~~~~~~~~~~ Original issue's description: > Move JoinString to the base namespace. > > Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. > > Update callers who pass empty separators to use a base::StringPiece() > > Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). > > TBR=zelidrag@chromium.org for chromeos > > Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 > Cr-Commit-Position: refs/heads/master@{#338762} TBR=jam@chromium.org,zelidrag@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1237873004 Cr-Commit-Position: refs/heads/master@{#338770}
* Move JoinString to the base namespace.brettw2015-07-141-1/+1
| | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Review URL: https://codereview.chromium.org/1223153003 Cr-Commit-Position: refs/heads/master@{#338762}
* Check whether the handle returned by PeekNext() is empty before accessing itjochen2015-07-132-2/+4
| | | | | | | | | BUG=507625 R=haraken@chromium.org Review URL: https://codereview.chromium.org/1232343004 Cr-Commit-Position: refs/heads/master@{#338480}
* Reland "Implement V8Platform::CallDelayedOnForegroundThread. (patchset #2 ↵ulan2015-06-242-0/+11
| | | | | | | | | | | | id:20001 of https://codereview.chromium.org/1181113003/)" This reverts commit f4f00c7a28bb5786f5dce52acf4e8bd2d39df6a2. BUG=490559 Review URL: https://codereview.chromium.org/1204873003 Cr-Commit-Position: refs/heads/master@{#335937}
* Load V8 startup data directly from the APK on Android.agrieve2015-06-191-18/+22
| | | | | | | | | | Startup data files are now stored uncompressed within the .apk, increasing size of the apk, but decreasing total disk requirements (since they don't need to be extracted). BUG=394502 Review URL: https://codereview.chromium.org/1156873002 Cr-Commit-Position: refs/heads/master@{#335271}
* Additional diagnostics for http://crbug.com/501799.oth2015-06-191-0/+26
| | | | | | | | BUG=501799 Review URL: https://codereview.chromium.org/1174263003 Cr-Commit-Position: refs/heads/master@{#335256}
* Take 2: Moved logic for mapping child process FDs for ICU and V8 into ↵agrieve2015-06-192-72/+93
| | | | | | | | | | | | | | | | | | child_process_launcher.cc Used to be defined in each app's ContentBrowserClient, but since content/ is the one that receives the FDs, it makes sense that it should be the one to send them. This also removes ChildProcessLauncher::AppendMappedFileCommandLineSwitches as it is no longer needed. Changes MemoryMappedFile::Region to be a POD so that it doesn't create require static initializers. BUG=394502 Review URL: https://codereview.chromium.org/1185973003 Cr-Commit-Position: refs/heads/master@{#335207}
* Remove unnecessary message_loop_proxy.h includesskyostil2015-06-171-1/+0
| | | | | | | | | BUG=465354 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1165333003 Cr-Commit-Position: refs/heads/master@{#334844}
* Revert of Implement V8Platform::CallDelayedOnForegroundThread. (patchset #2 ↵ulan2015-06-172-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/1181113003/) Reason for revert: We need to first roll V8 with empty implementation of the function and then use "override" here. The trick with "virtual" does not work because chromium style checks for "override". Original issue's description: > Implement V8Platform::CallDelayedOnForegroundThread. > > The corresponding change on V8 side: https://codereview.chromium.org/1179153002 > > BUG=490559 > > Committed: https://crrev.com/06c3d1b9b782c2bdb3a4e121819351f95804cea5 > Cr-Commit-Position: refs/heads/master@{#334592} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490559 Review URL: https://codereview.chromium.org/1186173005 Cr-Commit-Position: refs/heads/master@{#334794}
* Revert of Moved logic for mapping child process FDs for ICU and V8 into ↵mek2015-06-162-84/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | child_process_launcher.cc (patchset #20 id:380001 of https://codereview.chromium.org/1182443003/) Reason for revert: Adds new static initializers in http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=4979 # icu_util.cc cc::VertexShaderQuadAA::VertexShaderQuadAA() # icu_util.cc base::MemoryMappedFile::MemoryMappedFile() # icu_util.cc base::i18n::(anonymous namespace)::g_icudtl_region # icu_util.cc base::i18n::(anonymous namespace)::g_icudtl_mapped_file # icu_util.cc operator new(unsigned long) Original issue's description: > Moved logic for mapping child process FDs for ICU and V8 into child_process_launcher.cc > > Used to be defined in each app's ContentBrowserClient, but since > content/ is the one that receives the FDs, it makes sense that it should > be the one to send them. > > This also removes ChildProcessLauncher::AppendMappedFileCommandLineSwitches > as it is no longer needed. > > BUG=394502 > > Committed: https://crrev.com/228414fc8870f88f11ada7512e88ea6999890f56 > Cr-Commit-Position: refs/heads/master@{#334702} TBR=jochen@chromium.org,jam@chromium.org,jungshik@google.com,michaelbai@chromium.org,rmcilroy@chromium.org,thestig@chromium.org,agrieve@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=394502 Review URL: https://codereview.chromium.org/1187213002 Cr-Commit-Position: refs/heads/master@{#334719}
* Moved logic for mapping child process FDs for ICU and V8 into ↵agrieve2015-06-162-61/+84
| | | | | | | | | | | | | | | | | child_process_launcher.cc Used to be defined in each app's ContentBrowserClient, but since content/ is the one that receives the FDs, it makes sense that it should be the one to send them. This also removes ChildProcessLauncher::AppendMappedFileCommandLineSwitches as it is no longer needed. BUG=394502 Review URL: https://codereview.chromium.org/1182443003 Cr-Commit-Position: refs/heads/master@{#334702}
* Implement V8Platform::CallDelayedOnForegroundThread.ulan2015-06-162-0/+13
| | | | | | | | | | The corresponding change on V8 side: https://codereview.chromium.org/1179153002 BUG=490559 Review URL: https://codereview.chromium.org/1181113003 Cr-Commit-Position: refs/heads/master@{#334592}
* Remove remaining use of the deprecated MessageLoopProxyskyostil2015-06-123-8/+7
| | | | | | | | | | | | | This patch removes the remaining usage of MessageLoopProxy outside base/. Note that there are still some call sites for Thread::message_loop_proxy() and MessageLoop::message_loop_proxy() which will be cleaned up separately. BUG=465354 Review URL: https://codereview.chromium.org/1169923009 Cr-Commit-Position: refs/heads/master@{#334198}
* Fixing v8 dump provider to remove empty dumps and refactoring the dumper.ssid2015-06-122-73/+58
| | | | | | | | | | | | | | | | | The V8 memory dump had heap_objects dump even when the --track_gc_object_stats was turned off, as empty dumps. This CL removes empty ones and refactors code for doing so. Also removing available size attribute from memory dumps for tracing. The available size doesn't return accurate value because the freelist size depends on the phase of sweeping. Taking the statistics at a random dump point will give arbitrary results. So this field is removed now. BUG=481504 Review URL: https://codereview.chromium.org/1173653002 Cr-Commit-Position: refs/heads/master@{#334178}
* Reland: Plugin Placeholders: Refactor for platforms that don't support pluginstommycli2015-06-113-81/+21
| | | | | | | | | | | | | | | This patch removes a lot of plugin placeholder code from builds that don't support plugins (enable_plugins==0). This is a reland of https://codereview.chromium.org/1126073003/. See patchsets for fixes of the crashes. BUG=493889 TBR= Review URL: https://codereview.chromium.org/1161923004 Cr-Commit-Position: refs/heads/master@{#334054}
* Allow startup with missing V8 snapshot file.erikcorry2015-06-087-119/+173
| | | | | | | | | | | | | | | | | | We want to stop shipping the snapshot file, and instead we want to generate it on the client. This will reduce the download size. But since snapshot generation will be asynchronous in a utility process, it might not be present on the first few runs of the browser. This means we have to be able to start up without the snapshot file (just with the natives source file). This CL fixes Blink to cope with a missing snapshot file (V8 could already cope). R=rmcilroy@chromium.org, sky@chromium.org BUG= Review URL: https://codereview.chromium.org/1164483003 Cr-Commit-Position: refs/heads/master@{#333258}
* Adding object counts to v8 memory dump provider.ssid2015-06-046-22/+127
| | | | | | | | | | | | | | | This CL adds the v8 heap object counts recorded from the previous GC into chrome://tracing. This is the second part of adding v8 heap memory statistics into tracing. Note: Chrome should be run with --js-flags='--track_gc_object_stats --noincremental-marking' for object tracking. BUG=476013 Review URL: https://codereview.chromium.org/1131263005 Cr-Commit-Position: refs/heads/master@{#332884}
* Replace more ObserverList with base::ObserverList.brettw2015-06-031-1/+1
| | | | | | | | | | | | This is everything but the chrome directory CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=zelidrag@chromium.org (chromeos) TBR=keybuk@chromium.org (device/bluetooth) Review URL: https://codereview.chromium.org/1162943002 Cr-Commit-Position: refs/heads/master@{#332626}
* Fix for DCHECK failure at startup of gin_shell.kolczyk2015-06-031-1/+2
| | | | | | | | | | | | | It was introduced by rewriting code to use SingeThreadTaskRunner instead of MessageLoopProxy. Reproduces with gin_unittests too. BUG= Review URL: https://codereview.chromium.org/1153473009 Cr-Commit-Position: refs/heads/master@{#332597}
* Re-land: gin: Use V8 Maybe APIsbashi2015-06-0217-79/+204
| | | | | | | | | | | | | | | The previous CL was reverted because it broke layout tests. Cause: GetKeyModifiersFromV8() in test_runner/event_sender.cc passes NULL as v8::Isolate*, which is cleary wrong. Pass blink::mainThreadIsolate() as the other callsites do. BUG=479439 Review URL: https://codereview.chromium.org/1152653004 Cr-Commit-Position: refs/heads/master@{#332312}
* Reland of Adding total available size of heap in v8 isolate memory dump ↵ssid2015-05-291-4/+6
| | | | | | | | | | | | | | | | | | | | | provider. Reason: Now the API for available sizes is fixed and returns correct value now (crrev.com/1141693003). So, this CL can land now. Original issue's description (crrev.com/1129403003): > Adding total available size of heap in v8 isolate memory dump provider. > > The total available size is now returned by GetHeapStatistics api. > This CL uses the value in the dump provider to show the value in > other_spaces segment of the memory dump. > > BUG=481504 Review URL: https://codereview.chromium.org/1158373002 Cr-Commit-Position: refs/heads/master@{#331952}
* Delete constant declarations from v8_initializer.h that have no definitionsagrieve2015-05-291-4/+0
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1157383004 Cr-Commit-Position: refs/heads/master@{#331950}
* Revert of gin: Use V8 Maybe APIs (patchset #7 id:160001 of ↵bashi2015-05-2917-204/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1106393002/) Reason for revert: Broke layout tests Original issue's description: > gin: Use V8 Maybe APIs > > TEST=gin_unittests > BUG=479439 > > Committed: https://crrev.com/7a6acf6c7d45e24f07781c69249d90967013bbe4 > Cr-Commit-Position: refs/heads/master@{#331923} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479439 Review URL: https://codereview.chromium.org/1161053002 Cr-Commit-Position: refs/heads/master@{#331930}
* gin: Use V8 Maybe APIsbashi2015-05-2917-79/+204
| | | | | | | | | TEST=gin_unittests BUG=479439 Review URL: https://codereview.chromium.org/1106393002 Cr-Commit-Position: refs/heads/master@{#331923}
generated by cgit v1.1 at 2025-03-15 02:15:22 +0000