| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes these tests from unit_tests target and move them into the
not so new google_apis_unittests target.
BUG=257421
TEST=google_apis_unittests
R=joi@chromium.org,thestig@chromium.org
TBR=thestig
Review URL: https://codereview.chromium.org/98283005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds interfaces to OAuth2TokenService::Observer for observing access token request events. The token details section on about:signin-internal is repurposed to display account, token requester, request time and request status of access tokens.
BUG=309106,311414
TBR=benwells@chromium.org,brettw@chromium.org,rlarocque@chromium.org,gene@chromium.org,bauerb@chromium.org,ajwong@chromium.org,zea@chromium.org,ben@chromium.org,mnissler@chromium.org,nkostylev@chromium.org
Review URL: https://codereview.chromium.org/64853006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
google_apis/, gpu/, ipc/, media/, net/ to use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/112963005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
printing/, remoting/, rlz/, sync/, ui/ to use the base:: namespace.
BUG=88666
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/116433007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=308318,309131,308681
TEST=manual, added MergeSessionTest.MergeSessionThrottle
Review URL: https://codereview.chromium.org/118733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- authentication attempt for invalid OAuth2 refresh token
- authentication of an existing user
BUG=none
TEST=OAuth2.*
Review URL: https://codereview.chromium.org/108663008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Expanded FakeGaia class to cover all other auth related calls.
BUG=none
TEST=OAuth2Test.*
R=rogerta@chromium.org, xiyuan@chromium.org
Review URL: https://codereview.chromium.org/99863007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Show 'Cancel' button on footer bar when SAML is active;
- Add a message on top of sign-in frame when redirected to saml idp page;
- Use logo and padding as signin screen for confirm password and no password
screen;
BUG=307202
EST=Browser tests SamlTest.*.
Review URL: https://codereview.chromium.org/70763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
For details, please refer to the attached bug
BUG=328563, 329016
Review URL: https://codereview.chromium.org/115343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The function should set the load flags to ignore cookies.
BUG=327120
Review URL: https://codereview.chromium.org/98403011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*****************
Reverting the revert. Congrats, the original CL wasn't the cause for the failure; sorry for the mess.
*****************
> Revert 239759 "The comment in base64.h implies that base::Base64..."
>
> > The comment in base64.h implies that base::Base64Encode() can return false, but
> > this cannot happen in practice. Fix the comment.
> >
> > The implementation of Base64Encode() attempts to check for the return value
> > MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> > value. Remove the check.
> >
> > Remove unneeded integer cast.
> >
> > Change the return type to void.
> >
> > BUG=323357
> > TEST=base_unittests, compile all
> > TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/86913002
>
> TBR=ricea@chromium.org
>
> Review URL: https://codereview.chromium.org/101113004
TBR=vadimt@chromium.org
Review URL: https://codereview.chromium.org/111883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> The comment in base64.h implies that base::Base64Encode() can return false, but
> this cannot happen in practice. Fix the comment.
>
> The implementation of Base64Encode() attempts to check for the return value
> MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> value. Remove the check.
>
> Remove unneeded integer cast.
>
> Change the return type to void.
>
> BUG=323357
> TEST=base_unittests, compile all
> TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
>
> Review URL: https://codereview.chromium.org/86913002
TBR=ricea@chromium.org
Review URL: https://codereview.chromium.org/101113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this cannot happen in practice. Fix the comment.
The implementation of Base64Encode() attempts to check for the return value
MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
value. Remove the check.
Remove unneeded integer cast.
Change the return type to void.
BUG=323357
TEST=base_unittests, compile all
TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
Review URL: https://codereview.chromium.org/86913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will now inspect outcome of /ListAccounts call to check if the primary
session SID/LSID cookies got run over by browser session restore process.
For now, the outcome of this test is just reported as a UMA histogram.
BUG=309131
TEST=none
Review URL: https://codereview.chromium.org/103463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I couldn't reproduce the original failure, but the logs look like an
unrelated crash in the login screen code. Before re-enabling, the test
needed some updates after changes to the identity API implementation
in https://codereview.chromium.org/26715002
BUG=chromium:306611
Review URL: https://codereview.chromium.org/103263004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
base namespace.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/102593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves EmptyString*, kWhitespace*, and the UTF 8 Byte Order Marker to the base:: namespace.
Many of them just got changed to a default-constructed string when a reference was not required.
I qualified some string16s with base:: when I was changing adjacent code. I need to do another pass to finish these up.
BUG=
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/89243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=247755,259543
Review URL: https://codereview.chromium.org/69853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=mattm@chromium.org
BUG=315301
Review URL: https://codereview.chromium.org/70633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=315259
Review URL: https://codereview.chromium.org/66403006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Both OAuth2TokenService and ProfileSyncService will now retry on HTTP 500s. Note that ProfileSyncService retries will only kick in if OA2TS gives up after a fixed number of attempts.
BUG=311420
Review URL: https://codereview.chromium.org/61833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move mergesession from SigninManager to reconcilor.
Implement ListAccounts.
Start implementing reconcile action, but still a noop for now.
This CL depends on https://codereview.chromium.org/57103002/
Alan: here is an implementation of the ListAccounts. I also added lots of
DVLOG() to the code. Let me know if you'd rather I took those out and put
in a separate CL.
Hui: please review. This CL adds more functionality to the reconcilor but
its still not complete. However, it enables AC behind the flag for merge
session so you don't need to do that manually.
BUG=305249
Review URL: https://codereview.chromium.org/57363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also changed the token fetcher to return SERVICE_ERROR when
we see an HTTP 400 + custom service error, versus INVALID_GAIA_CREDENTIALS.
R=courage@chromium.org, droger@chromium.org, pavely@chromium.org, rlarocque@chromium.org
TBR=rlarocque@chromium.org
(/invalidation)
BUG=314705
Review URL: https://codereview.chromium.org/57993006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=277149
Review URL: https://codereview.chromium.org/57103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The AccountTracker class fetches gaia IDs for all accounts signed into
Chrome, and calls its observers any time an account is added, removed, or
changes sign-in state.
The IdentityAPI class observes the AccountTracker and routes the events
to listening apps and extensions.
BUG=305830
Review URL: https://codereview.chromium.org/30503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the Android platform does not inform the native code
that new credentials are available. This CL adds the necessary
functionality to fire the required notifications.
* Adds a Java instance of the OAuth2TokenService.
* Adds FireRefreshTokenAvailable().
* Adds support for Java-based observers.
* Adds a BroadcastReceiver to trigger the notification for the
Chrome Shell.
BUG=302143
Review URL: https://codereview.chromium.org/25653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
O2TS.StartRequest
* Removing virtual keyword from OAuth2TokenService.StartRequest
* Introducing virtual CreateRequest in OAuth2TokenService to allow derive classes to control the creation of Requests
* Overriding CreateRequest in DeviceOAuth2TokenService with a wrapper over the Consumer, so that the refresh token can be validated by ValidatingConsumer, before it is passed on to the actual consumer.
BUG=282454
Review URL: https://codereview.chromium.org/23850010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, jamesr@chromium.org, koz@chromium.org, piman@chromium.org, sergeyu@chromium.org, thestig@chromium.org, vitalybuka@chromium.org
TBR=cpu, dmichael, joi, xhwang
Review URL: https://codereview.chromium.org/24579003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, avi@chromium.org, isherman@chromium.org, jamesr@chromium.org, joi@chromium.org, sergeyu@chromium.org, sky@chromium.org, thestig@chromium.org, xhwang@chromium.org
Review URL: https://codereview.chromium.org/24649002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adding account_id as a parameter to public methods, like: StartRequestXX, RefreshTokenIsAvailable, GetRefreshToken, InvalidateToken,
* Updating callers and derived classes,
* Updating cache handling for the OAuth2 access tokens in OAuth2TokenService
BUG=277149
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224031
Review URL: https://chromiumcodereview.appspot.com/23382008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for the benefit of integration tests that need the browser to
interface with GAIA and friends, such as for OAuth2 token minting.
BUG=chromium:243889
R=joi@chromium.org, xiyuan@chromium.org, zelidrag@chromium.org
Review URL: https://codereview.chromium.org/24172005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Making OAuth2TokenService multi-login aware:
> * Adding account_id as a parameter to public methods, like: StartRequestXX, RefreshTokenIsAvailable, GetRefreshToken, InvalidateToken,
> * Updating callers and derived classes,
> * Updating cache handling for the OAuth2 access tokens in OAuth2TokenService
>
> BUG=277149
>
> Review URL: https://chromiumcodereview.appspot.com/23382008
TBR=fgorski@chromium.org
BUG=294624
Review URL: https://codereview.chromium.org/23800008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that most consuming code can actually handle a GURL
return value better. Other consumers can use GURL::Resolve() which
provides nicer semantics for construction URLs that string
concatenation, which had been used before.
BUG=chromium:243889
R=akalin@chromium.org, bauerb@chromium.org, brettw@chromium.org, courage@chromium.org, isherman@chromium.org, rogerta@chromium.org, sail@chromium.org, sky@chromium.org, zelidrag@chromium.org
Review URL: https://codereview.chromium.org/23691043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adding account_id as a parameter to public methods, like: StartRequestXX, RefreshTokenIsAvailable, GetRefreshToken, InvalidateToken,
* Updating callers and derived classes,
* Updating cache handling for the OAuth2 access tokens in OAuth2TokenService
BUG=277149
Review URL: https://chromiumcodereview.appspot.com/23382008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OAuth2TokenService
BUG=268937
TEST=OAuth2TokenServiceTest.SameScopesRequestedForDifferentClients
TBR=tim (for chrome/browser/sync)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221303
Review URL: https://chromiumcodereview.appspot.com/22581003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This collects timing data as well as error codes for initial policy
fetches on Chrome OS. These block Profile creation, so we'd like to
get some insight on how much delay this encurs in the field.
BUG=271321
TEST=Log in to an enrolled device, check chrome://histograms
Review URL: https://chromiumcodereview.appspot.com/23271009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OAuth2TokenService"
This reverts commit 2a0ff28378173300b81b2874736c30a6c48d0029.
Reason: BuildBot Vista fails TokenServiceUpdateClearsCache test.
BUG=
TBR=zelidrag@chromium.org
Review URL: https://codereview.chromium.org/23767004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OAuth2TokenService
BUG=268937
TEST=OAuth2TokenServiceTest.SameScopesRequestedForDifferentClients
TBR=tim (for chrome/browser/sync)
Review URL: https://chromiumcodereview.appspot.com/22581003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The message loop must be run till the end for running clean up tasks.
BUG=279634
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/23481007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for removing the dependency from c/b/google_apis/ to
the chrome/ directory and move the whole directory content
to more componentized, top-level google_api/ directory.
As discussed in http://crbug.com/146989#c28 - #c30, OAuth2TokenSerive,
which is the last dependency, is in fact written sorely using
google_api/ items and hence itself can easily be moved to there.
BUG=264570, 146989
Review URL: https://chromiumcodereview.appspot.com/23202015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=269532
TBR=kinaba@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22571004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=266183
TEST=kiosk tests
Review URL: https://chromiumcodereview.appspot.com/21164006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enterprise Enrollment was still using going through OAuthWrap for
authentication, which is deprecated and shouldn't be used any longer.
The OAuth2 approach is in line with what regular Chrome OS login and
user policy do.
BUG=chromium:238624
TEST=Manual: Chrome OS enterprise enrollment still works.
Review URL: https://chromiumcodereview.appspot.com/19787008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until this CL, TestingProfile had 3 distinct URLRequestContexts it would return to the user: one via profile->GetDefaultStoragePartition()->GetRequestContext(), one via profile->GetRequestContext(), and one via profile->GetResourceContext->GetRequestContext(). All of these had different cookie stores. This CL unified them so they all return the one from profile->GetDefaultStoragePartition()->GetRequestContext(). This correctly mimics how production code works.
Doing this had a bunch of implications:
(1) Removes TestingProfile::CreateRequestContext()/ResetRequestContext()
(2) Changes MockRequestContext to share the URLRequestContext with TestingProfile.
(3) TestingProfile now requires all BrowserThreads.
Point (3) effectively adds TestBrowserThreadBundle into a bunch more spots. Because of that, we also have the following changes:
(a) AshTestBase now has a TestBrowserThreadBundle
(b) Removed a bunch of real threads from tests.
(c) TemplateUrlService has reworked synchronization semantics.
(d) Removed MultiThreadTestHelper.
(e) Added TestingIOThread class + testing API in IOThread to mock out various IO thread tasks which enervated with the new TestBrowserThreadBundle.
TBR=bauerb,brettw,isherman,joth,jyasskin,mattm,mmenke,mnissler,pkasting,rkc,rlp,satorux,tim,xians,joth
BUG=159193
Review URL: https://chromiumcodereview.appspot.com/17127002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions/, google_apis/, gpu/, ipc/, jingle/.
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19607005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Updating OAuth2MintTokenFlow to use access_token instead of refresh_token
* Updating Experimental Identity API and Identity API to fetch access_token for GAIA from ProfileOAuth2TokenService and use that instead of a refresh token
* Updating IdentityAPI to implementOAuth2TokenService::Observer, to clear errors properly when user signs in
* Updating IdentitySigninFlow to remove dependency on TokenService and instead implement OAuth2TokenService::Observer
* Updating and adding tests for Identity API
* Updating ExtensionInstallPrompt to invoke OAuth2MintTokenFlow using the access_token instead of refresh_token
BUG=243737
Review URL: https://chromiumcodereview.appspot.com/18755006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
directories.
BUG=229660
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/18919005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestingProfile was only being used in order to retrieve a
net::TestURLRequestContextGetter. google_apis tests can do this themselves
using a combination of MessageLoop and MessageLoopProxy.
This one more step forward on moving these tests to a google_apis_unittests
target.
BUG=255301
TEST=unit_tests
R=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
google_apis/, gpu/, ipc/, jingle/.
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18156002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209149 0039d316-1c4b-4281-b951-d872f2087c98
|