summaryrefslogtreecommitdiffstats
path: root/google_apis/google_api_keys.cc
Commit message (Collapse)AuthorAgeFilesLines
* Display an infobar on startup when Google API keys are missing.phajdan.jr@chromium.org2013-05-161-0/+15
| | | | | | | | | BUG=158766 R=joi@chromium.org, pkasting@chromium.org Review URL: https://codereview.chromium.org/14766011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200599 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-13/+16
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-091-16/+13
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-13/+16
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* Move stringize_macros to base/strings.brettw@chromium.org2013-01-311-1/+1
| | | | | | | | | | This removes the unused L-string macros in the file. BUG= Review URL: https://codereview.chromium.org/12090083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179926 0039d316-1c4b-4281-b951-d872f2087c98
* Remove temporary keys. See http://chromium.org/developers/how-tos/api-keys.joi@chromium.org2013-01-311-10/+3
| | | | | | | | | BUG=145584 Review URL: https://chromiumcodereview.appspot.com/12091043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179878 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid having two copies of implementation from google_api_keys.ccjoi@chromium.org2013-01-101-0/+2
| | | | | | | | | | | | | | | This fixes a problem that was only happening with some linkers, where the linker would choose the version of functions from google_api_keys.cc that was defined in the google_api_keys_unittest.cc file when that source file got #included at global scope. Thanks to blundell@chromium.org for the report. BUG=None Review URL: https://chromiumcodereview.appspot.com/11819043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176207 0039d316-1c4b-4281-b951-d872f2087c98
* Adding unit tests for google_api_keys functionality.joi@chromium.org2012-09-211-4/+0
| | | | | | | | | | TBR=ben@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10941034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157972 0039d316-1c4b-4281-b951-d872f2087c98
* Check in temporary keys to aid transition.joi@chromium.org2012-09-171-17/+16
| | | | | | | | | TBR=odean@chromium.org BUG=145584 Review URL: https://codereview.chromium.org/10913298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157145 0039d316-1c4b-4281-b951-d872f2087c98
* Auto-detect whether internal keys should be used.joi@chromium.org2012-09-171-7/+26
| | | | | | | | | | | | | Allow overriding to explicitly use or not use internal keys, regardless of what is auto-detected. Fix a bug in the implementation, where the default value was not being used for unset tokens. BUG=145584 Review URL: https://codereview.chromium.org/10933126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157130 0039d316-1c4b-4281-b951-d872f2087c98
* include.gypi variables to specify API keys or use internal header for keys.joi@chromium.org2012-09-131-9/+13
| | | | | | | | BUG=145584 Review URL: https://codereview.chromium.org/10918196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156538 0039d316-1c4b-4281-b951-d872f2087c98
* Add include of internal-only file for official builds.joi@chromium.org2012-09-111-39/+23
| | | | | | | | | | | | | | Remove unused function, and add a few log messages. While I'm updating to match the internal change, add the relevant directory to .gitignore. BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10916238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156132 0039d316-1c4b-4281-b951-d872f2087c98
* Moving google_apis and GaiaClient to src/google_apis.joi@chromium.org2012-09-071-0/+250
TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-11 17:11:27 +0000