| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add ManagedUserTokenFetcher to fetch scoped-down tokens.
>
> TBR=rogerta@chromium.org
> BUG=228833
>
> Review URL: https://chromiumcodereview.appspot.com/15977002
BUG=245241
TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/15675014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta@chromium.org
BUG=228833
Review URL: https://chromiumcodereview.appspot.com/15977002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Deprecate lso-host to replace with lso-url, which is the complete origin (not just the host).
* Allow for http access of gaia-urls, not just https.
* Add data member gaia_url_ and accessor to GaiaUrls, replacing gaia_origin_url_
* Replace javascript params gaiaOrigin and gaiaUrlPath with gaiaUrl.
* Replace SetGaiaOriginForTesting with SetGaiaUrlForTesting.
BUG=239151
TEST=manual with telemetry auth server. on linux and on the device with GAIA_FLAGS="--gaia-url=https://gaiastaging.corp.google.com --lso-url=https://test-sandbox.auth.corp.google.com --google-apis-host=www.googleapis-test.sandbox.google.com --oauth2-client-id=236834563817.apps.googleusercontent.com --oauth2-client-secret=RsKv5AwFKSzNgE0yjnurkPVI"
Review URL: https://chromiumcodereview.appspot.com/14786022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When getAuthToken needs to prompt a user for permissions, it now uses
a web-based authorization flow instead of native dialogs.
BUG=228908
(step #4 of the bug description)
Review URL: https://chromiumcodereview.appspot.com/15148007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158766
R=joi@chromium.org, pkasting@chromium.org
Review URL: https://codereview.chromium.org/14766011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This works around the bug we've had where on some Windows machines, one of the invocations of check_internal.py mysteriously causes a file to open up in Visual Studio. We have no idea why, but this should avoid the problem. See details in bug.
BUG=241208
Review URL: https://chromiumcodereview.appspot.com/12330155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
kGaiaOAuth2Url where used only by Cloud Print code and it was replaced by GaiaUrls. Not it's used only inside of unittest.
BUG=236756
Review URL: https://chromiumcodereview.appspot.com/14623017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/14945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14383023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
token from the policy server. This token will be stored in the device's Local State for use by Cloud Print across all profiles (including Guest and Public Sessions). The new steps that fetch the token during enrollment are optional, so that enrollment will still succeed if a policy server doesn't support robot api tokens.
BUG=164606
Review URL: https://chromiumcodereview.appspot.com/12538009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=92948
Review URL: https://chromiumcodereview.appspot.com/14169010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.
BUG=234765
Review URL: https://codereview.chromium.org/14113028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the plan to make sync sign-in more integral to a user's profile, we're adding an explicit ability to "sign out" of the profile in place of signing out of Google inside the content area. This CL adds that basic sign-out functionality by adding a "sign out" button to the avatar menu that, when clicked, goes through the steps of signing out of Google and closing all browser windows associated with that profile.
Future CLs will do the Right Thing(tm) of requiring sign-in before opening that profile so that the tabs can resume where there were, just as though there had been no sign-out event.
The UI included here is temporary. A new profile-switcher menu is being discussed and the core functionality included here will eventually get triggered from that once the design is finalized. In other words, the UI presented here will eventually be replaced.
See it in action:
https://docs.google.com/a/google.com/file/d/0B4S7cIAPVn9XdzJFZXl2SncxMlE/edit?usp=sharing
Previous avatar menu:
https://docs.google.com/a/google.com/file/d/0B4S7cIAPVn9XY3dZMXRUNGtHd3M/edit?usp=sharing
To test:
- launch with --enable-profile-signout
- create a second profile (so Avatar menu appears)
- sign-in to a Google account (like gmail)
- open Avatar menu and click the "sign out" button
- (window will close when sign-out is complete)
- re-open profile
- go to a Google account
- note that you are not signed in
BUG=
Review URL: https://chromiumcodereview.appspot.com/12726012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Identity.getAuthToken caches access tokens from GAIA. Tokens expirations
are handled automatically, but if an access token goes bad for some other
reason, the application can call identity.invalidateAuthToken to remove
a bad token from the cache.
BUG=228908
(step #1 of the bug description)
Review URL: https://chromiumcodereview.appspot.com/14329014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A number of users have been reporting problems with the identity API. Gaia investigations reveal that these users have overflowed a limit on the number of login tokens they can have for Chrome. Revoking tokens we don't need any longer should mitigate the problem.
This is identical to https://codereview.chromium.org/13249007/ but with a corrected base url.
BUG=224462
Review URL: https://chromiumcodereview.appspot.com/13599003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* added TokenService initialization for kiosk app launch
* wired up kiosk robot account auth file (/home/chronos/kiosk_auth) processing - we can now read value of oauth2 refresh token + client id/secret that will be used for Identity API calls in kiosk mode.
BUG=224129
TEST=manual kiosk test
Review URL: https://chromiumcodereview.appspot.com/12918030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
driven flow.
BUG=181008
TEST=experiments that are in progress
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12704002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes the auth server returns '403 Rate Limit Exceeded' but it is treated as a permanent error and makes Files.app offline-mode. This patch makes '403' treated as a temporary error.
BUG=180830
TEST=Repeat logging-in and opening Files.app 20 times, and confirms the error is not happen.
Review URL: https://codereview.chromium.org/12630010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/12755010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use of StringPrintf now requires prefixing with base:: or a per-scope using directive
TBR'd:
abodenha: chrome/service
brettw: content, third_party, webkit
darin: base, chrome/browser, chrome/renderer
dgarret: courgette
enne: cc
fischmann: media
gbillock: sql
joi: google_apis,components
rsleevi: net, crypto
sky: chrome/test
thestig: printing, chrome/common,
tsepez: ipc
wez: remoting
yfriedman: testing/android
NOTRY=true
R=brettw@chromium.org
TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12767006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LoginFailure::None() to LoginFailureNone() so that they do not clash with None defined in /usr/include/X11/X.h.
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12686006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=175186
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=177721
TEST=existing TokenService unit tests
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12316076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=174637
Review URL: https://chromiumcodereview.appspot.com/12279005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
re-auth.
BUG=171945
TEST=Connect a profile to a given account. Change the password of that
account. Stop and restart chrome. Notice the auth error and try to re-auth.
Make sure that signing in with the same account works, and trying to sign in
with a different account fails with a message indicating which account to use.
Review URL: https://chromiumcodereview.appspot.com/12082125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
TBR=miket
Review URL: https://chromiumcodereview.appspot.com/12245003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This net error occurs frequently during ChromeOS sign-in when tokens are being
fetched, due to network change notifications triggered by the network library,
the portal detector and sometimes proxy configuration changes.
BUG=173671
Review URL: https://chromiumcodereview.appspot.com/12161003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the unused L-string macros in the file.
BUG=
Review URL: https://codereview.chromium.org/12090083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=145584
Review URL: https://chromiumcodereview.appspot.com/12091043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored all OAuth1/2 code out of LoginUtils into OAuthLoginManager class.
Created OAuth2-based specialization of OAuthLoginManager (behind --force-oauth2 switch). This new class uses OAuth2 refresh tokens as a base token from which all others are minted - incl. GAIA credentials and session cookies.
BUG=166192, 169999
TEST=existing unit, browser tests, additional manual testing
TBR=sky
Review URL: https://codereview.chromium.org/11649055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a problem that was only happening with some linkers, where
the linker would choose the version of functions from
google_api_keys.cc that was defined in the google_api_keys_unittest.cc
file when that source file got #included at global scope. Thanks to
blundell@chromium.org for the report.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11819043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used.
BUG=169093
Review URL: https://chromiumcodereview.appspot.com/11829038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=166496
BUG=167187
TBR=joi
Review URL: https://chromiumcodereview.appspot.com/11818045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=168602
TEST=existing unittests
Review URL: https://codereview.chromium.org/11786006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions_downloader.cc (extensions, retail mode AppPack)
gaia_oauth_fetcher.cc
gaia_oauth_client.cc
device_management_service.cc (user/device policy fetches, auto-enrollment)
All of these have been noticed to fail when network change notifications are sent, in particular on ChromeOS.
TBR=jochen
BUG=145021,163710,130602,chromium-os:16114
Review URL: https://codereview.chromium.org/11572044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that error.
BUG=164363
Review URL: https://codereview.chromium.org/11464028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97126
Review URL: https://chromiumcodereview.appspot.com/11367014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
retrieved by the sign in manager instead of having the token service create a
new one.
BUG=156964
TEST=Use the one-click sign in feature and make sure it works correctly.
Try with gmail.com account and with dasher account. Try with accounts that
have 2-factor enabled and disabled. There are no user visible changes from
this CL.
Review URL: https://chromiumcodereview.appspot.com/11290002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously GaiaOAuthClient was accessing its members after calling the
delegate, so it was crashing if the delegate destroys GaiaOAuthClient object.
Second problem this change solves is that it was not possible to call
GetUserInfo() from OnRefreshTokenResponse().
Review URL: https://chromiumcodereview.appspot.com/11271038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The new method allows getting email of the user given an access token.
Review URL: https://chromiumcodereview.appspot.com/11226067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that OWNERS supports per-file owners, we can limit the scope of the
top-level wildcard to just DEPS, and make darin and ben owners for
everything else and remove the broad use of "set noparent".
R=ben@chromium.org, darin@chromium.org
BUG=88315
Review URL: https://codereview.chromium.org/11191038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137118
TEST=See unit tests, not called in any code yet
Review URL: https://chromiumcodereview.appspot.com/11185002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137118
TEST=See unit tests, not called in any code yet
Review URL: https://chromiumcodereview.appspot.com/11091048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
constructor.
TBR=nkostylev@chromium.org
BUG=none
TEST=compile
Review URL: https://chromiumcodereview.appspot.com/11000061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=153453
Review URL: https://chromiumcodereview.appspot.com/11038011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To prevent hitting rate limits on how fast we can access the server to get an
auth token to get a channel Id, we cache the channel Id when we get one.
Note that a channel Id is per profile, so we store them by profile login name.
BUG=149733
Review URL: https://chromiumcodereview.appspot.com/10951022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=150911
Review URL: https://codereview.chromium.org/10966009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159502 0039d316-1c4b-4281-b951-d872f2087c98
|