summaryrefslogtreecommitdiffstats
path: root/google_apis
Commit message (Collapse)AuthorAgeFilesLines
* Rename PrivateMode enum values:rch@chromium.org2014-04-011-1/+1
| | | | | | | | | | | | | | | | | | kPrivacyModeDisabled => PRIVACY_MODE_DISABLED kPrivacyModeEnabled => PRIVACY_MODE_ENABLED To match the chromium style guide: Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. R=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 Review URL: https://codereview.chromium.org/215023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260729 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add support for canary connection attemptszea@chromium.org2014-03-285-84/+190
| | | | | | | | | | | | | | Canary connection attempts occur on network changes, and are capable of bypassing backoff (without resetting it). As such they happen immediately if no connection attempt is already in progress, but if they fail backoff will be increased accordingly. BUG=355126 R=asvitkine@chromium.org, jianli@chromium.org Review URL: https://codereview.chromium.org/213693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Rename PrivateMode enum values: ↵rch@chromium.org2014-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/215023002/) Reason for revert: Broke build. http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/71042/steps/compile/logs/stdio#error1 Original issue's description: > Rename PrivateMode enum values: > > kPrivacyModeDisabled => PRIVACY_MODE_DISABLED > kPrivacyModeEnabled => PRIVACY_MODE_ENABLED > > To match the chromium style guide: > > Though the Google C++ Style Guide now says to use kConstantNaming for enums, > Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. > > R=mef@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 TBR=mef@chromium.org,zea@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/217053010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260296 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PrivateMode enum values:rch@chromium.org2014-03-281-1/+1
| | | | | | | | | | | | | | | | kPrivacyModeDisabled => PRIVACY_MODE_DISABLED kPrivacyModeEnabled => PRIVACY_MODE_ENABLED To match the chromium style guide: Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. R=mef@chromium.org Review URL: https://codereview.chromium.org/215023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260281 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Return cancel closure from FileSystem::GetFileContenthashimoto@chromium.org2014-03-281-11/+0
| | | | | | | | | | | | | | | This change does not fix the bug, just a preparation for the actual fix. No behavior change is intended. Return cancel closure from DownloadOperation and FileSystem. Change user code (SyncClient and DriveFileStreamReader) to use the returned closure. BUG=344789 TEST=unit_tests Review URL: https://codereview.chromium.org/214363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260184 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Make FileResource copyablehashimoto@chromium.org2014-03-283-22/+36
| | | | | | | | | | | To implement FakeDriveService without GData WAPI classes. BUG=334544 TEST=unit_tests Review URL: https://codereview.chromium.org/216433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260182 0039d316-1c4b-4281-b951-d872f2087c98
* Removing myself from OWNERS, as I no longer expect to be active on Chromium.joi@chromium.org2014-03-271-1/+0
| | | | | | | | | | | | | | For //content/port and //content/public, specifying avi@ as an OWNER even though he is also in the higher-level OWNERS file, as he is the remaining intended reviewer (rather than jam@) for less involved changes to the API, as specified in the comments in those files. Removing a comment about CCing myself and erikwright@ from the android_webview file as dependencies there have already been fixed. TBR=darin@chromium.org NOTRY=true BUG=none Review URL: https://codereview.chromium.org/213113007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259977 0039d316-1c4b-4281-b951-d872f2087c98
* Delete some dead code.thakis@chromium.org2014-03-272-24/+0
| | | | | | | | | | | | Found by a tweaked -Wunused-member-function Nuno Lopes is working on. BUG=none R=brettw@chromium.org, miket@chromium.org, rsleevi@chromium.org, sky@chromium.org TBR=rogerta, sky Review URL: https://codereview.chromium.org/213363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259767 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Destroy connection factory on CheckOutzea@chromium.org2014-03-265-64/+139
| | | | | | | | | | | | | Connection factory assumes that the mcs client (in the form of RequestBuilder callback) is still alive, which can result in DCHECKs if not true. Also refactors GCMClientImpl testing to make this testable. BUG=354344 Review URL: https://codereview.chromium.org/208333006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259405 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add port 443 fallback logic and histogramszea@chromium.org2014-03-245-14/+72
| | | | | | | | | | | | | | | Alternate between the default (5228) endpoint and the fallback (443) endpoint. Also introduce histograms for tracking endpoint and proxy success rate. Relanding due to compile issue. Original review: https://codereview.chromium.org/205343003/ BUG=351890 TBR=jianli@chromium.org, fgorski@chromium.org, asvitkine@chromium.org Review URL: https://codereview.chromium.org/206873006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258997 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258720 "[GCM] Add port 443 fallback logic and histograms"cpu@chromium.org2014-03-224-67/+12
| | | | | | | | | | | | | | | | | | | | | This broke linux Clang compile. gcm_tools_mcs_probe.cc line 294 > [GCM] Add port 443 fallback logic and histograms > > Alternate between the default (5228) endpoint and the fallback (443) endpoint. > Also introduce histograms for tracking endpoint and proxy success rate. > > BUG=351890 > > Review URL: https://codereview.chromium.org/205343003 TBR=zea@chromium.org Review URL: https://codereview.chromium.org/209343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258735 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258732 "Revert 258713 "Disable GCMClientImplTest.Register..."cpu@chromium.org2014-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Never mind, it was the other gcm related CL the 258720 one. > Revert 258713 "Disable GCMClientImplTest.RegisterAppFromCache" > > Compile break on Linux Clang at gcm_client_impl_unittest > gcm_tools_mcs_probe.cc line 294 > > > > Disable GCMClientImplTest.RegisterAppFromCache > > > > TBR=zea@chromium.org > > > > Review URL: https://codereview.chromium.org/209293002 > > R=luken@chromium.org > TBR=jianli@chromium.org > > Review URL: https://codereview.chromium.org/208333010 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/196173012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258734 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258713 "Disable GCMClientImplTest.RegisterAppFromCache"cpu@chromium.org2014-03-221-1/+1
| | | | | | | | | | | | | | | | | | | Compile break on Linux Clang at gcm_client_impl_unittest gcm_tools_mcs_probe.cc line 294 > Disable GCMClientImplTest.RegisterAppFromCache > > TBR=zea@chromium.org > > Review URL: https://codereview.chromium.org/209293002 R=luken@chromium.org TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/208333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258732 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add port 443 fallback logic and histogramszea@chromium.org2014-03-224-12/+67
| | | | | | | | | | | Alternate between the default (5228) endpoint and the fallback (443) endpoint. Also introduce histograms for tracking endpoint and proxy success rate. BUG=351890 Review URL: https://codereview.chromium.org/205343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258720 0039d316-1c4b-4281-b951-d872f2087c98
* Disable GCMClientImplTest.RegisterAppFromCachejianli@chromium.org2014-03-221-1/+1
| | | | | | | | TBR=zea@chromium.org Review URL: https://codereview.chromium.org/209293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compiling errors in gcm_store_impl_unittestjianli@chromium.org2014-03-211-3/+3
| | | | | | | | | TBR=vandebo@chromium.org BUG= Review URL: https://codereview.chromium.org/209183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258709 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Move registration info persistence from extension state store to GCM storejianli@chromium.org2014-03-2111-333/+498
| | | | | | | | | | | | | | | This is the effort decouple the extension specific logic from GCMProfileService. Also remove the code to persist user serial number mappings since it is not needed any more. BUG=343268 TEST=tests updated Review URL: https://codereview.chromium.org/207443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258706 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Fix proxy resolution fallbackzea@chromium.org2014-03-191-6/+3
| | | | | | | | | | | An infinite loop of proxy retries could result due to ignoring the error code returned by the fallback code. We now just fail synchronously. BUG=353739 Review URL: https://codereview.chromium.org/196573036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258116 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Adding chrome.gcm.unregister to gcm APIfgorski@chromium.org2014-03-197-63/+68
| | | | | | | | | | | | | | | | * Updating the gcm.json to include chrome.gcm.unregister * Modifying UnregistrationRequest to return proper Status * Modifying callbacks to properly carry status up the stack as GCMClient::Result * Making GCMProfileService.Unregister function public. * Adding tests for chrome.gcm.unregister * Adding test for GCMProfileService.Unregister BUG=351006 Review URL: https://codereview.chromium.org/196133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257888 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Delete old, unused contacts code.derat@chromium.org2014-03-183-219/+0
| | | | | | | | | | | This never got turned on. BUG=350213 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/190063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702) in google_apis/.pkasting@chromium.org2014-03-183-131/+32
| | | | | | | | | | BUG=346399 TEST=none R=mtomasz@chromium.org, rogerta@chromium.org Review URL: https://codereview.chromium.org/203033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257739 0039d316-1c4b-4281-b951-d872f2087c98
* components: Rename encryptor directory to os_crypt.tfarina@chromium.org2014-03-185-6/+6
| | | | | | | | | | | | | | Joi suggested doing this rename in a follow up CL ( https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h#newcode16). So here it is. BUG=341293 TEST=None, no functional changes. R=joi@chromium.org,thestig@chromium.org,bcwhite@chromium.org Review URL: https://codereview.chromium.org/200713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257573 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Incoming GCM message without type should be treated as data messagejianli@chromium.org2014-03-181-1/+1
| | | | | | | | | | BUG=353363 TEST=Manual test by following repro steps R=zea@chromium.org Review URL: https://codereview.chromium.org/200763009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257546 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Check "modificationDate" property of a change before applying ithashimoto@chromium.org2014-03-174-0/+27
| | | | | | | | | | | | | | Updating a locally edited entry with an older change results in unnecessarily overwriting users' edit. Add "modificationDate" field to ChangeResource. (Corresponding API documentation: https://developers.google.com/drive/v2/reference/changes#resource) Request "modificationDate" Use "modificationDate" for conflict resolution in ChangeListProcessor. BUG=350398 Review URL: https://codereview.chromium.org/199343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257384 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add proxy resolution support.zea@chromium.org2014-03-143-35/+204
| | | | | | | | | | | | | | | | | GCM will use the proxy resolver associated with the current network session to resolve proxies. There is no direct fallback at the moment, so if a proxy resolution completes, but doesn't handle the data properly (because it's intercepting/mangling the response), connections will fail. Direct fallback, and attempting alternate ports, will be introduced in a later patch. BUG=351889 TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/197473008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257023 0039d316-1c4b-4281-b951-d872f2087c98
* Add create access token fetcher to OAuthTokenService.msarda@chromium.org2014-03-1311-89/+110
| | | | | | | | | | | | | | This CL add a factory method to create access token fetchers in the OAuth2 token service. This allows subclasses to create specific access token fetchers and re-use the OAuth2 caching logic without duplicating the code. TBR=atwilson, blundell, gene BUG=320625 Review URL: https://codereview.chromium.org/193043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256816 0039d316-1c4b-4281-b951-d872f2087c98
* Remove command-line flags for OAuth scopes.mnissler@chromium.org2014-03-129-42/+13
| | | | | | | | | | | | | There is no reason why one would want to switch to alternate OAuth scopes, because these are identifiers and not URLs to make requests to. BUG=chromium:350299 TBR=bauerb@chromium.org Review URL: https://codereview.chromium.org/190353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256541 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Propagating SendError details all the way to the event.fgorski@chromium.org2014-03-115-50/+98
| | | | | | | | | | | | | OnSendError allows to specify more message content than simply and error message and message ID, but it currently is ignored. This patch fixes that problem by introducing SendErrorDetails structure and updating the whole stack to handle it properly. BUG=350026 Review URL: https://codereview.chromium.org/191443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256187 0039d316-1c4b-4281-b951-d872f2087c98
* Show device information in chrome://gcm-internals page.juyik@chromium.org2014-03-076-0/+81
| | | | | | | | | | OWNER reviewer: arv BUG=341256 Review URL: https://codereview.chromium.org/176823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255692 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow the senders that the application is currently registered for to ↵fgorski@chromium.org2014-03-073-5/+9
| | | | | | | | | | | | | | | | | | | send messages to it. * GCMProfileService adds a check that the app is currently registered for the sender_id of the sender that sent the message * IncomingMessage is extended to add sender_id * GCMClientImpl adds the sender_id to the incoming message in the handling code. * Adding a test verifying that messages are not delivered when not registered for senders * fixing the GCM Profile Service tests that were previously not registering for senders before delivering messages * Also: moving the DCHECKS in the GCMClientImpl::HandleIncomingMessage higher up to run them as soon as the checks values are available. This CL obsoletes https://codereview.chromium.org/185933003/ BUG=344665 Review URL: https://codereview.chromium.org/185133008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255483 0039d316-1c4b-4281-b951-d872f2087c98
* Move WriteFile and WriteFileDescriptor from file_util to base namespace.brettw@chromium.org2014-03-061-1/+1
| | | | | | | | | R=viettrungluu@chromium.org TBR=viettrungluu Review URL: https://codereview.chromium.org/184563006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Remove the requirement for manifest keyjianli@chromium.org2014-03-057-17/+1
| | | | | | | | | | | | We also remove cert from the registration request. BUG=345413 TEST=tests updated R=fgorski@chromium.org, tim@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/179043005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255136 0039d316-1c4b-4281-b951-d872f2087c98
* Extract OAuth2AccessTokenFetcher interface.msarda@chromium.org2014-03-0513-454/+539
| | | | | | | | | | | | | | This CL extracts the interface of OAuth2AccessTokenFetcher as the implementation for mobile is different . It renames the existing OAuth2AccessTokenFetcher to OAuth2AccessTokenFetcherImpl. TBR=davemoore@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/182573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254966 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Stop/restart GCM when the state is forced off/onjianli@chromium.org2014-03-057-3/+48
| | | | | | | | | | BUG=348642 TEST=new tests added R=dimich@chromium.org, fgorski@chromium.org, tim@chromium.org Review URL: https://codereview.chromium.org/183013007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254893 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Add request class for Permissions.insert API.kinaba@chromium.org2014-03-046-0/+214
| | | | | | | | BUG=348465 Review URL: https://codereview.chromium.org/185723004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254738 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-2/+2
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] RegistrationRequest is retrying when sender is invlalidfgorski@chromium.org2014-03-012-19/+44
| | | | | | | | | | | | | | | | | | It turns out that some of the Error="*" responses come as HTTP_OK, and some not. Given that check for HTTP_OK was done before response was parsed, we were missing some of the error conditions, including INVALID_SENDER and retrying assuming UNKNOWN_ERROR. The problem was already partially mitigated by failing after sever attempts, but with this fix we will actually start seeing the INVALID_SENDER response. Semantics of the HTTP_NOT_OK result was updated to distinguish it from UNKNOWN_ERROR in the following way: * if we have HTTP_OK but cannot parse token or error, we return UNKNOWN_ERROR, * if we don't have HTTP_OK an cannot parse error, we return HTTP_NOT_OK. Also updating the string comparisons in GetStatusFromError to use find instead of ==, to make sure that if there is more content in response, we can parse the error. BUG=345408 Review URL: https://codereview.chromium.org/181743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254282 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Adding collapse key support to downstream messagesfgorski@chromium.org2014-02-282-0/+4
| | | | | | | | | | | | | | | The initial API definition omitted collapse key support for downstream messages. This patch adds the collapseKey property to the message parameter of chrome.gcm.onMessage event, as well as collapse_key to gcm::GCMClient::IncomingMessage. Tests on both API and GCMProfileService level were updated. BUG=346855 Review URL: https://codereview.chromium.org/182483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254235 0039d316-1c4b-4281-b951-d872f2087c98
* Rename components's Encryptor to OSEncrypt.tfarina@chromium.org2014-02-283-9/+9
| | | | | | | | | | | | | To avoid confusion with the Encryptor class that exists under crypto/. BUG=341293 TEST=None R=joi@chromium.org,bcwhite@chromium.org TBR=thestig Review URL: https://codereview.chromium.org/183953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254177 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Stop requesting unused URLshashimoto@chromium.org2014-02-283-71/+0
| | | | | | | | | | | Remove self_link_, download_url_, embed_link_, thumbnail_link_ and web_content_link_ from FileResource. BUG=347871 TEST=unit_tests Review URL: https://codereview.chromium.org/184193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254142 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Request file lists with a number of multiples of 100hashimoto@chromium.org2014-02-282-2/+2
| | | | | | | | | | | Drive server seems to show the best performance when returning entries with a number of multiples of 100 BUG=347871 TEST=unit_tests Review URL: https://codereview.chromium.org/182823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254141 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Make sure GCM checkout logic is invoked when the profile is signed outjianli@chromium.org2014-02-276-43/+53
| | | | | | | | | | | | | | | We now always create GCMProfileService that listens to profile notifications such that GCM checkout logic could be invoked when the profile is signed out. We now move the GCM check-in logic from GCMClient::Initialize to GCMClient::CheckIn. BUG=344031 TEST=new tests added and existing tests updated Review URL: https://codereview.chromium.org/165993005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253787 0039d316-1c4b-4281-b951-d872f2087c98
* signin: mark OAuth2TokenService::RefreshTokenIsAvailable const because it istim@chromium.org2014-02-275-8/+13
| | | | | | | | | | R=rogerta@chromium.org TBR=gene@chromium.org, mnissler@chromium.org, haitaol@chromium.org BUG=none Review URL: https://codereview.chromium.org/130613008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253745 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Enable Registration Request to give after 5 retries.fgorski@chromium.org2014-02-274-8/+80
| | | | | | | | | | | | When a Chrome app issues a registration, that operation might be looping endlessly, when an error is recoverable. If meanwhile app wants to issue another registration (perhaps with a different set of senders) it will always be receiving and error (asynchronous operation pending) without a chance to cancel. The update is going to allow the registraiton to fail, after a 6 attempts (1 initial attempt + 5 retries). That approach ensures that applications follow an exponential backoff policy and have a chance to issue a new registration request after a period of time. BUG=344010 Review URL: https://codereview.chromium.org/180113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253739 0039d316-1c4b-4281-b951-d872f2087c98
* Convert scoped_ptr_malloc -> scoped_ptr, part 2.viettrungluu@chromium.org2014-02-261-4/+3
| | | | | | | | | | | | scoped_ptr_malloc is deprecated; let's get rid of it. BUG=344245 R=brettw@chromium.org TBR=rsleevi@chromium.org,miket@chromium.org,ryanmyers@chromium.org,dalecurtis@chromium.org, cpu@chromium.org Review URL: https://codereview.chromium.org/169193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253582 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3 more registartion status codes for UMA collection. Also added tests.juyik@chromium.org2014-02-263-27/+81
| | | | | | | | | | BUG=284553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252218 Review URL: https://codereview.chromium.org/165903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253460 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite DeviceOAuth2TokenService.mnissler@chromium.org2014-02-262-14/+1
| | | | | | | | | | | | | | | | | | The old code handled asynchronous system salt loading in the factory code, which made the Service a PITA to use. This change rewrites DeviceOauth2TokenService to fold all asynchronous operations into regular OAuth2TokenService implementation behavior, which is already set up with Observers and callbacks already. Also, this change improves the code to only perform validation once, even if there are multiple concurrent token requests. BUG=chromium:269455 TEST=Existing unit tests. TBR=rogerta@chromium.org Review URL: https://codereview.chromium.org/159773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253453 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the GCMStoreImplTest.GetNextPersistentId on Windowsfgorski@chromium.org2014-02-251-2/+4
| | | | | | | | | | | | | | | | | | Problem: It seems that consecutive calls to base::Time::Now().ToInternalValue() might yield the same outcome multiple times in a row, which is not suitable for producing unique IDs for testing. Fix: Persist a starting value based on current time and then increment it with every call. BUG=345118 R=zea@chromium.org Review URL: https://codereview.chromium.org/177243007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253229 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Make RMQ ack logic more resilientzea@chromium.org2014-02-251-16/+42
| | | | | | | | | | | | Redundant ids (those already acknowledged) are now supported during a stream ack. Additionally, id order is no longer assumed. BUG=343974 R=fgorski@chromium.org Review URL: https://codereview.chromium.org/173713009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253228 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Adding a list of accounts present on the client to checkin requestfgorski@chromium.org2014-02-228-14/+43
| | | | | | | | | | | | | | | | | | We need to bind device id (profile specific) to accounts running in that profile. For that reason we are grabbing all of the accounts as tracked by the ProfileOAuth2TokenService and pass them to Initialize method of GCMClientImpl. The list of accounts is then passed to CheckinRequest when the request is happening. Once the CheckinRequest is done more often than simply on login, we may want to give a more updated list of accounts than the one present on startup of Chromium. For now there is no reason to handle that case. BUG=343203 Review URL: https://codereview.chromium.org/171513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252759 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-09-16 12:27:11 +0000