summaryrefslogtreecommitdiffstats
path: root/google_apis
Commit message (Collapse)AuthorAgeFilesLines
* Adding GServicesSettings class and testsfgorski@chromium.org2014-04-174-0/+476
| | | | | | | | BUG=359254 Review URL: https://codereview.chromium.org/226923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264419 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 264313 "Add activity recording capability to gcm internal..."asargent@chromium.org2014-04-1614-522/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | This caused a compile error on the Win x64 builder: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17353/steps/compile/logs/stdio FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj.rsp /c ..\..\google_apis\gcm\tools\mcs_probe.cc /Foobj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj /Fdobj\google_apis\gcm\mcs_probe.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\google_apis\gcm\tools\mcs_probe.cc(309) :error C2661: 'gcm::MCSClient::MCSClient' : no overloaded function takes 4 arguments ninja: build stopped: subcommand failed. > Add activity recording capability to gcm internals page. User can refresh, start/stop recording, and clear recording logs. > Also added more information to the device info section and fixed a bug there. > > arv: owner review of chrome/browser/resources/*. > jianli & fgorski please review the rest of the code, and zea for owner review of these code. > > BUG=341256 > > Review URL: https://codereview.chromium.org/202083005 TBR=juyik@chromium.org Review URL: https://codereview.chromium.org/240583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264319 0039d316-1c4b-4281-b951-d872f2087c98
* Add activity recording capability to gcm internals page. User can refresh, ↵juyik@chromium.org2014-04-1614-28/+522
| | | | | | | | | | | | | | | start/stop recording, and clear recording logs. Also added more information to the device info section and fixed a bug there. arv: owner review of chrome/browser/resources/*. jianli & fgorski please review the rest of the code, and zea for owner review of these code. BUG=341256 Review URL: https://codereview.chromium.org/202083005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264313 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused parsers and URL generators for WAPI.fukino@chromium.org2014-04-167-957/+5
| | | | | | | | | | | | | Remove unused parsers, which are AccountMetadata, AppIcon, and InstalledApp. ResourceEntry and ResourceList are in use, and other surviving parsers are referenced from ResourceEntry or ResourceList. Remove unused URL generator for WAPI along with parsers. BUG=353554 TEST=run unit_tests Review URL: https://codereview.chromium.org/236743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264134 0039d316-1c4b-4281-b951-d872f2087c98
* gaia::AreEmailsSame() should consider X@gmail.com == X@googlemail.com.rogerta@chromium.org2014-04-153-18/+32
| | | | | | | | BUG=253081 Review URL: https://codereview.chromium.org/235603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263914 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the mock-keychain related bool from GCMStore constructorfgorski@chromium.org2014-04-117-25/+35
| | | | | | | | | | | | Removing the first parameter of GCMStore constructor. Adding BuildGCMStore and SetUpForTesting to GCMInternalsBuilder. Moving GCMInternalsBuilder to its own files in gcm/engine/ BUG=343360 Review URL: https://codereview.chromium.org/232113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263354 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused property from drive api parsers.fukino@chromium.org2014-04-113-149/+2
| | | | | | | | | BUG=353554 TEST=run unit_tests Review URL: https://codereview.chromium.org/234613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263241 0039d316-1c4b-4281-b951-d872f2087c98
* Adding basic G-services handlingfgorski@chromium.org2014-04-1010-79/+298
| | | | | | | | | | | | | | | | | * extracting CheckinRequest::RequestInfo to better manage checkin parameters * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) * extracting G-services settings from checkin response * storing and loading of the G-services settings in GCM Store This patch relands https://codereview.chromium.org/215363007/ after all of the trybots, buildbots and CQ have been updated to run gcm_unit_tests TBR=zea@chromium.org,jianli@chromium.org BUG=359254 Review URL: https://codereview.chromium.org/233103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263079 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Removing the mock-keychain related bool from GCMStore constructor ↵fgorski@chromium.org2014-04-088-35/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/221453003/) Reason for revert: gcm_unit_tests were disabled on a Mac because they were hanging on build bots. This is due to a combination of factors such as gcm_unit_tests not running in the CQ and possible keychain related configuration updates. In order to fix the problem step by step, this change will have to be attempted again. Original issue's description: > Removing the mock-keychain related bool from GCMStore constructor > > Removing the first parameter of GCMStore constructor. > Adding BuildGCMStore to GCMInternalsBuilder. > > BUG=342360 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261842 TBR=jianli@chromium.org,zea@chromium.org NOTREECHECKS=true NOTRY=true BUG=342360 Review URL: https://codereview.chromium.org/226223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262333 0039d316-1c4b-4281-b951-d872f2087c98
* Unregister gcm::ConnectionFactoryImpl from NetworkChangeNotifier.pauljensen@chromium.org2014-04-081-0/+2
| | | | | | | | | R=zea@chromium.org BUG=359980 Review URL: https://codereview.chromium.org/224723020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262296 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all uses of GG_LONGLONG and GG_ULONGLONG.viettrungluu@chromium.org2014-04-081-2/+2
| | | | | | | | | | | | | | | | | | | 123LL and 123ULL now work everywhere. You can also use INT64_C and UINT64_C (from <stdint.h>) in Chromium code (we force-define __STDC_CONSTANT_MACROS). (And sometimes you can just use static_cast<(u)int64_t>.) Don't remove their definitions yet, because some macros that are multiply-defined (in an identical way) rely on them. D'oh. R=brettw@chromium.org TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262147 Review URL: https://codereview.chromium.org/218953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262242 "Adding basic G-services handling"scottmg@chromium.org2014-04-0810-298/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Looks like it's failing on various Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20(dbg)(4)/builds/22407 in range http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=%2Ftrunk%2Fsrc&range=262232%3A262247&mode=html > Adding basic G-services handling > > * extracting CheckinRequest::RequestInfo to better manage checkin parameters > * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) > * extracting G-services settings from checkin response > * storing and loading of the G-services settings in GCM Store > > BUG=359254 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261912 > > Review URL: https://codereview.chromium.org/215363007 TBR=fgorski@chromium.org Review URL: https://codereview.chromium.org/227413010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262266 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Fix crash due to connection retry while logging in.zea@chromium.org2014-04-072-3/+38
| | | | | | | | | | | | | It was possible for a backoff retry to attempt while a previous attempt was in the middle of logging in. This could result in resetting the socket, which would lead a crash later if the login failed. Protect against this by ignoring backoff retries if we know we're logging in. BUG=360680 Review URL: https://codereview.chromium.org/227513006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262258 0039d316-1c4b-4281-b951-d872f2087c98
* Adding basic G-services handlingfgorski@chromium.org2014-04-0710-79/+298
| | | | | | | | | | | | | | | * extracting CheckinRequest::RequestInfo to better manage checkin parameters * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) * extracting G-services settings from checkin response * storing and loading of the G-services settings in GCM Store BUG=359254 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261912 Review URL: https://codereview.chromium.org/215363007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262147 "Remove all uses of GG_LONGLONG and GG_ULONGLONG."scottmg@chromium.org2014-04-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | > Remove all uses of GG_LONGLONG and GG_ULONGLONG. > > 123LL and 123ULL now work everywhere. You can also use INT64_C and > UINT64_C (from <stdint.h>) in Chromium code (we force-define > __STDC_CONSTANT_MACROS). (And sometimes you can just use > static_cast<(u)int64_t>.) > > Don't remove their definitions yet, because some macros that are > multiply-defined (in an identical way) rely on them. D'oh. > > R=brettw@chromium.org > TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org > > Review URL: https://codereview.chromium.org/218953003 TBR=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/227743006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262165 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all uses of GG_LONGLONG and GG_ULONGLONG.viettrungluu@chromium.org2014-04-071-2/+2
| | | | | | | | | | | | | | | | | 123LL and 123ULL now work everywhere. You can also use INT64_C and UINT64_C (from <stdint.h>) in Chromium code (we force-define __STDC_CONSTANT_MACROS). (And sometimes you can just use static_cast<(u)int64_t>.) Don't remove their definitions yet, because some macros that are multiply-defined (in an identical way) rely on them. D'oh. R=brettw@chromium.org TBR=sky@chromium.org,satorux@chromium.org,vrk@chromium.org,rch@chromium.org,shess@chromium.org Review URL: https://codereview.chromium.org/218953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262147 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of [GCM] Adding periodic checkin controlled by G-services settings ↵tommycli@chromium.org2014-04-0411-481/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/215363007/) Reason for revert: http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%282%29/builds/25118 These tests fail: gcm_unit_tests: GServicesSettingsDifferentDigest GServicesSettingsSameDigest PeriodicCheckin They should be in the cq, I believe scottmg has filed a bug to put them in the CQ list. Original issue's description: > Adding periodic checkin controlled by G-services settings > > * extracting CheckinRequest::RequestInfo to better manage checkin parameters > * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) > * extracting G-services settings from checkin response > * storing and loading of the G-services settings in GCM Store > > BUG=359254 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261912 TBR=zea@chromium.org,jianli@chromium.org,fgorski@chromium.org NOTREECHECKS=true NOTRY=true BUG=359254 Review URL: https://codereview.chromium.org/226893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261916 0039d316-1c4b-4281-b951-d872f2087c98
* Adding periodic checkin controlled by G-services settingsfgorski@chromium.org2014-04-0411-89/+481
| | | | | | | | | | | | | * extracting CheckinRequest::RequestInfo to better manage checkin parameters * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) * extracting G-services settings from checkin response * storing and loading of the G-services settings in GCM Store BUG=359254 Review URL: https://codereview.chromium.org/215363007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261912 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the mock-keychain related bool from GCMStore constructorfgorski@chromium.org2014-04-048-13/+35
| | | | | | | | | | | Removing the first parameter of GCMStore constructor. Adding BuildGCMStore to GCMInternalsBuilder. BUG=342360 Review URL: https://codereview.chromium.org/221453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261842 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Remove unused GData WAPI requestshashimoto@chromium.org2014-04-033-2502/+10
| | | | | | | | | | | GetResourceEntryReqeust is used by DriveAPIService BUG=357038 TEST=build Review URL: https://codereview.chromium.org/221883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261413 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Minimum change for periodic checkinfgorski@chromium.org2014-04-036-18/+140
| | | | | | | | | | | * enforces checkin every couple of days. * persists/load the last checkin time from gcm store. BUG=355814 Review URL: https://codereview.chromium.org/222913004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261324 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PrivateMode enum values:rch@chromium.org2014-04-011-1/+1
| | | | | | | | | | | | | | | | | | kPrivacyModeDisabled => PRIVACY_MODE_DISABLED kPrivacyModeEnabled => PRIVACY_MODE_ENABLED To match the chromium style guide: Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. R=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 Review URL: https://codereview.chromium.org/215023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260729 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add support for canary connection attemptszea@chromium.org2014-03-285-84/+190
| | | | | | | | | | | | | | Canary connection attempts occur on network changes, and are capable of bypassing backoff (without resetting it). As such they happen immediately if no connection attempt is already in progress, but if they fail backoff will be increased accordingly. BUG=355126 R=asvitkine@chromium.org, jianli@chromium.org Review URL: https://codereview.chromium.org/213693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Rename PrivateMode enum values: ↵rch@chromium.org2014-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/215023002/) Reason for revert: Broke build. http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/71042/steps/compile/logs/stdio#error1 Original issue's description: > Rename PrivateMode enum values: > > kPrivacyModeDisabled => PRIVACY_MODE_DISABLED > kPrivacyModeEnabled => PRIVACY_MODE_ENABLED > > To match the chromium style guide: > > Though the Google C++ Style Guide now says to use kConstantNaming for enums, > Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. > > R=mef@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 TBR=mef@chromium.org,zea@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/217053010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260296 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PrivateMode enum values:rch@chromium.org2014-03-281-1/+1
| | | | | | | | | | | | | | | | kPrivacyModeDisabled => PRIVACY_MODE_DISABLED kPrivacyModeEnabled => PRIVACY_MODE_ENABLED To match the chromium style guide: Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. R=mef@chromium.org Review URL: https://codereview.chromium.org/215023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260281 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Return cancel closure from FileSystem::GetFileContenthashimoto@chromium.org2014-03-281-11/+0
| | | | | | | | | | | | | | | This change does not fix the bug, just a preparation for the actual fix. No behavior change is intended. Return cancel closure from DownloadOperation and FileSystem. Change user code (SyncClient and DriveFileStreamReader) to use the returned closure. BUG=344789 TEST=unit_tests Review URL: https://codereview.chromium.org/214363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260184 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Make FileResource copyablehashimoto@chromium.org2014-03-283-22/+36
| | | | | | | | | | | To implement FakeDriveService without GData WAPI classes. BUG=334544 TEST=unit_tests Review URL: https://codereview.chromium.org/216433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260182 0039d316-1c4b-4281-b951-d872f2087c98
* Removing myself from OWNERS, as I no longer expect to be active on Chromium.joi@chromium.org2014-03-271-1/+0
| | | | | | | | | | | | | | For //content/port and //content/public, specifying avi@ as an OWNER even though he is also in the higher-level OWNERS file, as he is the remaining intended reviewer (rather than jam@) for less involved changes to the API, as specified in the comments in those files. Removing a comment about CCing myself and erikwright@ from the android_webview file as dependencies there have already been fixed. TBR=darin@chromium.org NOTRY=true BUG=none Review URL: https://codereview.chromium.org/213113007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259977 0039d316-1c4b-4281-b951-d872f2087c98
* Delete some dead code.thakis@chromium.org2014-03-272-24/+0
| | | | | | | | | | | | Found by a tweaked -Wunused-member-function Nuno Lopes is working on. BUG=none R=brettw@chromium.org, miket@chromium.org, rsleevi@chromium.org, sky@chromium.org TBR=rogerta, sky Review URL: https://codereview.chromium.org/213363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259767 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Destroy connection factory on CheckOutzea@chromium.org2014-03-265-64/+139
| | | | | | | | | | | | | Connection factory assumes that the mcs client (in the form of RequestBuilder callback) is still alive, which can result in DCHECKs if not true. Also refactors GCMClientImpl testing to make this testable. BUG=354344 Review URL: https://codereview.chromium.org/208333006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259405 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add port 443 fallback logic and histogramszea@chromium.org2014-03-245-14/+72
| | | | | | | | | | | | | | | Alternate between the default (5228) endpoint and the fallback (443) endpoint. Also introduce histograms for tracking endpoint and proxy success rate. Relanding due to compile issue. Original review: https://codereview.chromium.org/205343003/ BUG=351890 TBR=jianli@chromium.org, fgorski@chromium.org, asvitkine@chromium.org Review URL: https://codereview.chromium.org/206873006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258997 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258720 "[GCM] Add port 443 fallback logic and histograms"cpu@chromium.org2014-03-224-67/+12
| | | | | | | | | | | | | | | | | | | | | This broke linux Clang compile. gcm_tools_mcs_probe.cc line 294 > [GCM] Add port 443 fallback logic and histograms > > Alternate between the default (5228) endpoint and the fallback (443) endpoint. > Also introduce histograms for tracking endpoint and proxy success rate. > > BUG=351890 > > Review URL: https://codereview.chromium.org/205343003 TBR=zea@chromium.org Review URL: https://codereview.chromium.org/209343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258735 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258732 "Revert 258713 "Disable GCMClientImplTest.Register..."cpu@chromium.org2014-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Never mind, it was the other gcm related CL the 258720 one. > Revert 258713 "Disable GCMClientImplTest.RegisterAppFromCache" > > Compile break on Linux Clang at gcm_client_impl_unittest > gcm_tools_mcs_probe.cc line 294 > > > > Disable GCMClientImplTest.RegisterAppFromCache > > > > TBR=zea@chromium.org > > > > Review URL: https://codereview.chromium.org/209293002 > > R=luken@chromium.org > TBR=jianli@chromium.org > > Review URL: https://codereview.chromium.org/208333010 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/196173012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258734 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 258713 "Disable GCMClientImplTest.RegisterAppFromCache"cpu@chromium.org2014-03-221-1/+1
| | | | | | | | | | | | | | | | | | | Compile break on Linux Clang at gcm_client_impl_unittest gcm_tools_mcs_probe.cc line 294 > Disable GCMClientImplTest.RegisterAppFromCache > > TBR=zea@chromium.org > > Review URL: https://codereview.chromium.org/209293002 R=luken@chromium.org TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/208333010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258732 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add port 443 fallback logic and histogramszea@chromium.org2014-03-224-12/+67
| | | | | | | | | | | Alternate between the default (5228) endpoint and the fallback (443) endpoint. Also introduce histograms for tracking endpoint and proxy success rate. BUG=351890 Review URL: https://codereview.chromium.org/205343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258720 0039d316-1c4b-4281-b951-d872f2087c98
* Disable GCMClientImplTest.RegisterAppFromCachejianli@chromium.org2014-03-221-1/+1
| | | | | | | | TBR=zea@chromium.org Review URL: https://codereview.chromium.org/209293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compiling errors in gcm_store_impl_unittestjianli@chromium.org2014-03-211-3/+3
| | | | | | | | | TBR=vandebo@chromium.org BUG= Review URL: https://codereview.chromium.org/209183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258709 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Move registration info persistence from extension state store to GCM storejianli@chromium.org2014-03-2111-333/+498
| | | | | | | | | | | | | | | This is the effort decouple the extension specific logic from GCMProfileService. Also remove the code to persist user serial number mappings since it is not needed any more. BUG=343268 TEST=tests updated Review URL: https://codereview.chromium.org/207443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258706 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Fix proxy resolution fallbackzea@chromium.org2014-03-191-6/+3
| | | | | | | | | | | An infinite loop of proxy retries could result due to ignoring the error code returned by the fallback code. We now just fail synchronously. BUG=353739 Review URL: https://codereview.chromium.org/196573036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258116 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Adding chrome.gcm.unregister to gcm APIfgorski@chromium.org2014-03-197-63/+68
| | | | | | | | | | | | | | | | * Updating the gcm.json to include chrome.gcm.unregister * Modifying UnregistrationRequest to return proper Status * Modifying callbacks to properly carry status up the stack as GCMClient::Result * Making GCMProfileService.Unregister function public. * Adding tests for chrome.gcm.unregister * Adding test for GCMProfileService.Unregister BUG=351006 Review URL: https://codereview.chromium.org/196133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257888 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Delete old, unused contacts code.derat@chromium.org2014-03-183-219/+0
| | | | | | | | | | | This never got turned on. BUG=350213 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/190063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "unreachable code" warnings (MSVC warning 4702) in google_apis/.pkasting@chromium.org2014-03-183-131/+32
| | | | | | | | | | BUG=346399 TEST=none R=mtomasz@chromium.org, rogerta@chromium.org Review URL: https://codereview.chromium.org/203033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257739 0039d316-1c4b-4281-b951-d872f2087c98
* components: Rename encryptor directory to os_crypt.tfarina@chromium.org2014-03-185-6/+6
| | | | | | | | | | | | | | Joi suggested doing this rename in a follow up CL ( https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h#newcode16). So here it is. BUG=341293 TEST=None, no functional changes. R=joi@chromium.org,thestig@chromium.org,bcwhite@chromium.org Review URL: https://codereview.chromium.org/200713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257573 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Incoming GCM message without type should be treated as data messagejianli@chromium.org2014-03-181-1/+1
| | | | | | | | | | BUG=353363 TEST=Manual test by following repro steps R=zea@chromium.org Review URL: https://codereview.chromium.org/200763009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257546 0039d316-1c4b-4281-b951-d872f2087c98
* drive: Check "modificationDate" property of a change before applying ithashimoto@chromium.org2014-03-174-0/+27
| | | | | | | | | | | | | | Updating a locally edited entry with an older change results in unnecessarily overwriting users' edit. Add "modificationDate" field to ChangeResource. (Corresponding API documentation: https://developers.google.com/drive/v2/reference/changes#resource) Request "modificationDate" Use "modificationDate" for conflict resolution in ChangeListProcessor. BUG=350398 Review URL: https://codereview.chromium.org/199343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257384 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Add proxy resolution support.zea@chromium.org2014-03-143-35/+204
| | | | | | | | | | | | | | | | | GCM will use the proxy resolver associated with the current network session to resolve proxies. There is no direct fallback at the moment, so if a proxy resolution completes, but doesn't handle the data properly (because it's intercepting/mangling the response), connections will fail. Direct fallback, and attempting alternate ports, will be introduced in a later patch. BUG=351889 TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/197473008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257023 0039d316-1c4b-4281-b951-d872f2087c98
* Add create access token fetcher to OAuthTokenService.msarda@chromium.org2014-03-1311-89/+110
| | | | | | | | | | | | | | This CL add a factory method to create access token fetchers in the OAuth2 token service. This allows subclasses to create specific access token fetchers and re-use the OAuth2 caching logic without duplicating the code. TBR=atwilson, blundell, gene BUG=320625 Review URL: https://codereview.chromium.org/193043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256816 0039d316-1c4b-4281-b951-d872f2087c98
* Remove command-line flags for OAuth scopes.mnissler@chromium.org2014-03-129-42/+13
| | | | | | | | | | | | | There is no reason why one would want to switch to alternate OAuth scopes, because these are identifiers and not URLs to make requests to. BUG=chromium:350299 TBR=bauerb@chromium.org Review URL: https://codereview.chromium.org/190353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256541 0039d316-1c4b-4281-b951-d872f2087c98
* [GCM] Propagating SendError details all the way to the event.fgorski@chromium.org2014-03-115-50/+98
| | | | | | | | | | | | | OnSendError allows to specify more message content than simply and error message and message ID, but it currently is ignored. This patch fixes that problem by introducing SendErrorDetails structure and updating the whole stack to handle it properly. BUG=350026 Review URL: https://codereview.chromium.org/191443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256187 0039d316-1c4b-4281-b951-d872f2087c98
* Show device information in chrome://gcm-internals page.juyik@chromium.org2014-03-076-0/+81
| | | | | | | | | | OWNER reviewer: arv BUG=341256 Review URL: https://codereview.chromium.org/176823009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255692 0039d316-1c4b-4281-b951-d872f2087c98