summaryrefslogtreecommitdiffstats
path: root/google_apis
Commit message (Collapse)AuthorAgeFilesLines
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-0911-105/+124
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-0911-124/+105
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-0911-105/+124
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* revoke unused OAuth2 tokens on signout and re-signin courage@chromium.org2013-04-055-0/+58
| | | | | | | | | | | | A number of users have been reporting problems with the identity API. Gaia investigations reveal that these users have overflowed a limit on the number of login tokens they can have for Chrome. Revoking tokens we don't need any longer should mitigate the problem. This is identical to https://codereview.chromium.org/13249007/ but with a corrected base url. BUG=224462 Review URL: https://chromiumcodereview.appspot.com/13599003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192491 0039d316-1c4b-4281-b951-d872f2087c98
* Few imporant fixes needed for kiosk app for robot accounts:zelidrag@chromium.org2013-03-302-2/+23
| | | | | | | | | | | | * added TokenService initialization for kiosk app launch * wired up kiosk robot account auth file (/home/chronos/kiosk_auth) processing - we can now read value of oauth2 refresh token + client id/secret that will be used for Identity API calls in kiosk mode. BUG=224129 TEST=manual kiosk test Review URL: https://chromiumcodereview.appspot.com/12918030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191525 0039d316-1c4b-4281-b951-d872f2087c98
* Support for auth code based authentication flow for both app and web UI ↵zelidrag@chromium.org2013-03-252-18/+24
| | | | | | | | | | | | driven flow. BUG=181008 TEST=experiments that are in progress TBR=sky Review URL: https://chromiumcodereview.appspot.com/12704002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190338 0039d316-1c4b-4281-b951-d872f2087c98
* Files.app: Treats HTTP_FORBIDDEN (403) as temporary error on authentication.yoshiki@chromium.org2013-03-221-0/+9
| | | | | | | | | | | Sometimes the auth server returns '403 Rate Limit Exceeded' but it is treated as a permanent error and makes Files.app offline-mode. This patch makes '403' treated as a temporary error. BUG=180830 TEST=Repeat logging-in and opening Files.app 20 times, and confirms the error is not happen. Review URL: https://codereview.chromium.org/12630010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189787 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code in google_apis/gaiadcheng@chromium.org2013-03-2113-923/+0
| | | | | | | | | BUG=none TBR=joi@chromium.org Review URL: https://codereview.chromium.org/12755010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189710 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] Remove StringPrintf from global namespacegroby@chromium.org2013-03-187-29/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of StringPrintf now requires prefixing with base:: or a per-scope using directive TBR'd: abodenha: chrome/service brettw: content, third_party, webkit darin: base, chrome/browser, chrome/renderer dgarret: courgette enne: cc fischmann: media gbillock: sql joi: google_apis,components rsleevi: net, crypto sky: chrome/test thestig: printing, chrome/common, tsepez: ipc wez: remoting yfriedman: testing/android NOTRY=true R=brettw@chromium.org TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org BUG= Review URL: https://codereview.chromium.org/12767006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GoogleServiceAuthError::None() to AuthErrorNone() and ↵antrim@chromium.org2013-03-123-3/+3
| | | | | | | | | | LoginFailure::None() to LoginFailureNone() so that they do not clash with None defined in /usr/include/X11/X.h. TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12686006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187652 0039d316-1c4b-4281-b951-d872f2087c98
* src/: Update the remaining include paths of string_split.h to its new location.tfarina@chromium.org2013-03-063-3/+3
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
* Removed OAuth2 access token from TokenService.zelidrag@chromium.org2013-02-272-2/+0
| | | | | | | | | | | BUG=177721 TEST=existing TokenService unit tests TBR=sky Review URL: https://chromiumcodereview.appspot.com/12316076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184883 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete kDeviceManagementService token typeatwilson@chromium.org2013-02-192-2/+0
| | | | | | | | | BUG=174637 Review URL: https://chromiumcodereview.appspot.com/12279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183229 0039d316-1c4b-4281-b951-d872f2087c98
* Web-based-signin must not let the user sign in with a different account onrogerta@chromium.org2013-02-083-0/+17
| | | | | | | | | | | | | | | re-auth. BUG=171945 TEST=Connect a profile to a given account. Change the password of that account. Stop and restart chrome. Notice the auth error and try to re-auth. Make sure that signing in with the same account works, and trying to sign in with a different account fails with a message indicating which account to use. Review URL: https://chromiumcodereview.appspot.com/12082125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181511 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, assorted top directories edition.rsleevi@chromium.org2013-02-073-10/+13
| | | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=miket Review URL: https://chromiumcodereview.appspot.com/12245003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181292 0039d316-1c4b-4281-b951-d872f2087c98
* Make gaia and oauth token fetchers recover from ERR_NETWORK_CHANGED.joaodasilva@chromium.org2013-02-045-0/+26
| | | | | | | | | | | | | This net error occurs frequently during ChromeOS sign-in when tokens are being fetched, due to network change notifications triggered by the network library, the portal detector and sometimes proxy configuration changes. BUG=173671 Review URL: https://chromiumcodereview.appspot.com/12161003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180550 0039d316-1c4b-4281-b951-d872f2087c98
* Move stringize_macros to base/strings.brettw@chromium.org2013-01-312-2/+2
| | | | | | | | | | This removes the unused L-string macros in the file. BUG= Review URL: https://codereview.chromium.org/12090083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179926 0039d316-1c4b-4281-b951-d872f2087c98
* Remove temporary keys. See http://chromium.org/developers/how-tos/api-keys.joi@chromium.org2013-01-312-36/+24
| | | | | | | | | BUG=145584 Review URL: https://chromiumcodereview.appspot.com/12091043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179878 0039d316-1c4b-4281-b951-d872f2087c98
* OAuth2 sign-in flow for ChromeOS.zelidrag@chromium.org2013-01-152-7/+44
| | | | | | | | | | | | | | Refactored all OAuth1/2 code out of LoginUtils into OAuthLoginManager class. Created OAuth2-based specialization of OAuthLoginManager (behind --force-oauth2 switch). This new class uses OAuth2 refresh tokens as a base token from which all others are minted - incl. GAIA credentials and session cookies. BUG=166192, 169999 TEST=existing unit, browser tests, additional manual testing TBR=sky Review URL: https://codereview.chromium.org/11649055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176800 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid having two copies of implementation from google_api_keys.ccjoi@chromium.org2013-01-103-4/+19
| | | | | | | | | | | | | | | This fixes a problem that was only happening with some linkers, where the linker would choose the version of functions from google_api_keys.cc that was defined in the google_api_keys_unittest.cc file when that source file got #included at global scope. Thanks to blundell@chromium.org for the report. BUG=None Review URL: https://chromiumcodereview.appspot.com/11819043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176207 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of GaiaAuthFetcherTest tests to work when non-official keys are ↵joi@chromium.org2013-01-101-8/+14
| | | | | | | | | | | used. BUG=169093 Review URL: https://chromiumcodereview.appspot.com/11829038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176203 0039d316-1c4b-4281-b951-d872f2087c98
* Make all google_apis build on Win64jschuh@chromium.org2013-01-101-0/+2
| | | | | | | | | | BUG=166496 BUG=167187 TBR=joi Review URL: https://chromiumcodereview.appspot.com/11818045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176025 0039d316-1c4b-4281-b951-d872f2087c98
* Added --lso-host switch that lets us override hosts for LSO URLs.zelidrag@chromium.org2013-01-094-35/+71
| | | | | | | | | BUG=168602 TEST=existing unittests Review URL: https://codereview.chromium.org/11786006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175900 0039d316-1c4b-4281-b951-d872f2087c98
* Automatically retry the following URLFetchers when the network changes:joaodasilva@chromium.org2012-12-141-0/+7
| | | | | | | | | | | | | | | | extensions_downloader.cc (extensions, retail mode AppPack) gaia_oauth_fetcher.cc gaia_oauth_client.cc device_management_service.cc (user/device policy fetches, auto-enrollment) All of these have been noticed to fail when network change notifications are sent, in particular on ChromeOS. TBR=jochen BUG=145021,163710,130602,chromium-os:16114 Review URL: https://codereview.chromium.org/11572044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173232 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ERR_NETWORK_CHANGED and allow URLFetcher to automatically retry on ↵joaodasilva@chromium.org2012-12-141-4/+4
| | | | | | | | | | that error. BUG=164363 Review URL: https://codereview.chromium.org/11464028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173227 0039d316-1c4b-4281-b951-d872f2087c98
* Make OAuthUserInfoUrl configurable.rmsousa@chromium.org2012-11-133-1/+9
| | | | | | | | | BUG=97126 Review URL: https://chromiumcodereview.appspot.com/11367014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167445 0039d316-1c4b-4281-b951-d872f2087c98
* When using the one-click sign in feature, re-use the oauth2 refesh tokenrogerta@chromium.org2012-10-301-0/+3
| | | | | | | | | | | | | | | | retrieved by the sign in manager instead of having the token service create a new one. BUG=156964 TEST=Use the one-click sign in feature and make sure it works correctly. Try with gmail.com account and with dasher account. Try with accounts that have 2-factor enabled and disabled. There are no user visible changes from this CL. Review URL: https://chromiumcodereview.appspot.com/11290002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164945 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GaiaOAuthClient to handle the case when it's destroyed from callbacks.sergeyu@chromium.org2012-10-261-3/+5
| | | | | | | | | | | | Previously GaiaOAuthClient was accessing its members after calling the delegate, so it was crashing if the delegate destroys GaiaOAuthClient object. Second problem this change solves is that it was not possible to call GetUserInfo() from OnRefreshTokenResponse(). Review URL: https://chromiumcodereview.appspot.com/11271038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164396 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetUserInfo() in GaiaOAuthClient.sergeyu@chromium.org2012-10-253-21/+123
| | | | | | | | | The new method allows getting email of the user given an access token. Review URL: https://chromiumcodereview.appspot.com/11226067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164003 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all the "set noparent" directivesdpranke@chromium.org2012-10-191-2/+0
| | | | | | | | | | | | | Now that OWNERS supports per-file owners, we can limit the scope of the top-level wildcard to just DEPS, and make darin and ben owners for everything else and remove the broad use of "set noparent". R=ben@chromium.org, darin@chromium.org BUG=88315 Review URL: https://codereview.chromium.org/11191038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163069 0039d316-1c4b-4281-b951-d872f2087c98
* No need to support old style dasher domains.rogerta@chromium.org2012-10-162-5/+3
| | | | | | | | | | BUG=137118 TEST=See unit tests, not called in any code yet Review URL: https://chromiumcodereview.appspot.com/11185002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162184 0039d316-1c4b-4281-b951-d872f2087c98
* Add helper function to test that a given URL is a valid Gaia sign in URL.rogerta@chromium.org2012-10-113-0/+31
| | | | | | | | | | BUG=137118 TEST=See unit tests, not called in any code yet Review URL: https://chromiumcodereview.appspot.com/11091048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161282 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes some really silly memory leaks, and eliminates an unusedgspencer@chromium.org2012-10-031-2/+2
| | | | | | | | | | | | constructor. TBR=nkostylev@chromium.org BUG=none TEST=compile Review URL: https://chromiumcodereview.appspot.com/11000061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159807 0039d316-1c4b-4281-b951-d872f2087c98
* Let GaiaOAuthClient::GetTokensFromAuthCode use any given redirect URL.simonmorris@chromium.org2012-10-023-1/+9
| | | | | | | | | BUG=153453 Review URL: https://chromiumcodereview.appspot.com/11038011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159736 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the channel IDpetewil@chromium.org2012-10-012-0/+5
| | | | | | | | | | | | | | To prevent hitting rate limits on how fast we can access the server to get an auth token to get a channel Id, we cache the channel Id when we get one. Note that a channel Id is per profile, so we store them by profile login name. BUG=149733 Review URL: https://chromiumcodereview.appspot.com/10951022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159576 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow OAuth2MintTokenFlow to outlive profile.estade@chromium.org2012-10-012-21/+0
| | | | | | | | BUG=150911 Review URL: https://codereview.chromium.org/10966009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159502 0039d316-1c4b-4281-b951-d872f2087c98
* Log ChromeToMobile search and auth errors to UMA and INFO.msw@chromium.org2012-09-241-0/+3
| | | | | | | | | | | | | | | | | | Add more UMA and VLOG(0) to OnGetTokenFailure and HandleSearchResponse. (add supporting GoogleServiceAuthError::NUM_STATES enum value) (add supporting CTMService SEARCH_[SUCCESS|ERROR] enum values) (change existing LOG_IF(INFO, ...) to VLOG_IF(0, ...) in HandleSubmitResponse) ChromeToMobile.AuthError UMA histogram added here: https://chromereviews.googleplex.com/4964015 BUG=102709,120941 TEST=Additional UMA and INFO logging of any auth token generation errors. R=joi@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10970055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158345 0039d316-1c4b-4281-b951-d872f2087c98
* Adding unit tests for google_api_keys functionality.joi@chromium.org2012-09-213-42/+381
| | | | | | | | | | TBR=ben@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10941034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157972 0039d316-1c4b-4281-b951-d872f2087c98
* Remove API keys from source.jamiewalch@chromium.org2012-09-181-1/+1
| | | | | | | | | | | Also fixes a bug in google_api_keys that made it fail when used as a module. BUG= Review URL: https://chromiumcodereview.appspot.com/10939005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157405 0039d316-1c4b-4281-b951-d872f2087c98
* Add a preliminary Python API for retrieving Google API keys.joi@chromium.org2012-09-171-0/+92
| | | | | | | | | | | | | | | | This has nearly identical semantics to the C++ API for builds where the internal key file is available. For builds where that file is not available, it does not yet have the same semantics, since at the moment it does not have access to the gyp variables that would be required (this is a TODO item). Instead, it will simply try to find keys from environment variables, and if they are not found it will use 'dummytoken' as the default token for each key. BUG=145584 Review URL: https://codereview.chromium.org/10933138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157247 0039d316-1c4b-4281-b951-d872f2087c98
* Check in temporary keys to aid transition.joi@chromium.org2012-09-171-17/+16
| | | | | | | | | TBR=odean@chromium.org BUG=145584 Review URL: https://codereview.chromium.org/10913298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157145 0039d316-1c4b-4281-b951-d872f2087c98
* Auto-detect whether internal keys should be used.joi@chromium.org2012-09-172-7/+46
| | | | | | | | | | | | | Allow overriding to explicitly use or not use internal keys, regardless of what is auto-detected. Fix a bug in the implementation, where the default value was not being used for unset tokens. BUG=145584 Review URL: https://codereview.chromium.org/10933126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157130 0039d316-1c4b-4281-b951-d872f2087c98
* Moved /GetOAuthToken GAIA request to accounts.google.com.zelidrag@chromium.org2012-09-133-40/+2
| | | | | | | | | | BUG=147347 TEST=ChromeOS login BVTs Review URL: https://chromiumcodereview.appspot.com/10910234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156596 0039d316-1c4b-4281-b951-d872f2087c98
* include.gypi variables to specify API keys or use internal header for keys.joi@chromium.org2012-09-133-9/+100
| | | | | | | | BUG=145584 Review URL: https://codereview.chromium.org/10918196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156538 0039d316-1c4b-4281-b951-d872f2087c98
* Add include of internal-only file for official builds.joi@chromium.org2012-09-111-39/+23
| | | | | | | | | | | | | | Remove unused function, and add a few log messages. While I'm updating to match the internal change, add the relevant directory to .gitignore. BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10916238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156132 0039d316-1c4b-4281-b951-d872f2087c98
* google_apis/gaia: Fix more clang warnings about missing virtual and OVERRIDE ↵tfarina@chromium.org2012-09-091-1/+1
| | | | | | | | | | | | annotations. BUG=115047 TBR=rogerta@chromium.org Review URL: https://chromiumcodereview.appspot.com/10907133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155605 0039d316-1c4b-4281-b951-d872f2087c98
* Moving google_apis and GaiaClient to src/google_apis.joi@chromium.org2012-09-0752-0/+9505
TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 06:16:16 +0000