| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
directories.
BUG=229660
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/18919005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The build warning is no longer necessary as we now have an infobar
show up to warn developers if API keys haven't been set.
The Python API may never need to be better than it is today, so
removing the TODO there; it will be improved if and when needed.
The underlying reason for the inconsistent semantics between setting
the GOOGLE_DEFAULT_CLIENT_ID/SECRET environment variables and the
google_default_client_id/secret gyp variables is gone, so I fixed this
mismatch in the current change.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/18851002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestingProfile was only being used in order to retrieve a
net::TestURLRequestContextGetter. google_apis tests can do this themselves
using a combination of MessageLoop and MessageLoopProxy.
This one more step forward on moving these tests to a google_apis_unittests
target.
BUG=255301
TEST=unit_tests
R=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
google_apis/, gpu/, ipc/, jingle/.
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18156002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=everything compiles OK
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17894007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/17696002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before using the robot account refresh token stored in an enterprise
device's Local State, verify that the token is owned by the service
account id found in the device policy.
BUG=245121
Review URL: https://chromiumcodereview.appspot.com/17109006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes sync and net compile with no "using *Value".
BUG=
Review URL: https://codereview.chromium.org/17034006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
errors Google Authentication service included in response body.
* Adding parsing to the Failure situation in OAuth2MintTokenFlow
BUG=121976
Review URL: https://chromiumcodereview.appspot.com/17286013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=226464
Review URL: https://chromiumcodereview.appspot.com/15780020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=247359
Review URL: https://chromiumcodereview.appspot.com/16866014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileSyncService requests access token from OAuth2TokenService and passes it
to ServerConnectionManager through UpdateCredentials. When server returns
AUTH_ERROR it gets propagated to ProfileSyncService through OnGetStatusChange
call. At this point ProfileSyncService needs to invalidate old token with
OAuth2TokenService and request a new one.
Access token is requested in PSS::StartUp since this is the place where all
preconditions are verified. There is a call to pre-request access token in
Initialize and Observe after Login token is loaded.
There are still two tests disabled, I'll fix them and update this CR.
BUG=226464
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15421011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16632010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This keeps the forwarding header, just updates all current callers.
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16514006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/.
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15995038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Since this will not be used on Android or iOS, only the NSS implementation is
complete; OpenSSL is stubbed out.
Review URL: https://chromiumcodereview.appspot.com/15793005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The memory leak in the original version is fixed, by running the message loop at test tear down.
TBR=atwilson@chromium.org,rogerta@chromium.org
BUG=228833
Review URL: https://chromiumcodereview.appspot.com/16173008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"operator T*"
Linux fixes
BUG=110610
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/16288003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add ManagedUserTokenFetcher to fetch scoped-down tokens.
>
> TBR=rogerta@chromium.org
> BUG=228833
>
> Review URL: https://chromiumcodereview.appspot.com/15977002
BUG=245241
TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/15675014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta@chromium.org
BUG=228833
Review URL: https://chromiumcodereview.appspot.com/15977002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Deprecate lso-host to replace with lso-url, which is the complete origin (not just the host).
* Allow for http access of gaia-urls, not just https.
* Add data member gaia_url_ and accessor to GaiaUrls, replacing gaia_origin_url_
* Replace javascript params gaiaOrigin and gaiaUrlPath with gaiaUrl.
* Replace SetGaiaOriginForTesting with SetGaiaUrlForTesting.
BUG=239151
TEST=manual with telemetry auth server. on linux and on the device with GAIA_FLAGS="--gaia-url=https://gaiastaging.corp.google.com --lso-url=https://test-sandbox.auth.corp.google.com --google-apis-host=www.googleapis-test.sandbox.google.com --oauth2-client-id=236834563817.apps.googleusercontent.com --oauth2-client-secret=RsKv5AwFKSzNgE0yjnurkPVI"
Review URL: https://chromiumcodereview.appspot.com/14786022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When getAuthToken needs to prompt a user for permissions, it now uses
a web-based authorization flow instead of native dialogs.
BUG=228908
(step #4 of the bug description)
Review URL: https://chromiumcodereview.appspot.com/15148007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158766
R=joi@chromium.org, pkasting@chromium.org
Review URL: https://codereview.chromium.org/14766011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This works around the bug we've had where on some Windows machines, one of the invocations of check_internal.py mysteriously causes a file to open up in Visual Studio. We have no idea why, but this should avoid the problem. See details in bug.
BUG=241208
Review URL: https://chromiumcodereview.appspot.com/12330155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
kGaiaOAuth2Url where used only by Cloud Print code and it was replaced by GaiaUrls. Not it's used only inside of unittest.
BUG=236756
Review URL: https://chromiumcodereview.appspot.com/14623017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/14945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14383023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
token from the policy server. This token will be stored in the device's Local State for use by Cloud Print across all profiles (including Guest and Public Sessions). The new steps that fetch the token during enrollment are optional, so that enrollment will still succeed if a policy server doesn't support robot api tokens.
BUG=164606
Review URL: https://chromiumcodereview.appspot.com/12538009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=92948
Review URL: https://chromiumcodereview.appspot.com/14169010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.
BUG=234765
Review URL: https://codereview.chromium.org/14113028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the plan to make sync sign-in more integral to a user's profile, we're adding an explicit ability to "sign out" of the profile in place of signing out of Google inside the content area. This CL adds that basic sign-out functionality by adding a "sign out" button to the avatar menu that, when clicked, goes through the steps of signing out of Google and closing all browser windows associated with that profile.
Future CLs will do the Right Thing(tm) of requiring sign-in before opening that profile so that the tabs can resume where there were, just as though there had been no sign-out event.
The UI included here is temporary. A new profile-switcher menu is being discussed and the core functionality included here will eventually get triggered from that once the design is finalized. In other words, the UI presented here will eventually be replaced.
See it in action:
https://docs.google.com/a/google.com/file/d/0B4S7cIAPVn9XdzJFZXl2SncxMlE/edit?usp=sharing
Previous avatar menu:
https://docs.google.com/a/google.com/file/d/0B4S7cIAPVn9XY3dZMXRUNGtHd3M/edit?usp=sharing
To test:
- launch with --enable-profile-signout
- create a second profile (so Avatar menu appears)
- sign-in to a Google account (like gmail)
- open Avatar menu and click the "sign out" button
- (window will close when sign-out is complete)
- re-open profile
- go to a Google account
- note that you are not signed in
BUG=
Review URL: https://chromiumcodereview.appspot.com/12726012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Identity.getAuthToken caches access tokens from GAIA. Tokens expirations
are handled automatically, but if an access token goes bad for some other
reason, the application can call identity.invalidateAuthToken to remove
a bad token from the cache.
BUG=228908
(step #1 of the bug description)
Review URL: https://chromiumcodereview.appspot.com/14329014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A number of users have been reporting problems with the identity API. Gaia investigations reveal that these users have overflowed a limit on the number of login tokens they can have for Chrome. Revoking tokens we don't need any longer should mitigate the problem.
This is identical to https://codereview.chromium.org/13249007/ but with a corrected base url.
BUG=224462
Review URL: https://chromiumcodereview.appspot.com/13599003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* added TokenService initialization for kiosk app launch
* wired up kiosk robot account auth file (/home/chronos/kiosk_auth) processing - we can now read value of oauth2 refresh token + client id/secret that will be used for Identity API calls in kiosk mode.
BUG=224129
TEST=manual kiosk test
Review URL: https://chromiumcodereview.appspot.com/12918030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
driven flow.
BUG=181008
TEST=experiments that are in progress
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12704002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes the auth server returns '403 Rate Limit Exceeded' but it is treated as a permanent error and makes Files.app offline-mode. This patch makes '403' treated as a temporary error.
BUG=180830
TEST=Repeat logging-in and opening Files.app 20 times, and confirms the error is not happen.
Review URL: https://codereview.chromium.org/12630010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/12755010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use of StringPrintf now requires prefixing with base:: or a per-scope using directive
TBR'd:
abodenha: chrome/service
brettw: content, third_party, webkit
darin: base, chrome/browser, chrome/renderer
dgarret: courgette
enne: cc
fischmann: media
gbillock: sql
joi: google_apis,components
rsleevi: net, crypto
sky: chrome/test
thestig: printing, chrome/common,
tsepez: ipc
wez: remoting
yfriedman: testing/android
NOTRY=true
R=brettw@chromium.org
TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12767006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
LoginFailure::None() to LoginFailureNone() so that they do not clash with None defined in /usr/include/X11/X.h.
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12686006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=175186
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=177721
TEST=existing TokenService unit tests
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12316076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=174637
Review URL: https://chromiumcodereview.appspot.com/12279005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
re-auth.
BUG=171945
TEST=Connect a profile to a given account. Change the password of that
account. Stop and restart chrome. Notice the auth error and try to re-auth.
Make sure that signing in with the same account works, and trying to sign in
with a different account fails with a message indicating which account to use.
Review URL: https://chromiumcodereview.appspot.com/12082125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
TBR=miket
Review URL: https://chromiumcodereview.appspot.com/12245003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This net error occurs frequently during ChromeOS sign-in when tokens are being
fetched, due to network change notifications triggered by the network library,
the portal detector and sometimes proxy configuration changes.
BUG=173671
Review URL: https://chromiumcodereview.appspot.com/12161003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the unused L-string macros in the file.
BUG=
Review URL: https://codereview.chromium.org/12090083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=145584
Review URL: https://chromiumcodereview.appspot.com/12091043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179878 0039d316-1c4b-4281-b951-d872f2087c98
|