| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the Android platform does not inform the native code
that new credentials are available. This CL adds the necessary
functionality to fire the required notifications.
* Adds a Java instance of the OAuth2TokenService.
* Adds FireRefreshTokenAvailable().
* Adds support for Java-based observers.
* Adds a BroadcastReceiver to trigger the notification for the
Chrome Shell.
BUG=302143
Review URL: https://codereview.chromium.org/25653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=rogerta@chromium.org
Review URL: https://codereview.chromium.org/25042002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
O2TS.StartRequest
* Removing virtual keyword from OAuth2TokenService.StartRequest
* Introducing virtual CreateRequest in OAuth2TokenService to allow derive classes to control the creation of Requests
* Overriding CreateRequest in DeviceOAuth2TokenService with a wrapper over the Consumer, so that the refresh token can be validated by ValidatingConsumer, before it is passed on to the actual consumer.
BUG=282454
Review URL: https://codereview.chromium.org/23850010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, jamesr@chromium.org, koz@chromium.org, piman@chromium.org, sergeyu@chromium.org, thestig@chromium.org, vitalybuka@chromium.org
TBR=cpu, dmichael, joi, xhwang
Review URL: https://codereview.chromium.org/24579003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
R=akalin@chromium.org, avi@chromium.org, isherman@chromium.org, jamesr@chromium.org, joi@chromium.org, sergeyu@chromium.org, sky@chromium.org, thestig@chromium.org, xhwang@chromium.org
Review URL: https://codereview.chromium.org/24649002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adding account_id as a parameter to public methods, like: StartRequestXX, RefreshTokenIsAvailable, GetRefreshToken, InvalidateToken,
* Updating callers and derived classes,
* Updating cache handling for the OAuth2 access tokens in OAuth2TokenService
BUG=277149
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224031
Review URL: https://chromiumcodereview.appspot.com/23382008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for the benefit of integration tests that need the browser to
interface with GAIA and friends, such as for OAuth2 token minting.
BUG=chromium:243889
R=joi@chromium.org, xiyuan@chromium.org, zelidrag@chromium.org
Review URL: https://codereview.chromium.org/24172005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Making OAuth2TokenService multi-login aware:
> * Adding account_id as a parameter to public methods, like: StartRequestXX, RefreshTokenIsAvailable, GetRefreshToken, InvalidateToken,
> * Updating callers and derived classes,
> * Updating cache handling for the OAuth2 access tokens in OAuth2TokenService
>
> BUG=277149
>
> Review URL: https://chromiumcodereview.appspot.com/23382008
TBR=fgorski@chromium.org
BUG=294624
Review URL: https://codereview.chromium.org/23800008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that most consuming code can actually handle a GURL
return value better. Other consumers can use GURL::Resolve() which
provides nicer semantics for construction URLs that string
concatenation, which had been used before.
BUG=chromium:243889
R=akalin@chromium.org, bauerb@chromium.org, brettw@chromium.org, courage@chromium.org, isherman@chromium.org, rogerta@chromium.org, sail@chromium.org, sky@chromium.org, zelidrag@chromium.org
Review URL: https://codereview.chromium.org/23691043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements the first step of moving google_apis tests from unit_tests target
to a new google_apis_unittests.
This establishes a new unit test executable (google_apis_unittests) and _copy_
(not move) the test google_api_keys_unittest.cc from unit_tests target into
google_apis_unittests target.
BUG=257421
TEST=google_apis_unittests runs and passes, all green.
R=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23976004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adding account_id as a parameter to public methods, like: StartRequestXX, RefreshTokenIsAvailable, GetRefreshToken, InvalidateToken,
* Updating callers and derived classes,
* Updating cache handling for the OAuth2 access tokens in OAuth2TokenService
BUG=277149
Review URL: https://chromiumcodereview.appspot.com/23382008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OAuth2TokenService
BUG=268937
TEST=OAuth2TokenServiceTest.SameScopesRequestedForDifferentClients
TBR=tim (for chrome/browser/sync)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221303
Review URL: https://chromiumcodereview.appspot.com/22581003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This collects timing data as well as error codes for initial policy
fetches on Chrome OS. These block Profile creation, so we'd like to
get some insight on how much delay this encurs in the field.
BUG=271321
TEST=Log in to an enrolled device, check chrome://histograms
Review URL: https://chromiumcodereview.appspot.com/23271009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OAuth2TokenService"
This reverts commit 2a0ff28378173300b81b2874736c30a6c48d0029.
Reason: BuildBot Vista fails TokenServiceUpdateClearsCache test.
BUG=
TBR=zelidrag@chromium.org
Review URL: https://codereview.chromium.org/23767004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OAuth2TokenService
BUG=268937
TEST=OAuth2TokenServiceTest.SameScopesRequestedForDifferentClients
TBR=tim (for chrome/browser/sync)
Review URL: https://chromiumcodereview.appspot.com/22581003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The message loop must be run till the end for running clean up tasks.
BUG=279634
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/23481007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for removing the dependency from c/b/google_apis/ to
the chrome/ directory and move the whole directory content
to more componentized, top-level google_api/ directory.
As discussed in http://crbug.com/146989#c28 - #c30, OAuth2TokenSerive,
which is the last dependency, is in fact written sorely using
google_api/ items and hence itself can easily be moved to there.
BUG=264570, 146989
Review URL: https://chromiumcodereview.appspot.com/23202015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This CL removes the client id from the apps V2 patch. There is a separate (not public) CL that adds a new one.
Review URL: https://chromiumcodereview.appspot.com/22901007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=269532
TBR=kinaba@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22571004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change allows running a host *already configured* with service account credentials. Support for obtaining service account credentails during host setup will come in follow up CLs.
BUG=224742
Review URL: https://chromiumcodereview.appspot.com/19796006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=266183
TEST=kiosk tests
Review URL: https://chromiumcodereview.appspot.com/21164006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enterprise Enrollment was still using going through OAuthWrap for
authentication, which is deprecated and shouldn't be used any longer.
The OAuth2 approach is in line with what regular Chrome OS login and
user policy do.
BUG=chromium:238624
TEST=Manual: Chrome OS enterprise enrollment still works.
Review URL: https://chromiumcodereview.appspot.com/19787008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until this CL, TestingProfile had 3 distinct URLRequestContexts it would return to the user: one via profile->GetDefaultStoragePartition()->GetRequestContext(), one via profile->GetRequestContext(), and one via profile->GetResourceContext->GetRequestContext(). All of these had different cookie stores. This CL unified them so they all return the one from profile->GetDefaultStoragePartition()->GetRequestContext(). This correctly mimics how production code works.
Doing this had a bunch of implications:
(1) Removes TestingProfile::CreateRequestContext()/ResetRequestContext()
(2) Changes MockRequestContext to share the URLRequestContext with TestingProfile.
(3) TestingProfile now requires all BrowserThreads.
Point (3) effectively adds TestBrowserThreadBundle into a bunch more spots. Because of that, we also have the following changes:
(a) AshTestBase now has a TestBrowserThreadBundle
(b) Removed a bunch of real threads from tests.
(c) TemplateUrlService has reworked synchronization semantics.
(d) Removed MultiThreadTestHelper.
(e) Added TestingIOThread class + testing API in IOThread to mock out various IO thread tasks which enervated with the new TestBrowserThreadBundle.
TBR=bauerb,brettw,isherman,joth,jyasskin,mattm,mmenke,mnissler,pkasting,rkc,rlp,satorux,tim,xians,joth
BUG=159193
Review URL: https://chromiumcodereview.appspot.com/17127002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions/, google_apis/, gpu/, ipc/, jingle/.
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19607005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Updating OAuth2MintTokenFlow to use access_token instead of refresh_token
* Updating Experimental Identity API and Identity API to fetch access_token for GAIA from ProfileOAuth2TokenService and use that instead of a refresh token
* Updating IdentityAPI to implementOAuth2TokenService::Observer, to clear errors properly when user signs in
* Updating IdentitySigninFlow to remove dependency on TokenService and instead implement OAuth2TokenService::Observer
* Updating and adding tests for Identity API
* Updating ExtensionInstallPrompt to invoke OAuth2MintTokenFlow using the access_token instead of refresh_token
BUG=243737
Review URL: https://chromiumcodereview.appspot.com/18755006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
directories.
BUG=229660
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/18919005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The build warning is no longer necessary as we now have an infobar
show up to warn developers if API keys haven't been set.
The Python API may never need to be better than it is today, so
removing the TODO there; it will be improved if and when needed.
The underlying reason for the inconsistent semantics between setting
the GOOGLE_DEFAULT_CLIENT_ID/SECRET environment variables and the
google_default_client_id/secret gyp variables is gone, so I fixed this
mismatch in the current change.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/18851002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestingProfile was only being used in order to retrieve a
net::TestURLRequestContextGetter. google_apis tests can do this themselves
using a combination of MessageLoop and MessageLoopProxy.
This one more step forward on moving these tests to a google_apis_unittests
target.
BUG=255301
TEST=unit_tests
R=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
google_apis/, gpu/, ipc/, jingle/.
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18156002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=everything compiles OK
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17894007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/17696002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before using the robot account refresh token stored in an enterprise
device's Local State, verify that the token is owned by the service
account id found in the device policy.
BUG=245121
Review URL: https://chromiumcodereview.appspot.com/17109006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes sync and net compile with no "using *Value".
BUG=
Review URL: https://codereview.chromium.org/17034006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
errors Google Authentication service included in response body.
* Adding parsing to the Failure situation in OAuth2MintTokenFlow
BUG=121976
Review URL: https://chromiumcodereview.appspot.com/17286013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=226464
Review URL: https://chromiumcodereview.appspot.com/15780020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=247359
Review URL: https://chromiumcodereview.appspot.com/16866014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProfileSyncService requests access token from OAuth2TokenService and passes it
to ServerConnectionManager through UpdateCredentials. When server returns
AUTH_ERROR it gets propagated to ProfileSyncService through OnGetStatusChange
call. At this point ProfileSyncService needs to invalidate old token with
OAuth2TokenService and request a new one.
Access token is requested in PSS::StartUp since this is the place where all
preconditions are verified. There is a call to pre-request access token in
Initialize and Observe after Login token is loaded.
There are still two tests disabled, I'll fix them and update this CR.
BUG=226464
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15421011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16632010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This keeps the forwarding header, just updates all current callers.
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16514006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/.
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15995038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Since this will not be used on Android or iOS, only the NSS implementation is
complete; OpenSSL is stubbed out.
Review URL: https://chromiumcodereview.appspot.com/15793005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The memory leak in the original version is fixed, by running the message loop at test tear down.
TBR=atwilson@chromium.org,rogerta@chromium.org
BUG=228833
Review URL: https://chromiumcodereview.appspot.com/16173008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"operator T*"
Linux fixes
BUG=110610
TBR=darin
Review URL: https://chromiumcodereview.appspot.com/16288003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add ManagedUserTokenFetcher to fetch scoped-down tokens.
>
> TBR=rogerta@chromium.org
> BUG=228833
>
> Review URL: https://chromiumcodereview.appspot.com/15977002
BUG=245241
TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/15675014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta@chromium.org
BUG=228833
Review URL: https://chromiumcodereview.appspot.com/15977002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Deprecate lso-host to replace with lso-url, which is the complete origin (not just the host).
* Allow for http access of gaia-urls, not just https.
* Add data member gaia_url_ and accessor to GaiaUrls, replacing gaia_origin_url_
* Replace javascript params gaiaOrigin and gaiaUrlPath with gaiaUrl.
* Replace SetGaiaOriginForTesting with SetGaiaUrlForTesting.
BUG=239151
TEST=manual with telemetry auth server. on linux and on the device with GAIA_FLAGS="--gaia-url=https://gaiastaging.corp.google.com --lso-url=https://test-sandbox.auth.corp.google.com --google-apis-host=www.googleapis-test.sandbox.google.com --oauth2-client-id=236834563817.apps.googleusercontent.com --oauth2-client-secret=RsKv5AwFKSzNgE0yjnurkPVI"
Review URL: https://chromiumcodereview.appspot.com/14786022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When getAuthToken needs to prompt a user for permissions, it now uses
a web-based authorization flow instead of native dialogs.
BUG=228908
(step #4 of the bug description)
Review URL: https://chromiumcodereview.appspot.com/15148007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=158766
R=joi@chromium.org, pkasting@chromium.org
Review URL: https://codereview.chromium.org/14766011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This works around the bug we've had where on some Windows machines, one of the invocations of check_internal.py mysteriously causes a file to open up in Visual Studio. We have no idea why, but this should avoid the problem. See details in bug.
BUG=241208
Review URL: https://chromiumcodereview.appspot.com/12330155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
kGaiaOAuth2Url where used only by Cloud Print code and it was replaced by GaiaUrls. Not it's used only inside of unittest.
BUG=236756
Review URL: https://chromiumcodereview.appspot.com/14623017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198930 0039d316-1c4b-4281-b951-d872f2087c98
|