| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Uses the new form for most (but not quite all) of the remaining users of the old form.
Reland of https://codereview.chromium.org/1272823003 but with no changes to the way media parses codec lists. The previous landing attempted to simplify some handling but there are layout tests that expect the old behavior, and I'm not qualified to tell if it's OK to change.
TBR=sky
Review URL: https://codereview.chromium.org/1274123003
Cr-Commit-Position: refs/heads/master@{#342489}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1272823003/ )
Reason for revert:
Caused Blink layout test failures in media/encrypted-media/encrypted-media-requestmediakeysystemaccess.html :
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fencrypted-media%2Fencrypted-media-requestmediakeysystemaccess.html
Original issue's description:
> Update SplitString calls to new form
>
> Uses the new form for most (but not quite all) of the remaining users of the old form.
>
> Changes media mime util codec list parsing to expect no result from the string "," rather than two empty strings. The old SplitString call had a special case where if the input was empty, it would return empty, but if it had one split character, it would return two empty strings as results.
>
> The new one lets you choose but the options are either (1) empty string -> one empty string and "," -> two empty strings, or (2) map both to no results for when you don't want empty results. I'm pretty sure media codec parsing actually wants the latter behavior, so I updated the call to discard empty results and MimeUtilTest.ParseCodecString is updated.
>
> Committed: https://crrev.com/0aa7c64253cca8b636d52d1d01d94f96ab9c13fa
> Cr-Commit-Position: refs/heads/master@{#342238}
TBR=sky@chromium.org,dalecurtis@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1278973003
Cr-Commit-Position: refs/heads/master@{#342257}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses the new form for most (but not quite all) of the remaining users of the old form.
Changes media mime util codec list parsing to expect no result from the string "," rather than two empty strings. The old SplitString call had a special case where if the input was empty, it would return empty, but if it had one split character, it would return two empty strings as results.
The new one lets you choose but the options are either (1) empty string -> one empty string and "," -> two empty strings, or (2) map both to no results for when you don't want empty results. I'm pretty sure media codec parsing actually wants the latter behavior, so I updated the call to discard empty results and MimeUtilTest.ParseCodecString is updated.
Review URL: https://codereview.chromium.org/1272823003
Cr-Commit-Position: refs/heads/master@{#342238}
|
|
|
|
|
|
|
|
|
|
|
| |
ANGLE uses different back-end APIs for Rendering. Add the ability to
filter test expectations based on API.
BUG=511982
Review URL: https://codereview.chromium.org/1251993002
Cr-Commit-Position: refs/heads/master@{#339952}
|
|
|
|
|
|
|
|
|
| |
BUG=508746
TEST=gpu_unittests
Review URL: https://codereview.chromium.org/1246203003
Cr-Commit-Position: refs/heads/master@{#339832}
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change.
BUG=506255
TBR=jam
Review URL: https://codereview.chromium.org/1242023005
Cr-Commit-Position: refs/heads/master@{#339175}
|
|
|
|
|
|
|
|
|
| |
NOPRESUBMIT=true
(no presubmit due to removing base:: from a ScopedAllowIO)
Review URL: https://codereview.chromium.org/1172183002
Cr-Commit-Position: refs/heads/master@{#334108}
|
|
|
|
|
|
|
|
| |
Remove url:: variants. Add the 4-element version from url:: to base::
Review URL: https://codereview.chromium.org/1172753003
Cr-Commit-Position: refs/heads/master@{#333597}
|
|
|
|
|
|
|
|
|
|
|
|
| |
It allows test GPUTestConfigTest.LoadCurrentConfig to pass on Yosemite.
BUG=474551
TEST=gpu_unittests --gtest_filter="GPUTestConfigTest.LoadCurrentConfig"
Review URL: https://codereview.chromium.org/1068813002
Cr-Commit-Position: refs/heads/master@{#325221}
|
|
|
|
|
|
|
|
|
| |
TBR=cpu@chromium.org,jochen@chromium.org,piman@chromium.org,rockot@chromium.org,rsleevi@chromium.org,vrk@chromium.org
,zea@chromium.org
Review URL: https://codereview.chromium.org/563173002
Cr-Commit-Position: refs/heads/master@{#294712}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace
>
> Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is
> generally a NOP but will allow me to delete the other 4 variants in a followup
> (wanted to do that separately since that will require more review, since
> callsites will be changed in nontrivial ways).
>
> In some cases, LowerCaseEqualsASCII is called with a WebString, which no
> longer is implicitly converted. I added base::string16(...) around such
> calls to force the right conversion. It happened in these files:
> window_container_type.cc
> savable_resources.cc
> render_view_impl.cc
> blink_ax_tree_source.cc
> password_form_conversion_utils.cc
> translate_helper.cc
> chrome_render_view_observer.cc
> dom_serializer_browsertest.cc
>
> R=jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/448143008
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/474483002
Cr-Commit-Position: refs/heads/master@{#289320}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is
generally a NOP but will allow me to delete the other 4 variants in a followup
(wanted to do that separately since that will require more review, since
callsites will be changed in nontrivial ways).
In some cases, LowerCaseEqualsASCII is called with a WebString, which no
longer is implicitly converted. I added base::string16(...) around such
calls to force the right conversion. It happened in these files:
window_container_type.cc
savable_resources.cc
render_view_impl.cc
blink_ax_tree_source.cc
password_form_conversion_utils.cc
translate_helper.cc
chrome_render_view_observer.cc
dom_serializer_browsertest.cc
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/448143008
Cr-Commit-Position: refs/heads/master@{#289312}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=338160
TEST=gpu_unittests on 10.9 bots
R=kbr@chromium.org
Review URL: https://codereview.chromium.org/141753015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/26131003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/19579005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16632010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Again, these code is not depending on any content stuff, so moving it to gpu/ side will allow us to disable more gpu tests per GPU.
BUG=230477
TEST=gpu_unittests,tree
TBR=kbr@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/15827008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202690 0039d316-1c4b-4281-b951-d872f2087c98
|