| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
BUG=175002
Reland of 198820 and 298824
Original review = https://codereview.chromium.org/13165005
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/16392011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke both windows clobber and official builders' compile with this error:
771>Link:
771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and
object ..\..\..\build\Release\lib\gcp_portmon64.exp
771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86'
conflicts with target machine type 'x64'
771>
771>Build FAILED.
> Move FileEnumerator to its own file, do some refactoring.
>
> It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
>
> BUG=175002
> R=rvargas@chromium.org
>
> Review URL: https://codereview.chromium.org/13165005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14824006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
BUG=175002
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/13165005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14273038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.
BUG=234765
Review URL: https://chromiumcodereview.appspot.com/14337005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This changelist was automatically generated using a clang tool.
BUG=171111
Review URL: https://codereview.chromium.org/13454036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This won't be allowed by unique_ptr<T> or scoped_ptr<T>.
BUG=171118
Review URL: https://codereview.chromium.org/13710002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12211108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes.
Review URL: https://codereview.chromium.org/12163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10828063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104040
R=ben@chromium.org
TBR=tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boolean flag.
This is just prep work for a large CL that rewrites the JSON parser. Splitting
out this interface change will make it easier to review the other CL.
BUG=121469
TEST=No functional change.
Review URL: https://chromiumcodereview.appspot.com/9960077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=base_unittests
TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org
Review URL: http://codereview.chromium.org/9590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make compositor_model_bench
Review URL: http://codereview.chromium.org/8576003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
jingle, and media.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8511045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In
the current version, we simulate the performance of the existing forward
rendering model; coming changes will prototype a new model.
BUG=None
TEST=self
This is http://codereview.chromium.org/7718020/ with trivial fixes
Original change by Joshua Trask <joshtrask@google.com>
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98706
Review URL: http://codereview.chromium.org/7792002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In
the current version, we simulate the performance of the existing forward
rendering model; coming changes will prototype a new model.
BUG=None
TEST=self
This is http://codereview.chromium.org/7718020/ with trivial fixes
Original change by Joshua Trask <joshtrask@google.com>
Review URL: http://codereview.chromium.org/7792002
Patch from Joshua Trask <joshtrask@google.com>.
TBR=piman@google.com
Review URL: http://codereview.chromium.org/7792016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In
the current version, we simulate the performance of the existing forward
rendering model; coming changes will prototype a new model.
BUG=None
TEST=self
This is http://codereview.chromium.org/7718020/ with trivial fixes
Original change by Joshua Trask <joshtrask@google.com>
Review URL: http://codereview.chromium.org/7792002
Patch from Joshua Trask <joshtrask@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98706 0039d316-1c4b-4281-b951-d872f2087c98
|