| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
But do not use it yet.
Also introduce the test utilities to create the ProfileSyncServiceMock on iOS.
BUG=565305,565339
Review URL: https://codereview.chromium.org/1520953002
Cr-Commit-Position: refs/heads/master@{#365006}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ref-counted dependencies being injected by SyncClient are now
injected directly into the DTC's via the components factory.
BUG=543199
TBR=sdefresne
Review URL: https://codereview.chromium.org/1460723004
Cr-Commit-Position: refs/heads/master@{#364465}
|
|
|
|
|
|
|
|
|
|
|
| |
Move preferences from ios::prefs namespace to prefs namespace as there is
no risk of collision with preferences from chrome/commom/pref_names.cc.
BUG=513323
Review URL: https://codereview.chromium.org/1504863002
Cr-Commit-Position: refs/heads/master@{#363474}
|
|
|
|
|
|
|
|
| |
BUG=561569
Review URL: https://codereview.chromium.org/1479223002
Cr-Commit-Position: refs/heads/master@{#361997}
|
|
|
|
|
|
|
|
|
|
| |
This is the upstream part of the downstream CL 307417013.
BUG=544795, 548612, 453435
Review URL: https://codereview.chromium.org/1471073006
Cr-Commit-Position: refs/heads/master@{#361976}
|
|
|
|
|
|
|
|
|
|
| |
This CL renames the methods so that they are consistently using
"BrowserState" instead of a mix of "BrowserState" and
"ChromeBrowserState".
Review URL: https://codereview.chromium.org/1463833002
Cr-Commit-Position: refs/heads/master@{#361080}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync team has decided that datatype specific code should no longer
live in sync_driver. //c/sync_driver will conceptually be at the same
level as //sync in the dependency tree, with datatype logic living in
special components such as sync_sessions or the datatype components
themselves.
BUG=543199
TBR=jam
Review URL: https://codereview.chromium.org/1443453002
Cr-Commit-Position: refs/heads/master@{#359886}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds an //ios/chrome-specific implementation of
LocalEventSessionRouter. The implementation is similar to (and based on)
NotificationServiceSessionsRouter, but uses iOS equivalents to the
notifications used by NotificationServiceSessionsRouter.
BUG=544865
Review URL: https://codereview.chromium.org/1429493006
Cr-Commit-Position: refs/heads/master@{#356802}
|
|
|
|
|
|
|
|
|
|
| |
IOSChromeSyncedTabDelegate has the bug that was fixed for
TabContentsSyncedTabDelegate in https://codereview.chromium.org/1422393002.
This CL fixes it the same way.
Review URL: https://codereview.chromium.org/1423313002
Cr-Commit-Position: refs/heads/master@{#356797}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IOSChromeSyncedTabDelegate is an //ios/chrome-specific implementation of
SyncedTabDelegate. It is conceptually similar to TabContentsSyncedTabDelegate.
This CL only introduces the class; it is not yet being used.
BUG=544864
Review URL: https://codereview.chromium.org/1420703003
Cr-Commit-Position: refs/heads/master@{#356304}
|
|
|
|
|
|
|
|
|
|
|
|
| |
A recent CL introduced a new optional observer method in the
SyncServiceObserver interface. This CL forwards that callback in the
iOS-specific Objective-C bridge of that interface.
BUG=512825
Review URL: https://codereview.chromium.org/1420093003
Cr-Commit-Position: refs/heads/master@{#356017}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When cleaning up ProfileSyncServiceAndroid I noticed these inconsistencies
but it seemed like PSS was the one that should be changed, not PSSA.
Renames:
- EncryptEverythingEnabled -> IsEncryptEverythingEnabled
- EncryptEverythingAllowed -> IsEncryptEverythingAllowed
- FirstSetupInProgress -> IsFirstSetupInProgress
- backend_initialized -> IsBackendInitialized
- setup_in_progress -> IsSetupInProgress
BUG=497518
TBR=rogerta,stevenjb,pam,sdefresne
Review URL: https://codereview.chromium.org/1321903005
Cr-Commit-Position: refs/heads/master@{#348178}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Public APIs from base should live inside base:: so moved Singleton class
and structs to base{} and fixed consumers.
also fixed:
** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template
gets instantiated in a single compilation unit.
chrome/browser/plugins/plugin_finder.h \
chromecast/media/base/media_message_loop.h \
content/browser/media/android/media_drm_credential_manager.h
Presubmit warnings:
src/chrome/browser/extensions/warning_badge_service_factory.h:5:
#ifndef header guard has wrong style, please use:
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_
[build/header_guard] [5]
src/chrome/browser/extensions/warning_badge_service_factory.h:39:
#endif line should be "#endif //
CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_"
[build/header_guard] [5]
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1308823002
Cr-Commit-Position: refs/heads/master@{#348136}
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup iOS BrowserStateKeyedService factories to follow style guide and to
fix typos in the factory description comments.
BUG=429756
Review URL: https://codereview.chromium.org/1222013005
Cr-Commit-Position: refs/heads/master@{#337633}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move OnDataTypeRequestsSyncStartup() methode from ProfileSyncService to
a pure abstract method on sync_driver::SyncService to allow implementation
of GetFlareForSyncableService on iOS.
BUG=478763
Review URL: https://codereview.chromium.org/1212883002
Cr-Commit-Position: refs/heads/master@{#336443}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, there were three methods for stopping sync: RequestStop(),
DisableForUser() and StopSyncingPermanently(). The differences between
these are whether they set IsSyncRequested to false (DisableForUser
did not) and whether they clear the local sync data (RequestStop did
not).
In this CL there two methods for stopping sync, the public RequestStop()
and the private StopImpl(). Both take a parameter of the enum "DataFate",
which has two values: KEEP_DATA and CLEAR_DATA.
The pure logical mapping between the old and new is:
- RequestStop -> RequestStop(KEEP_DATA)
- StopSyncingPermanently -> RequestStop(CLEAR_DATA)
- DisableForUser -> StopImpl(CLEAR_DATA)
Since StopImpl() is private, any external uses of DisableForUser have been
converted to RequestStop(CLEAR_DATA), as well as some internal
uses for which it was deemed correct.
Finally, this CL contains a fix to a bug in Android's SigninManager that
those changes revealed. Previously the short circuit logic in
ProfileSyncServiceAndroid::EnableSync was preventing a crash
caused by it being called before native sign in, but with these changes
IsSyncRequested is correctly set to false and therefore the short
circuit is not hit.
BUG=495192
Review URL: https://codereview.chromium.org/1178923003
Cr-Commit-Position: refs/heads/master@{#335317}
|
|
|
|
|
|
|
|
| |
BUG=429756
Review URL: https://codereview.chromium.org/1195593002
Cr-Commit-Position: refs/heads/master@{#335239}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of an effort to clean up sync's state interface.
CanStartSync more accurately represents the conceptual implication of
the conditions that the method checks.
Note that at present, this does not map perfectly to what is actually
checked when sync tries to start, but that will happen in an upcoming
change.
BUG=495192
TBR=sdefresne,pkasting
Review URL: https://codereview.chromium.org/1175243009
Cr-Commit-Position: refs/heads/master@{#334545}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of an effort to clean up sync's state interface.
Note that SyncRequested is the inverse of the old StartSuppressed, so
every invocation should be inverted.
BUG=495192
TBR=rogerta,sdefresne
Review URL: https://codereview.chromium.org/1151853008
Cr-Commit-Position: refs/heads/master@{#333403}
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncSetupService allows configuring sync. It handles enabling and disabling it,
as well as choosing datatypes. Most actions are delayed until a commit is done,
to allow the complex sync setup flow on iOS.
BUG=429756
Review URL: https://codereview.chromium.org/1148573002
Cr-Commit-Position: refs/heads/master@{#330736}
|
|
PrefObserverBridge and SyncObserverBridge are C++ classes that bridge C++
observer event to Objective-C classes.
BUG=429756
Review URL: https://codereview.chromium.org/1090413007
Cr-Commit-Position: refs/heads/master@{#326566}
|