summaryrefslogtreecommitdiffstats
path: root/ipc/ipc_message_utils.cc
Commit message (Collapse)AuthorAgeFilesLines
* Update uses of UTF conversions in courgette/, device/, extensions/, ↵avi@chromium.org2013-12-251-2/+2
| | | | | | | | | | | | google_apis/, gpu/, ipc/, media/, net/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/112963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242496 0039d316-1c4b-4281-b951-d872f2087c98
* Move more uses of string16 to specify base::brettw@chromium.org2013-12-031-2/+2
| | | | | | | | | | This makes base, ui, and net compile without the "using base::string16" directive that's currently checked in. BUG= Review URL: https://codereview.chromium.org/100303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238246 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize ParamTraits<float> and ParamTraits<double>piman@chromium.org2013-10-311-21/+2
| | | | | | | | | | | | | | These function become hot on some benchmarks. WriteData is inefficient because it writes the length, even though it's known on the reader side (compile-time constant). For <float> we can simply use WriteFloat. For <double> we can use WriteBytes instead of WriteData. BUG=307480 Review URL: https://codereview.chromium.org/39363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232060 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for marshalling unsigned char in IPC.tsepez@chromium.org2013-07-121-17/+34
| | | | | | | | | | | | | | | | | | | | Previously, we've supported unsigned short, but not unsigned char. There are a few places where folks are passing around color values that must be in the 0..255, and we can save both bytes written and avoid explicit range checks by the receiving method by using this rather than larger types. We support unsigned char only. Signed char is evil due to questionable signedness in the C specs. I've re-arranged the order of these specializatons so that they go in order of increasing size as they go down the page. R=jam@chromium.org BUG=259903 Review URL: https://chromiumcodereview.appspot.com/18068016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211473 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in courgette/, crypto/, dbus/, device/, ↵avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | | | google_apis/, gpu/, ipc/, jingle/. BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18156002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209149 0039d316-1c4b-4281-b951-d872f2087c98
* Add base namespace to more values in sync and elsewhere.brettw@chromium.org2013-06-211-3/+3
| | | | | | | | | | This makes sync and net compile with no "using *Value". BUG= Review URL: https://codereview.chromium.org/17034006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207907 0039d316-1c4b-4281-b951-d872f2087c98
* Make net and ipc explicitly use the base namespace for Values.brettw@chromium.org2013-06-131-36/+40
| | | | | | | | | | | They're currently relying on a using in values.h that we want to remove. I removed several usings in net for consistency. BUG= R=willchan@chromium.org Review URL: https://codereview.chromium.org/15662008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206187 0039d316-1c4b-4281-b951-d872f2087c98
* Move nullable_string16.h to the string subdirectory.avi@chromium.org2013-06-131-6/+9
| | | | | | | | | | BUG=247723 TEST=no change TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/16415016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206066 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 205889 "Revert 205775 "Revert 205772 "Revert "Revert 2054..."jochen@chromium.org2013-06-131-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 205775 "Revert 205772 "Revert "Revert 205443 "headless wi..." > > > Revert 205772 "Revert "Revert 205443 "headless windows content_s..." > > > > > Revert "Revert 205443 "headless windows content_shell"" > > > > > > Also, add more verbose debug output to LOGFONT pickle code > > > > > > The NOTREACHED() is reached on WebKit Win7 (dbg) bots, but I cannot reproduce > > > locally, so I need more data from the bots > > > > > > I'll revert the CL once the Webkit Win Debug builder cycled once. > > > > > > BUG=248520 > > > TBR=jam@chromium.org > > > > > > Review URL: https://codereview.chromium.org/16309013 > > > > TBR=jochen@chromium.org > > > > Review URL: https://codereview.chromium.org/16034019 > > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/16817004 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/16941002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206029 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 205775 "Revert 205772 "Revert "Revert 205443 "headless wi..."jochen@chromium.org2013-06-121-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | > Revert 205772 "Revert "Revert 205443 "headless windows content_s..." > > > Revert "Revert 205443 "headless windows content_shell"" > > > > Also, add more verbose debug output to LOGFONT pickle code > > > > The NOTREACHED() is reached on WebKit Win7 (dbg) bots, but I cannot reproduce > > locally, so I need more data from the bots > > > > I'll revert the CL once the Webkit Win Debug builder cycled once. > > > > BUG=248520 > > TBR=jam@chromium.org > > > > Review URL: https://codereview.chromium.org/16309013 > > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/16034019 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/16817004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205889 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 205772 "Revert "Revert 205443 "headless windows content_s..."jochen@chromium.org2013-06-121-2/+0
| | | | | | | | | | | | | | | | | | | | | | > Revert "Revert 205443 "headless windows content_shell"" > > Also, add more verbose debug output to LOGFONT pickle code > > The NOTREACHED() is reached on WebKit Win7 (dbg) bots, but I cannot reproduce > locally, so I need more data from the bots > > I'll revert the CL once the Webkit Win Debug builder cycled once. > > BUG=248520 > TBR=jam@chromium.org > > Review URL: https://codereview.chromium.org/16309013 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/16034019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205775 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 205443 "headless windows content_shell""jochen@chromium.org2013-06-121-0/+2
| | | | | | | | | | | | | | | | Also, add more verbose debug output to LOGFONT pickle code The NOTREACHED() is reached on WebKit Win7 (dbg) bots, but I cannot reproduce locally, so I need more data from the bots I'll revert the CL once the Webkit Win Debug builder cycled once. BUG=248520 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/16309013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205772 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in ipc/, jingle/, media/.avi@chromium.org2013-06-111-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16684003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205436 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ↵avi@chromium.org2013-06-071-1/+1
| | | | | | | | | | | | ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15995038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
* Proudly fixing funny indents since 1969groby@chromium.org2013-03-301-3/+3
| | | | | | | | | | R=tsepez@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/12681030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191520 0039d316-1c4b-4281-b951-d872f2087c98
* Fix libcxx build.eugenis@chromium.org2013-03-201-2/+5
| | | | | | | | | | | | | | In libcxx, vector<bool>::const_reference is not the same as bool. This requires a new specialization of ParamTraits. BUG=178409 R=tsepez@chromium.org,agl@chromium.org Review URL: https://chromiumcodereview.appspot.com/12943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189383 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] Remove StringPrintf from global namespacegroby@chromium.org2013-03-181-9/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of StringPrintf now requires prefixing with base:: or a per-scope using directive TBR'd: abodenha: chrome/service brettw: content, third_party, webkit darin: base, chrome/browser, chrome/renderer dgarret: courgette enne: cc fischmann: media gbillock: sql joi: google_apis,components rsleevi: net, crypto sky: chrome/test thestig: printing, chrome/common, tsepez: ipc wez: remoting yfriedman: testing/android NOTRY=true R=brettw@chromium.org TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org BUG= Review URL: https://codereview.chromium.org/12767006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC handling for INVALID_HANDLE_VALUE on Win64 buildsjschuh@chromium.org2013-03-041-5/+5
| | | | | | | | BUG=179693 R=cpu@chromium.org Review URL: https://codereview.chromium.org/12381066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185826 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-241-1/+1
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Rename FilePath -> base::FilePath in various toplevel directoriesbrettw@chromium.org2013-02-101-6/+6
| | | | | | Review URL: https://codereview.chromium.org/12211108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181639 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Do not use Value::Create* functions.tfarina@chromium.org2013-01-301-4/+4
| | | | | | | | | | BUG=160586 R=darin@chromium.org,estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/12079026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179538 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow '\0' characters in FilePath.aedla@chromium.org2013-01-281-9/+2
| | | | | | | | | BUG=169777 Review URL: https://chromiumcodereview.appspot.com/11642041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179141 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced DictionaryValue::key_iterator by DictionaryValue::Iterator outside ↵pneubeck@chromium.org2013-01-181-16/+6
| | | | | | | | | | | | | | | of chrome/browser. Marked Iterator::HasNext() as deprecated and added a method Iterator::CanAdvance() as replacement. As DictionaryValue::Iterator is actually a const iterator, I had to add several missing const annotations, mostly, in json_schema_validator.* and command.* BUG=162611 TEST=No new tests. Only semantically equivalent refactorings. Review URL: https://chromiumcodereview.appspot.com/11418150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177673 0039d316-1c4b-4281-b951-d872f2087c98
* Validate that paths don't contain embedded NULLs at deserialization.cevans@chromium.org2013-01-031-0/+3
| | | | | | | | BUG=166867 Review URL: https://chromiumcodereview.appspot.com/11743009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174935 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IPC::MessageIterator.viettrungluu@chromium.org2012-12-171-17/+0
| | | | | | | | | | It's a rarely-used and completely unnecessary (and thin) wrapper around PickleIterator. Review URL: https://chromiumcodereview.appspot.com/11570038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173525 0039d316-1c4b-4281-b951-d872f2087c98
* Verify lfFaceName is NUL terminated in IPC deserializer.jschuh@chromium.org2012-11-211-7/+10
| | | | | | | | BUG=162066 Review URL: https://chromiumcodereview.appspot.com/11416115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168937 0039d316-1c4b-4281-b951-d872f2087c98
* LogData.message_name not marshalled across logging IPCs.tsepez@chromium.org2012-11-151-0/+2
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11364242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167838 0039d316-1c4b-4281-b951-d872f2087c98
* Correct const accessors in base/values.(h|cc), Part II (ListValue)vabr@chromium.org2012-08-031-1/+1
| | | | | | | | | | | | | | For problem description and other info please see the BUG page. This is for ListValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj Review URL: https://chromiumcodereview.appspot.com/10837044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149819 0039d316-1c4b-4281-b951-d872f2087c98
* Correct const accessors in base/values.(h|cc)vabr@chromium.org2012-07-271-1/+1
| | | | | | | | | | | | | For problem description and other info please see the BUG page. This is for DictionaryValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar scottbyer achuith agl mnissler davemoore garykac akalin hans bulach phajdan.jr jamesr Review URL: https://chromiumcodereview.appspot.com/10834004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148833 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed several CHECKED_RETURN defects in ipc message utils ccorenb@chromium.org2012-07-261-4/+9
| | | | | | | | | | | | | CID_COUNT=3 CID=104154,104155,104156 BUG= TEST= TBR=jeremy Review URL: https://chromiumcodereview.appspot.com/10829024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148469 0039d316-1c4b-4281-b951-d872f2087c98
* Make the serialization of IPC::Messages inside other IPC::Messages independentbrettw@chromium.org2012-06-291-10/+31
| | | | | | | | | | | | | | of the platform. This is necessary for sending nested messages between nacl (which the IPC system thinks is posix and so has extra header goo) and a Windows client app (which doesn't have this stuff). BUG= Review URL: https://chromiumcodereview.appspot.com/10667002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144840 0039d316-1c4b-4281-b951-d872f2087c98
* This groups the ParamTraits into different categories and orders the .cc ↵brettw@chromium.org2012-06-041-137/+412
| | | | | | | | | | | file the same. It makes all non-trivial Read/Write calls non-inline. TEST=it compiles BUG=none Review URL: https://chromiumcodereview.appspot.com/10498002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140375 0039d316-1c4b-4281-b951-d872f2087c98
* Move ParamTraits<base::PlatformFileInfo> and <base::PlatformFileError>.tsepez@chromium.org2012-05-301-0/+43
| | | | | | | | | | Move thse to ipc/ from content/common so that they may be used in directories parallel to content/. Pre-requisite for fixing the associated bug. BUG=127624 Review URL: https://chromiumcodereview.appspot.com/10442072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139636 0039d316-1c4b-4281-b951-d872f2087c98
* JSONWriter cleanup: integrate pretty print into write options.ericdingle@chromium.org2012-03-161-2/+2
| | | | | | | | | | | BUG= TEST=base_unittests TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org Review URL: http://codereview.chromium.org/9590002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127080 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Pickle Read methods to use higher performance PickleIterator.jbates@chromium.org2012-03-071-15/+21
| | | | | | | | | | | | | | | | There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize IPC:ChannelHandle from existing HANDLEamit@chromium.org2012-01-241-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1] Add a ctor to IPC:ChannelHandle that takes a pipe HANDLE. 2] Corresponding change in Channel::ChannelImpl::CreatePipe to attach to the given pipe instead of creating a new one. Being able to hand over a pipe handle to IPC::Channel in this way has other advantages such as using anonymous pipes and safer connections between process with different level of privileges. Here's how it can be done: Server Process: - Create a server pipe, anonymous pipe is fine too. - Server creates a client handle of pipe using CreateFile. - Use DuplicateHandle to duplicate this handle for the client process. - pass over the handle value to the client process, say using comman line. Client process: - Simply receive the handle from the server and hand it over to IPC:Channel using IPC::ChannelHandle. Apart from being more flexible, this is more secure as it removes the 'connection window' while using names. BUG=none TEST=none Review URL: http://codereview.chromium.org/9150030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118786 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IPC logging on Windows.jam@chromium.org2011-10-171-6/+3
| | | | | | Review URL: http://codereview.chromium.org/8322013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105937 0039d316-1c4b-4281-b951-d872f2087c98
* Improve IPC logging for ChannelHandle and NPVariant_Paramsteveblock@chromium.org2011-09-231-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7885043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102475 0039d316-1c4b-4281-b951-d872f2087c98
* Add metrics to measure time elapsed between form load and form submission ↵isherman@chromium.org2011-09-021-3/+22
| | | | | | | | | | | with or without Autofill. BUG=none TEST=unit_tests --gtest_filter=AutofillMetricsTest.* Review URL: http://codereview.chromium.org/7740070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99447 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IPC marshalling of dictionaries with dots in their key names.kalman@chromium.org2011-08-191-1/+1
| | | | | | | | | | BUG= TEST=unit test Review URL: http://codereview.chromium.org/7671057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97435 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove using declaration of BinaryValue as it's no longer necessary.tfarina@chromium.org2011-08-051-2/+3
| | | | | | | | | | | BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7550026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95638 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize struct member in LogData.finnur@chromium.org2011-03-301-2/+7
| | | | | | | | | BUG=None TEST=None CID=13235, 1234. Review URL: http://codereview.chromium.org/6731040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79811 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Real* to Double* in values.* and dependent filesarv@chromium.org2011-02-011-4/+4
| | | | | | | | | BUG=None TEST=Compiles and passes all tests Review URL: http://codereview.chromium.org/6248026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73232 0039d316-1c4b-4281-b951-d872f2087c98
* Add proxies for some of the PDF & Flash functionality. There are still a fewbrettw@chromium.org2010-11-121-0/+17
| | | | | | | | | | | unimplemented parts in the Flash proxy, and I only implemented the necessary part of the PDF one. TEST=none BUG=none Review URL: http://codereview.chromium.org/4752008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65951 0039d316-1c4b-4281-b951-d872f2087c98
* Added IPC ParamTraits for TimeDelta.apatrick@chromium.org2010-10-211-0/+19
| | | | | | | | | | | | Already reviewed as part of http://codereview.chromium.org/3794011/show TBR=kbr@chromium.org TEST=try BUG=none Review URL: http://codereview.chromium.org/4026004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63435 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63388 - ↵stoyan@chromium.org2010-10-211-19/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests%20(dbg)(2)/builds/10949 - Relanding 61718. I disabled the GPU watchdog in three new cases: - If the OSMesa software renderer is in use. This will disable it on bots. - When running on valgrind, whether on a bot or locally. - In debug builds I added a GPU process initialization time to the GPU info. I moved the GPU initialization code outside the watchdog protection because it can take a long time and trigger the watchdog. I increased the timeout. I set up a field trial with different timeouts to see the rate of failure for each period. I made ui_tests always run with OSMesa, for consistent operation on bots and when run locally. Original CL description: I added a watchdog thread that intermitently checks the main thread can respond to tasks posted on its message queue. I fixed some bugs that preventede GGL from failing when the GPU channel was lost. Added a command line swith to disable the watchdog thread for debugging purposes. TEST=try, local testing of all features BUG=none Review URL: http://codereview.chromium.org/3794011 TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/3979004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63396 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding 61718.apatrick@chromium.org2010-10-211-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I disabled the GPU watchdog in three new cases: - If the OSMesa software renderer is in use. This will disable it on bots. - When running on valgrind, whether on a bot or locally. - In debug builds I added a GPU process initialization time to the GPU info. I moved the GPU initialization code outside the watchdog protection because it can take a long time and trigger the watchdog. I increased the timeout. I set up a field trial with different timeouts to see the rate of failure for each period. I made ui_tests always run with OSMesa, for consistent operation on bots and when run locally. Original CL description: I added a watchdog thread that intermitently checks the main thread can respond to tasks posted on its message queue. I fixed some bugs that preventede GGL from failing when the GPU channel was lost. Added a command line swith to disable the watchdog thread for debugging purposes. TEST=try, local testing of all features BUG=none Review URL: http://codereview.chromium.org/3794011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63388 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to ↵erg@google.com2010-09-301-0/+32
| | | | | | | | | | | | | | non-POD structs. Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on a whole bunch of virtual dtors that were missing it. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3522004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all wstrings from the IPC logging subsystem.erg@google.com2010-08-181-16/+52
| | | | | | | | | | | | | | | | Changes all IPC Log methods from wstring to string. All static logging debug data changed from wchar[] to char[]. Various string conversion/numeric headers no longer need to be included in ipc_message_utils.h and have been removed (and added in all implementation files that require them). BUG=none TEST=none Review URL: http://codereview.chromium.org/3159013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56563 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 20:48:36 +0000