summaryrefslogtreecommitdiffstats
path: root/ipc
Commit message (Collapse)AuthorAgeFilesLines
* Initialize IPC:ChannelHandle from existing HANDLEamit@chromium.org2012-01-244-13/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1] Add a ctor to IPC:ChannelHandle that takes a pipe HANDLE. 2] Corresponding change in Channel::ChannelImpl::CreatePipe to attach to the given pipe instead of creating a new one. Being able to hand over a pipe handle to IPC::Channel in this way has other advantages such as using anonymous pipes and safer connections between process with different level of privileges. Here's how it can be done: Server Process: - Create a server pipe, anonymous pipe is fine too. - Server creates a client handle of pipe using CreateFile. - Use DuplicateHandle to duplicate this handle for the client process. - pass over the handle value to the client process, say using comman line. Client process: - Simply receive the handle from the server and hand it over to IPC:Channel using IPC::ChannelHandle. Apart from being more flexible, this is more secure as it removes the 'connection window' while using names. BUG=none TEST=none Review URL: http://codereview.chromium.org/9150030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118786 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by jeremy.tedvessenes@gmail.com2012-01-134-9/+9
| | | | | | | | | | | R=jeremy@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9148039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117557 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplement ReceivedSyncMsgQueue::DispatchMessagesjhorwich@chromium.org2012-01-112-18/+288
| | | | | | | | | | | | | | | | | Implementation of IPC::SyncChannel::ReceivedSyncMsgQueue::DispatchMessages that does not hold any messages in a local stack-frame's delayed_queue, which was causing me to see an inbound sync message from a plugin not dispatched while the renderer was waiting for replies from the plugin. This was causing the plugin and renderer to deadlock waiting for each other. BUG=108491 TEST=Run Pepperized O3D and observe for tab hangs TEST=Run ipc_tests unittests Review URL: http://codereview.chromium.org/9022038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117309 0039d316-1c4b-4281-b951-d872f2087c98
* Change over IgnoreReturn to IgnoreResult. remove IgnoreReturn.ajwong@chromium.org2012-01-061-3/+2
| | | | | | | | | BUG=98919 TEST=existing Review URL: http://codereview.chromium.org/9111032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116631 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix leaks.jhawkins@chromium.org2011-12-211-0/+2
| | | | | | | | | | | | CID=2168,8197,8198,100251,100256,100820,101011,101982,101983,101984,101988, 102256 BUG=none TEST=none R=dpapad Review URL: http://codereview.chromium.org/8989036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115422 0039d316-1c4b-4281-b951-d872f2087c98
* Removing MessageLoop::QuitTask() from ipc/dcheng@chromium.org2011-12-081-1/+1
| | | | | | | | | | | | | base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Review URL: http://codereview.chromium.org/8885020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113697 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add an Options enum to MessageBoxView control.tfarina@chromium.org2011-12-071-1/+1
| | | | | | | | | R=sky@chromium.org TBR=jam@chromium.org Review URL: http://codereview.chromium.org/8553001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113331 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert IPC::SendTask.jhawkins@chromium.org2011-11-292-12/+14
| | | | | | | | | | | BUG=none TEST=none R=groby@chromium.org Review URL: http://codereview.chromium.org/8714003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111837 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert Tasks in ipc_sync_channel_unittest.cc.jhawkins@chromium.org2011-11-281-21/+14
| | | | | | | | | | | BUG=none TEST=none R=groby@chromium.org Review URL: http://codereview.chromium.org/8718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111728 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of view_messages.h includes from chrome by making the ↵jam@chromium.org2011-11-217-1/+20
| | | | | | | | | TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it. BUG=98716 Review URL: http://codereview.chromium.org/8603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110963 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to ipc/.avi@chromium.org2011-11-177-21/+21
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8590004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110495 0039d316-1c4b-4281-b951-d872f2087c98
* Allow proxy channels to be created without initializing the underlying channel.kkania@chromium.org2011-11-165-34/+139
| | | | | | | | | | | | | | This fixes a bug where a client needed to guarantee a message filter was in place before any messages were received. It also follows the style of not having constructors that do complex initialization. BUG=102894 TEST=none Review URL: http://codereview.chromium.org/8417054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110229 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment a different third IPC hook for about:profilerjar@chromium.org2011-11-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito So far, I've uncommented two hooks, with no problems ;-). One of these hooks will illuminate the problems. r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8463033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110114 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-1/+2
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded forward declarations in base, dbug, gpu, ipc, ↵thestig@chromium.org2011-11-152-7/+5
| | | | | | | | | | jingle, and media. BUG=none TEST=none Review URL: http://codereview.chromium.org/8511045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109998 0039d316-1c4b-4281-b951-d872f2087c98
* base:Bind: Convert ipc/.jhawkins@chromium.org2011-11-127-62/+71
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8539036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109810 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 109760 - Uncomment third IPC hook for about:profilerjar@chromium.org2011-11-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito So far, I've uncommented two hooks, with no problems ;-). One of these hooks will illuminate the problems. r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8491065 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8538035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109762 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment third IPC hook for about:profilerjar@chromium.org2011-11-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito So far, I've uncommented two hooks, with no problems ;-). One of these hooks will illuminate the problems. r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8491065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109760 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment second IPC hook for about:profilerjar@chromium.org2011-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8540015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109721 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment first (major) IPC hook for about:profilerjar@chromium.org2011-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8515022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109553 0039d316-1c4b-4281-b951-d872f2087c98
* Land commented out IPC hooks for profilingjar@chromium.org2011-11-111-31/+42
| | | | | | | | | | | | | When I uncomment them all, then browser tests timeout under ASAN for no apparent reason. This landing will make it easier for me to uncomment them one at a time. (without going back to square one). r=rtenneti BUG/103830 Review URL: http://codereview.chromium.org/8526016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109542 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 109357 - Support tracking of IPC messages as tasks in profilerjar@chromium.org2011-11-101-36/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was previously landed as 108752, but reverted in 109004 by Joi to try to stop flaky failures in ASAN bot when running browser_tests.. The failures included: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito I'm now landing 1 hook at a time back into the build, to see which one(s) tickle flakiness. The other hooks are commented out, so that I can try several alternatives and figure out what is tickling the problem. The restructuring of the code was already landed, and did not *appear* to induce the failures. Hence it is likely that one of the IPC hooks is the problem. If I need to, I'll TBR various owners, since I've already gotten permission for this landing. r=rtenneti Review URL: http://codereview.chromium.org/8499039 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8506037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109371 0039d316-1c4b-4281-b951-d872f2087c98
* Support tracking of IPC messages as tasks in profilerjar@chromium.org2011-11-101-26/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was previously landed as 108752, but reverted in 109004 by Joi to try to stop flaky failures in ASAN bot when running browser_tests.. The failures included: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito I'm now landing 1 hook at a time back into the build, to see which one(s) tickle flakiness. The other hooks are commented out, so that I can try several alternatives and figure out what is tickling the problem. The restructuring of the code was already landed, and did not *appear* to induce the failures. Hence it is likely that one of the IPC hooks is the problem. If I need to, I'll TBR various owners, since I've already gotten permission for this landing. r=rtenneti Review URL: http://codereview.chromium.org/8499039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109357 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 108752 - Support tracking of IPC messages as tasks in profilerjoi@chromium.org2011-11-081-21/+14
| | | | | | | | | | | | | | Also started to do more cleanup, including creating a base/profiler directory, and moving parts of the over-sized tracked_objects.* into that directory. r=rtenneti Review URL: http://codereview.chromium.org/8480014 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8496008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109004 0039d316-1c4b-4281-b951-d872f2087c98
* Support tracking of IPC messages as tasks in profilerjar@chromium.org2011-11-051-14/+21
| | | | | | | | | | | Also started to do more cleanup, including creating a base/profiler directory, and moving parts of the over-sized tracked_objects.* into that directory. r=rtenneti Review URL: http://codereview.chromium.org/8480014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108752 0039d316-1c4b-4281-b951-d872f2087c98
* Android IPC changes.jrg@chromium.org2011-11-046-5/+25
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8437033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108589 0039d316-1c4b-4281-b951-d872f2087c98
* Add gamepad IPC message definitions, not in-use yet.scottmg@chromium.org2011-10-281-0/+1
| | | | | | | | | | | | | Part of larger patch here http://codereview.chromium.org/8345027/ which is updated with remaining pieces. BUG=79050 TEST= Review URL: http://codereview.chromium.org/8417034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107765 0039d316-1c4b-4281-b951-d872f2087c98
* more content exports.dpranke@chromium.org2011-10-271-2/+2
| | | | | | | | | | R=jam@chromium.org BUG=90442 TEST=none Review URL: http://codereview.chromium.org/8381024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107510 0039d316-1c4b-4281-b951-d872f2087c98
* Update automation messages to use the new way of declaring message structs, ↵jam@chromium.org2011-10-211-3/+1
| | | | | | | | to cut back on unnecessary code. Review URL: http://codereview.chromium.org/8356020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106734 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the renderer component of the Java Bridgesteveblock@chromium.org2011-10-201-0/+1
| | | | | | | | | | | | This patch adds JavaBridgeDispatcher, which handles injecting Java objects into the main frame of a RenderView. It also adds the IPC messages that are sent from browser to renderer to manage the injection of these Java objects. BUG=96703 Review URL: http://codereview.chromium.org/8347005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106614 0039d316-1c4b-4281-b951-d872f2087c98
* More message names and some timing output for the IPC logging.scottbyer@chromium.org2011-10-203-9/+87
| | | | | | | | | | | | With ANSI color if asked for. BUG=none TEST=none Review URL: http://codereview.chromium.org/8319023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106541 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD patch for ipc, split from CR #8275005mark@chromium.org2011-10-181-1/+5
| | | | | | | | | | | | | Include <sys/uio.h> on OpenBSD and share the getpeerid code with Mac. Patch by Robert Nagy <robert@openbsd.org> BUG= TEST= Review URL: http://codereview.chromium.org/8330025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106080 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IPC logging on Windows.jam@chromium.org2011-10-172-7/+12
| | | | | | Review URL: http://codereview.chromium.org/8322013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105937 0039d316-1c4b-4281-b951-d872f2087c98
* Use a placeholder instead of the default plugin for missing plug-ins on Mac ↵bauerb@chromium.org2011-10-051-0/+31
| | | | | | | | | | | | and Linux. BUG=62079 TEST=Missing plug-in placeholder looks different Review URL: http://codereview.chromium.org/7990005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104144 0039d316-1c4b-4281-b951-d872f2087c98
* Here are more exports needed for content_unittests to link in the component ↵dpranke@chromium.org2011-09-301-1/+1
| | | | | | | | | | | | build. R=jam@chromium.org, darin@chromium.org BUG=90442 TEST= Review URL: http://codereview.chromium.org/8054037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103394 0039d316-1c4b-4281-b951-d872f2087c98
* Improve IPC logging for ChannelHandle and NPVariant_Paramsteveblock@chromium.org2011-09-231-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7885043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102475 0039d316-1c4b-4281-b951-d872f2087c98
* Delete Tracked, and move Location to its own file.ajwong@chromium.org2011-09-215-1/+6
| | | | | | | | | | | | | The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure. Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file. BUG=none TEST=builds Review URL: http://codereview.chromium.org/7879006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gyp flag to enable dcheck by default in release withoutnsylvain@chromium.org2011-09-201-3/+3
| | | | | | | | | having the pass a flag. This will be used on the try bots. BUG=96753 Review URL: http://codereview.chromium.org/7719007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102017 0039d316-1c4b-4281-b951-d872f2087c98
* Wait properly for renderer crashesphajdan.jr@chromium.org2011-09-195-24/+54
| | | | | | | | | | | | | | This replaces a Sleep in automation with a wait for renderer crash. It turns out that our IPC on POSIX had one loophole that caused it not to notice very early crashes, so I also fixed that. The problem was that when the child process died before connecting to the parent's IPC channel, the parent wouldn't notice the crash because the child end of the IPC pipe was kept open for too long. This change makes the code close the child end of the pipe right after forking the child. This might also help with automation not noticing the browser crash during initial launch, or at least should be a good step toward fixing that problem. BUG=38497,90489 Review URL: http://codereview.chromium.org/7870008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101760 0039d316-1c4b-4281-b951-d872f2087c98
* Add messages/handlers for the invocation sequence. Copy from ↵gbillock@chromium.org2011-09-161-0/+1
| | | | | | | | | | | | | | geolocation_dispatcher. Get return path serialization working. R=groby@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/7823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101536 0039d316-1c4b-4281-b951-d872f2087c98
* Have SyncMessageFilter hold a reference to MessageLoopProxy instead of a ↵sievers@chromium.org2011-09-162-11/+14
| | | | | | | | | | | weak pointer. BUG=95867 Review URL: http://codereview.chromium.org/7908013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101473 0039d316-1c4b-4281-b951-d872f2087c98
* Move the V8 benchmarking_extension.cc/.h files out of webkit/extensions into ↵ananta@chromium.org2011-09-151-0/+1
| | | | | | | | | | | | | | | | | | | chrome as the functionality exposed by this extension is chrome specific. The IPCs used by this extension have all been moved to chrome to a new header file benchmarking_messages.h in chrome\common. Added a new message filter object in chrome\browser which filters the benchmarking IPCs. Most of the changes in this CL are centered around ensuring that the benchmarking stuff gets initialized in the same order as before. Continuing changes to get rid of the pattern of IPC messags spanning across content and chrome. BUG=87335 Review URL: http://codereview.chromium.org/7885013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101214 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak if user of IPC::SyncMessage never calls GetReplyDeserializer().dmichael@chromium.org2011-09-092-6/+9
| | | | | | | | | | | | | | | This isn't a problem for most real code, because SyncChannel and SyncMessageFilter do it for you. It shows up in ppapi_unittests (and presumably any other tests that rely on IPC::TestSink). Also removed some code that worked around the problem. Bonus: Allow running ppapi_unittests in tools/valgrind/chrome_tests.py. BUG=90240 TEST=valgrind trybots Review URL: http://codereview.chromium.org/7831060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100496 0039d316-1c4b-4281-b951-d872f2087c98
* add IPC_MESSAGE_EXPORT to IPC_STRUCT_BEGIN.dpranke@chromium.org2011-09-061-6/+6
| | | | | | | | | | | This is needed for complex message structures that need to marshall a lot of params (like ViewHostMsg_FrameNavigate_Params). R=darin@chromium.org BUG=90442 Review URL: http://codereview.chromium.org/7828067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99853 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99810 - Get the rest of the chrome target to build (but not link) ↵ben@chromium.org2011-09-061-11/+2
| | | | | | | | | | | | | with USE_AURA. http://crbug.com/93947 TEST=none Review URL: http://codereview.chromium.org/7839002 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7840010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99813 0039d316-1c4b-4281-b951-d872f2087c98
* Get the rest of the chrome target to build (but not link) with USE_AURA.ben@chromium.org2011-09-061-2/+11
| | | | | | | | http://crbug.com/93947 TEST=none Review URL: http://codereview.chromium.org/7839002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99810 0039d316-1c4b-4281-b951-d872f2087c98
* Add metrics to measure time elapsed between form load and form submission ↵isherman@chromium.org2011-09-022-3/+31
| | | | | | | | | | | with or without Autofill. BUG=none TEST=unit_tests --gtest_filter=AutofillMetricsTest.* Review URL: http://codereview.chromium.org/7740070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99447 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some constants declared as anonymous enums into static consts so ↵pkasting@chromium.org2011-09-016-32/+24
| | | | | | | | | | | | | | they have types. This defines the constants where they're declared to preserve the existing readability as well as allow us to do things like dimension arrays based on the values of the constants. The drawback to defining constants at their declaration point is that supplying them to a templated function, like what DCHECK_EQ() expands into, triggers an "undefined symbol" error on Mac/Linux (and adding explicit storage for them in the .cc file can cause duplicate symbol errors on Windows). Here I've worked around that by converting DCHECK_EQ(a, b) to DCHECK(b == a). The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but in general naming enums used to declare constants like this is bizarre ("enum Constants { ... }"?). BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7817005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99087 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce number of unnamed-type-template-args violations (mostly when passing ↵pkasting@chromium.org2011-09-011-12/+10
| | | | | | | | | | values to DCHECK(), ASSERT_EQ(), etc.), generally by naming previously-anonymous enums. We've decided not to eliminate the warning entirely because doing so is only possible with tons of ugly static_cast<>()s in Mac code. BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7605019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99086 0039d316-1c4b-4281-b951-d872f2087c98
* Moved the following IPC messages used by the chrome NPAPI plugin installer ↵ananta@chromium.org2011-08-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | out of content into Chrome. 1. PluginProcessHostMsg_GetPluginFinderUrl 2. PluginProcessHostMsg_MissingPluginStatus 3. PluginProcessHostMsg_DownloadUrl These messages are prefixed with Chrome. Removed the InstallMissingPlugin and OnInstallMissingPlugin handlers from the NPAPI plugin sources and from our webkit plugin implementation. The plugin infobar no longer sends over an IPC message to initiate installation of the third party plugin. It sends over a windows message which is handled in the plugin installer for Windows. This functionality is not implemented for the mac and linux as before. To display the plugin installation infobar the PluginProcessHostMsg_MissingPluginStatus message sent by the plugin needs the routing id and the renderer process id. This information is now passed along with the plugin instantiation parameters in NPP_New. These parameters are only read by the default plugin. This is a continuation of the fixes to ensure that IPC's don't span across content and chrome. BUG=87335 Review URL: http://codereview.chromium.org/7812020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99062 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-05 16:14:42 +0000