| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This came up in code review, where somebody was creating a SyncChannel on the IO thread. That will easily lead to deadlocks.
For ChannelProxy, it seems OK to have them be the same thread so long as there is no Listener. We apparently already do this in one place:
https://code.google.com/p/chromium/codesearch#chromium/src/components/nacl/browser/nacl_process_host.cc&l=866
BUG=
Review URL: https://codereview.chromium.org/234253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There are no callers except tests.
BUG=None
Review URL: https://codereview.chromium.org/238813010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes enough issues so that we can compile and link some libraries, but
it is not yet a working build.
Work remaining:
- base needs JNI support ('base_jni_headers', etc.)
- we need to figure out what should link and/or be APKs to run the tests
- we need to adjust GN to only build in the host config, not the target config.
R=brettw@chromium.org, cjhopman@chromium.org
TBR=jam
BUG=360936
Review URL: https://codereview.chromium.org/227673008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert some static libraries to source sets.
Add an "icu" metalibrary that can be used by targets needing both ICU libs.
Rename some base targets to have shorter names.
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/225093021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=350378
Review URL: https://codereview.chromium.org/219653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=335082
TBR=thakis
Review URL: https://codereview.chromium.org/219963007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/218403010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Also delete two dead methods in other files.)
BUG=31877
NOTRY=true
Review URL: https://codereview.chromium.org/218133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Temporary CHECK version 2 in IPC::Channel::Send() to help track down crash.
>
> TBR=sievers@chromium.org, cpu@chromium.org
> BUG=357915
>
> Review URL: https://codereview.chromium.org/218433002
TBR=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/216933007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Another temporary CHECK to help track down crash in IPC.
>
> (Grasping at straws here.)
>
> TBR=sievers@chromium.org, cpu@chromium.org
> BUG=357915
>
> Review URL: https://codereview.chromium.org/218513002
TBR=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/218573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Grasping at straws here.)
TBR=sievers@chromium.org, cpu@chromium.org
BUG=357915
Review URL: https://codereview.chromium.org/218513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sievers@chromium.org, cpu@chromium.org
BUG=357915
Review URL: https://codereview.chromium.org/218433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add a temporary CHECK to IPC::Channel::Send() to help track down crash.
>
> TBR=cbentzel@chromium.org, cpu@chromium.org
> BUG=357915
>
> Review URL: https://codereview.chromium.org/216293008
TBR=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/217323004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=cbentzel@chromium.org, cpu@chromium.org
BUG=357915
Review URL: https://codereview.chromium.org/216293008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322664
Review URL: https://codereview.chromium.org/209193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=cpu@chromium.org
NOTRY=true
No try as this is blocking the Win64 build.
Review URL: https://codereview.chromium.org/206853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing the following steps with ChannelProxy leads to a data race:
1) Create the ChannelProxy, but don't initialize it.
2) Add a filter.
3) Init the ChannelProxy.
The problem is, AddFilter() posts a task from the Listener thread to the IPC task runner to do OnAddFilter. Prior to this patch, OnAddFilter will try to read channel_ even though channel_ may not have been initialized, and it's accessed without any synchronization.
This patch only really adds the filter if peer_pid_ has been set on the IPC::Channel thread; otherwise, it waits until the connection has been established to really add filters.
See the bug for more detail.
BUG=244383
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256188
Review URL: https://codereview.chromium.org/183553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was several minor issues:
- Base perf logging file location was off-limits on Android
- Printf needs to be flushed to be visible on Android.
- Android needs to reset the 'PipeMap' manually since we can't 'exec' after
forking a test process. If we don't do this the Channel thinks we are in a single-
process test and tries to open an FD which was closed during forking.
- Android's base file descriptor needs to be increased to prevent stomping
the android native logging file-descriptor with the default pipe.
- The test took too long, so the 'exponent' is reduced from 5 to 3
- We need an APK
With this patch the test runs like on other platforms, and lots of testing code is
fixed such that it works the same way on all platforms.
BUG=345471
Review URL: https://codereview.chromium.org/196343019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The typical number of components per LatencyInfo instance is quite small. Avoid
unnecessary heap allocation by using a SmallMap to store component entries.
This reduces the average browser send time cost per touch or scroll event by
~15us on a Nexus 4, and ~22us on a Galaxy Nexus.
BUG=341613
Review URL: https://codereview.chromium.org/157003005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is initiated and owned by RenderProcessHost. I've added a
method to RenderProcessHostImpl to create the channel. No one is
calling it yet, that will come after this.
RenderProcessHostImpl::CreateMojoChannel initiates the connection and
sends an IPC message to the renderer. The renderer than creates its
end of the connection.
End to end test will come once I've added all the pieces.
BUG=none
TEST=none
R=darin@chromium.org, tsepez@chromium.org, viettrungluu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257342
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257505
Review URL: https://codereview.chromium.org/195993010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Broke Linux Official builds -- packaging stuff. mojo_system.so needs to be
added to some list(s) somewhere, I think.]
> Adds the ability for the renderer to create the mojo channel
>
> This is initiated and owned by RenderProcessHost. I've added a
> method to RenderProcessHostImpl to create the channel. No one is
> calling it yet, that will come after this.
>
> RenderProcessHostImpl::CreateMojoChannel initiates the connection and
> sends an IPC message to the renderer. The renderer than creates its
> end of the connection.
>
> End to end test will come once I've added all the pieces.
>
> BUG=none
> TEST=none
> R=darin@chromium.org, tsepez@chromium.org, viettrungluu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257342
>
> Review URL: https://codereview.chromium.org/195993010
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/202683004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is initiated and owned by RenderProcessHost. I've added a
method to RenderProcessHostImpl to create the channel. No one is
calling it yet, that will come after this.
RenderProcessHostImpl::CreateMojoChannel initiates the connection and
sends an IPC message to the renderer. The renderer than creates its
end of the connection.
End to end test will come once I've added all the pieces.
BUG=none
TEST=none
R=darin@chromium.org, tsepez@chromium.org, viettrungluu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257342
Review URL: https://codereview.chromium.org/195993010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later.
I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified.
I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition).
Reland of https://codereview.chromium.org/191673003/
R=agl, viettrungluu
Review URL: https://codereview.chromium.org/202113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/195993010/)
Reason for revert:
Broke linux bot:
FAILED: c++ -Wl,-z,now -Wl,-z,relro -pthread -Wl,-z,noexecstack -fPIC -L. -Wl,-uIsHeapProfilerRunning,-uProfilerStart -Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi -Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl -Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv -m32 -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o content_perftests -Wl,--start-group obj/content/browser/renderer_host/input/content_perftests.input_router_impl_perftest.o obj/content/common/content_perftests.cc_messages_perftest.o obj/content/test/content_perftests.run_all_perftests.o obj/content/libcontent_browser.a obj/content/libcontent_common.a obj/content/libtest_support_content.a obj/base/libtest_support_base.a obj/cc/libcc.a obj/testing/libgtest.a obj/testing/perf/libperf_test.a obj/ui/gfx/libgfx.a obj/ui/gfx/libgfx_geometry.a obj/base/libbase.a obj/base/libbase_static.a obj/base/allocator/liballocator_extension_thunks.a obj/third_party/modp_b64/libmodp_b64.a obj/base/third_party/dynamic_annotations/libdynamic_annotations.a obj/base/libsymbolize.a obj/base/libxdg_mime.a obj/third_party/libevent/libevent.a obj/components/libtracing.a obj/ipc/libipc.a obj/net/libnet.a obj/base/libbase_i18n.a obj/third_party/icu/libicui18n.a obj/third_party/icu/libicuuc.a obj/third_party/icu/libicudata.a obj/crypto/libcrcrypto.a obj/net/third_party/nss/libcrssl.a obj/sdch/libsdch.a obj/third_party/zlib/libchrome_zlib.a obj/url/liburl_lib.a obj/build/linux/libgio.a obj/skia/libskia_library.a obj/skia/libskia_opts.a obj/skia/libskia_opts_ssse3.a obj/third_party/sfntly/libsfntly.a obj/skia/libskia_chrome.a obj/skia/libskia_chrome_opts.a obj/third_party/libjingle/libjingle.a obj/third_party/libjingle/libjingle_p2p_constants.a obj/ui/accessibility/libaccessibility.a obj/third_party/libpng/libpng.a obj/third_party/libjpeg_turbo/libjpeg_turbo.a obj/ui/accessibility/libax_gen.a obj/tools/json_schema_compiler/libapi_gen_util.a obj/ui/base/libui_base.a obj/ui/events/libevents_base.a obj/ui/events/libdom4_keycode_converter.a obj/ui/events/libevents.a obj/ui/shell_dialogs/libshell_dialogs.a obj/ui/aura/libaura.a obj/gpu/libcommand_buffer_client.a obj/gpu/libcommand_buffer_common.a obj/gpu/command_buffer/libgles2_utils.a obj/gpu/libcommand_buffer_service.a obj/gpu/libdisk_cache_proto.a obj/third_party/protobuf/libprotobuf_lite.a obj/third_party/re2/libre2.a obj/third_party/smhasher/libcityhash.a obj/ui/gl/libgl_wrapper.a obj/third_party/angle/src/libtranslator.a obj/third_party/angle/src/libpreprocessor.a obj/gpu/libgles2_cmd_helper.a obj/gpu/libgpu_config.a obj/build/linux/libpci.a obj/third_party/libXNVCtrl/libXNVCtrl.a obj/gpu/libgpu_ipc.a obj/ui/compositor/libcompositor.a obj/media/libmedia.a obj/third_party/opus/libopus.a obj/media/libshared_memory_support.a obj/media/libshared_memory_support_sse.a obj/third_party/ffmpeg/libffmpeg.a obj/third_party/libvpx/libvpx.a obj/third_party/libvpx/libvpx_asm_offsets_vp8.a obj/third_party/libvpx/libvpx_intrinsics_mmx.a obj/third_party/libvpx/libvpx_intrinsics_sse2.a obj/third_party/libvpx/libvpx_intrinsics_ssse3.a obj/media/libmedia_asm.a obj/media/libmedia_mmx.a obj/media/libmedia_sse.a obj/media/libmedia_sse2.a obj/gpu/libgles2_c_lib.a obj/gpu/libgles2_implementation.a obj/gpu/skia_bindings/libgpu_skia_bindings.a obj/third_party/WebKit/Source/platform/libblink_platform.a obj/third_party/WebKit/Source/wtf/libwtf.a obj/third_party/WebKit/Source/platform/libblink_common.a obj/third_party/libwebp/libwebp_dec.a obj/third_party/libwebp/libwebp_dsp.a obj/third_party/libwebp/libwebp_utils.a obj/third_party/libwebp/libwebp_demux.a obj/third_party/libwebp/libwebp_enc.a obj/third_party/ots/libots.a obj/third_party/brotli/libbrotli.a obj/third_party/qcms/libqcms.a obj/v8/tools/gyp/libv8_base.ia32.a obj/v8/tools/gyp/libv8_snapshot.a obj/third_party/iccjpeg/libiccjpeg.a obj/third_party/harfbuzz-ng/libharfbuzz-ng.a obj/third_party/WebKit/Source/web/libblink_web.a obj/third_party/WebKit/Source/core/libwebcore_dom.a obj/third_party/WebKit/Source/heap/libblink_heap.a obj/third_party/WebKit/Source/heap/libblink_heap_asm_stubs.a obj/third_party/libxml/libxml2.a obj/third_party/libxslt/libxslt.a obj/third_party/sqlite/libsqlite3.a obj/third_party/WebKit/Source/core/libwebcore_html.a obj/third_party/WebKit/Source/core/libwebcore_remaining.a obj/third_party/WebKit/Source/core/libwebcore_rendering.a obj/third_party/WebKit/Source/core/libwebcore_svg.a obj/third_party/WebKit/Source/core/libwebcore_generated.a obj/gin/libgin.a obj/third_party/WebKit/Source/modules/libmodules.a obj/webkit/common/gpu/libwebkit_gpu.a obj/webkit/common/libwebkit_common.a obj/webkit/libwebkit_storage_browser.a obj/sql/libsql.a obj/third_party/leveldatabase/libleveldatabase.a obj/third_party/snappy/libsnappy.a obj/webkit/libwebkit_storage_common.a obj/mojo/libmojo_environment_chromium.a obj/mojo/libmojo_environment_chromium_impl.a obj/mojo/libmojo_common_lib.a obj/mojo/libmojo_system_impl.a obj/ppapi/libppapi_shared.a obj/ui/surface/libsurface.a obj/google_apis/libgoogle_apis.a obj/third_party/zlib/google/libzip.a obj/third_party/zlib/libminizip.a obj/ui/events/libgesture_detection.a obj/ui/snapshot/libsnapshot.a obj/content/browser/speech/proto/libspeech_proto.a obj/net/libhttp_server.a obj/printing/libprinting.a obj/sandbox/libsandbox_services.a obj/sandbox/libsuid_sandbox_client.a obj/sandbox/libseccomp_bpf.a obj/sandbox/libseccomp_bpf_helpers.a libyuv.a obj/jingle/libjingle_glue.a obj/third_party/webrtc/modules/libdesktop_capture.a obj/third_party/webrtc/system_wrappers/source/libsystem_wrappers.a obj/third_party/webrtc/modules/libdesktop_capture_differ_sse2.a obj/sandbox/libc_urandom_override.a obj/ppapi/libppapi_ipc.a obj/third_party/flac/libflac.a obj/third_party/speex/libspeex.a obj/dbus/libdbus.a obj/net/libnet_test_support.a obj/testing/libgmock.a obj/net/tools/tld_cleanup/libtld_cleanup_util.a obj/base/allocator/liballocator.a obj/net/libnet_with_v8.a obj/ui/events/libevents_test_support.a obj/ui/gfx/libgfx_test_support.a obj/content/libcontent_app_both.a obj/content/libcontent_child.a obj/webkit/child/libwebkit_child.a obj/ui/native_theme/libnative_theme.a obj/content/libcontent_gpu.a obj/content/libcontent_ppapi_plugin.a obj/content/libcontent_renderer.a obj/webkit/renderer/compositor_bindings/libwebkit_compositor_bindings.a obj/webkit/renderer/compositor_bindings/libwebkit_compositor_support.a obj/mojo/libmojo_js_bindings_lib.a obj/third_party/libjingle/libjingle_webrtc.a obj/third_party/libjingle/libjingle_webrtc_common.a obj/third_party/libsrtp/libsrtp.a obj/third_party/webrtc/modules/libmedia_file.a obj/third_party/webrtc/modules/libvideo_capture_module.a obj/third_party/webrtc/modules/libwebrtc_utility.a obj/third_party/webrtc/modules/libaudio_coding_module.a obj/third_party/webrtc/modules/libCNG.a obj/third_party/webrtc/common_audio/libcommon_audio.a obj/third_party/webrtc/common_audio/libcommon_audio_sse2.a obj/third_party/webrtc/modules/libG711.a obj/third_party/webrtc/modules/libG722.a obj/third_party/webrtc/modules/libiLBC.a obj/third_party/webrtc/modules/libiSAC.a obj/third_party/webrtc/modules/libiSACFix.a obj/third_party/webrtc/modules/libPCM16B.a obj/third_party/webrtc/modules/libNetEq.a obj/third_party/webrtc/modules/libwebrtc_opus.a obj/third_party/webrtc/modules/libacm2.a obj/third_party/webrtc/modules/libNetEq4.a obj/third_party/webrtc/modules/libwebrtc_video_coding.a obj/third_party/webrtc/modules/libwebrtc_i420.a obj/third_party/webrtc/common_video/libcommon_video.a obj/third_party/webrtc/modules/video_coding/utility/libvideo_coding_utility.a obj/third_party/webrtc/modules/video_coding/codecs/vp8/libwebrtc_vp8.a obj/third_party/webrtc/modules/libvideo_render_module.a obj/third_party/usrsctp/libusrsctplib.a obj/third_party/libjingle/libpeerconnection.a obj/third_party/webrtc/video_engine/libvideo_engine_core.a obj/third_party/webrtc/modules/librtp_rtcp.a obj/third_party/webrtc/modules/libpaced_sender.a obj/third_party/webrtc/modules/libremote_bitrate_estimator.a obj/third_party/webrtc/modules/remote_bitrate_estimator/librbe_components.a obj/third_party/webrtc/modules/libbitrate_controller.a obj/third_party/webrtc/modules/libvideo_processing.a obj/third_party/webrtc/modules/libvideo_processing_sse2.a obj/third_party/webrtc/voice_engine/libvoice_engine.a obj/third_party/webrtc/modules/libaudio_conference_mixer.a obj/third_party/webrtc/modules/libaudio_processing.a obj/third_party/webrtc/modules/libaudioproc_debug_proto.a obj/third_party/webrtc/modules/libaudio_processing_sse2.a obj/third_party/webrtc/modules/libaudio_device.a obj/ppapi/libppapi_host.a obj/ppapi/libppapi_proxy.a obj/content/libcontent_utility.a obj/content/libcontent_worker.a obj/cc/libcc_test_support.a obj/gpu/libgpu_unittest_utils.a obj/ui/gl/libgl_unittest_utils.a obj/ppapi/libppapi_unittest_shared.a obj/ipc/libtest_support_ipc.a obj/ui/aura/libaura_test_support.a obj/ui/compositor/libcompositor_test_support.a obj/ui/libui_test_support.a lib/libmojo_system.so -Wl,--end-group -lrt -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lX11 -lXi -lXrandr -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lgconf-2 -lgio-2.0 -lresolv -lfontconfig -lfreetype -lpangocairo-1.0 -lcairo -lpangoft2-1.0 -lpango-1.0 -lexpat -lXcursor -lXext -lXfixes -lXrender -lXcomposite -lasound -lXdamage -lXtst -lcups -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lgnutls -lgcrypt -lz -lpthread -lcrypt -lm -L/lib/i386-linux-gnu -lcap -ludev -ldbus-1
obj/content/common/mojo/content_common.mojo_channel_init.o: In function `content::MojoChannelInit::Init(int, scoped_refptr<base::TaskRunner>)':
mojo_channel_init.cc:(.text._ZN7content15MojoChannelInit4InitEi13scoped_refptrIN4base10TaskRunnerEE+0x230): undefined reference to `MojoClose'
obj/content/common/mojo/content_common.mojo_channel_init.o: In function `content::MojoChannelInit::~MojoChannelInit()':
mojo_channel_init.cc:(.text._ZN7content15MojoChannelInitD2Ev+0x124): undefined reference to `MojoClose'
mojo_channel_init.cc:(.text._ZN7content15MojoChannelInitD2Ev+0x134): undefined reference to `MojoClose'
obj/mojo/system/embedder/mojo_system_impl.embedder.o: In function `mojo::embedder::Init()':
embedder.cc:(.text._ZN4mojo8embedder4InitEv+0x30): undefined reference to `mojo::Core::Init(mojo::Core*)'
obj/mojo/system/embedder/mojo_system_impl.embedder.o: In function `mojo::embedder::CreateChannel(mojo::embedder::ScopedPlatformHandle, scoped_refptr<base::TaskRunner>, base::Callback<void (mojo::embedder::ChannelInfo*)>)':
embedder.cc:(.text._ZN4mojo8embedder13CreateChannelENS0_20ScopedPlatformHandleE13scoped_refptrIN4base10TaskRunnerEENS3_8CallbackIFvPNS0_11ChannelInfoEEEE+0x29): undefined reference to `mojo::Core::Get()'
obj/mojo/system/mojo_system_impl.core_impl.o: In function `mojo::system::CoreImpl::~CoreImpl()':
core_impl.cc:(.text._ZN4mojo6system8CoreImplD2Ev+0x4b): undefined reference to `mojo::Core::~Core()'
collect2: ld returned 1 exit status
ninja: build stopped: subcommand failed.
http://build.chromium.org/p/chromium/builders/Linux/builds/48261/steps/compile/logs/stdio
Original issue's description:
> Adds the ability for the renderer to create the mojo channel
>
> This is initiated and owned by RenderProcessHost. I've added a
> method to RenderProcessHostImpl to create the channel. No one is
> calling it yet, that will come after this.
>
> RenderProcessHostImpl::CreateMojoChannel initiates the connection and
> sends an IPC message to the renderer. The renderer than creates its
> end of the connection.
>
> End to end test will come once I've added all the pieces.
>
> BUG=none
> TEST=none
> R=darin@chromium.org, tsepez@chromium.org, viettrungluu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257342
TBR=darin@chromium.org,tsepez@chromium.org,viettrungluu@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/201283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is initiated and owned by RenderProcessHost. I've added a
method to RenderProcessHostImpl to create the channel. No one is
calling it yet, that will come after this.
RenderProcessHostImpl::CreateMojoChannel initiates the connection and
sends an IPC message to the renderer. The renderer than creates its
end of the connection.
End to end test will come once I've added all the pieces.
BUG=none
TEST=none
R=darin@chromium.org, tsepez@chromium.org, viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/195993010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/191673003/)
Reason for revert:
Doesn't correctly link
/mnt/data/b/build/slave/Chromium_Linux_Codesearch/build/src/third_party/gold/gold64: warning: hidden symbol 'base::internal::ScopedFDCloseTraits::Free(int)' in obj/base/files/nacl_helper.scoped_file.o is referenced by DSO lib/libipc.so
Original issue's description:
> Implement ScopedFD in terms of ScopedGeneric.
>
> Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later.
>
> I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified.
>
> I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition).
>
> BUG=
> R=agl@chromium.org, viettrungluu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257179
TBR=viettrungluu@chromium.org,agl@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/201203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later.
I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified.
I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition).
BUG=
R=agl@chromium.org, viettrungluu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001
Review URL: https://codereview.chromium.org/191673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/191673003/)
Reason for revert:
Doesn't build on android:
FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/memory/base.discardable_memory_allocator_android.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_CONFIGURATION_POLICY -DENABLE_NEW_GAMEPAD_API=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_MANAGED_USERS=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DBASE_IMPLEMENTATION -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen/base -I../../third_party/android_tools/ndk/sources/android/cpufeatures -I../.. -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-reserved-user-defined-literal -Wno-deprecated-register -Xclang -load -Xclang /mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-url-directory -fcolor-diagnostics -Wexit-time-destructors -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mthumb -no-integrated-as -B/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -Wa,--noexecstack -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -target arm-linux-androideabi -mllvm -arm-enable-ehabi --sysroot=/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm -I/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -g -fomit-frame-pointer -fdata-sections -ffunction-sections -funwind-tables -g0 -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -Wno-implicit-exception-spec-mismatch -Wno-abi -c ../../base/memory/discardable_memory_allocator_android.cc -o obj/base/memory/base.discardable_memory_allocator_android.o
../../base/memory/discardable_memory_allocator_android.cc:84:25:error: no matching function for call to 'mmap'
void* const address = mmap(
^~~~
/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm/usr/include/sys/mman.h:47:15: note: candidate function not viable: no known conversion from 'base::ScopedFD' (aka 'ScopedGeneric<int, internal::ScopedFDCloseTraits>') to 'int' for 5th argument
extern void* mmap(void *, size_t, int, int, int, off_t);
^
1 error generated.
Original issue's description:
> Implement ScopedFD in terms of ScopedGeneric.
>
> Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later.
>
> I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified.
>
> I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition).
>
> BUG=
> R=agl@chromium.org, viettrungluu@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001
TBR=viettrungluu@chromium.org,agl@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/197873014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later.
I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified.
I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition).
BUG=
R=agl@chromium.org, viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/191673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move most of chrome/common/extensions/extension_messages.h
into a new extensions/common/extension_messages.h file.
WebApplicationInfo-related IPC definitions are now in
chrome/common/extensions/chrome_extension_messages.h.
BUG=335159
TBR=sky@chromium.org,cdn@chromium.org
Review URL: https://codereview.chromium.org/194333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
TBR=jochen@chromium.org
BUG=348616
Review URL: https://codereview.chromium.org/183973021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/183553004/)
Reason for revert:
Since this has landed, testsuite content_browsertests is failing on bot Android Tests (dbg) on the chromium.linux waterfall.
Specifically, the WebContentsImplBrowserTest.OpenURLSubframe test is consistently crashing, with the following DCHECK:
[FATAL:device_orientation_message_filter.cc(18)] Check failed: BrowserThread::CurrentlyOn(BrowserThread::IO).
This corresponds the the following DCHECK about being on the IO thread:
DeviceOrientationMessageFilter::~DeviceOrientationMessageFilter() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (is_started_)
DeviceInertialSensorService::GetInstance()->RemoveConsumer(
CONSUMER_TYPE_ORIENTATION);
}
This same DCHECK failed in one of the try jobs on this CL: http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/133648
Since this DCHECK has never been observed to fail before (certainly not in the last 200 builds), and has failed both in this CL's try job and twice in a row on the waterfall since landing this CL, it seems very likely that this CL is the cause.
At a guess, the changes to ChannelProxy::Context::OnRemoveFilter seem quite relevant here.
Original issue's description:
> Eliminate a potential race in IPC::ChannelProxy
>
> Doing the following steps with ChannelProxy leads to a data race:
> 1) Create the ChannelProxy, but don't initialize it.
> 2) Add a filter.
> 3) Init the ChannelProxy.
>
> The problem is, AddFilter() posts a task from the Listener thread to the IPC task runner to do OnAddFilter. Prior to this patch, OnAddFilter will try to read channel_ even though channel_ may not have been initialized, and it's accessed without any synchronization.
>
> This patch only really adds the filter if peer_pid_ has been set on the IPC::Channel thread; otherwise, it waits until the connection has been established to really add filters.
>
> See the bug for more detail.
>
> BUG=244383
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256188
TBR=jam@chromium.org,dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=244383
Review URL: https://codereview.chromium.org/194923004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing the following steps with ChannelProxy leads to a data race:
1) Create the ChannelProxy, but don't initialize it.
2) Add a filter.
3) Init the ChannelProxy.
The problem is, AddFilter() posts a task from the Listener thread to the IPC task runner to do OnAddFilter. Prior to this patch, OnAddFilter will try to read channel_ even though channel_ may not have been initialized, and it's accessed without any synchronization.
This patch only really adds the filter if peer_pid_ has been set on the IPC::Channel thread; otherwise, it waits until the connection has been established to really add filters.
See the bug for more detail.
BUG=244383
Review URL: https://codereview.chromium.org/183553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(It was only ever given a "true" value once, and even that seemed dubious.)
R=phajdan.jr@chromium.org
TBR=darin@chromium.org, jeremy@chromium.org
Review URL: https://codereview.chromium.org/191483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's POSIX-only and redundant.
R=phajdan.jr@chromium.org
TBR=brettw@chromium.org,jam@chromium.org,gene@chromium.org
Review URL: https://codereview.chromium.org/187993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=322664
R=mseaborn@chromium.org, cpu@chromium.org
Review URL: https://codereview.chromium.org/165663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is using RenderViewObserver::OrientationChangeEvent and dispatch
the information down to the renderer. More will come with locking
and unlocking abilities.
BUG=162827
Review URL: https://codereview.chromium.org/176963016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step to separate CDM messages from MediaPlayer messages. In a
follow up CL, CDM messages will be moved to separate files.
BUG=315312
TBR=dcheng@chromium.org, ddorwin@chromium.org
Review URL: https://codereview.chromium.org/181903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Temperarily revert this CL so that I can land
https://codereview.chromium.org/181593004/, which needs to be merged back to
M34.
> Rename MediaKeys*Msg to Cdm*Msg.
>
> This is the first step to separate CDM messages from MediaPlayer messages. In a
> follow up CL, CDM messages will be moved to separate files.
>
> BUG=315312
> R=dcheng@chromium.org, ddorwin@chromium.org
>
> Review URL: https://codereview.chromium.org/181483005
TBR=xhwang@chromium.org
Review URL: https://codereview.chromium.org/180843008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step to separate CDM messages from MediaPlayer messages. In a
follow up CL, CDM messages will be moved to separate files.
BUG=315312
R=dcheng@chromium.org, ddorwin@chromium.org
Review URL: https://codereview.chromium.org/181483005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=345453
Review URL: https://codereview.chromium.org/178473007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChannelProxy currently offers messages to all member MessageFilters. It turns
out that a good portion of the most common message types will never be filtered,
making the O(N) filter walk an unnecessary affair. To prevent this, allow
MessageFilters to indicate which (if any) subset of message classes they may
filter, allowing the ChannelProxy to refine the list of filters that are offered
a particular message. This saves ~35us per message received on the browser IO
thread for a typical Android device.
Relanding with a few more guards for MessageFilter removal, access and message
class subscription.
BUG=340881
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/142923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/177123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
events. (https://codereview.chromium.org/164913004/)
Reason for revert:
SEE: https://code.google.com/p/chromium/issues/detail?id=346595
Original issue's description:
> Chromium plumbing for Screen Orientation API orientationchange events.
>
> This is using RenderViewObserver::OrientationChangeEvent and dispatch
> the information down to the renderer. More will come with locking
> and unlocking abilities.
>
> BUG=162827
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253029
TBR=jochen@chromium.org,cdn@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=162827
Review URL: https://codereview.chromium.org/177293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is using RenderViewObserver::OrientationChangeEvent and dispatch
the information down to the renderer. More will come with locking
and unlocking abilities.
BUG=162827
Review URL: https://codereview.chromium.org/164913004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=345453
R=brettw@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/174493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By this CL, plugin starts to talk with hosts via IPC.
For that purpose, ppapi_proxy is linked to nacl_helper (temporarily). This increase the size of nacl_helper, but when we split nacl_helper for non-sfi mode, it'll be resolved.
In SFI mode, this CL shouldn't affect the concept of IPC
channel connection between the plugin and the hosts. We
still use NaClIPCAdapter to wrap the IPC channel, and
NaClDesc for the plugin-side IPC file descriptors.
In non-SFI mode, we neither intercept nor rewrite the
message using NaClIPCAdapter, and the channels are
connected between the plugin and the hosts directly.
Note: plugin_main_nacl.cc is renamed to plugin_main.cc, because files with _nacl.cc suffix are automatically excluded from the sources of non-untrusted libs.
This increases the size of nacl_helper (temporarily) intentionally.
GYP_DEFINES="target_arch=ia32 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks
Before:
text data bss dec hex filename
1469882 15576 108644 1594102 1852f6 out/Release/nacl_helper
After:
text data bss dec hex filename
5641443 124636 126980 5893059 59ebc3 out/Release/nacl_helper
GYP_DEFINES="target_arch=x64 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks
Before:
text data bss dec hex filename
2063530 27910 213872 2305312 232d20 out/Release/nacl_helper
After:
text data bss dec hex filename
6304467 234424 247984 6786875 678f3b out/Release/nacl_helper
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Ran trybot.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252503
Review URL: https://codereview.chromium.org/140573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 3d41a2a63bbd307fcee6e6c5547ce5fe29e2f4a5.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By this CL, plugin starts to talk with hosts via IPC.
For that purpose, ppapi_proxy is linked to nacl_helper (temporarily). This increase the size of nacl_helper, but when we split nacl_helper for non-sfi mode, it'll be resolved.
In SFI mode, this CL shouldn't affect the concept of IPC
channel connection between the plugin and the hosts. We
still use NaClIPCAdapter to wrap the IPC channel, and
NaClDesc for the plugin-side IPC file descriptors.
In non-SFI mode, we neither intercept nor rewrite the
message using NaClIPCAdapter, and the channels are
connected between the plugin and the hosts directly.
Note: plugin_main_nacl.cc is renamed to plugin_main.cc, because files with _nacl.cc suffix are automatically excluded from the sources of non-untrusted libs.
This increases the size of nacl_helper (temporarily) intentionally.
GYP_DEFINES="target_arch=ia32 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks
Before:
text data bss dec hex filename
1469882 15576 108644 1594102 1852f6 out/Release/nacl_helper
After:
text data bss dec hex filename
5641443 124636 126980 5893059 59ebc3 out/Release/nacl_helper
GYP_DEFINES="target_arch=x64 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks
Before:
text data bss dec hex filename
2063530 27910 213872 2305312 232d20 out/Release/nacl_helper
After:
text data bss dec hex filename
6304467 234424 247984 6786875 678f3b out/Release/nacl_helper
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Ran trybot.
Review URL: https://codereview.chromium.org/140573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252503 0039d316-1c4b-4281-b951-d872f2087c98
|