summaryrefslogtreecommitdiffstats
path: root/ipc
Commit message (Collapse)AuthorAgeFilesLines
* Linux: remove unmaintained SELinux code.phajdan.jr@chromium.org2013-05-171-5/+0
| | | | | | | | | | | | See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/YpU7t2XaGRg/V9-diQZQQDwJ for discussion. BUG=none R=agl@chromium.org, jln@chromium.org Review URL: https://codereview.chromium.org/14771026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200838 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded base/file_util.h includes in chrome_frame, ↵thestig@chromium.org2013-05-162-2/+1
| | | | | | | | courgette, ipc, media, and net. Review URL: https://chromiumcodereview.appspot.com/14820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200419 0039d316-1c4b-4281-b951-d872f2087c98
* Implement web speech synthesis.dmazzoni@chromium.org2013-05-031-0/+1
| | | | | | | | | | | | | | | | Refactors TtsController a bit so that it can be used both by Tts extensions and by web speech. Implements almost all of the features of the web speech API. Requires corresponding WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=111695 BUG=171887 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12589005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198060 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove ALLOW_THIS_IN_INITIALIZER_LIST macro.tfarina@chromium.org2013-05-011-1/+1
| | | | | | | | | | | | All the usages were fixed in past revisions and the remaining usages were fixed within this patch. BUG=234765 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/14657004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197671 0039d316-1c4b-4281-b951-d872f2087c98
* Add kenrb as security team owner for ipc_message_start.h.kenrb@chromium.org2013-04-301-0/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/14674005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197503 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Use base::MessageLoop.xhwang@chromium.org2013-04-3018-101/+101
| | | | | | | | | BUG=236029 R=agl@chromium.org Review URL: https://chromiumcodereview.appspot.com/14383024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197465 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement form validation message UI with native widgets. (Common and Mac)tkent@chromium.org2013-04-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The current form validation message UI with Shadow DOM has a lot of problems and some of them are unresolvable if we continue to use Shadow DOM. We should stop using Shadow DOM. This patch implements a platform-indepedent part of WebKit::WebValidationMessageClient, and the Mac part. - Introduce ValidationMessageAgent, which implements WebKit::WebValidationMessageClient and lives in a renderer process of the chrome module. It dispatches IPC messages to the browser process. ValidationMessageAgent is used only on Mac for now. - ValidationMessageFilter receives the IPC messages in the browser process, and instructs to show/hide validation message UI. - Add common interface to control validation message UI validation_message_bubble.h - Add skelton implementations for non-Mac and a real implementation for Mac validation_message_bubble_*.* BUG=90252,90958,92816,104829,106621,113352,115451,125330,143356,146212,155448,166981,231170 Review URL: https://chromiumcodereview.appspot.com/13160004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197226 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new pair of IPC categories for messages that need handling as input eventsjamesr@chromium.org2013-04-271-0/+1
| | | | | | | | | | | | | | | | | | | | The compositor thread input filtering mechanism adds the possibility of handling some IPCs in the render process main thread in a different order than they were sent from the browser process since it filters some messages from the IO thread. For the most part, this is OK since the exact order of different types of messages is not important but there are some input-related messages that do need to processed in order - for instance MouseCaptureLost (see crbug.com/231532). This adds a new IPC class, InputMsg, for messages that need input-like filtering and InputHostMsg for their ACKs. All messages of this class are routed through the compositor thread to preserve order. BUG=233365 Review URL: https://chromiumcodereview.appspot.com/14487003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196907 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.scherkus@chromium.org2013-04-262-3/+3
| | | | | | | | | | It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details. BUG=234765 Review URL: https://chromiumcodereview.appspot.com/14261019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196807 0039d316-1c4b-4281-b951-d872f2087c98
* Adding WebRTC logging filter, handler and handler host.grunell@chromium.org2013-04-181-0/+1
| | | | | | | | | | | Updates to and usage of these will be added in coming CLs. BUG=229829 Review URL: https://chromiumcodereview.appspot.com/13119009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 193974 "Test extension reloading behavior."dmazzoni@chromium.org2013-04-121-3/+2
| | | | | | | | | | | | | | | | | | | | ExtensionServiceTest.ReloadExtension failed on Linux. > Test extension reloading behavior. > > By testing the actual interaction with renderer processes and the > notification system, I can expose the fact that we're starting a whole > extra process and loading the extension around 3 times. > > > BUG=178542 > > Review URL: https://chromiumcodereview.appspot.com/13533007 TBR=jyasskin@chromium.org Review URL: https://codereview.chromium.org/13844013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193986 0039d316-1c4b-4281-b951-d872f2087c98
* Test extension reloading behavior.jyasskin@chromium.org2013-04-121-2/+3
| | | | | | | | | | | | | By testing the actual interaction with renderer processes and the notification system, I can expose the fact that we're starting a whole extra process and loading the extension around 3 times. BUG=178542 Review URL: https://chromiumcodereview.appspot.com/13533007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193974 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-1/+2
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-091-2/+1
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-1/+2
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* Move MessageLoop to base namespace.brettw@chromium.org2013-03-311-1/+3
| | | | | | | | | | This adds a "using" to the header to avoid having to update everything at once. However, all forward declares and the locations that use the forward declares need to be updated (since they don't see the using in message_loop.h). BUG= Review URL: https://codereview.chromium.org/13243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191566 0039d316-1c4b-4281-b951-d872f2087c98
* Proudly fixing funny indents since 1969groby@chromium.org2013-03-301-3/+3
| | | | | | | | | | R=tsepez@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/12681030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191520 0039d316-1c4b-4281-b951-d872f2087c98
* Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper.dimich@chromium.org2013-03-291-1/+1
| | | | | | | | | | | | | | | | | | This is the first step of fixing http://crbug.com/196769. The problem is that there are two types of users of Content::DownloadFavicon() - the favicon consumers and regular icons and images consumers. Recently, the otherwise-generic image download+decoding implementation regressed because it was assumed to be only used for favicon loading. The proposed fix is to add a parameter to the method (enum, FAVICON/IMAGE) and rename it from DownloadFavicon to DownloadImage, to make sure the name corresponds to the impl/usage. This is rename-only part, no additional parameter yet. The FaviconHelper class was split in 2, with new ImageLoadingHelper dealing with images. BUG=196769 Review URL: https://chromiumcodereview.appspot.com/12780024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix libcxx build.eugenis@chromium.org2013-03-201-2/+5
| | | | | | | | | | | | | | In libcxx, vector<bool>::const_reference is not the same as bool. This requires a new specialization of ParamTraits. BUG=178409 R=tsepez@chromium.org,agl@chromium.org Review URL: https://chromiumcodereview.appspot.com/12943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189383 0039d316-1c4b-4281-b951-d872f2087c98
* Add cevans as an IPC OWNER for all areas.palmer@chromium.org2013-03-181-0/+1
| | | | | | | | | | He was an OWNER of some; now all. NOTRY=true Review URL: https://codereview.chromium.org/12672006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188870 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] Remove StringPrintf from global namespacegroby@chromium.org2013-03-182-10/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of StringPrintf now requires prefixing with base:: or a per-scope using directive TBR'd: abodenha: chrome/service brettw: content, third_party, webkit darin: base, chrome/browser, chrome/renderer dgarret: courgette enne: cc fischmann: media gbillock: sql joi: google_apis,components rsleevi: net, crypto sky: chrome/test thestig: printing, chrome/common, tsepez: ipc wez: remoting yfriedman: testing/android NOTRY=true R=brettw@chromium.org TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org BUG= Review URL: https://codereview.chromium.org/12767006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
* [mac] App shimsjeremya@chromium.org2013-03-181-0/+1
| | | | | | | | | | | | | | | | The AppShimHostController uses an IPC::ChannelFactory to listen on a socket for app shims connecting. App shims send a launch message when they start, so we translate that into actually launching the app. I changed chrome_main_app_mode_mac.mm to use the IPC channel instead of sending an Apple Event as before, and added an event loop and an IO thread. BUG=138733 Review URL: https://chromiumcodereview.appspot.com/12623005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188675 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket.jeremya@chromium.org2013-03-1313-185/+631
| | | | | | | | | | | | | | | IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate when a client connects. The delegate is expected to craft an IPC::Channel from the handle it is given. Previously committed: - https://src.chromium.org/viewvc/chrome?view=rev&revision=186912 - https://src.chromium.org/viewvc/chrome?view=rev&revision=187233 - https://src.chromium.org/viewvc/chrome?view=rev&revision=187554 Review URL: https://codereview.chromium.org/12386010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187772 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 187554 "Implement IPC::ChannelFactory, a class that accep..."falken@chromium.org2013-03-1313-615/+185
| | | | | | | | | | | | | | | | | | | | | | Reverting because it seems to cause failures on ipc_tests (UnixDomainSocketUtil.Connect, UnixDomainSocketUtil.SendReceive) on Android. > Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket. > > IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate > when a client connects. The delegate is expected to craft an IPC::Channel from > the handle it is given. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186912 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187233 > > Review URL: https://chromiumcodereview.appspot.com/12386010 TBR=jeremya@chromium.org Review URL: https://codereview.chromium.org/12431017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187760 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket.jeremya@chromium.org2013-03-1213-185/+615
| | | | | | | | | | | | | | IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate when a client connects. The delegate is expected to craft an IPC::Channel from the handle it is given. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187233 Review URL: https://chromiumcodereview.appspot.com/12386010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187554 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 187233dmikurube@chromium.org2013-03-1113-636/+185
| | | | | | | | | | | | | | | | | > Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket. > > IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate > when a client connects. The delegate is expected to craft an IPC::Channel from > the handle it is given. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186912 > > Review URL: https://chromiumcodereview.appspot.com/12386010 TBR=jeremya@chromium.org Review URL: https://codereview.chromium.org/12761003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187240 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket.jeremya@chromium.org2013-03-1113-185/+636
| | | | | | | | | | | | IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate when a client connects. The delegate is expected to craft an IPC::Channel from the handle it is given. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186912 Review URL: https://chromiumcodereview.appspot.com/12386010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187233 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 186912jeremya@chromium.org2013-03-0813-621/+185
| | | | | | | | | | | | | | | > Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket. > > IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate > when a client connects. The delegate is expected to craft an IPC::Channel from > the handle it is given. > > Review URL: https://codereview.chromium.org/12386010 TBR=jeremya@chromium.org Review URL: https://codereview.chromium.org/12510008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186919 0039d316-1c4b-4281-b951-d872f2087c98
* Implement IPC::ChannelFactory, a class that accept()s on a UNIX socket.jeremya@chromium.org2013-03-0813-185/+621
| | | | | | | | | | IPC::ChannelFactory listens on a UNIX domain socket and notifies its delegate when a client connects. The delegate is expected to craft an IPC::Channel from the handle it is given. Review URL: https://codereview.chromium.org/12386010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186912 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC handling for INVALID_HANDLE_VALUE on Win64 buildsjschuh@chromium.org2013-03-041-5/+5
| | | | | | | | BUG=179693 R=cpu@chromium.org Review URL: https://codereview.chromium.org/12381066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185826 0039d316-1c4b-4281-b951-d872f2087c98
* Minimal Chrome Frame with Aura.grt@chromium.org2013-02-281-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It builds and runs, but not a whole lot else. This change includes: * ChromeFrameAutomationProvider is now OS_WIN only. In practice, this has been the case for some time. Now it's formalized by giving the implementation files the _win suffix. * Automation messages and datatypes used exclusively by Chrome Frame now use HWND directly rather than a toolkit-specific gfx typedef of one since the requirement is that an actual HWND be sent over the channel. A change in toolkit (e.g., switching to Aura) must not change this. As a consequence of this change, some automation types and messages are now only defined for OS_WIN builds. * ExternalTabContainerWin is no longer derived from a NativeWidget type (this was previously the case so that the ETCW could be notified of NW lifecycle events). Now, in contrast, ETCW registers itself as an observer of its Widget. Two additional lifecycle methods have been added to WidgetObserver: OnWidgetCreated and OnWidgetDestroyed. * ExternalTabContianerWin initializes its Widget with an instance of DesktopNativeWidgetAura when use_aura. * A special note about HWND IPC marshaling: this change adds a type mapping from HWND to a generic HANDLE in ipc_message_utils.h, which allows for the removal of a hack in content_message_generator.h to marshal HWNDs. This change reverts all of: * r178752 -- Remove CF from all.gyp targets if use_aura is defined. * r164590 -- Remove setup -> Chrome Frame dependency. Make it possible to build an installer for Aura. and portions of: * r99993 -- Get chrome to link with USE_AURA * r99787 -- Preliminary work to allow Chrome to build with USE_AURA. BUG=171018 TEST=chrome_frame_tests provides good coverage in non-Aura builds. Review URL: https://chromiumcodereview.appspot.com/12220101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185328 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-244-6/+6
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Wrap unit test into IPC namespace.tfarina@chromium.org2013-02-151-3/+4
| | | | | | | | | | | | So we can remove the 'using namespace' directive. BUG=82078 TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/12286003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182802 0039d316-1c4b-4281-b951-d872f2087c98
* Rename FilePath -> base::FilePath in various toplevel directoriesbrettw@chromium.org2013-02-104-21/+21
| | | | | | Review URL: https://codereview.chromium.org/12211108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181639 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Convert MessageLoop::RunUntilIdle() usage to base::RunLoop variant.tfarina@chromium.org2013-02-081-6/+6
| | | | | | | | | | | | | | The former method is deprecated and actually it is just using RunLoop internally. The later is the cannonical method and should be used instead. BUG=131220 TEST=ipc_tests R=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/12225081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181539 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTTF: Add missing virtual destructors."phajdan.jr@chromium.org2013-02-061-2/+0
| | | | | | | | | | | | | | It turned out this is not necessary, we have a better warning already enabled in clang (-Wdelete-non-virtual-dtor, part of -Wall). TBR=darin,satorux,fischman,jamesr,jar,sky BUG=45135 Review URL: https://codereview.chromium.org/12224027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180971 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, ipc/ edition.rsleevi@chromium.org2013-02-065-60/+60
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://chromiumcodereview.appspot.com/12220032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180954 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Add missing virtual destructors.phajdan.jr@chromium.org2013-02-051-0/+2
| | | | | | | | | | | R=jar TBR=darin,satorux,fischman,jamesr,sky BUG=45135 Review URL: https://codereview.chromium.org/12086018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180669 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Simplify WaitableEventWatcher.teravest@chromium.org2013-02-042-15/+27
| | | | | | | | | | | | | | | | | | | | | | | This change uses a callback instead of a delegate for specifying what should be called when a WaitableEvent occurs. This simplifies the class and gets rid of a workaround internal to the class to prevent name collision on "Delegate" inner classes. Tested (linux and windows): out/Debug/base_unittests --gtest_filter=*WaitableEventWatcherTest* out/Release/ipc_tests with valgrind and leak-check=yes Previously reverted at: https://codereview.chromium.org/12087120/ BUG= Review URL: https://chromiumcodereview.appspot.com/12094106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180450 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath to base namespace.brettw@chromium.org2013-02-021-3/+3
| | | | | | | This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes. Review URL: https://codereview.chromium.org/12163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Chrome Signin from Webstoreguohui@chromium.org2013-02-011-0/+1
| | | | | | | | | | | | This CL adds webstore as a new source for Chrome signin. It also grabs password as soon as password form is submitted rather than at the end of navigation. The reason is webstore runs in its own context, redirect from gaia to webstore results in context swap during which password data is discarded, thus password must be sent to the oneclick signin helper before redirect occurs. PM mock at https://docs.google.com/a/google.com/presentation/d/1zCvdhBXKL8RDQwuRauSZdgCbiRexJRZ564z9Uw0wS6U/edit?disco=AAAAAFg3OEI#slide=id.g996e03e1_00. This CL implements the transition from slide 7 to 8. BUG=173433 Review URL: https://codereview.chromium.org/12086069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180086 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 179987dmichael@chromium.org2013-01-312-24/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Caused memory leak: Leak_DefinitelyLost 4,196 (1,600 direct, 2,596 indirect) bytes in 4 blocks are definitely lost in loss record 608 of 639 operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1140) IPC::SyncChannel::SyncChannel(IPC::ChannelHandle const&, IPC::Channel::Mode, IPC::Listener*, base::SingleThreadTaskRunner*, bool, base::WaitableEvent*) (ipc/ipc_sync_channel.cc:410) (anonymous namespace)::RestrictedDispatchPipeWorker::Run() (ipc/ipc_sync_channel_unittest.cc:1636) (anonymous namespace)::Worker::OnStart() (ipc/ipc_sync_channel_unittest.cc:176) Suppression (error hash=#2A77226DFEFF6041#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN3IPC11SyncChannelC1ERKNS_13ChannelHandleENS_7Channel4ModeEPNS_8ListenerEPN4base22SingleThreadTaskRunnerEbPNS8_13WaitableEventE fun:_ZN12_GLOBAL__N_128RestrictedDispatchPipeWorker3RunEv fun:_ZN12_GLOBAL__N_16Worker7OnStartEv } 15:02:51 memcheck_a http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/22101 > Refactor: Simplify WaitableEventWatcher. > > This change uses a callback instead of a delegate for specifying what > should be called when a WaitableEvent occurs. > > This simplifies the class and gets rid of a workaround internal to the > class to prevent name collision on "Delegate" inner classes. > > Tested (on linux and windows): > ninja -C out/Debug chrome > out/Debug/base_unittests --gtest_filter=*WaitableEventWatcherTest* > > BUG= > > > Review URL: https://chromiumcodereview.appspot.com/11953112 TBR=teravest@chromium.org Review URL: https://codereview.chromium.org/12087120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179993 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Simplify WaitableEventWatcher.teravest@chromium.org2013-01-312-15/+24
| | | | | | | | | | | | | | | | | | | This change uses a callback instead of a delegate for specifying what should be called when a WaitableEvent occurs. This simplifies the class and gets rid of a workaround internal to the class to prevent name collision on "Delegate" inner classes. Tested (on linux and windows): ninja -C out/Debug chrome out/Debug/base_unittests --gtest_filter=*WaitableEventWatcherTest* BUG= Review URL: https://chromiumcodereview.appspot.com/11953112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179987 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Do not use Value::Create* functions.tfarina@chromium.org2013-01-302-15/+15
| | | | | | | | | | BUG=160586 R=darin@chromium.org,estade@chromium.org Review URL: https://chromiumcodereview.appspot.com/12079026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179538 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow '\0' characters in FilePath.aedla@chromium.org2013-01-282-17/+12
| | | | | | | | | BUG=169777 Review URL: https://chromiumcodereview.appspot.com/11642041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179141 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor (many) IPC tests, notably most of the multiprocess tests.viettrungluu@chromium.org2013-01-2510-518/+472
| | | | | | | | | | | This factors out common code and, more importantly/usefully, makes test-specific code more local, and thus easier to add new tests and maintain existing ones. In particular, this allows you to add a new test "client" (running in another process) without modifying ipc_test_base.*. Review URL: https://codereview.chromium.org/12051048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178901 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Kill the base::Passed(foo.Pass()) meme.tfarina@chromium.org2013-01-231-1/+1
| | | | | | | | | | | | This can be simply spelled as base::Passed(&foo). BUG=155593 R=dmichael@chromium.org Review URL: https://chromiumcodereview.appspot.com/12042027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178209 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize visitedlinks to src/components/visitedlinkboliu@chromium.org2013-01-231-0/+1
| | | | | | | | | | | | | | | All visitedlink files moved to src/components/visitedlink/[browser|common|renderer|test] Created static lib targets for browser, common, and renderer. Test files are moved but still uses old test targets in chrome/ Dcommitted due to AllowScopedIO being moved but still triggers presubmit error. Bots are mostly happy. BUG=168716 Review URL: https://codereview.chromium.org/11825011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178176 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling nacl_win64 targets when building in target_arch!=ia32 mode.bradnelson@google.com2013-01-211-1/+1
| | | | | | | | | | | | | | | | When building on windows with target_arch=x64, we no longer need win32 targets forced to be 64-bit. This gates out these targets when target_arch!=ia32. (Prior CL dropped the minimal set to break the dependency between these targets and the rest of the build. This eliminates them completely.) BUG=None TEST=None R=jschuh@chromium.org,thestig@chromium.org TBR=darin@chromium.org,abodenha@chromium.org,apatrick@chromium.org,sra@chromium.org,wtc@chromium.org Review URL: https://chromiumcodereview.appspot.com/11929039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177959 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced DictionaryValue::key_iterator by DictionaryValue::Iterator outside ↵pneubeck@chromium.org2013-01-181-16/+6
| | | | | | | | | | | | | | | of chrome/browser. Marked Iterator::HasNext() as deprecated and added a method Iterator::CanAdvance() as replacement. As DictionaryValue::Iterator is actually a const iterator, I had to add several missing const annotations, mostly, in json_schema_validator.* and command.* BUG=162611 TEST=No new tests. Only semantically equivalent refactorings. Review URL: https://chromiumcodereview.appspot.com/11418150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177673 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 05:21:52 +0000