summaryrefslogtreecommitdiffstats
path: root/ipc
Commit message (Collapse)AuthorAgeFilesLines
* Revert of Eliminate a potential race in IPC::ChannelProxy ↵johnme@chromium.org2014-03-114-54/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/183553004/) Reason for revert: Since this has landed, testsuite content_browsertests is failing on bot Android Tests (dbg) on the chromium.linux waterfall. Specifically, the WebContentsImplBrowserTest.OpenURLSubframe test is consistently crashing, with the following DCHECK: [FATAL:device_orientation_message_filter.cc(18)] Check failed: BrowserThread::CurrentlyOn(BrowserThread::IO). This corresponds the the following DCHECK about being on the IO thread: DeviceOrientationMessageFilter::~DeviceOrientationMessageFilter() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); if (is_started_) DeviceInertialSensorService::GetInstance()->RemoveConsumer( CONSUMER_TYPE_ORIENTATION); } This same DCHECK failed in one of the try jobs on this CL: http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/133648 Since this DCHECK has never been observed to fail before (certainly not in the last 200 builds), and has failed both in this CL's try job and twice in a row on the waterfall since landing this CL, it seems very likely that this CL is the cause. At a guess, the changes to ChannelProxy::Context::OnRemoveFilter seem quite relevant here. Original issue's description: > Eliminate a potential race in IPC::ChannelProxy > > Doing the following steps with ChannelProxy leads to a data race: > 1) Create the ChannelProxy, but don't initialize it. > 2) Add a filter. > 3) Init the ChannelProxy. > > The problem is, AddFilter() posts a task from the Listener thread to the IPC task runner to do OnAddFilter. Prior to this patch, OnAddFilter will try to read channel_ even though channel_ may not have been initialized, and it's accessed without any synchronization. > > This patch only really adds the filter if peer_pid_ has been set on the IPC::Channel thread; otherwise, it waits until the connection has been established to really add filters. > > See the bug for more detail. > > BUG=244383 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256188 TBR=jam@chromium.org,dmichael@chromium.org NOTREECHECKS=true NOTRY=true BUG=244383 Review URL: https://codereview.chromium.org/194923004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256221 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate a potential race in IPC::ChannelProxydmichael@chromium.org2014-03-114-20/+54
| | | | | | | | | | | | | | | | | | | Doing the following steps with ChannelProxy leads to a data race: 1) Create the ChannelProxy, but don't initialize it. 2) Add a filter. 3) Init the ChannelProxy. The problem is, AddFilter() posts a task from the Listener thread to the IPC task runner to do OnAddFilter. Prior to this patch, OnAddFilter will try to read channel_ even though channel_ may not have been initialized, and it's accessed without any synchronization. This patch only really adds the filter if peer_pid_ has been set on the IPC::Channel thread; otherwise, it waits until the connection has been established to really add filters. See the bug for more detail. BUG=244383 Review URL: https://codereview.chromium.org/183553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256188 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of multiprocess_test's debug_on_start arguments.viettrungluu@chromium.org2014-03-092-15/+7
| | | | | | | | | | | (It was only ever given a "true" value once, and even that seemed dubious.) R=phajdan.jr@chromium.org TBR=darin@chromium.org, jeremy@chromium.org Review URL: https://codereview.chromium.org/191483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255801 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the MultiProcessTest::SpawnChild() that as an fds_to_map argument.viettrungluu@chromium.org2014-03-061-5/+4
| | | | | | | | | | | It's POSIX-only and redundant. R=phajdan.jr@chromium.org TBR=brettw@chromium.org,jam@chromium.org,gene@chromium.org Review URL: https://codereview.chromium.org/187993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255289 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some PlatformFile uses from NaCl.rvargas@chromium.org2014-03-052-0/+11
| | | | | | | | | BUG=322664 R=mseaborn@chromium.org, cpu@chromium.org Review URL: https://codereview.chromium.org/165663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255131 0039d316-1c4b-4281-b951-d872f2087c98
* Add use_allocator instead of linux_use_tcmalloc to switch the allocator.dmikurube@chromium.org2014-03-051-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change is to add a new build option 'use_allocator' which will replace 'linux_use_tcmalloc' in the future. It doesn't change the behavior immediately. The migration plan is as follows: 1) (this change) ... Add 'use_allocator' and set its default to "see_use_tcmalloc". ... Change allocator conditions to check use_allocator firstly. ... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc". ... NO IMPACT without specifying use_allocator explicitly. 2) Change Blink to accept use_allocator. http://crrev.com/177053003/ 3) Change gyp to accept use_allocator. http://crrev.com/178643004/ 4) PSA the transition period to chromium-dev@. 5) (after the PSA-ed transition period) ... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default. ... Remove all linux_use_tcmalloc. ... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified. At the point of this change (1), linux_use_tcmalloc is still used by default because 'use_allocator%': "see_use_tcmalloc". As written in http://crbug.com/345554, linux_use_tcmalloc would be confusing to have more options about allocators. We plan to: A) enable gperftools' heap-profiler with non-tcmalloc allocator, B) add a new memory allocator instead of tcmalloc. BUG=345554, 339604, 341349 R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org Review URL: https://codereview.chromium.org/177353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium plumbing for Screen Orientation API orientationchange events. mlamouri@chromium.org2014-02-271-0/+1
| | | | | | | | | | | | This is using RenderViewObserver::OrientationChangeEvent and dispatch the information down to the renderer. More will come with locking and unlocking abilities. BUG=162827 Review URL: https://codereview.chromium.org/176963016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253911 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r253665 "Rename MediaKeys*Msg to Cdm*Msg."xhwang@chromium.org2014-02-271-0/+1
| | | | | | | | | | | | This is the first step to separate CDM messages from MediaPlayer messages. In a follow up CL, CDM messages will be moved to separate files. BUG=315312 TBR=dcheng@chromium.org, ddorwin@chromium.org Review URL: https://codereview.chromium.org/181903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253807 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 253665 "Rename MediaKeys*Msg to Cdm*Msg."xhwang@chromium.org2014-02-271-1/+0
| | | | | | | | | | | | | | | | | | | | | | Temperarily revert this CL so that I can land https://codereview.chromium.org/181593004/, which needs to be merged back to M34. > Rename MediaKeys*Msg to Cdm*Msg. > > This is the first step to separate CDM messages from MediaPlayer messages. In a > follow up CL, CDM messages will be moved to separate files. > > BUG=315312 > R=dcheng@chromium.org, ddorwin@chromium.org > > Review URL: https://codereview.chromium.org/181483005 TBR=xhwang@chromium.org Review URL: https://codereview.chromium.org/180843008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253673 0039d316-1c4b-4281-b951-d872f2087c98
* Rename MediaKeys*Msg to Cdm*Msg.xhwang@chromium.org2014-02-271-0/+1
| | | | | | | | | | | | This is the first step to separate CDM messages from MediaPlayer messages. In a follow up CL, CDM messages will be moved to separate files. BUG=315312 R=dcheng@chromium.org, ddorwin@chromium.org Review URL: https://codereview.chromium.org/181483005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253665 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ipc_untrusted -> ipc_naclsergeyu@chromium.org2014-02-261-3/+3
| | | | | | | | BUG=345453 Review URL: https://codereview.chromium.org/178473007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253448 0039d316-1c4b-4281-b951-d872f2087c98
* Allow MessageFilters to restrict listening to specific message classesjdduke@chromium.org2014-02-264-6/+390
| | | | | | | | | | | | | | | | | | | | ChannelProxy currently offers messages to all member MessageFilters. It turns out that a good portion of the most common message types will never be filtered, making the O(N) filter walk an unnecessary affair. To prevent this, allow MessageFilters to indicate which (if any) subset of message classes they may filter, allowing the ChannelProxy to refine the list of filters that are offered a particular message. This saves ~35us per message received on the browser IO thread for a typical Android device. Relanding with a few more guards for MessageFilter removal, access and message class subscription. BUG=340881 TBR=asargent@chromium.org Review URL: https://codereview.chromium.org/142923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253361 0039d316-1c4b-4281-b951-d872f2087c98
* Use StaticAtomicSequenceNumber instead of subtle::Atomic32 in IPCMessage.andrew@tullo.ch2014-02-251-3/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/177123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253169 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Chromium plumbing for Screen Orientation API orientationchange ↵acleung@chromium.org2014-02-251-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | events. (https://codereview.chromium.org/164913004/) Reason for revert: SEE: https://code.google.com/p/chromium/issues/detail?id=346595 Original issue's description: > Chromium plumbing for Screen Orientation API orientationchange events. > > This is using RenderViewObserver::OrientationChangeEvent and dispatch > the information down to the renderer. More will come with locking > and unlocking abilities. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253029 TBR=jochen@chromium.org,cdn@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=162827 Review URL: https://codereview.chromium.org/177293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253077 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium plumbing for Screen Orientation API orientationchange events.mlamouri@chromium.org2014-02-241-0/+1
| | | | | | | | | | | | This is using RenderViewObserver::OrientationChangeEvent and dispatch the information down to the renderer. More will come with locking and unlocking abilities. BUG=162827 Review URL: https://codereview.chromium.org/164913004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253029 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base_untrusted to base_naclsergeyu@chromium.org2014-02-221-1/+1
| | | | | | | | | | BUG=345453 R=brettw@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/174493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252732 0039d316-1c4b-4281-b951-d872f2087c98
* Connect PPAPI IPC channels for non-SFI mode.hidehiko@chromium.org2014-02-211-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By this CL, plugin starts to talk with hosts via IPC. For that purpose, ppapi_proxy is linked to nacl_helper (temporarily). This increase the size of nacl_helper, but when we split nacl_helper for non-sfi mode, it'll be resolved. In SFI mode, this CL shouldn't affect the concept of IPC channel connection between the plugin and the hosts. We still use NaClIPCAdapter to wrap the IPC channel, and NaClDesc for the plugin-side IPC file descriptors. In non-SFI mode, we neither intercept nor rewrite the message using NaClIPCAdapter, and the channels are connected between the plugin and the hosts directly. Note: plugin_main_nacl.cc is renamed to plugin_main.cc, because files with _nacl.cc suffix are automatically excluded from the sources of non-untrusted libs. This increases the size of nacl_helper (temporarily) intentionally. GYP_DEFINES="target_arch=ia32 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks Before: text data bss dec hex filename 1469882 15576 108644 1594102 1852f6 out/Release/nacl_helper After: text data bss dec hex filename 5641443 124636 126980 5893059 59ebc3 out/Release/nacl_helper GYP_DEFINES="target_arch=x64 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks Before: text data bss dec hex filename 2063530 27910 213872 2305312 232d20 out/Release/nacl_helper After: text data bss dec hex filename 6304467 234424 247984 6786875 678f3b out/Release/nacl_helper BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734 TEST=Ran trybot. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252503 Review URL: https://codereview.chromium.org/140573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Connect PPAPI IPC channels for non-SFI mode."loislo@chromium.org2014-02-211-6/+0
| | | | | | This reverts commit 3d41a2a63bbd307fcee6e6c5547ce5fe29e2f4a5. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252506 0039d316-1c4b-4281-b951-d872f2087c98
* Connect PPAPI IPC channels for non-SFI mode.hidehiko@chromium.org2014-02-211-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By this CL, plugin starts to talk with hosts via IPC. For that purpose, ppapi_proxy is linked to nacl_helper (temporarily). This increase the size of nacl_helper, but when we split nacl_helper for non-sfi mode, it'll be resolved. In SFI mode, this CL shouldn't affect the concept of IPC channel connection between the plugin and the hosts. We still use NaClIPCAdapter to wrap the IPC channel, and NaClDesc for the plugin-side IPC file descriptors. In non-SFI mode, we neither intercept nor rewrite the message using NaClIPCAdapter, and the channels are connected between the plugin and the hosts directly. Note: plugin_main_nacl.cc is renamed to plugin_main.cc, because files with _nacl.cc suffix are automatically excluded from the sources of non-untrusted libs. This increases the size of nacl_helper (temporarily) intentionally. GYP_DEFINES="target_arch=ia32 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks Before: text data bss dec hex filename 1469882 15576 108644 1594102 1852f6 out/Release/nacl_helper After: text data bss dec hex filename 5641443 124636 126980 5893059 59ebc3 out/Release/nacl_helper GYP_DEFINES="target_arch=x64 remove_webcore_debug_symbols=1 linux_strip_symbols=1" GYP_GENERATORS="ninja" gclient runhooks Before: text data bss dec hex filename 2063530 27910 213872 2305312 232d20 out/Release/nacl_helper After: text data bss dec hex filename 6304467 234424 247984 6786875 678f3b out/Release/nacl_helper BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734 TEST=Ran trybot. Review URL: https://codereview.chromium.org/140573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix posix IPC channel hanging problem.hubbe@chromium.org2014-02-212-10/+61
| | | | | | | | | | | | | | | | If a channel closes right before a send call, listeners might not be notified of the problem, which can cause hangs. This CL fixes that and adds a test that makes sure that this does not happen in the future. This is similar to cl/150893002, but takes a slightly different approach to how to make sure everything happens in the right order. In particular, it avoids closing the socket (and calling OnChannelError()) from Send(). BUG=338709 Review URL: https://codereview.chromium.org/172773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252430 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Allow MessageFilters to restrict listening to specific message classes"jdduke@chromium.org2014-02-214-383/+6
| | | | | | | | | | | | | This reverts commit 2955e4e3c747fd4aa3c227d6c4e4c698cf31b3c4. Reason for revert: Frequent crashes on Windows. BUG=345368 TBR= Review URL: https://codereview.chromium.org/165333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Fix posix IPC channel hanging problem. ↵hubbe@chromium.org2014-02-182-66/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/150893002/) Reason for revert: https://crash.corp.google.com/samples?q=reportid=%2702eaaf63ed6fdda9%27 https://crash.corp.google.com/samples?q=reportid=%272ac5bc4dd7c49ced%27 Original issue's description: > Fix posix IPC channel hanging problem. > > If a channel closes right before a send call, listeners might not be notified of > the problem, which can cause hangs. This CL fixes that and adds a test that makes > sure that this does not happen in the future. > > This is cl/30133002 + a memory leak fix. > > BUG=338709 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250964 TBR=shess@chromium.org,cpu@chromium.org,hubbe@google.com NOTREECHECKS=true NOTRY=true BUG=338709 Review URL: https://codereview.chromium.org/170863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251791 0039d316-1c4b-4281-b951-d872f2087c98
* Allow MessageFilters to restrict listening to specific message classesjdduke@chromium.org2014-02-164-6/+383
| | | | | | | | | | | | | | | | | ChannelProxy currently offers messages to all member MessageFilters. It turns out that a good portion of the most common message types will never be filtered, making the O(N) filter walk an unnecessary affair. To prevent this, allow MessageFilters to indicate which (if any) subset of message classes they may filter, allowing the ChannelProxy to refine the list of filters that are offered a particular message. This saves ~35us per message received on the browser IO thread for a typical Android device. BUG=340881 TBR=asargent@chromium.org Review URL: https://codereview.chromium.org/142923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251622 0039d316-1c4b-4281-b951-d872f2087c98
* IPC glue between cast library transport and encoders.hubbe@chromium.org2014-02-151-0/+1
| | | | | | | | | | This CL lets the cast library run the packetizing and encryption in the browser and the video and audio encoding in the renderer. The encoded data is sent over IPC to the browser. BUG=301920 Review URL: https://codereview.chromium.org/138753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix posix IPC channel hanging problem.hubbe@chromium.org2014-02-132-6/+66
| | | | | | | | | | | | | | If a channel closes right before a send call, listeners might not be notified of the problem, which can cause hangs. This CL fixes that and adds a test that makes sure that this does not happen in the future. This is cl/30133002 + a memory leak fix. BUG=338709 Review URL: https://codereview.chromium.org/150893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250964 0039d316-1c4b-4281-b951-d872f2087c98
* Make flow event traces disabled-by-defaultfmeawad@chromium.org2014-02-064-8/+11
| | | | | | | | | | Currently all flow events are in the category "toplevel.flow", they originated from "ipc" and "task" categories. BUG=338427 Review URL: https://codereview.chromium.org/148173011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249450 0039d316-1c4b-4281-b951-d872f2087c98
* Web MIDI: make naming convention be consistenttoyoshim@chromium.org2014-02-041-1/+1
| | | | | | | | | | | | | | | | | | | Naming cleanup based on following rules: - MidiFooBar ... use this style to be consistent with chromium - WebMIDIFooBar ... Web API name related things, or names in blink - MIDIFooBar ... APIs and structures defined by each operating systems Other cleanup: - Modify some TODO(crogers) to TODO(toyoshim) - Add some crbug links. - Remove some obsolete UI TODOs related to infobars BUG=none TEST=build for all platforms Review URL: https://codereview.chromium.org/151343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248686 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Fix posix IPC channel hanging problem. ↵hubbe@chromium.org2014-01-302-64/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/30133002/) Reason for revert: Seems to cause some leaks. Reverting while I investigate. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/22398 Original issue's description: > Fix posix IPC channel hanging problem. > > If a channel closes right before a send call, listeners might not be notified of > the problem, which can cause hangs. This CL fixes that and adds a test that makes > sure that this does not happen in the future. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248060 TBR=cpu@chromium.org,shess@chromium.org,hubbe@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/150883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248067 0039d316-1c4b-4281-b951-d872f2087c98
* Fix posix IPC channel hanging problem.hubbe@chromium.org2014-01-302-6/+64
| | | | | | | | | | If a channel closes right before a send call, listeners might not be notified of the problem, which can cause hangs. This CL fixes that and adds a test that makes sure that this does not happen in the future. Review URL: https://codereview.chromium.org/30133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248060 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Media Galleries to use base::Filervargas@chromium.org2014-01-273-11/+12
| | | | | | | | | | | | | | | Unfortunately, this brings in changes to webkit/browser/fileapi, and once that changes, a lot of files have to be updated. The bright side is that most of the collateral changes are just trivial renaming of PlatformFileError -> File::Error and PlatformFileInfo -> File::Info BUG=322664 Review URL: https://codereview.chromium.org/145303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247301 0039d316-1c4b-4281-b951-d872f2087c98
* Changing a DCHECK to a CHECK in order to catch this error in release builds.tommi@chromium.org2014-01-211-1/+1
| | | | | | | | | | | | | | | | | I managed to hit this problem locally by following reproduction steps in bug 335031. My guess is that this might be causing data corruption and several so-far unexplained crashes, so I think that a reasonable first step is to upgrade the DCHECK to a CHECK. Committing as TBR to get this in asap. BUG=335031 TBR=agl@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/143443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246036 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an outdated comment.eroman@chromium.org2014-01-111-4/+0
| | | | | | | | It is obsolete now that the code is using a MessageLoopProxy. Review URL: https://codereview.chromium.org/133903006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244333 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Win64 build of base library even in a Win32 build.petewil@chromium.org2014-01-091-1/+1
| | | | | | | | | | | | | | | Some components of a 32 bit build of chrome for Windows need to be built as Win64 Dlls. To allow those components to use base, we make a Win64 build of the base library even when building chrome 32 bit. This is needed by the Chrome Desk Band code. crbug.com/327435. https://codereview.chromium.org/79173004/ BUG=327435 Review URL: https://codereview.chromium.org/103333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243936 0039d316-1c4b-4281-b951-d872f2087c98
* Separate EmbeddedWorker messages into another file to use different msg classkinuko@chromium.org2014-01-091-0/+1
| | | | | | | | | | | | | | | | So that we can rely on IPC_MESSAGE_CLASS(msg) check to determine which messages we want to relay onto another thread. Mostly just shuffling, - Separated EmbeddedWorker messages out of service_worker_messages.h into embedded_worker_messages.h - Added a new message class for that - Created a new directory content/common/service_worker (and OWNERS file) as now we have multiple header files for SW under common/ BUG=313530 Review URL: https://codereview.chromium.org/127583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243871 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC stubs between browser and ServiceWorker's worker context in the ↵kinuko@chromium.org2014-01-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | child process - Add ServiceWorkerHostMsg_WorkerStarted and ServiceWorkerHostMsg_WorkerStopped that are sent from embedded worker to the browser process - Add ServiceWorkerContextMsg_FetchEvent for messages from embedded worker to the browser process FetchEvent/FetchRequest code is a bit rough as it's meant to be a placeholder. I can remove the part from this CL if it doesn't look reay yet. The new code uses new IPC class (ServiceWorkerContextMsg) for dispatching messages specifically sent to the embedded workers's worker context, which may feel a bit noisy. (Alternative suggestions welcome) BUG=313530 R=alecflett@chromium.org, jochen@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/118103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243081 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in courgette/, device/, extensions/, ↵avi@chromium.org2013-12-252-4/+4
| | | | | | | | | | | | google_apis/, gpu/, ipc/, media/, net/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/112963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242496 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16s in ipc/.dbeam@chromium.org2013-12-202-4/+4
| | | | | | | | | R=tsepez@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/108793005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242050 0039d316-1c4b-4281-b951-d872f2087c98
* Add myself to OWNERS for IPC messages.dcheng@chromium.org2013-12-071-0/+1
| | | | | | | | | BUG=none R=jam@chromium.org, palmer@chromium.org Review URL: https://codereview.chromium.org/100823011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239279 0039d316-1c4b-4281-b951-d872f2087c98
* Add nasko@chromium.org in OWNERS for IPC messages.nasko@chromium.org2013-12-061-0/+1
| | | | | | | | | BUG=None R=jam@chromium.org Review URL: https://codereview.chromium.org/107463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239085 0039d316-1c4b-4281-b951-d872f2087c98
* Move directory creation functions to base namespace.brettw@chromium.org2013-12-032-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/100573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
* Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.mark@chromium.org2013-12-036-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is generally undefined on Mac, but as of r223369, it is incorrect in Chrome on Mac. To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not used with close, and that IGNORE_EINTR is only used with close. Unnecessary #includes of eintr_wrapper.h are also removed. base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc contain non-mechanical changes. Variable naming within the latter is updated per r178174. Missing #includes for <errno.h> in content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were manually added. Mechanical changes were generated by running: sed -E -i '' \ -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \ -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \ -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \ $(git grep -El 'HANDLE_EINTR.*close') sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \ $(grep -EL '(HANDLE|IGNORE)_EINTR' \ $(git grep -El '#include.*eintr_wrapper\.h"')) BUG=269623 R=agl@chromium.org, jln@chromium.org TBR=OWNERS Review URL: https://codereview.chromium.org/100253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
* Run ipc_tests serially when using new test launcher.phajdan.jr@chromium.org2013-12-032-1/+41
| | | | | | | | | | | | | | On Windows they would hit resource contention issues otherwise and run slower than serially. Run time is in seconds anyway. BUG=236893 R=jeremy@chromium.org Review URL: https://codereview.chromium.org/93663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238251 0039d316-1c4b-4281-b951-d872f2087c98
* Move more uses of string16 to specify base::brettw@chromium.org2013-12-032-4/+4
| | | | | | | | | | This makes base, ui, and net compile without the "using base::string16" directive that's currently checked in. BUG= Review URL: https://codereview.chromium.org/100303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238246 0039d316-1c4b-4281-b951-d872f2087c98
* more spell checkingthakis@chromium.org2013-11-051-1/+1
| | | | | | | | | BUG=none NOTRY=true Review URL: https://codereview.chromium.org/57463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232902 0039d316-1c4b-4281-b951-d872f2087c98
* Revert https://src.chromium.org/viewvc/chrome?view=rev&revision=231330bbudge@chromium.org2013-11-0415-52/+84
| | | | | | | | | | This is a speculative revert to see if it's the cause of hanging renderers. BUG=313112 Review URL: https://codereview.chromium.org/57783006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232819 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize ParamTraits<float> and ParamTraits<double>piman@chromium.org2013-10-312-23/+8
| | | | | | | | | | | | | | These function become hot on some benchmarks. WriteData is inefficient because it writes the length, even though it's known on the reader side (compile-time constant). For <float> we can simply use WriteFloat. For <double> we can use WriteBytes instead of WriteData. BUG=307480 Review URL: https://codereview.chromium.org/39363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232060 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused IPC::Message priority.bbudge@chromium.org2013-10-2815-84/+52
| | | | | | | | | | | | | | | | | Removes the PriorityValue enum and field from IPC::Message. This doesn't appear to be used anywhere. Changes the data message ctor to take a size_t data_len parameter. This works around an ambiguity problem with the main ctor, which has a similar signature and would require lots of futzing with our test code to fix. To make this work, the matching Pickle constructor is also changed to take a size_t data_len parameter. BUG=194304 Review URL: https://codereview.chromium.org/35643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231330 0039d316-1c4b-4281-b951-d872f2087c98
* IPC_END_MESSAGE_MAP: Made unreachable DCHECK reachable.mgiuca@chromium.org2013-10-231-1/+1
| | | | | | | | BUG=309505 Review URL: https://codereview.chromium.org/31623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230555 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ipc fuzzing code.thestig@chromium.org2013-10-192-23/+0
| | | | | | | | BUG=298372 Review URL: https://codereview.chromium.org/27031007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229577 0039d316-1c4b-4281-b951-d872f2087c98
* Pass StatsTable shared memory via global descriptors on Posix rather than ↵rmcilroy@chromium.org2013-10-161-0/+4
| | | | | | | | | | | | | | using named shared memory. This is required for to enable chrome://stats Android where there is no /dev/shm. This also provides the added advantage of not requiring the --no-sandbox command line flag with the --enable-stats-table on Posix. BUG=None Review URL: https://codereview.chromium.org/22911027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228903 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 10:57:11 +0000