| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This can be simply spelled as base::Passed(&foo).
BUG=155593
R=dmichael@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12042027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All visitedlink files moved to src/components/visitedlink/[browser|common|renderer|test]
Created static lib targets for browser, common, and renderer.
Test files are moved but still uses old test targets in chrome/
Dcommitted due to AllowScopedIO being moved but still
triggers presubmit error. Bots are mostly happy.
BUG=168716
Review URL: https://codereview.chromium.org/11825011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building on windows with target_arch=x64, we no longer need win32 targets
forced to be 64-bit. This gates out these targets when target_arch!=ia32.
(Prior CL dropped the minimal set to break the dependency between these targets
and the rest of the build. This eliminates them completely.)
BUG=None
TEST=None
R=jschuh@chromium.org,thestig@chromium.org
TBR=darin@chromium.org,abodenha@chromium.org,apatrick@chromium.org,sra@chromium.org,wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11929039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of chrome/browser.
Marked Iterator::HasNext() as deprecated and added a method Iterator::CanAdvance() as replacement.
As DictionaryValue::Iterator is actually a const iterator, I had to add several missing const annotations, mostly, in json_schema_validator.* and command.*
BUG=162611
TEST=No new tests. Only semantically equivalent refactorings.
Review URL: https://chromiumcodereview.appspot.com/11418150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It wasn't used anywhere other than in ipc_perftests (which, up till very
recently, weren't even compiled) in a non-essential way.
Review URL: https://chromiumcodereview.appspot.com/11964002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11858023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make it run with a decent spread of parameters.
TBR=jam
Review URL: https://codereview.chromium.org/11886009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
channel is being closed.
This resulted in messages being dispatched to objects while they were closing the IPC channel, potentially when they were in a partially destroyed state, leading to a crash.
BUG=165269
Review URL: https://chromiumcodereview.appspot.com/11840003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is speculative: I fixed crbug.com/25841, and hope that that's the
underlying cause for crbug.com/70075 (flakiness on Windows). Or maybe the cause
was something else that has also since gone away (since the test was reliable
for a long time before).
BUG=70075
Review URL: https://chromiumcodereview.appspot.com/11861018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11858018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reduces chances of (very confusing) name collisions between different
tests.
Review URL: https://codereview.chromium.org/11865015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This means that the (one, semi-manual) IPC perf test that we have will build
without manual hackery (and do so separately from the ipc_tests target).
Review URL: https://chromiumcodereview.appspot.com/11819041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change implements the data collection part of webrtc-internals.
RTCPeerConnectionHandler is an existing class living in the main renderer thread and knows about the status of a peer connection. With this CL, it reports every peer connection creation to PeerConnectionTracker.
PeerConnectionTracker is also running in the renderer process. It assigns an integer ID to each peer connectionstore and sends the basic peer connection info to PeerConnectionTrackerHost along with the ID.
PeerConnectionTrackerHost is running in the browser process in the IO thread. It simply passes anything it receives from PeerConnectionTracker to WebRTCInternals.
WebRTCInternals is a singlton running in the browser process. It sends the data received from PeerConnectionTrackerHost to every observer, i.e. webrtc-internals page. WebRTCInternalsUIObserver will be implemented in another change list.
BUG=168232
Review URL: https://chromiumcodereview.appspot.com/11753020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"suppressions"/annotations.
Shut down explicitly, rather than doing it in a virtual destructor, which leads
to a vtable race.
(Possibly also related is http://crbug.com/70075, but I haven't been able to
reproduce, so I'll try to re-enable that separately.)
BUG=25841
TEST=ipc_tests + TSAN still happy
Review URL: https://chromiumcodereview.appspot.com/11761038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's still all terribly manual and fragile, but that'll be taken care of
separately.
Review URL: https://chromiumcodereview.appspot.com/11797002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11794011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the browser process launches the plugin, it explicitly tells each side the PID of the other side, and we now use this PID for sharing handles. Previously we'd use the PID from the IPC channel.
Using the PID from the IPC channel creates a race condition because the PID isn't set until the "hello" message from the opposite side is processed, which isn't guaranteed at any particular time.
BUG=168222
Review URL: https://codereview.chromium.org/11722017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11722033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=166867
Review URL: https://chromiumcodereview.appspot.com/11743009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's a rarely-used and completely unnecessary (and thin) wrapper around
PickleIterator.
Review URL: https://chromiumcodereview.appspot.com/11570038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11574040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add Ppapi IPC messages and a handler inside of the NaCl IRT to enable, disable, and send the result of tracing.
BUG=93839
Review URL: https://codereview.chromium.org/11411118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
public methods (with Send() being the only exception) are called on the thread that created the object.
Tests calling Send() from a wrong thread should be fixed first before similar check can be added to Send(). See http://crbug.com/163523 for details.
BUG=163091,163523
Review URL: https://chromiumcodereview.appspot.com/11308278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the incoming message length is larger than Channel::kMaximumMessageSize, the RHS for the check for message size will become negative - since both sides are promoted to unsigned, the negative will simply become a very large value hence breaking the check.
R=tsepez@chromium.org
BUG=None.
Review URL: https://codereview.chromium.org/11413204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a Mac test for the about ipc controller - it was just not executed on the bots before.
BUG=none
TEST=win dbg still compiles, no mac unit_tests failures
Review URL: https://chromiumcodereview.appspot.com/11280186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since I refactored the registering of IPC loggers to go through a proper API,
there's no dependency from ipc to chrome anymore, and we can enable it in
debug builds
BUG=none
TEST=compiles in debug build
------------------------------------------------------
Caused "unresolved external" link errors on Windows Debug builds:
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%20%28dbg%29/builds/5494/steps/compile/logs/stdio
Possibly the cause of various "malloc" related failures seen elsewhere in
the tree:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Sync&number=25248
Review URL: https://chromiumcodereview.appspot.com/11415122
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/11428013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since I refactored the registering of IPC loggers to go through a proper API,
there's no dependency from ipc to chrome anymore, and we can enable it in
debug builds
BUG=none
TEST=compiles in debug build
Review URL: https://chromiumcodereview.appspot.com/11415122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
R=darin@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11308132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=162066
Review URL: https://chromiumcodereview.appspot.com/11416115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note: This was a TODO for brett in ipc_channel.h
TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11308082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RunAllPending() is deprecated and we should switch to RunUntilIdle().
BUG=131220
TBR=cpu@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11420048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is TODO in ipc_channel.h that I'm working on.
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11416016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11364242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11366229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using std::vector to hold UploadElement is bad for two reasons:
1. It results in a lot of unnecessary copy of uploaded data.
2. Appending new chunks may result in invalidating the pointer held by UploadBytesElementReader.
BUG=160028
TEST=git try
TBR=ananta@chromium.org, tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11275223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This file represents a posix-only concept.
BUG=
Review URL: https://codereview.chromium.org/11293210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I add a new content API to register IPC message loggers, and modify the IPC
message macros to not directly create the g_log_function_mapping. That allows
for multiple files generating IPC loggers. Also, it gets rid of the ctor/dtor
for the g_log_function_mapping.
BUG=101600,111316,155765
Review URL: https://codereview.chromium.org/11347012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that new message files can't be added to chromium without triggering a security review.
Review URL: https://chromiumcodereview.appspot.com/11048038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136677
Review URL: https://chromiumcodereview.appspot.com/10979047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Render to the surface it provides to us.
BUG=151718
Review URL: https://codereview.chromium.org/10984007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116317
TEST=builds
Review URL: https://chromiumcodereview.appspot.com/10982031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
-traits that are only used by chrome should be in chrome
-traits that aren't used by chrome shouldn't be in content/public
-use macros for serialization where possible
-traits that are only used by one message file should just be listed in it
-get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change.
Review URL: https://codereview.chromium.org/10980010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=148648
TBR=dmichael
Review URL: https://codereview.chromium.org/10959063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Only hooked up in "aura_demo --viewer" right now, and doesn't actually accomplish anything other than opening a window yet.
Review URL: https://codereview.chromium.org/10872002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To do this properly, we need a new type of trace event "FLOW" which will be drawn as lines in about:tracing from BEGIN to END.
Also instruments SequencedWorkerPool and ChannelReader::DispatchInputData, which were not currently traced.
BUG=79942
Review URL: https://codereview.chromium.org/10913242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10908183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android, some GYP client targets were explicitly depending on both the
native and Java sides of a library.
This removes the dependencies to {base,net}_java and make the native side
('base' and 'net) of these libraries depend on their Java counterpart.
On Android it rarely makes sense to depend on a single side of a Java/C++
library.
The {base,net}_java can now be considered as "private" targets although GYP
does not support this concept unfortunately (AFAICT).
Note that I made sure that the resulting APKs' size is unchanged.
Additionally, this CL removes 'base_java' (i.e. does not replace it with
'base') from the targets including 'build/apk_test.gypi'. This dependency
should not have been there (in the wrong layer) in the first place. It's needed
by ChromeNativeTestActivity.java which clients should not know about.
BUG=146323
TBR=lipalani,sky,willchan,brettw
Review URL: https://chromiumcodereview.appspot.com/10913083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Thread object could (depending on a race) be destroyed on its own thread,
which is illegal. Instead, make sure that ownership of the thread is decoupled
from the filter to ensure it's destroyed (and joined) on a good thread.
BUG=129620
Review URL: https://chromiumcodereview.appspot.com/10914161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=146454
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10918062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79942
Review URL: https://chromiumcodereview.appspot.com/10919023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154840 0039d316-1c4b-4281-b951-d872f2087c98
|