summaryrefslogtreecommitdiffstats
path: root/ipc
Commit message (Collapse)AuthorAgeFilesLines
* Remove an outdated comment.eroman@chromium.org2014-01-111-4/+0
| | | | | | | | It is obsolete now that the code is using a MessageLoopProxy. Review URL: https://codereview.chromium.org/133903006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244333 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Win64 build of base library even in a Win32 build.petewil@chromium.org2014-01-091-1/+1
| | | | | | | | | | | | | | | Some components of a 32 bit build of chrome for Windows need to be built as Win64 Dlls. To allow those components to use base, we make a Win64 build of the base library even when building chrome 32 bit. This is needed by the Chrome Desk Band code. crbug.com/327435. https://codereview.chromium.org/79173004/ BUG=327435 Review URL: https://codereview.chromium.org/103333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243936 0039d316-1c4b-4281-b951-d872f2087c98
* Separate EmbeddedWorker messages into another file to use different msg classkinuko@chromium.org2014-01-091-0/+1
| | | | | | | | | | | | | | | | So that we can rely on IPC_MESSAGE_CLASS(msg) check to determine which messages we want to relay onto another thread. Mostly just shuffling, - Separated EmbeddedWorker messages out of service_worker_messages.h into embedded_worker_messages.h - Added a new message class for that - Created a new directory content/common/service_worker (and OWNERS file) as now we have multiple header files for SW under common/ BUG=313530 Review URL: https://codereview.chromium.org/127583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243871 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPC stubs between browser and ServiceWorker's worker context in the ↵kinuko@chromium.org2014-01-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | child process - Add ServiceWorkerHostMsg_WorkerStarted and ServiceWorkerHostMsg_WorkerStopped that are sent from embedded worker to the browser process - Add ServiceWorkerContextMsg_FetchEvent for messages from embedded worker to the browser process FetchEvent/FetchRequest code is a bit rough as it's meant to be a placeholder. I can remove the part from this CL if it doesn't look reay yet. The new code uses new IPC class (ServiceWorkerContextMsg) for dispatching messages specifically sent to the embedded workers's worker context, which may feel a bit noisy. (Alternative suggestions welcome) BUG=313530 R=alecflett@chromium.org, jochen@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/118103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243081 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in courgette/, device/, extensions/, ↵avi@chromium.org2013-12-252-4/+4
| | | | | | | | | | | | google_apis/, gpu/, ipc/, media/, net/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/112963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242496 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16s in ipc/.dbeam@chromium.org2013-12-202-4/+4
| | | | | | | | | R=tsepez@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/108793005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242050 0039d316-1c4b-4281-b951-d872f2087c98
* Add myself to OWNERS for IPC messages.dcheng@chromium.org2013-12-071-0/+1
| | | | | | | | | BUG=none R=jam@chromium.org, palmer@chromium.org Review URL: https://codereview.chromium.org/100823011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239279 0039d316-1c4b-4281-b951-d872f2087c98
* Add nasko@chromium.org in OWNERS for IPC messages.nasko@chromium.org2013-12-061-0/+1
| | | | | | | | | BUG=None R=jam@chromium.org Review URL: https://codereview.chromium.org/107463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239085 0039d316-1c4b-4281-b951-d872f2087c98
* Move directory creation functions to base namespace.brettw@chromium.org2013-12-032-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/100573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
* Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.mark@chromium.org2013-12-036-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is generally undefined on Mac, but as of r223369, it is incorrect in Chrome on Mac. To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not used with close, and that IGNORE_EINTR is only used with close. Unnecessary #includes of eintr_wrapper.h are also removed. base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc contain non-mechanical changes. Variable naming within the latter is updated per r178174. Missing #includes for <errno.h> in content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were manually added. Mechanical changes were generated by running: sed -E -i '' \ -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \ -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \ -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \ $(git grep -El 'HANDLE_EINTR.*close') sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \ $(grep -EL '(HANDLE|IGNORE)_EINTR' \ $(git grep -El '#include.*eintr_wrapper\.h"')) BUG=269623 R=agl@chromium.org, jln@chromium.org TBR=OWNERS Review URL: https://codereview.chromium.org/100253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
* Run ipc_tests serially when using new test launcher.phajdan.jr@chromium.org2013-12-032-1/+41
| | | | | | | | | | | | | | On Windows they would hit resource contention issues otherwise and run slower than serially. Run time is in seconds anyway. BUG=236893 R=jeremy@chromium.org Review URL: https://codereview.chromium.org/93663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238251 0039d316-1c4b-4281-b951-d872f2087c98
* Move more uses of string16 to specify base::brettw@chromium.org2013-12-032-4/+4
| | | | | | | | | | This makes base, ui, and net compile without the "using base::string16" directive that's currently checked in. BUG= Review URL: https://codereview.chromium.org/100303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238246 0039d316-1c4b-4281-b951-d872f2087c98
* more spell checkingthakis@chromium.org2013-11-051-1/+1
| | | | | | | | | BUG=none NOTRY=true Review URL: https://codereview.chromium.org/57463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232902 0039d316-1c4b-4281-b951-d872f2087c98
* Revert https://src.chromium.org/viewvc/chrome?view=rev&revision=231330bbudge@chromium.org2013-11-0415-52/+84
| | | | | | | | | | This is a speculative revert to see if it's the cause of hanging renderers. BUG=313112 Review URL: https://codereview.chromium.org/57783006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232819 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize ParamTraits<float> and ParamTraits<double>piman@chromium.org2013-10-312-23/+8
| | | | | | | | | | | | | | These function become hot on some benchmarks. WriteData is inefficient because it writes the length, even though it's known on the reader side (compile-time constant). For <float> we can simply use WriteFloat. For <double> we can use WriteBytes instead of WriteData. BUG=307480 Review URL: https://codereview.chromium.org/39363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232060 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused IPC::Message priority.bbudge@chromium.org2013-10-2815-84/+52
| | | | | | | | | | | | | | | | | Removes the PriorityValue enum and field from IPC::Message. This doesn't appear to be used anywhere. Changes the data message ctor to take a size_t data_len parameter. This works around an ambiguity problem with the main ctor, which has a similar signature and would require lots of futzing with our test code to fix. To make this work, the matching Pickle constructor is also changed to take a size_t data_len parameter. BUG=194304 Review URL: https://codereview.chromium.org/35643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231330 0039d316-1c4b-4281-b951-d872f2087c98
* IPC_END_MESSAGE_MAP: Made unreachable DCHECK reachable.mgiuca@chromium.org2013-10-231-1/+1
| | | | | | | | BUG=309505 Review URL: https://codereview.chromium.org/31623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230555 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ipc fuzzing code.thestig@chromium.org2013-10-192-23/+0
| | | | | | | | BUG=298372 Review URL: https://codereview.chromium.org/27031007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229577 0039d316-1c4b-4281-b951-d872f2087c98
* Pass StatsTable shared memory via global descriptors on Posix rather than ↵rmcilroy@chromium.org2013-10-161-0/+4
| | | | | | | | | | | | | | using named shared memory. This is required for to enable chrome://stats Android where there is no /dev/shm. This also provides the added advantage of not requiring the --no-sandbox command line flag with the --enable-stats-table on Posix. BUG=None Review URL: https://codereview.chromium.org/22911027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228903 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring: Move MessagePort-related IPCs and handling them away from ↵marja@chromium.org2013-10-151-0/+1
| | | | | | | | | | | | | | | | | Worker-related classes. MessagePorts can also be used by non-workers. This is part of a series of changes to fix cross-process MessagePorts. This CL contains no functional changes. BUG=278336 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228448 Review URL: https://codereview.chromium.org/25299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228662 0039d316-1c4b-4281-b951-d872f2087c98
* Alternative workaround for mac kernel bug.hubbe@chromium.org2013-10-1512-76/+396
| | | | | | | | | | BUG=298276 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227999 Review URL: https://codereview.chromium.org/25325002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228569 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 228448 "Refactoring: Move MessagePort-related IPCs and ha..."marja@chromium.org2013-10-141-1/+0
| | | | | | | | | | | | | | | | | | | > Refactoring: Move MessagePort-related IPCs and handling them away from Worker-related classes. > > MessagePorts can also be used by non-workers. > > This is part of a series of changes to fix cross-process MessagePorts. This CL > contains no functional changes. > > BUG=278336 > > Review URL: https://codereview.chromium.org/25299002 TBR=marja@chromium.org Review URL: https://codereview.chromium.org/27192002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228455 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring: Move MessagePort-related IPCs and handling them away from ↵marja@chromium.org2013-10-141-0/+1
| | | | | | | | | | | | | | | Worker-related classes. MessagePorts can also be used by non-workers. This is part of a series of changes to fix cross-process MessagePorts. This CL contains no functional changes. BUG=278336 Review URL: https://codereview.chromium.org/25299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228448 0039d316-1c4b-4281-b951-d872f2087c98
* Add newline at end of file.thakis@chromium.org2013-10-121-1/+1
| | | | | | | | | BUG=290204 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/27094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228321 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for VS2013 compiler bug in ipc_message_macros.hzturner@chromium.org2013-10-121-0/+7
| | | | | | | | BUG=288948 Review URL: https://codereview.chromium.org/23455048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 227999 "Alternative workaround for mac kernel bug."benwells@chromium.org2013-10-1112-393/+75
| | | | | | | | | | | | | | | | | > Alternative workaround for mac kernel bug. > > BUG=298276 > > Review URL: https://codereview.chromium.org/25325002 This change seemed to cause the Mac ASAN bot to timeout when running the ipc_tests. TBR=hubbe@chromium.org Review URL: https://codereview.chromium.org/26384003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228110 0039d316-1c4b-4281-b951-d872f2087c98
* Alternative workaround for mac kernel bug.hubbe@chromium.org2013-10-1012-75/+393
| | | | | | | | BUG=298276 Review URL: https://codereview.chromium.org/25325002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227999 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new RenderFrameHost per child frame when --site-per-process is enabled.nasko@chromium.org2013-10-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | This CL is continuation of https://codereview.chromium.org/23841002/: - Adds a new sync IPC for child frame creation. - Added frame_messages.h for frame related messages. - RenderView now creates and closes the main frame WebFrame rather than relying on the WebView to do it. - Extracted FrameTree out of WebContents. FYI, UMA stats for tracking for site instances has been disabled in another CL since they won't make sense until this code is enabled w/o the flag. Also, FrameHostMsg_Detach is ViewHostMsg_FrameDeatch renamed and FrameHostMsg_CreateChildFrame is ViewHostMsg_FrameAttached renamed plus a little more functionality to get a routing ID assigned by the browser. (https://codereview.chromium.org/23506013/ is the Blink-side of the CL) BUG=245126 Review URL: https://codereview.chromium.org/25503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226779 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 226555 "There is a bug in the mac kernel, which can cause..."morrita@chromium.org2013-10-031-30/+3
| | | | | | | | | | | | | | | | | | | > There is a bug in the mac kernel, which can cause a file descriptor to be closed > when sent multiple times between processes. By delaying the close on the sender side by > a few second, we can eliminate this problem. > > BUG=279443, 298276 > > Review URL: https://codereview.chromium.org/24365008 This is a speculative revert to fix Mac LayoutTests breakages. See crbug.com/303487 for detail. TBR=hubbe@chromium.org Review URL: https://codereview.chromium.org/25660009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226693 0039d316-1c4b-4281-b951-d872f2087c98
* There is a bug in the mac kernel, which can cause a file descriptor to be closedhubbe@chromium.org2013-10-021-3/+30
| | | | | | | | | | | when sent multiple times between processes. By delaying the close on the sender side by a few second, we can eliminate this problem. BUG=279443, 298276 Review URL: https://codereview.chromium.org/24365008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226555 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserMessageFilter not derive from IPC::ChannelProxy::MessageFilter. ↵jam@chromium.org2013-10-012-20/+2
| | | | | | | | | | This allows us to hide the OnMessageReceived which shouldn't be overridden from child classes, and also avoid the pattern of requiring an overridden method to have to call to the base class. R=scherkus@chromium.org, scherkus Review URL: https://codereview.chromium.org/24514003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226251 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out initial NavigationController browser implementationalecflett@chromium.org2013-09-211-1/+2
| | | | | | | | | | | This is the initial cut for the browser-side NavigationControllerDispatcherHost, and all the various related support plumbing to hook up two initial messages. BUG= 285976 Review URL: https://chromiumcodereview.appspot.com/23615009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224585 0039d316-1c4b-4281-b951-d872f2087c98
* Populate canPlayType to rendererqinmin@chromium.org2013-09-191-0/+1
| | | | | | | | | | | This CL implements the AddKeySystem() call, and using sync IPC to send the results back to the render process. TBR=jschuh BUG=224793 Review URL: https://chromiumcodereview.appspot.com/23513055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224064 0039d316-1c4b-4281-b951-d872f2087c98
* base: Split logging functions and PerfTimeLogger out of perftimer.htfarina@chromium.org2013-09-171-3/+3
| | | | | | | | | | | | | | | | Soon PerfTimer will move into base/timer/ directory as it is already used by production code. This splits the logging stuff into their owns files and also moves PerfTimeLogger into its own files. BUG=None TEST=base_unittests, ipc_perftests, etc... R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/23985006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223486 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::GlobalDescriptors::kBaseDescriptor instead of magic number 3.dongseong.hwang@intel.com2013-09-061-1/+6
| | | | | | Review URL: https://chromiumcodereview.appspot.com/23814006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221809 0039d316-1c4b-4281-b951-d872f2087c98
* Increase maximum file descriptors per IPC message on POSIX from 5 to 7.tommycli@chromium.org2013-08-292-3/+7
| | | | | | | | | | | | | | On POSIX, the maximum number of file descriptors passable in an IPC message is controlled by a constant 'kMaxDescriptorsPerMessage'. It's currently set at 5. This patch makes it 7. The Picasa album table reader utility process (https://codereview.chromium.org/18986012/) needs to pass 7 files to the utility process. This works on Windows, but fails on POSIX (Mac), due to the aforementioned limit. This CL increases this limit to 7, as well as adds some DLOG messages to give better info to developers who hit this limit. ipc_channel_posix.cc seems to indicate adding extra file descriptors just makes the messages longer by an 'int' per file descriptor. Making the maximum even larger would be okay with me too. BUG= Review URL: https://chromiumcodereview.appspot.com/23534018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220371 0039d316-1c4b-4281-b951-d872f2087c98
* Move perftimer.* into base/test/ directory.tfarina@chromium.org2013-08-241-1/+1
| | | | | | | | | | | | | This should address the TODO from tools/gn/secondary/base/BUILD.gn BUG=None TEST=test_support_perf R=brettw@chromium.org TBR=cpu, dalecurtis, akalin, thestig Review URL: https://chromiumcodereview.appspot.com/22887041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219448 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant newlib builds of untrusted librariesdschuff@chromium.org2013-08-221-1/+1
| | | | | | | | | | | | | | | | | | | | Recent gyp changes (see the bug) split the IRT build rules off from the newlib and glibc build. For libraries which go into the IRT, the build_irt variable should be set (but not necessarily build_newlib). For libraries that go into the NaCl SDK and/or testing nexes, build_newlib, build_glibc and build_pnacl_newlib should be used. These libraries modified in this CL go only into the NaCl IRT, so they only need to build with build_irt. R=bradnelson@chromium.org,dmichael@chromium.org,bbudge@chromium.org TBR=brettw@chromium.org,fischman@chromium.org,jbauman@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3577 BUG= https://code.google.com/p/chromium/issues/detail?id=277813 Review URL: https://chromiumcodereview.appspot.com/22296003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219142 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Correct bit-shift in IPC hash generation."dsinclair@chromium.org2013-08-141-1/+1
| | | | | | | | | | | | | | This reverts commit r213882. This change caused too much shifting. Reverting back to the original as it is, in fact, correct. BUG= TBR=cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/23081002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217408 0039d316-1c4b-4281-b951-d872f2087c98
* Revert EVS revisions 209760, 298753, 213143.hshi@chromium.org2013-08-071-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | The EVS codepath is now dead. We will be using sheu@'s VEA path for HW-encoded screen capture. Revert "Encoded video capture: wire up key frame and bitrate settings." This reverts commit 348baf5a7b91cc4801dca5eae2921072055f35bc. Revert "Fix build failure with Android AOSP builds." This reverts commit ad526fe2ad101e249fe862b6e98c7d78ccdbc5ca. Revert "Define EncodedVideoSource and RtcCapturedEncodingVideoCapturer." This reverts commit 76bf7f58d93256dfa5867b6730e446517ead2a30. BUG=221441,248334 TEST=trybot TBR=fischman@chromium.org Review URL: https://codereview.chromium.org/21421002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216262 0039d316-1c4b-4281-b951-d872f2087c98
* Use gyp variables for NaCl untrusted build paths instead of hardcoding them.dschuff@chromium.org2013-08-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | Add the build_irt variable to targets which are part of the NaCl IRT. The aim of this CL is to enable the IRT to use untrusted library builds which are separate from those linked into testing nexes and the NaCl SDK, and ultimately to allow a different compiler to be used to build them. These libraries get an extra build_irt variable which will cause them to be built an extra time for the IRT. This is a prerequisite for NaCl CL https://codereview.chromium.org/21362004 to be DEPSed into Chrome, after which the build_newlib variable for most of them can go away (most libraries only need to go into the IRT or into the SDK/test nexes, but not both). R=bradnelson@google.com TBR=dmichael@chromium.org,brettw@chromium.org,piman@chromium.org,fischman@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=3577 Review URL: https://chromiumcodereview.appspot.com/21898006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215530 0039d316-1c4b-4281-b951-d872f2087c98
* Created multi-process-friendly PowerMonitor interface.bajones@chromium.org2013-08-021-0/+1
| | | | | | | | | | | | | PowerMonitor status is now captured in the browser process, which has the appropriate UI thread, and then sent via IPC to other processes which are interested in the power state. BUG=236031 R=apatrick@chromium.org, jam@chromium.org, jar@chromium.org, jvoung@chromium.org, kbr@chromium.org, mpcomplete@chromium.org, palmer@chromium.org, piman@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/17074009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215381 0039d316-1c4b-4281-b951-d872f2087c98
* Correct bit-shift in IPC hash generation.dsinclair@chromium.org2013-07-261-1/+1
| | | | | | | | | | | | | | | | | | The actual bit shifting that happens does not match what is specified in the comment. With the current implementation we will shift the PID over 14 bits, this sets the top 22 bits with the bottom 22 bits of the PID. When then OR the count with 0x3fff giving us 14 bits which we shift over 8 bits. This will end up OR'ing 8 bits of the count with 8 bits of the PID. Instead, we shift the PID over 22 bits, giving is 10 bits of the PID and shift the 14 bits of the count over 8. There should be no OR'ing between the PID and the count. This then matches what is specified in the comments. BUG= Review URL: https://chromiumcodereview.appspot.com/20106002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213882 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in ipc for base/process changes.rsesek@chromium.org2013-07-2414-12/+10
| | | | | | | | | BUG=242290 R=cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/19525007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213349 0039d316-1c4b-4281-b951-d872f2087c98
* Run local discovery code in utility process.vitalybuka@chromium.org2013-07-181-0/+1
| | | | | | | | BUG=245391 Review URL: https://chromiumcodereview.appspot.com/19284005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212447 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in dbus/, device/, ↵avi@chromium.org2013-07-1711-11/+11
| | | | | | | | | | | | extensions/, google_apis/, gpu/, ipc/, jingle/. BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19607005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212157 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base::Delete to base::DeleteFilebrettw@chromium.org2013-07-161-1/+1
| | | | | | | | | | | Also renames DeleteAfterReboot to DeleteFileAfterReboot, and removes FileUtilProxy::RecursiveDelete which was never called. BUG= R=shess@chromium.org Review URL: https://codereview.chromium.org/18584011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211822 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ParamTraits::param_type for unsigned charjschuh@chromium.org2013-07-131-1/+1
| | | | | | | | | | | Minor bug in r211473. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://chromiumcodereview.appspot.com/19023006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211546 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for marshalling unsigned char in IPC.tsepez@chromium.org2013-07-122-25/+50
| | | | | | | | | | | | | | | | | | | | Previously, we've supported unsigned short, but not unsigned char. There are a few places where folks are passing around color values that must be in the 0..255, and we can save both bytes written and avoid explicit range checks by the receiving method by using this rather than larger types. We support unsigned char only. Signed char is evil due to questionable signedness in the C specs. I've re-arranged the order of these specializatons so that they go in order of increasing size as they go down the page. R=jam@chromium.org BUG=259903 Review URL: https://chromiumcodereview.appspot.com/18068016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211473 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathExists to base namespace.brettw@chromium.org2013-07-111-1/+1
| | | | | | | | | BUG= TBR=jam@chromium.org Review URL: https://codereview.chromium.org/18286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 20:47:11 +0000