| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Detect XMPP auth errors and add new notifications to SingleLoginAttempt
and Login.
Replace PushClientObserver::OnNotificationStateChange with
OnNotifications{Enabled,Disabled} notifications.
Change SyncNotifierObserver similarly.
Handle InvalidationClient errors and propagate auth errors from that,
too.
Propagate XMPP auth errors all the way up to SyncManager. It will be
handled in a future CL.
BUG=38091
TEST=
Review URL: https://chromiumcodereview.appspot.com/10545170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
UrlRequestContextGetter.
Also updated all code that depends on that methods.
TBR=mnissler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10539148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove the overrides for thread and messagequeue.
Review URL: https://chromiumcodereview.appspot.com/10534122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the process of ensuring no base classes for RefCounted classes have
public destructors, base::NonThreadSafe shows up frequently due to having
a public destructor.
Begin migrating all the code that has a base::NonThreadSafe member to
directly inheriting from base::NonThreadSafe, so that base::NonThreadSafe's
destructor can be made private.
BUG=123295
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10411046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetPeerAddress(IPEndPoint* address)
R=szym@chromium.org
BUG=128383
TEST=try bot
Review URL: https://chromiumcodereview.appspot.com/10491007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NetLog. It wasn't being queried for anything, so no reason
to be using it. This is in preparation for moving
CapturingNetLog from the net project to the net_unittests
project, as it shouldn't be used in production code.
R=eroman@chromium.org,akalin@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10448033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
destructor. But JingleThreadWrapper never gets a chance to remove pending messages from its queue.
The change will call Clear() in its destructor.
BUG=129321
Review URL: https://chromiumcodereview.appspot.com/10474002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a lot of duplicated code and unifies the two main
SyncNotifier implementations (P2P and Invalidation) to use the same
underlying transport layer.
Replace CacheInvalidationPacketHandler and ChromeNetwork with PushClientChannel.
Add PushClient::CreateDefaultOnIOThread which creates
an XmppPushClient directly.
BUG=76764
TEST=
Review URL: https://chromiumcodereview.appspot.com/10436013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split the previous implementation into two pieces:
XmppPushClient and NonBlockingPushClient.
Add FakePushClient and FakePushClientObserver.
Remove use of ThreadSafeObserverList.
Add PushClient::CreateDefault() function, which creates a
NonBlockingPushClient for an XmppPushClient.
Dep-inject PushClient into P2PNotifier.
Add some helper functions to notification_defines.{h,cc}.
BUG=76764
TEST=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138216
Review URL: https://chromiumcodereview.appspot.com/10413014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockCachingHostResolver or MockHostResolver.
Make explicit when HostResolver::Resolve is expected to never complete in tests.
Clean up TestURLRequestContext API.
BUG=126016,128745
TEST=net_unittests; jingle_unittests; sync_unit_tests
Review URL: https://chromiumcodereview.appspot.com/10408067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
1. Setting ice username and password for P2PTransportChannel.
2. Updating XMPP Auth cookie with Auth Token
Review URL: https://chromiumcodereview.appspot.com/10382003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split the previous implementation into two pieces:
XmppPushClient and NonBlockingPushClient.
Add FakePushClient and FakePushClientObserver.
Remove use of ThreadSafeObserverList.
Add PushClient::CreateDefault() function, which creates a
NonBlockingPushClient for an XmppPushClient.
Dep-inject PushClient into P2PNotifier.
Add some helper functions to notification_defines.{h,cc}.
BUG=76764
TEST=
Review URL: https://chromiumcodereview.appspot.com/10413014
TBR=akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split the previous implementation into two pieces:
XmppPushClient and NonBlockingPushClient.
Add FakePushClient and FakePushClientObserver.
Remove use of ThreadSafeObserverList.
Add PushClient::CreateDefault() function, which creates a
NonBlockingPushClient for an XmppPushClient.
Dep-inject PushClient into P2PNotifier.
Add some helper functions to notification_defines.{h,cc}.
BUG=76764
TEST=
Review URL: https://chromiumcodereview.appspot.com/10413014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Streamline methods of PushClient and its Observer subclass.
Remove sync/protocol/service_constants.h and consolidate use of each
constant in one place. Remove duplicate constant in cloud print code.
BUG=76764
TEST=
TBR=estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10398051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove dead DNS-resolution-related code.
Remove complicated XmppConnectionGenerator class now that we don't
have to do DNS resolution ourselves. Move the simplified logic into
MakeConnectionSettingsList(). Add unit tests for it.
Remove unused ConnectionOptions struct.
Simplify SingleLoginAttempt a bit and add tests for it. Also document
redirection protocol.
Simplify LoginSettings and add tests for it.
Move redirection timeout logic from Login to LoginSettings.
Replace some bools with enums.
Document sketchy (but necessary) include of libjingle's p2p/port.h.
Some minor cleanup here and there.
BUG=38091
TEST=
Review URL: https://chromiumcodereview.appspot.com/10391084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is because DNS resolution should be done by its
ResolvingClientSocketFactory (which may resolve through a proxy).
This is just tightening up the preconditions as ChromeAsyncSocket's
callers were already providing the hostname.
Remove some uses of base::Unretained.
Some other minor cleanup.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10389098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::AddressList extends std::vector<std::IPEndPoint> by canonical name. (Canonical name is planned to be removed as well.)
Removes dependency on sys_addrinfo.h throughout the codebase.
Introduces net::SockaddrStorage for convenience.
BUG=125696
TEST=green waterfall
Review URL: http://codereview.chromium.org/10309002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123295
TEST=none
Review URL: http://codereview.chromium.org/10038045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deps. Most of these are already listed in DEPS files, and it seems that we want to prevent includes on them just like normal directories that are in our tree (otherwise content can depend on native_client, for ex)
Review URL: https://chromiumcodereview.appspot.com/10248005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10209008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boolean flag.
This is just prep work for a large CL that rewrites the JSON parser. Splitting
out this interface change will make it easier to review the other CL.
BUG=121469
TEST=No functional change.
Review URL: https://chromiumcodereview.appspot.com/9960077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calling OS API routines for certificate verification. This
allows tests that depend on SSL to cycle noticably faster,
particularly when under memory instrumentation.
R=wtc
BUG=none
TEST=existing unittests
Review URL: http://codereview.chromium.org/9956047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
side.
In the new send-confirmation mode the PseudoTCP layer will wait until data
is sent to remote end before completing each write. This significantly
improves latency for remoting on low bandwidth networks.
Review URL: http://codereview.chromium.org/9791012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
subclasses.
BUG=120890
Review URL: https://chromiumcodereview.appspot.com/9958028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ntohX() in Chrome.
This primarily addresses issues with code using the OS-provided htonX() & ntohX() functions from within the Chrome sandbox. Under Windows these functions are provided by ws2_32.dll, which is no longer available within Chrome's sandbox.
The new base::HostToNetXX() and NetToHostXX() functions are safe for use by sandboxed code on Windows, and provide a single place where future fixes for other platforms can be made.
BUG=117252
Review URL: http://codereview.chromium.org/9716020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing CertVerifier implementation has been renamed to
MultiThreadedCertVerifier, consistent with ProxyResolver naming.
This is patch 1 of N for http://crbug.com/114343
BUG=114343
TEST=Compiles and existing unittests pass.
Review URL: https://chromiumcodereview.appspot.com/9476035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=115348
TEST=unit tests, manually checked 'Origin Bound Certs' contents after browsing
TBR=jam@chromium.org,willchan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9617039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=base_unittests
TBR=abodenha@chromium.org,ajwong@chromium.org,chocobo@chromium.org,mnissler@chromium.org,akalin@chromium.org,brettw@chromium.org,arv@chromium.org
Review URL: http://codereview.chromium.org/9590002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Roll webrtc to 1888.
BUG=115702,117252
TEST=apprtc.appspot.com on windows and linux
Review URL: https://chromiumcodereview.appspot.com/9600066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116567
TEST=apprtc.appspot.com
Review URL: http://codereview.chromium.org/9616021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sergeyu@chromium.org
BUG=108171
Review URL: http://codereview.chromium.org/9572038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make everything use this instead of rolling their own.
BUG=113723
TEST=
Review URL: https://chromiumcodereview.appspot.com/9562037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain@chromium.org
BUG=109517
TEST=sync_integration_tests is properly run.
NOTRY=true
Review URL: http://codereview.chromium.org/9513008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
talk_base::Thread.
* Remove the denendency to the htons(), htonl(), ntohs(), ntohl().
* Implement inet_pton_v4 without using ws2.
* Update the remoting_unittests.
BUG=115501
TEST=Build and run webrtc test on Windows.
Review URL: http://codereview.chromium.org/9455070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JingleSession and JingleSessionManager were previously deleted
asychronously, but it is not necessary anymore arter we've switched to
PepperSession and PepperSessionManager. Instead changed
LibjingleTransportFactory to delete libjingle objects asynchronously.
Also fixed some bugs related that would cause crash when channel auth
fails.
BUG=115374
Review URL: http://codereview.chromium.org/9433027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of a bool async.
Review URL: http://codereview.chromium.org/9425016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110485
Review URL: http://codereview.chromium.org/9366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new TransportFactory will be used on the host side first and then
later on the client side too when we ready to switch to Pepper UDP APIs.
BUG=110485
Review URL: http://codereview.chromium.org/9365002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead of a boolean async.
Review URL: http://codereview.chromium.org/9419032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through HTTPS Proxies. This also changes the mechanism used
to restart HttpProxyClientSocket requests with auth. Previously
the transport socket would be Disconnected, and then re-Connected
(which was not implemented for SSLClientSockets). However, the
approach was problematic in the face of, for example, ipv6. The
new approach is to close the HttpProxyClientSocket, and request
a new socket from the pool.
Initially was http://codereview.chromium.org/8502024
which turned out to have problems with NTLM auth.
Review URL: http://codereview.chromium.org/9148011
TBR=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108171
Review URL: http://codereview.chromium.org/9159068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PushNotifications* classes) in CacheInvalidationPacketHandler, and update unit test accordingly
- extend notifier::Notification and PushNotificationsSendUpdateTask to allow specification of recipients (and recipient-specific data)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119171
Review URL: http://codereview.chromium.org/9190029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- replace custom <iq>-stanza protocol with push notifications (using PushNotifications* classes) in CacheInvalidationPacketHandler, and update unit test accordingly
- extend notifier::Notification and PushNotificationsSendUpdateTask to allow specification of recipients (and recipient-specific data)
Review URL: http://codereview.chromium.org/9190029
TBR=ghc@google.com
Review URL: https://chromiumcodereview.appspot.com/9234053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
PushNotifications* classes) in CacheInvalidationPacketHandler, and update unit test accordingly
- extend notifier::Notification and PushNotificationsSendUpdateTask to allow specification of recipients (and recipient-specific data)
Review URL: http://codereview.chromium.org/9190029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9131032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through HTTPS Proxies. This also changes the mechanism used
to restart HttpProxyClientSocket requests with auth. Previously
the transport socket would be Disconnected, and then re-Connected
(which was not implemented for SSLClientSockets). However, the
approach was problematic in the face of, for example, ipv6. The
new approach is to close the HttpProxyClientSocket, and request
a new socket from the pool.
Initially was http://codereview.chromium.org/8502024
which turned out to have problems with NTLM auth.
Review URL: http://codereview.chromium.org/9148011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add app/webrtc.
* Add examples/peerconnection.
* Bug fixes.
Roll webrtc to 1311.
BUG=110255
TEST=build and unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118031
Review URL: http://codereview.chromium.org/9174012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add app/webrtc.
* Add examples/peerconnection.
* Bug fixes.
Roll webrtc to 1311.
BUG=110255
TEST=build and unit tests
Review URL: http://codereview.chromium.org/9174012
TBR=ronghuawu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9253007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add app/webrtc.
* Add examples/peerconnection.
* Bug fixes.
Roll webrtc to 1311.
BUG=110255
TEST=build and unit tests
Review URL: http://codereview.chromium.org/9174012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
VLOG instead of its own logging mechanism.
Review URL: http://codereview.chromium.org/8991010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117917 0039d316-1c4b-4281-b951-d872f2087c98
|