summaryrefslogtreecommitdiffstats
path: root/jingle
Commit message (Collapse)AuthorAgeFilesLines
* More FilePath -> base::FilePath replacement.brettw@chromium.org2013-02-101-3/+3
| | | | | | Review URL: https://codereview.chromium.org/12225112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181655 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, jingle/ edition.rsleevi@chromium.org2013-02-064-8/+8
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://chromiumcodereview.appspot.com/12220033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181044 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Componentize sync: Part Final: Target 'sync' is now its own componentrsimha@chromium.org2013-02-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the long term goals of the sync team has been to pull sync out of chrome_dll and into its own component. This should result in faster link times for component builds, and cleaner demarcation between sync code and the rest of chrome. This patch does the following: - Splits off sync.gyp into gypi files for sync_core, sync_api, sync_internal_api, sync_notifier and sync_proto. - Audits the dependencies of various targets in sync.gyp, sync_tests.gyp, and other chrome gyp files, and makes sure all dependencies are explicitly declared. - Makes targets declared in gyp files outside sync.gyp directly depend on sync.gyp:sync instead of inner sync targets. - Implements two versions of the target 'sync.gyp:sync': 1) In static mode, the public 'sync' target has a target type of 'none', and is composed of the static library targets 'sync_api', 'sync_core', 'sync_internal_api', 'sync_notifier', and 'sync_proto'. 2) In component mode, we build the public 'sync' target into a single shared library, which includes the contents of sync_api.gypi, sync_core.gypi, sync_internal_api.gypi, sync_notifier.gypi, and sync_proto.gypi. TBR=akalin,robertshield,thakis BUG=136928 TEST=Set GYP_DEFINES="component=shared_library" and build the 'all' target on all platforms. Review URL: https://codereview.chromium.org/11412211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180034 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the necessary changes to sync.gyp as well as its dependencies (most ↵blundell@chromium.org2013-01-241-3/+3
| | | | | | | | | | notably jingle) in order to bring up the complete sync_notifier target on iOS. TBR=thakis Review URL: https://chromiumcodereview.appspot.com/12041016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178650 0039d316-1c4b-4281-b951-d872f2087c98
* Make all jingle targets build on Win64jschuh@chromium.org2013-01-111-1/+0
| | | | | | | | | BUG=166496 BUG=167187 Review URL: https://chromiumcodereview.appspot.com/11818046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176355 0039d316-1c4b-4281-b951-d872f2087c98
* Build jingle targets when webrtc is enabled.wjia@chromium.org2012-12-141-3/+3
| | | | | | | BUG=161417 Review URL: https://codereview.chromium.org/11570014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173177 0039d316-1c4b-4281-b951-d872f2087c98
* [net] Make IPEndPoint::GetFamily() return AddressFamily and add ↵szym@chromium.org2012-12-131-1/+1
| | | | | | | | | | | | GetSockAddrFamily() to be used when creating sockets. BUG=126002 TEST=browse anywhere Review URL: https://chromiumcodereview.appspot.com/11528012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172768 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Treat XMPP auth errors as sync auth errorsakalin@chromium.org2012-12-053-4/+12
| | | | | | | | | | | | | | | | Add controls for XMPP authentication to XMPP test server. Add integration test for XMPP auth errors. Add some DVLOGs to help debugging. BUG=38091 TEST= Review URL: https://chromiumcodereview.appspot.com/10703035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171172 0039d316-1c4b-4281-b951-d872f2087c98
* jingle: Update the calls from RunAllPending() to RunUntilIdle().tfarina@chromium.org2012-11-308-60/+60
| | | | | | | | | | | | RunAllPending() is deprecated and we should switch to RunUntilIdle(). BUG=131220 TBR=ajwong@chromium.org Review URL: https://chromiumcodereview.appspot.com/11421172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170464 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 167337 - Move url_request_test_util into net namespacejochen@chromium.org2012-11-135-11/+15
| | | | | | | | | | | | | | | This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=wtc@chromium.org,darin@chromium.org Original Review URL: https://codereview.chromium.org/11369179 Review URL: https://chromiumcodereview.appspot.com/11365227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167413 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 167337 - Move url_request_test_util into net namespacejochen@chromium.org2012-11-135-15/+11
| | | | | | | | | | | | | | | This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=darin@chromium.org Review URL: https://codereview.chromium.org/11369179 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/11410066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167356 0039d316-1c4b-4281-b951-d872f2087c98
* Move url_request_test_util into net namespacejochen@chromium.org2012-11-135-11/+15
| | | | | | | | | | | | This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=darin@chromium.org Review URL: https://codereview.chromium.org/11369179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167337 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'https://' prefix for proxy resolution in ProxyResolvingClientSocketakalin@chromium.org2012-11-082-7/+9
| | | | | | | | | | | This is because we use TLS on the socket for all current use cases. BUG=159579 Review URL: https://chromiumcodereview.appspot.com/11364152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166780 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some jingle unittests on vs2012scottmg@chromium.org2012-11-021-0/+4
| | | | | | | | | | | | Appears to be invalid iterator usage. R=akalin@chromium.org BUG=158570 Review URL: https://chromiumcodereview.appspot.com/11338050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165610 0039d316-1c4b-4281-b951-d872f2087c98
* Android: Remove depenendency on libjingle_p2p and jingle_glue.nileshagrawal@chromium.org2012-10-291-3/+7
| | | | | | | | | BUG=155069 Review URL: https://chromiumcodereview.appspot.com/11308013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164765 0039d316-1c4b-4281-b951-d872f2087c98
* Adding XMPP ping functionality to CloudPrint. XMPP ping and timeout is ↵gene@chromium.org2012-10-2618-7/+281
| | | | | | | | | | controlled thorugh Service State file. BUG=157735 Review URL: https://chromiumcodereview.appspot.com/11232048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164385 0039d316-1c4b-4281-b951-d872f2087c98
* [net] Change factory methods for HostResolver and HostCache to return a ↵szym@chromium.org2012-10-221-1/+2
| | | | | | | | | | | | scoped_ptr. Move HostResolver factory methods to host_resolver.cc. This also fixes a double-free in ShellURLRequestContextGetter. Review URL: https://chromiumcodereview.appspot.com/10831277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163402 0039d316-1c4b-4281-b951-d872f2087c98
* Remove static variables from HttpStreamFactory.szager@chromium.org2012-09-071-0/+17
| | | | | | | | | | | Refresh of issue 10389162. BUG=124900 Review URL: https://chromiumcodereview.appspot.com/10834215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155485 0039d316-1c4b-4281-b951-d872f2087c98
* [net] Move DnsConfigService to NetworkChangeNotifier.szym@chromium.org2012-08-312-2/+2
| | | | | | | | | | | | | This merges DnsConfigWatcher back into DnsConfigService and installs DnsConfigService at NetworkChangeNotifier. It removes |detail| from OnDNSChanged callback, and exposes NetworkChangeNotifier::GetDnsConfig. BUG=142142 Review URL: https://chromiumcodereview.appspot.com/10873018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154485 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a crash when cancelling the same PacRequest twice.alexeypa@chromium.org2012-08-241-1/+3
| | | | | | | | | BUG=140096 Review URL: https://chromiumcodereview.appspot.com/10882038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153338 0039d316-1c4b-4281-b951-d872f2087c98
* Create stub jingle library for iOS.qsr@chromium.org2012-08-236-200/+255
| | | | | | | | | | | | iOS doesn't use libjingle, but needs a stub jingle library for sync to compile. BUG=143886 R=akalin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10829424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152975 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fix crash when converting Notification to stringakalin@chromium.org2012-08-173-9/+35
| | | | | | | | | | Also add test. BUG=142925 Review URL: https://chromiumcodereview.appspot.com/10831347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152158 0039d316-1c4b-4281-b951-d872f2087c98
* Update JingleThreadWrapper to allow it to be created using task runner.sergeyu@chromium.org2012-08-144-41/+53
| | | | | | | | | | | | | Previously JingleThreadWrapper required a MessageLoop. In NaCl we don't have MessageLoop for the main plugin thread, but have a task runner. This CL allows to use JingleThreadWrapper on the main NaCl thread. BUG=134216 TBR=tommi@chromium.org Review URL: https://chromiumcodereview.appspot.com/10823224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151458 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up logging for push_notifications_*.ccakalin@chromium.org2012-08-134-10/+22
| | | | | | | | | | | | | | Make Notification::ToString() base64 the data member (since it can hold binary data). Convert VLOGs to DVLOGs for push_notifications_*.cc. BUG=141692 Review URL: https://chromiumcodereview.appspot.com/10828264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151367 0039d316-1c4b-4281-b951-d872f2087c98
* Give MockRead and MockWrite distinct types.yutak@chromium.org2012-07-271-5/+4
| | | | | | | | | | | | | | | | | | | Currently, MockRead and MockWrite are defined as the same type by using typedef. However, these types are different types and should not be used interchangably. This change gives MockRead and MockWrite distinct types by using templates so the compiler can cause an error when these types are used interchangably. Some misuses of MockRead and MockWrite were found, so these are fixed in this change, too. BUG=none R=mmenke@chromium.org,akalin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10796085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148782 0039d316-1c4b-4281-b951-d872f2087c98
* Enable cert pinning for XMPP connection made by XmppClientSocketFactory.sergeyu@chromium.org2012-07-251-0/+3
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10807081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148251 0039d316-1c4b-4281-b951-d872f2087c98
* Move TaskPump class from jingle/notifier/base to jingle/gluesergeyu@chromium.org2012-07-2411-42/+47
| | | | | | | | | BUG=137140 Review URL: https://chromiumcodereview.appspot.com/10809066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148142 0039d316-1c4b-4281-b951-d872f2087c98
* Move ChromeAsyncSocket to jingle/gluesergeyu@chromium.org2012-07-2414-80/+80
| | | | | | | | | | | | ChromeAsyncSocket will be reused by chromoting for XMPP connections, moving it to jingle/glue. BUG=137140 Review URL: https://chromiumcodereview.appspot.com/10817013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148028 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce all the source files to be encoded in UTF-8.maruel@chromium.org2012-07-191-3/+3
| | | | | | | | | | | | | | Many files used random encoding. All of them were in comments or unit test files that were not compiled. In any case, not using unicode everywhere complexify the tools so enforcing it makes presubmit checks much simpler. R=joi@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10797029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147480 0039d316-1c4b-4281-b951-d872f2087c98
* Change SpdySession::GetSSLInfo to get the SSLInfo from the underlying socketrch@chromium.org2012-07-197-0/+35
| | | | | | | | | | | | | | | | even if the session is not "secure". This required refactoring StreamSocket to add WasNpnNegotiated() and GetSSLInfo() methods. This allows for a change to SpdySession::GetSSLInfo to accurately return the correct SSLInfo in the case of SPDY Proxy sessions. BUG=134690 TEST=\*DoNotUseSpdySessionIfCertDoesNotMatch\* Review URL: https://chromiumcodereview.appspot.com/10690122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147479 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling libjingle to 159.ronghuawu@chromium.org2012-07-141-2/+2
| | | | | | | | TEST=unit tests, webrtc pytest Review URL: https://chromiumcodereview.appspot.com/10689180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146709 0039d316-1c4b-4281-b951-d872f2087c98
* Remove #pragma once from jingleajwong@chromium.org2012-07-117-10/+3
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10702139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146072 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Make Login class listen to connection and DNS changesakalin@chromium.org2012-06-282-6/+36
| | | | | | | | | | | | | | | | | | Make sync_listen_notifications listen for network changes. Add a scoped NSAutoreleasePool to sync_listen_notifications. Relax DEPS for sync/tools a bit. BUG=106034 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144382 Review URL: https://chromiumcodereview.appspot.com/10675012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144622 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SSLHostInfo.agl@chromium.org2012-06-273-3/+2
| | | | | | | BUG=105208 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144468 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144382 - [Sync] Make Login class listen to connection and DNS changesnkostylev@chromium.org2012-06-272-37/+6
| | | | | | | | | | | | | | | | | | | | | | Reason: http://build.chromium.org/p/chromium/builders/Mac10.6%20Sync/builds/19046 Make sync_listen_notifications listen for network changes. Add a scoped NSAutoreleasePool to sync_listen_notifications. Relax DEPS for sync/tools a bit. BUG=106034 TEST= Review URL: https://chromiumcodereview.appspot.com/10675012 TBR=akalin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10690007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144439 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Make Login class listen to connection and DNS changesakalin@chromium.org2012-06-272-6/+37
| | | | | | | | | | | | | | | | Make sync_listen_notifications listen for network changes. Add a scoped NSAutoreleasePool to sync_listen_notifications. Relax DEPS for sync/tools a bit. BUG=106034 TEST= Review URL: https://chromiumcodereview.appspot.com/10675012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144382 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::ThreadChecker as a member var, rather than base::NonThreadSafersleevi@chromium.org2012-06-254-25/+25
| | | | | | | | | | BUG=123295 TEST=existing Review URL: https://chromiumcodereview.appspot.com/10663016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144011 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Propagate XMPP auth errors to SyncNotifierObserversakalin@chromium.org2012-06-1816-86/+218
| | | | | | | | | | | | | | | | | | | | | | | | Detect XMPP auth errors and add new notifications to SingleLoginAttempt and Login. Replace PushClientObserver::OnNotificationStateChange with OnNotifications{Enabled,Disabled} notifications. Change SyncNotifierObserver similarly. Handle InvalidationClient errors and propagate auth errors from that, too. Propagate XMPP auth errors all the way up to SyncManager. It will be handled in a future CL. BUG=38091 TEST= Review URL: https://chromiumcodereview.appspot.com/10545170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142806 0039d316-1c4b-4281-b951-d872f2087c98
* Replace GetIOMessageLoopProxy() with GetNetworkTaskRunner() in ↵sergeyu@chromium.org2012-06-162-3/+3
| | | | | | | | | | | | UrlRequestContextGetter. Also updated all code that depends on that methods. TBR=mnissler@chromium.org Review URL: https://chromiumcodereview.appspot.com/10539148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142560 0039d316-1c4b-4281-b951-d872f2087c98
* Update libjingle to 153.ronghuawu@chromium.org2012-06-132-2/+5
| | | | | | | | Remove the overrides for thread and messagequeue. Review URL: https://chromiumcodereview.appspot.com/10534122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141908 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors - sync and jinglersleevi@chromium.org2012-06-118-28/+29
| | | | | | | | | | | | | | | | | | In the process of ensuring no base classes for RefCounted classes have public destructors, base::NonThreadSafe shows up frequently due to having a public destructor. Begin migrating all the code that has a base::NonThreadSafe member to directly inheriting from base::NonThreadSafe, so that base::NonThreadSafe's destructor can be made private. BUG=123295 TEST=existing Review URL: https://chromiumcodereview.appspot.com/10411046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141530 0039d316-1c4b-4281-b951-d872f2087c98
* fixed issue 128383 - replace GetPeerAddress(AddressList* address) with ↵zhaoqin@chromium.org2012-06-087-12/+12
| | | | | | | | | | | | | GetPeerAddress(IPEndPoint* address) R=szym@chromium.org BUG=128383 TEST=try bot Review URL: https://chromiumcodereview.appspot.com/10491007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141125 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the CapturingNetLog in Jingle tests with a NULLmmenke@chromium.org2012-06-071-5/+2
| | | | | | | | | | | | | | NetLog. It wasn't being queried for anything, so no reason to be using it. This is in preparation for moving CapturingNetLog from the net project to the net_unittests project, as it shouldn't be used in production code. R=eroman@chromium.org,akalin@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10448033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141098 0039d316-1c4b-4281-b951-d872f2087c98
* Currently when talk_base::Thread exists, Clear(NULL) is called from its ↵mallinath@chromium.org2012-06-011-0/+1
| | | | | | | | | | | | destructor. But JingleThreadWrapper never gets a chance to remove pending messages from its queue. The change will call Clear() in its destructor. BUG=129321 Review URL: https://chromiumcodereview.appspot.com/10474002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140126 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Make InvalidationNotifier use PushClientakalin@chromium.org2012-05-304-2/+23
| | | | | | | | | | | | | | | | | | | This removes a lot of duplicated code and unifies the two main SyncNotifier implementations (P2P and Invalidation) to use the same underlying transport layer. Replace CacheInvalidationPacketHandler and ChromeNetwork with PushClientChannel. Add PushClient::CreateDefaultOnIOThread which creates an XmppPushClient directly. BUG=76764 TEST= Review URL: https://chromiumcodereview.appspot.com/10436013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139508 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Turn notifier::PushClient into an interfaceakalin@chromium.org2012-05-2318-442/+1126
| | | | | | | | | | | | | | | | | | | | | | | | | Split the previous implementation into two pieces: XmppPushClient and NonBlockingPushClient. Add FakePushClient and FakePushClientObserver. Remove use of ThreadSafeObserverList. Add PushClient::CreateDefault() function, which creates a NonBlockingPushClient for an XmppPushClient. Dep-inject PushClient into P2PNotifier. Add some helper functions to notification_defines.{h,cc}. BUG=76764 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138216 Review URL: https://chromiumcodereview.appspot.com/10413014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138431 0039d316-1c4b-4281-b951-d872f2087c98
* [net] Switch TestURLRequestContext and other tests to use ↵szym@chromium.org2012-05-232-26/+25
| | | | | | | | | | | | | | MockCachingHostResolver or MockHostResolver. Make explicit when HostResolver::Resolve is expected to never complete in tests. Clean up TestURLRequestContext API. BUG=126016,128745 TEST=net_unittests; jingle_unittests; sync_unit_tests Review URL: https://chromiumcodereview.appspot.com/10408067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138413 0039d316-1c4b-4281-b951-d872f2087c98
* Changes needed to roll libjingle r141 to chrome.sergeyu@chromium.org2012-05-227-14/+26
| | | | | | | | | 1. Setting ice username and password for P2PTransportChannel. 2. Updating XMPP Auth cookie with Auth Token Review URL: https://chromiumcodereview.appspot.com/10382003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138334 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 138216 - [Sync] Turn notifier::PushClient into an interfaceakalin@chromium.org2012-05-2218-1141/+442
| | | | | | | | | | | | | | | | | | | | | | | | | | Split the previous implementation into two pieces: XmppPushClient and NonBlockingPushClient. Add FakePushClient and FakePushClientObserver. Remove use of ThreadSafeObserverList. Add PushClient::CreateDefault() function, which creates a NonBlockingPushClient for an XmppPushClient. Dep-inject PushClient into P2PNotifier. Add some helper functions to notification_defines.{h,cc}. BUG=76764 TEST= Review URL: https://chromiumcodereview.appspot.com/10413014 TBR=akalin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138221 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Turn notifier::PushClient into an interfaceakalin@chromium.org2012-05-2218-442/+1141
| | | | | | | | | | | | | | | | | | | | | | | Split the previous implementation into two pieces: XmppPushClient and NonBlockingPushClient. Add FakePushClient and FakePushClientObserver. Remove use of ThreadSafeObserverList. Add PushClient::CreateDefault() function, which creates a NonBlockingPushClient for an XmppPushClient. Dep-inject PushClient into P2PNotifier. Add some helper functions to notification_defines.{h,cc}. BUG=76764 TEST= Review URL: https://chromiumcodereview.appspot.com/10413014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138216 0039d316-1c4b-4281-b951-d872f2087c98