| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should consistently:
#include "base/gtest_prod_util.h"
which does the gtest include (from the right place, in a
second repo, hidden in our tree).
This is critical to being able to supplant the FRIEND_TEST
macro, which we're experimenting with to optimize builds.
r=brettw
TBR=other owners (this is a trivial change)
BUG=107727
Review URL: http://codereview.chromium.org/8954017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Now with ChromeOS fix.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r114642 - it broke ChromeOS.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8944001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8898036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add IPv6 support to talk_base::SocketAddress
- Refactored PeerConnectionFactory interface
- Bug fixes
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8914025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That matches the CQ bots, and they're significantly faster.
The global trybots are added to all subdirectory PRESUBMITs automatically, so remove win, linux, mac from subdirectory PRESUBMITs (instead of changing them too).
BUG=99521
TEST=`git try` creates faster tryjobs.
TBR=willchan (net), akalin (sync)
Review URL: http://codereview.chromium.org/8162009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/task.h is going away and being replaced by base/bind.h and base/callback.h.
This CL was automatically generated by sed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8885018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users.
BUG=none
TEST=existing.
Review URL: http://codereview.chromium.org/8824006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8831001
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/8889036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8831001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DnsRRResoler has served its time and I don't have any further plans for it.
The TransportSecurityState will be used (in a future CL) to enforce public key
pinning at certificate verification time. Currently we only enforce it in
url_request_http_job.cc which means that we've already sent the HTTP request
(inc cookies) by the time we catch the problem. This was expeditious while we
fixed some other issues, but it's time to fix it.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8692012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8801005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv
Review URL: http://codereview.chromium.org/8801004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactoring and bug fixes
- Remove global variables of class type.
NOTE: I'm landing this for Ronghua since he's on leave. The change has already been reviewed here: http://codereview.chromium.org/8790011/
but I had to create a new issue in order to resolve merge conflicts.
TBR=sergeyu
Review URL: http://codereview.chromium.org/8802019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix uninitialized memory in the jingle thread wrapper
BUG=10502
TEST=content_unittests, valgrind is happy
Review URL: http://codereview.chromium.org/8689014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
* Do not fix them all at once otherwise the CL would be too large.
TBR=jamiewalch@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8665013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8589003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for using a MockClientSocketPoolManager. The default implementation has been moved into ClientSocketPoolManagerImpl. This allows HttpNetworkSessionPeer to replace the whole ClientSocketPoolManager rather than individual socket pools, which is necessary because socket pools will become more integrated in the future.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8572041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8549004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
jingle, and media.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8511045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/8551004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/8267001/
TBR=rvargas
BUG=99889
TEST=Green tree: ./net_unittests ; ./unit_tests --gtest_filter='PredictorTest.*' ; ./jingle_unittests
Review URL: http://codereview.chromium.org/8491024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockHostResolver should not depend on the job dispatch machinery of
HostResolverImpl. This implementation aims to be more readable/reliable
while providing the same testing utility.
MockHostResolver does not use extra threads hence cannot support
WaitingHostResolverProc. To mock slow resolution, HangingHostResolver is
provided for unit_tests:PredictorTest.
Updated host_resolver_impl_unittest to test HostResolverImpl directly
(rather than through MockHostResolver).
BUG=99889
TEST=./net_unittests ; ./unit_tests --gtest_filter='PredictorTest.*' ; ./jingle_unittests
Review URL: http://codereview.chromium.org/8267001
TBR=szym@chromium.org
Review URL: http://codereview.chromium.org/8491023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockHostResolver should not depend on the job dispatch machinery of
HostResolverImpl. This implementation aims to be more readable/reliable
while providing the same testing utility.
MockHostResolver does not use extra threads hence cannot support
WaitingHostResolverProc. To mock slow resolution, HangingHostResolver is
provided for unit_tests:PredictorTest.
Updated host_resolver_impl_unittest to test HostResolverImpl directly
(rather than through MockHostResolver).
BUG=99889
TEST=./net_unittests ; ./unit_tests --gtest_filter='PredictorTest.*' ; ./jingle_unittests
Review URL: http://codereview.chromium.org/8267001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101600,94925
TEST=none
TBR=vandebo,viettrungluu
Review URL: http://codereview.chromium.org/8487001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Beside other changes the new version of libjingle has
thread-safe QName class and has all std::string and QName
statics removed.
BUG=94993,102451
TEST=Compiles
Review URL: http://codereview.chromium.org/8413059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the only property we manage is whether or not a server supports SPDY, as indicated by NPN. Also introduce a chrome/ implementation of HttpServerPropertiesManager that persists the information to Prefererences.
When we get a SpdySession for a SPDY server, record that that server supports SPDY in HttpServerPropertiesManager. When preconnecting, if we know that the server supports SPDY, only preconnect 1 socket.
R=willchan
BUG=66472
TEST=browser ui and unit tests,network unit tests
Review URL: http://codereview.chromium.org/7827033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename CompletionCallback to OldCompletionCallback in preparation for introducing a new CompletionCallback based on base::Callback.
Also renames other CompletionCallback types like CancelableCompletionCallback and TestCompletionCallback and CompletionCallbackImpl. All using sed with s/CompletionCallback/OldCompletionCallback/g.
BUG=98719
TEST=none
Review URL: http://codereview.chromium.org/8070013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87336
TEST=jingle_unittests --gtest_filter=ProxyResolvingClientSocketTest.ReportsBadProxies
Review URL: http://codereview.chromium.org/7802002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Then new code is not enabled yet, there are still some issues that
need to be resolved before this code is used by default. I plan to
make the switch in M16, as there isn't enough time left in M15.
TEST=Manual
BUG=51198
Review URL: http://codereview.chromium.org/7778022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7795059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=93812
TEST=unittests, repro steps in the bug
Review URL: http://codereview.chromium.org/7850007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91439
TEST=None
Review URL: http://codereview.chromium.org/7820008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
original CL w/LGTMs: http://codereview.chromium.org/7812036/
Review URL: http://codereview.chromium.org/7824041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so the original code that created the delayed callback is lost."
This reverts commit 4cf5cf73d319b69c32ad30af8954235755856455. (r99284)
TBR=jbates@chromium.org
Review URL: http://codereview.chromium.org/7825026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the original code that created the delayed callback is lost.
This change adds a tracked_objects::Location parameter to the APIs in base/timer.h so we can trace the PostTask callbacks. The other files are touched to add the FROM_HERE Location parameter.
Review URL: http://codereview.chromium.org/7812036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
succeeded for the same request.
BUG=87336
TEST=net_unittests --gtest_filter=ProxyServiceTest.ProxyFallback:HttpStreamFactoryTest.JobNotifiesProxy
Review URL: http://codereview.chromium.org/7532011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Encode the changed types into the XMPP push message and nudge only for those data types.
Filter out notifications sent from the originating client.
Instead of calling observers directly, synthesize a notification and send it to the server with target = self only.
BUG=92928
TEST=
Review URL: http://codereview.chromium.org/7745040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaced LossyChannel test with a new LimitedChannel test. Instead of
dropping random packets the new test limits bandwidth of the channel,
which is closer to the environment for which TCP is designed.
BUG=93153
TEST=Test doesn't take 5 minutes on trybots.
Review URL: http://codereview.chromium.org/7708018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7583053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Compiles
BUG=None.
Review URL: http://codereview.chromium.org/7551034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows the send buffer size of UDP socket has a much smaller value
than the PseudoTcp's send buffer size. This causes PseudoTcp to flood
the UDP socket and results in a EWOULDBLOCK, however the code doesn't
handle this properly but simply treat the packet as lost. This happens
very often and causes Windows host to be very janky.
BUG=91495
TEST=None
Review URL: http://codereview.chromium.org/7508015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Send() is used in some of libjingle code. WebRTC needs to create two separate
threads which Send() messages to each other. This wasn't previously supported in
JingleThreadWrapper.
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7520014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Send() is used in some of libjingle code. WebRTC needs to create two separate
threads which Send() messages to each other. This wasn't previously supported in
JingleThreadWrapper.
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7520014
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/7540030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Send() is used in some of libjingle code. WebRTC needs to create two separate
threads which Send() messages to each other. This wasn't previously supported in
JingleThreadWrapper.
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/7520014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Increase the sizes of these two values so that we can cope with high latency
network.
BUG=91011
TEST=None
Review URL: http://codereview.chromium.org/7539006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91011
TEST=Unittests.
Review URL: http://codereview.chromium.org/7540003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
synchronous resolution.
BUG=90547,60149
TEST=net_unittests
Review URL: http://codereview.chromium.org/7520026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94552 0039d316-1c4b-4281-b951-d872f2087c98
|