| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
| |
This uses an automated script, so it'll catch things the first pass, done by hand, missed.
BUG=138542
TBR=dalecurtis@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1542013004
Cr-Commit-Position: refs/heads/master@{#366712}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This addition is quite pervasive in other folders [1], I found
it useful when uploading patches for e.g. cc/ and ui/. I guess
it wasn't added to media/ in the past due to the slight style
differences in this folder, but by now all new patches should
conform to Chromium style.
[1] https://code.google.com/p/chromium/codesearch#search/&q=CheckPatchFormatted&sq=package:chromium&type=cs
Review URL: https://codereview.chromium.org/1403413002
Cr-Commit-Position: refs/heads/master@{#354527}
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Not in gcl, which probably these days nobody working on Chromium uses.
BUG=None
R=maruel@chromium.org
TBR=maruel@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/887033002
Cr-Commit-Position: refs/heads/master@{#314039}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a PRESUBMIT test to src/media/ which enforces the following when using UMA_HISTOGRAM_ENUMERATION:
- The max enum value should be suffixed with 'MAX' or 'Max' (and it should be equal to the largest valid entry ever logged).
- One should be added to that max value when used in the UMA_HISTOGRAM_ENUMERATION macro.
To handle past misuses of UMA_HISTOGRAM_ENUMERATION for non-enums a comment of '// IGNORE_PRESUBMIT_UMA_MAX' was added to silence the presubmit check.
BUG=165553
TBR=danakj
Review URL: https://codereview.chromium.org/148553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254209 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
In most cases SingleThreadTaskRunner can be used instead.
BUG=315922
R=dalecurtis@chromium.org
Review URL: https://codereview.chromium.org/101503007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243408 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
system clock.
Added exclude regexp to prevent warning for certain reasonable cases: 1) a 'using base::Time' declaration; and 2) references to base::Time::kXXX constants (a bug fix).
BUG=247881
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17426008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
This change corrects all the "low-hanging fruit," leaving the VideoCaptureDevice interface and MediaLog (?) as separate changes; as they are referenced throughout other components.
Added a PRESUBMIT.py script for media/ code that will scan future code changes for use of base::Time (or base::Clock/DefaultClock) and prompt the developer with a warning explaining that clock skew is a serious and subtle source of bugs.
Testing: Ran all media_unittests and content_unittests. Manually ran through demo sites that utilize all of the following (on all of Win/Mac/Linux): 1. HTML5 audio and video; 2. PPAPI Flash video; 3. WebAudio API; 4. WebRTC; 5. Tab Capture API.
BUG=247881
TEST=media_unittests, content_unittests, manual confirmation of major media use cases
Review URL: https://chromiumcodereview.appspot.com/16823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206206 0039d316-1c4b-4281-b951-d872f2087c98
|
