summaryrefslogtreecommitdiffstats
path: root/media/audio
Commit message (Collapse)AuthorAgeFilesLines
* Simplify AlsaPcmOutputStream and AudioManagerLinux. Code was thread-safe, ↵enal@chromium.org2011-06-085-273/+159
| | | | | | | | | | | | | | but now client and audio threads are the same, so we don't need locks/ref counts/etc. http://codereview.chromium.org/7117001 BUG=62588 Review URL: http://codereview.chromium.org/7117001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88369 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for CoreAudio stereo problem for unknown speakersannacc@chromium.org2011-06-081-2/+22
| | | | | | | | | | BUG=85100 TEST=HTML5 videos with stereo channel layout on Mac with unconfigured speakers can be heard. Review URL: http://codereview.chromium.org/7134001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88339 0039d316-1c4b-4281-b951-d872f2087c98
* Better memory management for audio channel swizzle code.annacc@chromium.org2011-06-021-10/+16
| | | | | | | | | | | | | | This patch fixes some of the errors created by: http://codereview.chromium.org/7047020/ To see memory issue suppressions, see http://codereview.chromium.org/7077020/ and http://codereview.chromium.org/7085020/ BUG=84142 TEST=tools/valgrind/chrome_tests.sh -t media --gtest_filter=MacAudioTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87535 Review URL: http://codereview.chromium.org/7094007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87616 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 87535 - Better memory management for audio channel swizzle code.michaeln@google.com2011-06-011-16/+10
| | | | | | | | | | | | | | | | This patch fixes some of the errors created by: http://codereview.chromium.org/7047020/ To see memory issue suppressions, see http://codereview.chromium.org/7077020/ and http://codereview.chromium.org/7085020/ BUG=84142 TEST=tools/valgrind/chrome_tests.sh -t media --gtest_filter=MacAudioTest.* Review URL: http://codereview.chromium.org/7094007 TBR=annacc@chromium.org Review URL: http://codereview.chromium.org/7074037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87540 0039d316-1c4b-4281-b951-d872f2087c98
* Better memory management for audio channel swizzle code.annacc@chromium.org2011-06-011-10/+16
| | | | | | | | | | | | | This patch fixes some of the errors created by: http://codereview.chromium.org/7047020/ To see memory issue suppressions, see http://codereview.chromium.org/7077020/ and http://codereview.chromium.org/7085020/ BUG=84142 TEST=tools/valgrind/chrome_tests.sh -t media --gtest_filter=MacAudioTest.* Review URL: http://codereview.chromium.org/7094007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87535 0039d316-1c4b-4281-b951-d872f2087c98
* Adding GetAudioInputDeviceNames() to AudioManager, which allows for device ↵scherkus@chromium.org2011-06-0112-5/+196
| | | | | | | | | | | | | | enumeration. The current version only supports the default device and isn't fully implemented for Mac/Windows yet. Patch by xians@chromium.org: http://codereview.chromium.org/7060011/ BUG=none TEST=media_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87493 0039d316-1c4b-4281-b951-d872f2087c98
* Surround sound swizzling for Mac based on device channel layout preferences.annacc@chromium.org2011-05-262-20/+213
| | | | | | | | | | | | | This patch gets the surround sound channel layout from the user's device using CoreAudio. It then swizzles the channel layout from the source to match the user's prefered channel layout (if needed). BUG=none. TEST=none. Review URL: http://codereview.chromium.org/7047020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86851 0039d316-1c4b-4281-b951-d872f2087c98
* Description:annacc@chromium.org2011-05-1611-141/+241
| | | | | | | | | | | | | | | | | This patch gets the channel layout for surround sound channel order from ffmpeg and stores it so that chromium will be able to re-order the channels for various sound cards and OSes later. - AudioParameters gets a new field (channel_layout). - channel_layout.h stores an enum that we will use in chromium for channel values. - ffmpeg_common.h gets a new method for mapping the channel layout received from ffmpeg to an internal chromium enum value. BUG=None (though storing the channel order should help us solve some other bugs soon) TEST=media_unittests Review URL: http://codereview.chromium.org/6930039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85541 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 3.jhawkins@chromium.org2011-05-121-2/+2
| | | | | | | | | | | BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
* Updating logging in src/media/. Using DCHECK_EQ/NE/LE() where possible.kushi.p@gmail.com2011-04-292-4/+4
| | | | | | | | | BUG=58409 TEST=None Review URL: http://codereview.chromium.org/6893032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83557 0039d316-1c4b-4281-b951-d872f2087c98
* Replace AudioDecoder::media_format() with AudioDecoderConfig.scherkus@chromium.org2011-04-263-3/+69
| | | | | | | | | | | Also includes some cleanup for AudioParameter users including a new helper method GetBytesPerSecond(). BUG=28206 TEST=media_unittests, test_shell_tests, etc... Review URL: http://codereview.chromium.org/6903007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83098 0039d316-1c4b-4281-b951-d872f2087c98
* Blind fix for a Linux only crash in AudioManager::Destroythestig@chromium.org2011-04-221-4/+6
| | | | | | | | BUG=80059 TEST=none Review URL: http://codereview.chromium.org/6878081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82612 0039d316-1c4b-4281-b951-d872f2087c98
* Open ALSA device using hw_params callsdavej@chromium.org2011-04-192-4/+72
| | | | | | | | | | | Replaced using ALSA snd_pcm_set_params() with separate snd_pcm_hw_X() calls in order to use snd_pcm_hw_params_set_rate_near() which allows for setting rates on some devices that don't normally allow some rates like 22050Hz. BUG=chromium-os:13231, chromium-os:13721 TEST=Manual, 22khz audio should play (test file in bug) Review URL: http://codereview.chromium.org/6869037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82042 0039d316-1c4b-4281-b951-d872f2087c98
* Allow audio output on Linux to work with web audio APIcrogers@google.com2011-04-161-2/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6871030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81843 0039d316-1c4b-4281-b951-d872f2087c98
* Fix erratic HTML5 audio playbackdavej@chromium.org2011-04-142-21/+54
| | | | | | | | | | | | | | | This was affecting all platforms. The major issue was that he SetPlaybackRate(1) which is used to start playback was being done in the middle of the series of Seek operations. So doing Seek() followed by SetPlaybackRate(1) was done, the Seek could immediately stop the playback. To fix, Seek() was made atomic with regards to SetPlaybackRate() by delaying the execution of SetPlaybackRate until after the Seek sequence has completely finished. To make things run even smoother, a short delay was added before recyclilng a used audio stream in the Dispatcher. This gives the stream time to 'power down' before being reused. Tested on Linux, Chrome-OS (Cr48) and Mac with great results, making HTML5 audio much more usable for games. BUG=73045,59369,59370,65618 TEST=Manual, Quickly playing/stopping HTML5 audio should play cleanly. Review URL: http://codereview.chromium.org/6822019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81670 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux audio playbackdavej@chromium.org2011-04-142-2/+26
| | | | | | | | | | | | | Playing audio files shorter than about 11000 samples on Linux was either not working at all, or re-playing (starting and stopping on the same audio object) was working only intermittently. It was possible to stop audio playback before the first buffer was played, resulting in no sound at all. Also, if replaying, the buffer may have been dirty from the previous playback on the same device. So on Linux at least, these issues appear fixed. BUG=73045,47761,59367,59369,59370,65618 TEST=Manual, quickly playing short audio files on Linux should work Review URL: http://codereview.chromium.org/6776024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81669 0039d316-1c4b-4281-b951-d872f2087c98
* Implements AudioInputDevice API for low-latency audio input in the browser ↵scherkus@chromium.org2011-04-124-13/+85
| | | | | | | | | | | | | | process. Also refactors some shared audio code into audio_common.{cc,h}. Patch by henrika@chromim.org: http://codereview.chromium.org/6250196/ BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81315 0039d316-1c4b-4281-b951-d872f2087c98
* Mac platform was not treating 8bit PCM audio as unsigned data.sjl@google.com2011-04-011-4/+15
| | | | | | | | | | | If bits per channel is 8, open the stream as unsigned and use 128 as the silence value. BUG=70730 TEST=media_unittests and manual testing of a bunch of audio files (8 bit and others). Review URL: http://codereview.chromium.org/6689003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80181 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-2812-26/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Add WebKit API to retrieve the audio hardware sample-ratecrogers@google.com2011-03-232-0/+18
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6721015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79088 0039d316-1c4b-4281-b951-d872f2087c98
* Use default "output" rather than "input" device when querying hardware ↵crogers@google.com2011-03-221-3/+3
| | | | | | | | | | | sample-rate BUG=none TEST=none (tested locally on Mac OS X to verify that hardware sample-rate is correctly retrieved) Review URL: http://codereview.chromium.org/6721001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79055 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a test which checks for timing of audio recording callbacks.satish@chromium.org2011-03-111-50/+0
| | | | | | | | | | | | This frequently fails in various builders because the machines may be overloaded when the tests run, so I see no point in such a timing test. BUG=49497 TEST=none Review URL: http://codereview.chromium.org/6673022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77819 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up src/media to be consistent with static versus anonymous namespaces.scherkus@chromium.org2011-03-0721-184/+92
| | | | | | | | | | | | | We were using a mix of both (and sometimes even static functions *inside* anonymous namespaces!) so we decided to stick to using static. Also moved static/test code into media namespace and removed media:: prefixes. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6628020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77135 0039d316-1c4b-4281-b951-d872f2087c98
* Adds method to invoke platform provided audio input UI.satish@chromium.org2011-03-018-0/+78
| | | | | | | | | | | This will be used in a future CL by the speech input feature. BUG=69886 TEST=none Review URL: http://codereview.chromium.org/6602012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76363 0039d316-1c4b-4281-b951-d872f2087c98
* Bug-fixes for AudioInputStream:scherkus@chromium.org2011-02-162-2/+3
| | | | | | | | | | | | | | | - s/scoped_ptr/scoped_array/ for new[]'d memory; this fixes a bug valgrind found and which can cause memory corruption (as delete was being called instead of delete[] before, which can confuse the allocator). - Fix memory leak where AlsaPcmInputStreams would fail to be deleted. Patch by fischman@chromium.org: http://codereview.chromium.org/6523027/ BUG=none TEST=valgrind media_unittests stops complaining about leaking the AIS and using delete instead of delete[]. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75156 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NullAudioManager.sergeyu@chromium.org2011-02-141-27/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6473021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in WinAudioTest.PCMWaveStreamOpenLimit.robertshield@chromium.org2011-02-131-2/+3
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6487024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74745 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74590 - Disable AudioOutputControllerTest.CreateAndClose since it ↵sergeyu@chromium.org2011-02-121-5/+0
| | | | | | | | | | | | | | crashes on Windows in release. BUG=72718 TEST=none Review URL: http://codereview.chromium.org/6489032 TBR=maruel@chromium.org Review URL: http://codereview.chromium.org/6513007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74729 0039d316-1c4b-4281-b951-d872f2087c98
* clang: Fix several -Woverloaded-virtual warnings.thakis@chromium.org2011-02-111-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Real bugs: net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:310:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>' requested here CaptureGroupNameHttpProxySocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:316:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>' requested here CaptureGroupNameSSLSocketPool::CaptureGroupNameSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5511:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>' requested here new CaptureGroupNameTCPSocketPool(NULL, NULL); ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_network_transaction_unittest.cc:5630:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>' requested here new CaptureGroupNameSOCKSSocketPool(NULL, NULL); ^ In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_response_body_drainer_unittest.o 4 errors generated. net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:170:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>' requested here CapturePreconnectsHttpProxySocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:10: ./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:176:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>' requested here CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool( ^ In file included from ./net/http/http_network_session_peer.h:12: ./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:188:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>' requested here new CapturePreconnectsTCPSocketPool( ^ In file included from ./net/socket/socket_test_util.h:34: ./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual] virtual void ReleaseSocket(const std::string& group_name, ^ net/http/http_stream_factory_unittest.cc:237:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>' requested here new CapturePreconnectsSOCKSSocketPool( ^ In file included from net/http/http_stream_factory_unittest.cc:17: In file included from ./net/http/http_network_session_peer.h:11: ./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here virtual void ReleaseSocket(const std::string& group_name, ^ CXX(target) out/Debug/obj.target/net_unittests/net/http/http_vary_data_unittest.o 4 errors generated. make: *** [out/Debug/obj.target/net_unittests/net/http/http_stream_factory_unittest.o] Error 1 media/audio/linux/alsa_output_unittest.cc:83:3:error: 'MockAudioManagerLinux::MakeAudioInputStream' hides overloaded virtual function [-Woverloaded-virtual] MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:12: In file included from ./testing/gmock/include/gmock/gmock.h:61: testing/gmock/include/gmock/gmock-generated-function-mockers.h:632:28: note: instantiated from: ^ media/audio/linux/alsa_output_unittest.cc:83:3: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ media/audio/linux/alsa_output_unittest.cc:83:16: note: instantiated from: MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*( ^ In file included from media/audio/linux/alsa_output_unittest.cc:9: ./media/audio/linux/audio_manager_linux.h:30:29: note: hidden overloaded virtual function 'AudioManagerLinux::MakeAudioInputStream' declared here virtual AudioInputStream* MakeAudioInputStream(AudioParameters params); ^ CXX(target) out/Debug/obj.target/media_unittests/media/base/data_buffer_unittest.o CXX(target) out/Debug/obj.target/media_unittests/media/base/djb2_unittest.o 1 error generated. No bug, just confusing: In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5: In file included from ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:9: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. make: *** [out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_schedule_timer_test.o] Error 1 CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_private_test.o CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_test_factory.o In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:17: ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual] void HandleEvent(int event_index); ^ In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:7: In file included from ./webkit/plugins/npapi/test/plugin_arguments_test.h:8: ./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here virtual int16 HandleEvent(void* event); ^ 1 error generated. BUG=72205 TEST=none Review URL: http://codereview.chromium.org/6503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74642 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AudioOutputControllerTest.CreateAndClose since it crashes on Windows ↵maruel@chromium.org2011-02-111-0/+5
| | | | | | | | | | | in release. BUG=72718 TEST=none Review URL: http://codereview.chromium.org/6489032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74590 0039d316-1c4b-4281-b951-d872f2087c98
* Override AudioManager::MakeAudioInputStream() in NullAudioManager.sergeyu@chromium.org2011-02-101-7/+9
| | | | | | | | | BUG=72577 TEST=None Review URL: http://codereview.chromium.org/6487008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74492 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FakeAudioInputTest.BasicCallbacks after two crashes in a row.dmazzoni@chromium.org2011-02-101-2/+2
| | | | | | | | | TEST=disables crashing test BUG=49497 Review URL: http://codereview.chromium.org/6480012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74385 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up warnings found in our testing code.erg@google.com2011-02-071-2/+2
| | | | | | | | | | | | | Time wise, this only speeds things up by a minute, which I think is within the margin of error. I can't get a good size measurement since we aren't building .a files for a lot of this code. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6312137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73999 0039d316-1c4b-4281-b951-d872f2087c98
* media/audio/mac/audio_low_latency_output_mac.cc is missing an #include.mark@chromium.org2011-02-021-0/+2
| | | | | | | | | | | | | | | | | | audio_low_latency_output_mac.cc, new in r73058, uses the Mac OS X Component Manager. This includes the Component and ComponentDescription types, and the FindNextComponent, OpenAComponent, and CloseComponent calls. To use the Component Manager, #include <CoreServices/CoreServices.h> http://developer.apple.com/library/mac/#documentation/Carbon/Reference/Component_Manager/Reference/reference.html CoreServices.h is probably #included by something else when using the 10.5 SDK, but this caused a compilation failure with the 10.6 SDK. BUG=none TEST=none Review URL: http://codereview.chromium.org/6286056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73503 0039d316-1c4b-4281-b951-d872f2087c98
* Add a low-latency AudioOutputStream implementation for Mac OS X.crogers@google.com2011-01-296-12/+350
| | | | | | | | | BUG=none TEST=none (tested locally to verify this code plays audio with much lower latency than the current PCMQueueOutAudioOutputStream implementation) Review URL: http://codereview.chromium.org/6350019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73058 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-218-25/+25
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Implement renderer AudioDevice API for low-latency audio outputcrogers@google.com2011-01-152-0/+31
| | | | | | | | | BUG=none TEST=none (I tested locally for Mac OS X, but we'll need further testing for Windows and Linux as we add real-time threads, etc.) Review URL: http://codereview.chromium.org/6002005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71521 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in reading audio capture device name.satish@chromium.org2011-01-141-0/+3
| | | | | | | | | | | Relevant crash report: http://crash/reportdetail?reportid=c48906f8d604a9d5#crashing_thread BUG=69608 TEST=none Review URL: http://codereview.chromium.org/6333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71434 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-141-9/+9
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* Use the lock when accessing the buffer object.cevans@chromium.org2011-01-121-0/+1
| | | | | | | | | BUG=69195 TEST=play Z-Type for hours :) Review URL: http://codereview.chromium.org/6157007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71211 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Remove base/scoped_handle_win.h."tfarina@chromium.org2011-01-092-6/+7
| | | | | | | | | | | | | | | Fixed the problem with rlz library. Now should be fine to land this again. This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3. Original Review URL: http://codereview.chromium.org/6126002/ BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-072-7/+6
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-072-6/+7
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Fix indents. I am used to webkit style, so did it wrong in last commit.inferno@chromium.org2011-01-061-2/+2
| | | | | | | BUG=68244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70637 0039d316-1c4b-4281-b951-d872f2087c98
* Turn the volume range check into a bail out return to prevent browser crash.inferno@chromium.org2011-01-061-3/+5
| | | | | | | | | BUG=68244 TEST=None Review URL: http://codereview.chromium.org/6133001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70635 0039d316-1c4b-4281-b951-d872f2087c98
* Move CancellationFlag and WaitableEvent to the synchronization subdirectory.brettw@chromium.org2011-01-022-2/+2
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5977010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70369 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/platform_thread.h stub and fix up all callers to use the new ↵brettw@google.com2011-01-013-8/+10
| | | | | | | | | location and namespace. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70346 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/thread.h to base/threading, fix up callers to use the new location.brettw@chromium.org2011-01-015-5/+5
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AudioManager shutdownacolwell@chromium.org2010-12-236-2/+30
| | | | | | | | | | | | | | | | | | This patch makes sure the audio thread is stopped before the AudioManager is destroyed. Under heavy load it is possible to have tasks still on the audio thread's message loop when the audio manager is destroyed. These were getting called when the Thread object is destroyed which happens after all of the AudioManager destructors are called. The new Cleanup() method stops the thread before any destruction occurs. BUG=67804 TEST=none Review URL: http://codereview.chromium.org/6026011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70034 0039d316-1c4b-4281-b951-d872f2087c98
* Set scoped IO access when closing the audio input thread to allow joining.leandrogracia@chromium.org2010-12-221-0/+11
| | | | | | | | | | | This is a fix for the crash problem described by issue 67806. The problem was caused by a new included IO access assertion that prevented the IO thread to join any other thread. This raised an error when trying to stop the audio recording thread. BUG=67806 TEST=none Review URL: http://codereview.chromium.org/6063004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69994 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 10:53:33 +0000