summaryrefslogtreecommitdiffstats
path: root/media/base/media_switches.h
Commit message (Collapse)AuthorAgeFilesLines
* Flag to switch between MultiBufferDataSource and BufferedDataSourcehubbe2015-12-141-0/+2
| | | | | | | | | | | | | The flag is called --media-use-multibuffer and defaults to off. Depends on: https://codereview.chromium.org/1399603003/ BUG=514719, 516589 Review URL: https://codereview.chromium.org/1443273004 Cr-Commit-Position: refs/heads/master@{#365094}
* Implement WMPI suspend/resume.sandersd2015-12-121-0/+3
| | | | | | | | | | | With this change, WMPI translates WasShown()/WasHidden() on RenderFrameImpl to pipeline Suspend()/Resume(). BUG=516850 Review URL: https://codereview.chromium.org/1473733002 Cr-Commit-Position: refs/heads/master@{#364854}
* Convert audio thread hang crash to UMA. Dump driver info on Win.dalecurtis2015-12-111-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | This crash has gone on for too long and, as far as we know, can't be fixed within Chrome. So instead of crashing just log this data to UMA on all platforms. On Windows dump a non-crash report with the device driver name and version information since we have an open channel with Microsoft for tracking down misbehaving drivers. Introduces a new histogram Media.AudioThreadStatus for tracking started, hung, and recovered values. As well as code for reading the driver name and version from dxdiag structures. Notably, since this is now a UMA we will record hangs even on stable or beta, but only log crash dumps on Dev/Canary/Unknown; since these hangs appear to be high frequency, it doesn't seem wise or necessary to enable the crash dumps on stable/beta. If canary/unknown prove sufficient for crash key dumps, I'll limit to there in a followup CL. BUG=422522,478932,546750 TEST=new unittest, manual verification of uma values. TBR=thestig Review URL: https://codereview.chromium.org/1513143002 Cr-Commit-Position: refs/heads/master@{#364792}
* Add runtime flag for choosing WMPI or WMPA.dalecurtis2015-11-091-0/+1
| | | | | | | | | | | | | Adds a new switch, --enable-unified-media-pipeline to control usage of WMPI vs WMPA. Will be needed for finch experiments as well as local testing. BUG=507834 TEST=builds, command line flag works Review URL: https://codereview.chromium.org/1431193003 Cr-Commit-Position: refs/heads/master@{#358695}
* Add command line flag to disable MediaCodecPlayertimav2015-10-241-0/+1
| | | | | | | | | | | | | | During finch trial that turns MediaCodecPlayer on we might want to tun it off for the device in hand. This CL adds the command line flag --disable-media-thread-for-media-playback that forces the current player, i.e. MediaSourcePlayer. BUG=407577 Review URL: https://codereview.chromium.org/1421793005 Cr-Commit-Position: refs/heads/master@{#355961}
* Turn on VideoRendererAlgorithm for WebMediaPlayerMS by default.qiangchen2015-10-211-1/+1
| | | | | | | | | | | | | | The algorithm is intended to increase the rendering smoothness for WebRTC. Previously, it is behind flag --enable-rtc-smoothness-algorithm. Now it is on by default, and you can disable it by using flag --disable-rtc-smoothness-algorithm. The targeted workflow has been tested for a couple of months, and it went well. Now we've decided to bring it on to increase the test population, and let the code path to go over more comprehensive test on multiple platforms and for other workflows to make sure nothing is broken. BUG=514873 TEST=Keep an eye on Cast, as it uses WebMediaPlayerMS, but uses a different code path than webrtc to get frames. Review URL: https://codereview.chromium.org/1413163003 Cr-Commit-Position: refs/heads/master@{#355303}
* media: Remove VideoRendererImpl old push based path.dcastagna2015-09-211-2/+0
| | | | | | | | | | | | A new video renderering path, that uses VideoRendererAlgorithm, has been introduced as the default in m44. This CL removes the old push based video renderer code. BUG=532145 Review URL: https://codereview.chromium.org/1345663003 Cr-Commit-Position: refs/heads/master@{#350017}
* Make a flag enable-rtc-smoothness-algorithm for the new rendering algorithm.qiangchen2015-07-291-0/+2
| | | | | | | | BUG=514873 Review URL: https://codereview.chromium.org/1261633003 Cr-Commit-Position: refs/heads/master@{#340979}
* VideoCaptureParams: |use_gpu_memory_buffers| flag and FakeVCD adaptationmcasas2015-06-261-3/+1
| | | | | | | | | | | | | | | | | | | | VideoCaptureParams::use_native_gpu_memory_buffers [1] is OS_LINUX specific flag for indicating to the Device Driver to try and capture using those buffers. This CL changes that flag to be available in other platforms. It also removes the "native" indication, since that is Linux specific. FakeVCD is adapted, together with its unittests, to reflect this way of requesting capture in GMBs. [1] https://code.google.com/p/chromium/codesearch#chromium/src/media/base/video_capture_types.h&sq=package:chromium&type=cs&q=use_native_gpu_memory_buffers&l=122 BUG=503835 Review URL: https://codereview.chromium.org/1201393002 Cr-Commit-Position: refs/heads/master@{#336304}
* VideoCaptureParams: add flag for hinting capture using GpuMemoryBuffers & ↵mcasas2015-06-161-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | flag for it This CL adds a command line flag and storage for it in VideoCaptureParams, so we can hint the Video Capture Device to use native GpuMemoryBuffers. Ths is an experimental CL to be used while other moving parts of the capture using GMBs are landed and performance numbers/finch experiments are collected. For consistency with Style Guide, VideoCaptureFormat and VideoCaptureParams are changed from class to struct. This flag is only used in Linux. BUG=440843 Review URL: https://codereview.chromium.org/1191443003 Cr-Commit-Position: refs/heads/master@{#334674}
* media: Remove kDisableInfobarForProtectedMediaIdentifier flag.xhwang2015-06-121-1/+0
| | | | | | | | | | | This flag is currently not used anywhere. BUG=489429 R=ddorwin@chromium.org Review URL: https://codereview.chromium.org/1153543015 Cr-Commit-Position: refs/heads/master@{#334208}
* Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flaghenryhsu2015-05-121-3/+0
| | | | | | | | | | | | | Since decoder supports GetSupportedProfiles and v4l2 supports ENUM_FRAMESIZES, this flag can be removed and use runtime detection to get maximum resolution for a specified profile. BUG=350197 TEST=manually test pass on peach_pit, peach_pi, nyan_big and veyron_jerry. Review URL: https://codereview.chromium.org/1097913002 Cr-Commit-Position: refs/heads/master@{#329395}
* [RELAND] Added stub MediaSourcePlayer for developing behind the flagtimav2015-05-101-0/+1
| | | | | | | | | | | | | | | Added a new experimental flag and stub implementation for the player. Created Media thread and redirected demuxer messages to it. BUG=none Committed: https://crrev.com/8ad68b12db7db320a37e39e94be8d45205fee626 Cr-Commit-Position: refs/heads/master@{#329059} Review URL: https://codereview.chromium.org/1076013002 Cr-Commit-Position: refs/heads/master@{#329068}
* Revert of Added stub MediaSourcePlayer for developing behind the flag ↵miu2015-05-101-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #13 id:240001 of https://codereview.chromium.org/1076013002/) Reason for revert: Broke Android Clang Builder (dbg): http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Clang%20Builder%20%28dbg%29&number=59307 Original issue's description: > Added stub MediaSourcePlayer for developing behind the flag > > Added a new experimental flag and stub implementation for > the player. Created Media thread and redirected demuxer > messages to it. > > BUG=none > > Committed: https://crrev.com/8ad68b12db7db320a37e39e94be8d45205fee626 > Cr-Commit-Position: refs/heads/master@{#329059} TBR=qinmin@chromium.org,timav@google.com,xhwang@chromium.org,sievers@chromium.org,timav@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1132973002 Cr-Commit-Position: refs/heads/master@{#329061}
* Added stub MediaSourcePlayer for developing behind the flagtimav2015-05-091-0/+1
| | | | | | | | | | | | Added a new experimental flag and stub implementation for the player. Created Media thread and redirected demuxer messages to it. BUG=none Review URL: https://codereview.chromium.org/1076013002 Cr-Commit-Position: refs/heads/master@{#329059}
* Turn new video rendering path on by default, invert flag.dalecurtis2015-05-051-1/+1
| | | | | | | | | | | | | | | | | | | CPU, smoothness, and idle wakeup measures are all drastically improved and there appear to be no regressions thus far... so flip the flag and watch the channels for results! Layout test issues have been fixed by a couple of compositor side CLs prior to this landing: http://crrev.com/328220 http://crrev.com/328238 BUG=386551, 396803, 438680, 438766, 439548, 460190 TEST=manual, automated, layout, telemetry. Review URL: https://codereview.chromium.org/1125673008 Cr-Commit-Position: refs/heads/master@{#328386}
* Connect the new video rendering path to the compositor.dalecurtis2015-05-011-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hooks up the new VideoRendererAlgorithm to the VideoRendererImpl and it to the VideoRendererSink (VideoFrameCompositor) which finally talks to the VideoFrameProviderClientImpl! All of this is behind a new flag: --enable-new-video-renderer for right now. We'll slowly ramp it up based on crash and YouTube metrics. It is also available via chrome://flags for our YT friends to test immediately. The playback experience is significantly smoother, dropped frame counts are significantly more accurate, power consumption is much lower in background tabs, and slightly lower in the foreground! Smoothness scores (windows): New: 24: Smoothness: 98.750000, Freezing: 100.000000, ~Dropped: 29 / 749 (3.871829%) 30: Smoothness: 99.330000, Freezing: 100.000000, ~Dropped: 0 / 900 (0.000000%) 60: Smoothness: 99.280000, Freezing: 99.670000, ~Dropped: 6 / 1800 (0.333333%) Old: 24: Smoothness: 92.640000, Freezing: 100.000000, ~Dropped: 29 / 749 (3.871829%) 30: Smoothness: 68.490000, Freezing: 99.440000, ~Dropped: 5 / 900 (0.555556%) 60: Smoothness: 99.280000, Freezing: 99.670000, ~Dropped: 6 / 1800 (0.333333%) See http://xorax.sea/barcode/results_win/ for further details. Power consumption metrics on OSX for 1080p VP9 playback averaged over 10 runs: New: energy_consumption_mwh: 38.994639mWh idle_wakeups_total: 1459.600000count cpu_utilization (browser): 4.752003% cpu_utilization (gpu): 7.791677% cpu_utilization (renderer): 74.691065% Old: energy_consumption_mwh: 39.114139mWh idle_wakeups_total: 1947.900000count cpu_utilization (browser): 5.125488% cpu_utilization (gpu): 8.624919% cpu_utilization (renderer): 84.009566% New Background: energy_consumption_mwh: 31.402967mWh idle_wakeups_total: 195.500000count cpu_utilization (browser): 1.594367% cpu_utilization (gpu): 0.154281% cpu_utilization (renderer): 49.920668% Old Background: energy_consumption_mwh: 42.224069mWh idle_wakeups_total: 522.200000count cpu_utilization (browser): 1.629945% cpu_utilization (gpu): 0.155414% cpu_utilization (renderer): 63.333668% See http://xorax.sea/barcode/results_osx/ for the full run details. I wouldn't trust the absolute values for cpu or energy consumption, but the relative difference should be meaningful. This clamps background canvas updates from video to once every 250ms, but in practice I couldn't tell the difference when tab switching in a debug build. BUG=386551, 396803, 438680, 438766, 439548, 460190 TEST=manual playback, unit tests TBR=asvitkine Review URL: https://codereview.chromium.org/1083383005 Cr-Commit-Position: refs/heads/master@{#327889}
* Switch audio hang monitor to default-off. Enable for non-beta,stable.dalecurtis2015-04-281-0/+2
| | | | | | | | | | | | | Too many crashes and out of ideas for how to resolve this for right now; this at least provides the chance that these users might unhang themselves some time after the 2 minute hang timer. BUG=422522, 468074, 478932 TEST=start w/ and w/o hang monitor according to channel, flags. Review URL: https://codereview.chromium.org/1105083004 Cr-Commit-Position: refs/heads/master@{#327356}
* Move underflow threshold limits out of the video renderer.dalecurtis2015-04-031-0/+2
| | | | | | | | | | | | | | | | | | | | | The threshold logic is incorrect when there's no audio track, which the VideoRendererImpl has no knowledge of, so this logic needs to live in the RendererImpl. As a consequence of this, the underflow threshold is now based on wall clock time instead of media time; which means non-realtime playback will allow more or less media time to elapse before underflow occurs. Exposes a new command line flag --video-underflow-threshold-ms to allow for experiments varying the threshold for YouTube. BUG=423801, 470940 TEST=new unittests. Review URL: https://codereview.chromium.org/1034233002 Cr-Commit-Position: refs/heads/master@{#323599}
* Replace kMediaDrmEnableNonCompositing swicth with ↵ddorwin2015-04-021-1/+0
| | | | | | | | | | | | | | | use_video_overlay_for_embedded_encrypted_video pref Disables kMediaDrmEnableNonCompositing by default in WebView. It is now controlled by the pref. Also updates comments related to enabling unprefixed EME. BUG=470275,470279 Review URL: https://codereview.chromium.org/1045173002 Cr-Commit-Position: refs/heads/master@{#323420}
* Add flag --require-audio-hardware-for-testing.watk2015-02-111-0/+2
| | | | | | | | | | | | When enabled, tests that require audio hardware will fail if the system doesn't provide it. Otherwise, they will silently succeed. TEST=media_unittests (and AudioInputTests with !InputDevicesAvailable()) BUG=432624 Review URL: https://codereview.chromium.org/914483002 Cr-Commit-Position: refs/heads/master@{#315823}
* Makes the WebRTC fake device capable of playing audio from a file.phoglund2014-11-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The purpose of this patch is to be able to do advanced audio testing, such as AGC testing and (if possible) AEC testing. The patch adds a new flag --use-file-for-fake-audio-capture, similar to --use-file-for-fake-video-capture on the video side. It takes as argument a file to play back on the fake devices instead of the default generated beep sound. The new flag is to be used together with --use-fake-devices-for-media-stream (if the new flag isn't specified, the former flag will play beep sounds as usual). I think adding a new flag makes sense for now, but we could look at coalescing these flags in a later patch since more flags = bad. As for the implementation, I considered creating a new file fake input stream on the side of the old one, and have audio_manager_base.cc choose between the two implementations depending on how the flags were set. I ended up not doing since the two classes would have a lot in common, notably all the timing code. Another option could be to pull beeping/playing from file into a new abstraction which the fake input call stream calls into. I think the current implementation is reasonable though. Also, this patch will require the audio file to be in exactly the same format as the audio bus on the system. We may want to add resampling support later if this turns out to be a problem on the bots. Developed together with xians@. BUG=421054 R=dalecurtis@chromium.org Review URL: https://codereview.chromium.org/734993002 Cr-Commit-Position: refs/heads/master@{#305195}
* media: Remove FilterCollection.xhwang2014-08-291-0/+2
| | | | | | | | | | | | Now we pass Demuxer and Renderer directly into Pipeline, and create TextRenderer directly in Pipeline. As a result, we don't need FilterCollection anymore. BUG=408602 TEST=All existing tests pass. Review URL: https://codereview.chromium.org/511323003 Cr-Commit-Position: refs/heads/master@{#292542}
* Enable ADTS demuxing by default in Media Source.dalecurtis@chromium.org2014-05-281-2/+0
| | | | | | | | | | | | We now support ADTS demuxing in via src attribute, so lets enable it for Media Source as well. BUG=371633 TEST=existing tests Review URL: https://codereview.chromium.org/294403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273177 0039d316-1c4b-4281-b951-d872f2087c98
* Add 4k HW decode override flag and support larger bitstream buffers in V4L2VDA.posciak@chromium.org2014-05-201-0/+3
| | | | | | | | | | | | | | | | | | | Add a flag to override 4k hardware video decode capability detection in GVD if needed. This is for platforms that currently do not give us a proper way to detect it. Also bump input bistream size in V4L2VDA to accommodate potentially larger streams in higher resolutions. We cannot estimate input buffer size based on the stream, as we do not currently pass video config info down to the VDAs, and the bitstream buffers are needed in order to parse the stream to get that information. BUG=373717 TEST=4k video playback Review URL: https://codereview.chromium.org/285343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271653 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Mac Video Capture Device: split VCD into VCD and Factory.mcasas@chromium.org2014-05-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reland of the mentioned CL, that hit an internal bot due to a test needing the flag |kUseFakeDeviceForMediaStream|. Original CL message ----------------------------------------------- Mac Video Capture Device: split VCD into VCD and Factory. VideoCaptureDeviceMac includes factory and non-factory parts. This CL splits them into VideoCaptureDeviceMac and VideoCaptureDeviceFactoryMac. The latter inherits the previous class' static methods: Create(), GetDeviceNames() and GetDeviceSupportedFormats(). All video factory code previously in MediaStreamManager is moved into VideoCaptureFactory. This includes the use of the flag |kUseFakeDeviceForMediaStream|. This flag is moved correspondingly into media_switches.cc -- (but note that this flag is still used in MediaStreamManager for the Fake Audio parts). File media_switches.cc is included in several test files where the flag is used. VideoCaptureDeviceTest is splitted as well into: a) Tests that were exercising only the FakeVCD (FakeVideoCaptureDeviceTest). b) All other tests, that use the underlying OS webcam. This VideoCaptureDeviceTest gets a Factory and uses it instead of static methods. A unit test is added to VCDFMac, doing little for the moment but I'm planning to add support for testing at least the blacklisting -- req from rsesek@ in another CL. ------------------------------------------------------------------- TBR= perkj@chromium.org, dalecurtis@chromium.org, jochen@chromium.org BUG=288562, 323913, 255552 Review URL: https://codereview.chromium.org/278333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270391 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Mac Video Capture Device: split VCD into VCD and Factory. ↵mcasas@chromium.org2014-05-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/265263004/) Reason for revert: Some backoffice bots broke due to |kUseFakeDeviceForMediaStream| not being correctly defined - reverting until M36 storm passes and then I'll figure those out. Original issue's description: > Mac Video Capture Device: split VCD into VCD and Factory. > > VideoCaptureDeviceMac includes factory and non-factory parts. > This CL splits them into VideoCaptureDeviceMac and > VideoCaptureDeviceFactoryMac. The latter inherits the previous > class' static methods: Create(), GetDeviceNames() and > GetDeviceSupportedFormats(). > > All video factory code previously in MediaStreamManager is > moved into VideoCaptureFactory. This includes the use > of the flag |kUseFakeDeviceForMediaStream|. > This flag is moved correspondingly into media_switches.cc -- > (but note that this flag is still used in MediaStreamManager for > the Fake Audio parts). File media_switches.cc is > included in several test files where the flag is used. > > > VideoCaptureDeviceTest is splitted as well into: > a) Tests that were exercising only the FakeVCD > (FakeVideoCaptureDeviceTest). > b) All other tests, that use the underlying OS webcam. > This VideoCaptureDeviceTest gets a Factory and uses it > instead of static methods. > > A unit test is added to VCDFMac, doing little for the moment > but I'm planning to add support for testing at least the > blacklisting -- req from rsesek@ in another CL. > > BUG=288562, 323913, 255552 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269271 TBR=perkj@chromium.org,jochen@chromium.org,dalecurtis@chromium.org NOTREECHECKS=true NOTRY=true BUG=288562, 323913, 255552 Review URL: https://codereview.chromium.org/273063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269312 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Video Capture Device: split VCD into VCD and Factory.mcasas@chromium.org2014-05-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | VideoCaptureDeviceMac includes factory and non-factory parts. This CL splits them into VideoCaptureDeviceMac and VideoCaptureDeviceFactoryMac. The latter inherits the previous class' static methods: Create(), GetDeviceNames() and GetDeviceSupportedFormats(). All video factory code previously in MediaStreamManager is moved into VideoCaptureFactory. This includes the use of the flag |kUseFakeDeviceForMediaStream|. This flag is moved correspondingly into media_switches.cc -- (but note that this flag is still used in MediaStreamManager for the Fake Audio parts). File media_switches.cc is included in several test files where the flag is used. VideoCaptureDeviceTest is splitted as well into: a) Tests that were exercising only the FakeVCD (FakeVideoCaptureDeviceTest). b) All other tests, that use the underlying OS webcam. This VideoCaptureDeviceTest gets a Factory and uses it instead of static methods. A unit test is added to VCDFMac, doing little for the moment but I'm planning to add support for testing at least the blacklisting -- req from rsesek@ in another CL. BUG=288562, 323913, 255552 Review URL: https://codereview.chromium.org/265263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269271 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add flag to force QTKit in otherwise AVFoundation-enabled builds/configs.mcasas@chromium.org2014-05-031-0/+1
| | | | | | | | | | | | | | | | | | History: AVFoundation and QTKit are the two options for audio/video monitoring and video capture in Mac. AVFoundation is currently enabled in Mac OS X >= 10.7, and only via command line flag, which is currently enabled in developer and Canary builds. This CL adds a --force-qtkit flag that suppresses AVFoundation usage for those versions and channels that otherwise would use it. Please note the naming: --force-qtkit vs. --enable-avfoundation BUG=288562, 369024, 357250 Review URL: https://codereview.chromium.org/260873011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268065 0039d316-1c4b-4281-b951-d872f2087c98
* Deleted '--disable-system-sounds-manager' switch.ygorshenin@chromium.org2014-03-271-2/+0
| | | | | | | | | BUG=349033 TEST=none Review URL: https://codereview.chromium.org/212743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259901 0039d316-1c4b-4281-b951-d872f2087c98
* Enable MP3 stream parsing for Media Source by default.dalecurtis@chromium.org2014-03-211-1/+0
| | | | | | | | | BUG=341534 TEST=unittests. manual testing. clusterfuzz. Review URL: https://codereview.chromium.org/206793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258652 0039d316-1c4b-4281-b951-d872f2087c98
* Mac AVFoundation: disabled by default;mcasas@chromium.org2014-03-121-1/+1
| | | | | | | | | | | | | | | | This CL changes AVFoundation to be disabled by default and flips the flag (and associated chrome://flags) to "enable-avfoundation". This should address the performance regressions in the bugs. This also affects the webrtc apprtc browser test(s), where AVFoundation was disabled for ManyCam fake webcam to work properly. Same applies to webrtc browser tests and webrtc quality browser tests. BUG=288562, 348020, 349616, 342790, 327618 Review URL: https://codereview.chromium.org/189623011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256624 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated media switches.dalecurtis@chromium.org2014-03-071-5/+0
| | | | | | | | | | | | These switches are no longer necessary, having shipped for multiple stable version of Chrome now. BUG=343976 TEST=compile. Review URL: https://codereview.chromium.org/189123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255589 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ADTSStreamParser. Factorize MP3StreamParser and tests.dalecurtis@chromium.org2014-02-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Factorizes MP3StreamParser into MPEGAudioStreamParserBase for reuse with a new ADTSStreamParser. In the process, also factorizes the MP3StreamParserTest into a new test helper StreamParserTest for reuse with the ADTSStreamParserTest. Introduces an adts_constants.{cc,h} to remove duplicate constants across the AAC and ES ADTS parsers. Fixes a channel layout bug in the AAC parser. sfx.adts test file will be landed manually in a separate change. BUG=341648,340426 TEST=new unittests pass! NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250730 Review URL: https://codereview.chromium.org/120503006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250809 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 250730 "Introduce ADTSStreamParser. Factorize MP3StreamPa..."stevet@chromium.org2014-02-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Causing compile failure on mac: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/16420/steps/compile/logs/stdio > Introduce ADTSStreamParser. Factorize MP3StreamParser and tests. > > Factorizes MP3StreamParser into MPEGAudioStreamParserBase for reuse > with a new ADTSStreamParser. In the process, also factorizes the > MP3StreamParserTest into a new test helper StreamParserTest for > reuse with the ADTSStreamParserTest. > > Introduces an adts_constants.{cc,h} to remove duplicate constants > across the AAC and ES ADTS parsers. Fixes a channel layout bug in > the AAC parser. > > sfx.adts test file will be landed manually in a separate change. > > BUG=341648,340426 > TEST=new unittests pass! > > Review URL: https://codereview.chromium.org/120503006 TBR=dalecurtis@chromium.org Review URL: https://codereview.chromium.org/160593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250736 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ADTSStreamParser. Factorize MP3StreamParser and tests.dalecurtis@chromium.org2014-02-121-0/+1
| | | | | | | | | | | | | | | | | | | | Factorizes MP3StreamParser into MPEGAudioStreamParserBase for reuse with a new ADTSStreamParser. In the process, also factorizes the MP3StreamParserTest into a new test helper StreamParserTest for reuse with the ADTSStreamParserTest. Introduces an adts_constants.{cc,h} to remove duplicate constants across the AAC and ES ADTS parsers. Fixes a channel layout bug in the AAC parser. sfx.adts test file will be landed manually in a separate change. BUG=341648,340426 TEST=new unittests pass! Review URL: https://codereview.chromium.org/120503006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250730 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Mac AVFoundation experiment and enable AVFoundation by default.mcasas@chromium.org2014-02-121-1/+1
| | | | | | | | | | | | | | | This CL removes the code introduced to support a Chrome Finch experiment, in the CL [1]. It also enables AVFoundation by default, flipping the media switch --enable-avfoundation with --disable-avfoundation. [1] https://codereview.chromium.org/128373002/ BUG=158170,309554 Review URL: https://codereview.chromium.org/144473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250707 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetDeviceSupportedFormats to VideoCaptureDeviceMFWinmcasas@chromium.org2014-01-311-0/+1
| | | | | | | | | | | | | | | Added GetDeviceSupportedFormats() to VideoCaptureWin that simply multiplexes the MF/DS implementation. DS remains NOTIMPLEMENTED(), MF version is written. Added a --force-mediafoundation flag to force use of MF in Win 7 and Win 8 non-metro. BUG=309554 Review URL: https://codereview.chromium.org/149443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248178 0039d316-1c4b-4281-b951-d872f2087c98
* Remove EAC3 supports.ycheo@chromium.org2014-01-181-2/+0
| | | | | | | | | | | This reverts https://codereview.chromium.org/14641006/. BUG=334126 TEST=media_unittests Review URL: https://codereview.chromium.org/138743006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245774 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Chrome for TV code.ycheo@chromium.org2014-01-171-4/+0
| | | | | | | | BUG=334126 Review URL: https://codereview.chromium.org/136343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245449 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AVFoundation by defaultvrk@chromium.org2013-12-171-1/+1
| | | | | | | | | | | | | | This is essentially a revert of r239758, where AVFoundation was enabled by default on Macs. AVFoundation is causing browser crashes on every call to getUserMedia on certain Macs, hence we are changing the switch from a Disable switch to an Enable switch. BUG=288562,327532,329001 NOTRY=true Review URL: https://codereview.chromium.org/116673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241238 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 240962 "Revert 239758 "Enable Audio/Video dev monitoring ..."szym@chromium.org2013-12-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Does not compile on mac. > Revert 239758 "Enable Audio/Video dev monitoring and Video captu..." > > > Enable Audio/Video dev monitoring and Video capture via AVFoundation by default. > > > > Flipping the command line flag from explicitly enabling AVFoundation to > > disable AVFoundation. > > > > In the past there was a startup performance regression (http://crbug.com/311325 > > and http://crbug.com/311437), those type of regression should be monitored > > carefully during the next couple of days. > > > > BUG=288562 > > > > Review URL: https://codereview.chromium.org/101753003 > > TBR=mcasas@chromium.org > > Review URL: https://codereview.chromium.org/116553003 TBR=vrk@chromium.org Review URL: https://codereview.chromium.org/116613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240969 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239758 "Enable Audio/Video dev monitoring and Video captu..."vrk@chromium.org2013-12-161-1/+1
| | | | | | | | | | | | | | | | | | | | | > Enable Audio/Video dev monitoring and Video capture via AVFoundation by default. > > Flipping the command line flag from explicitly enabling AVFoundation to > disable AVFoundation. > > In the past there was a startup performance regression (http://crbug.com/311325 > and http://crbug.com/311437), those type of regression should be monitored > carefully during the next couple of days. > > BUG=288562 > > Review URL: https://codereview.chromium.org/101753003 TBR=mcasas@chromium.org Review URL: https://codereview.chromium.org/116553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240962 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239920 "Revert 239758 "Enable Audio/Video dev monitoring ..."vadimt@chromium.org2013-12-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting the revert. Congrats, the original CL wasn't the cause for the failure; sorry for the mess. > Revert 239758 "Enable Audio/Video dev monitoring and Video captu..." > > > Enable Audio/Video dev monitoring and Video capture via AVFoundation by default. > > > > Flipping the command line flag from explicitly enabling AVFoundation to > > disable AVFoundation. > > > > In the past there was a startup performance regression (http://crbug.com/311325 > > and http://crbug.com/311437), those type of regression should be monitored > > carefully during the next couple of days. > > > > BUG=288562 > > > > Review URL: https://codereview.chromium.org/101753003 > > TBR=mcasas@chromium.org > > Review URL: https://codereview.chromium.org/112033003 TBR=vadimt@chromium.org Review URL: https://codereview.chromium.org/98333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239939 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239758 "Enable Audio/Video dev monitoring and Video captu..."vadimt@chromium.org2013-12-101-1/+1
| | | | | | | | | | | | | | | | | | | | | > Enable Audio/Video dev monitoring and Video capture via AVFoundation by default. > > Flipping the command line flag from explicitly enabling AVFoundation to > disable AVFoundation. > > In the past there was a startup performance regression (http://crbug.com/311325 > and http://crbug.com/311437), those type of regression should be monitored > carefully during the next couple of days. > > BUG=288562 > > Review URL: https://codereview.chromium.org/101753003 TBR=mcasas@chromium.org Review URL: https://codereview.chromium.org/112033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239920 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Audio/Video dev monitoring and Video capture via AVFoundation by default.mcasas@chromium.org2013-12-101-1/+1
| | | | | | | | | | | | | | | Flipping the command line flag from explicitly enabling AVFoundation to disable AVFoundation. In the past there was a startup performance regression (http://crbug.com/311325 and http://crbug.com/311437), those type of regression should be monitored carefully during the next couple of days. BUG=288562 Review URL: https://codereview.chromium.org/101753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239758 0039d316-1c4b-4281-b951-d872f2087c98
* Debug video capture device to play back y4m movies.mcasas@chromium.org2013-12-051-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For video quality and performance testing. Based on a new command line flag: --use-file-for-fake-video-capture=blabla.y4m (Where blabla.y4m is the full path to the file to play) This flag _must_ be used in combination with the existing: --use-fake-device-for-media-stream The file format can be found described in the code and also here: http://wiki.multimedia.cx/index.php?title=YUV4MPEG2 And many examples here: http://media.xiph.org/video/derf/ (Only 420 would work -- 422 is _not_ supported). With these command line flag, navigating to a web site, f.e. http://goo.gl/qdwf6, and allowing using the camera, will playback the video in a loop, as opposed to a fake camera or a real camera stream. BUG=318797 Review URL: https://codereview.chromium.org/61833011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238973 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235405 "Revert 235337 "media: Enabling Opus playback by d..."zmo@chromium.org2013-11-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Will change the test expectations instead: crrev.com/71653011 > Revert 235337 "media: Enabling Opus playback by default." > > Very likely breaks media/media-can-play-ogg.html and media/media-can-play-webm.html in webkit layout tests. Reverting to confirm. > > > media: Enabling Opus playback by default. > > > > Flipping the flag for Opus playback from disabled by default > > to enabled by default. Changing the name of the flag to > > "disable-opus-playback". > > > > TEST=media_unittests > > BUG=315606 > > TBR=cpu > > > > Review URL: https://codereview.chromium.org/62183002 > > TBR=vigneshv@chromium.org > > Review URL: https://codereview.chromium.org/74303002 TBR=zmo@chromium.org Review URL: https://codereview.chromium.org/63643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235430 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235337 "media: Enabling Opus playback by default."zmo@chromium.org2013-11-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | Very likely breaks media/media-can-play-ogg.html and media/media-can-play-webm.html in webkit layout tests. Reverting to confirm. > media: Enabling Opus playback by default. > > Flipping the flag for Opus playback from disabled by default > to enabled by default. Changing the name of the flag to > "disable-opus-playback". > > TEST=media_unittests > BUG=315606 > TBR=cpu > > Review URL: https://codereview.chromium.org/62183002 TBR=vigneshv@chromium.org Review URL: https://codereview.chromium.org/74303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235405 0039d316-1c4b-4281-b951-d872f2087c98
* media: Enabling Opus playback by default.vigneshv@chromium.org2013-11-151-1/+1
| | | | | | | | | | | | | | Flipping the flag for Opus playback from disabled by default to enabled by default. Changing the name of the flag to "disable-opus-playback". TEST=media_unittests BUG=315606 TBR=cpu Review URL: https://codereview.chromium.org/62183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235337 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 00:54:41 +0000