| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/14952002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In r174057, enne@ added support for implicit testing to scoped_ptr<>. Removes
these in media/.
BUG=232084
Review URL: https://chromiumcodereview.appspot.com/13870018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
adding bear-vp8a.webm to media test files
BUG=147355
TBR=scherkus
Review URL: https://codereview.chromium.org/14036010
Patch from Vignesh Venkatasubramanian <vigneshv@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert 190807 "Fix a Chrome renderer hang which occurs when a We..."
>
> > Fix a Chrome renderer hang which occurs when a WebMediaPlayerImpl instance is shutting down and hangs due to
> > a deadlock between the media pipeline thread and the Renderer main thread.
> >
> > The media pipeline thread waits on a task(RendererGpuVideoDecoderFactories::AsyncCreateSharedMemory) to be
> > executed on the main thread while the main thread waits on the media pipeline thread to exit.
> >
> > The proposed fix is to introduce the following functions on the media::GpuVideoDecoder::Factories interface.
> > 1. Abort:- Called during shutdown.
> > 2. IsAborted:- Called to check if shutdown is in progress.
> >
> > The Abort function is called when the WebMediaPlayerImpl is shutting down. The video decoder factory sets an
> > event in this context. All tasks which complete asynchronously check for this event along with the event
> > which indicates that the async task completed. This ensures that they don't indefinitely wait during shutdown.
> > The asynchronous tasks in the RendererGpuVideoDecoderFactories now use a common event to signal completion
> > and return their results in member variables. This prevents a race between RendererGpuVideoDecoderFactories::Abort
> > being called and these tasks attempting to copy data to the callers stack which may have unwound at this point.
> >
> > While debugging this problem, I also found that there are scenarios where the GVD::Reset never completes
> > thus hanging the renderer. This problem occurs when the GVD is in the kDrainingDecoder state, i.e. waiting
> > for a Flush to complete. The VRB is waiting for the GVD::Reset operation to complete. The VDA is waiting for
> > output picture buffers which the VRB is holding on to. Proposed fix for that was to flush out the ready frames
> > in the VRB::Flush call which unblocks the VDA.
> >
> > I changed the ReadPixelsCB to take in a const SkBitmap& instead of void* to address the refcount issues with the
> > SkBitmap.
> >
> > While running my test case with tip two DCHECK's in VideoFrameStream::OnDecoderStopped fired. The first one
> > is the case where the decoder is stopped while there is a pending read callback. The second one is for the same
> > scenario with a pending reset. These fire when the media pipeline is destroyed on the main renderer thread while
> > these operations are pending. I added code in the GpuVideoDecoder::Stop function to fire these callbacks which
> > seems like the right thing to do.
> >
> > The other change in the GpuVideoDecoder::NotifyResetDone function was to remove the check for a NULL vda as there
> > are scenarios where in the decoder could be destroyed before this callback runs. We need to fire the read and
> > reset callbacks anyway.
> >
> > BUG=179551
> > TEST=The rapid_video_change_test.html file added to media\test\data, when loaded in chrome should hang without
> > this patch. Needs some more work to get something similar running in the Chrome OS autotest suite.
> > Review URL: https://codereview.chromium.org/12634011
>
> TBR=ananta@chromium.org
> Review URL: https://codereview.chromium.org/12942011
TBR=ygorshenin@chromium.org
Review URL: https://codereview.chromium.org/13044009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Fix a Chrome renderer hang which occurs when a WebMediaPlayerImpl instance is shutting down and hangs due to
> a deadlock between the media pipeline thread and the Renderer main thread.
>
> The media pipeline thread waits on a task(RendererGpuVideoDecoderFactories::AsyncCreateSharedMemory) to be
> executed on the main thread while the main thread waits on the media pipeline thread to exit.
>
> The proposed fix is to introduce the following functions on the media::GpuVideoDecoder::Factories interface.
> 1. Abort:- Called during shutdown.
> 2. IsAborted:- Called to check if shutdown is in progress.
>
> The Abort function is called when the WebMediaPlayerImpl is shutting down. The video decoder factory sets an
> event in this context. All tasks which complete asynchronously check for this event along with the event
> which indicates that the async task completed. This ensures that they don't indefinitely wait during shutdown.
> The asynchronous tasks in the RendererGpuVideoDecoderFactories now use a common event to signal completion
> and return their results in member variables. This prevents a race between RendererGpuVideoDecoderFactories::Abort
> being called and these tasks attempting to copy data to the callers stack which may have unwound at this point.
>
> While debugging this problem, I also found that there are scenarios where the GVD::Reset never completes
> thus hanging the renderer. This problem occurs when the GVD is in the kDrainingDecoder state, i.e. waiting
> for a Flush to complete. The VRB is waiting for the GVD::Reset operation to complete. The VDA is waiting for
> output picture buffers which the VRB is holding on to. Proposed fix for that was to flush out the ready frames
> in the VRB::Flush call which unblocks the VDA.
>
> I changed the ReadPixelsCB to take in a const SkBitmap& instead of void* to address the refcount issues with the
> SkBitmap.
>
> While running my test case with tip two DCHECK's in VideoFrameStream::OnDecoderStopped fired. The first one
> is the case where the decoder is stopped while there is a pending read callback. The second one is for the same
> scenario with a pending reset. These fire when the media pipeline is destroyed on the main renderer thread while
> these operations are pending. I added code in the GpuVideoDecoder::Stop function to fire these callbacks which
> seems like the right thing to do.
>
> The other change in the GpuVideoDecoder::NotifyResetDone function was to remove the check for a NULL vda as there
> are scenarios where in the decoder could be destroyed before this callback runs. We need to fire the read and
> reset callbacks anyway.
>
> BUG=179551
> TEST=The rapid_video_change_test.html file added to media\test\data, when loaded in chrome should hang without
> this patch. Needs some more work to get something similar running in the Chrome OS autotest suite.
> Review URL: https://codereview.chromium.org/12634011
TBR=ananta@chromium.org
Review URL: https://codereview.chromium.org/12942011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is shutting down and hangs due to
a deadlock between the media pipeline thread and the Renderer main thread.
The media pipeline thread waits on a task(RendererGpuVideoDecoderFactories::AsyncCreateSharedMemory) to be
executed on the main thread while the main thread waits on the media pipeline thread to exit.
The proposed fix is to introduce the following functions on the media::GpuVideoDecoder::Factories interface.
1. Abort:- Called during shutdown.
2. IsAborted:- Called to check if shutdown is in progress.
The Abort function is called when the WebMediaPlayerImpl is shutting down. The video decoder factory sets an
event in this context. All tasks which complete asynchronously check for this event along with the event
which indicates that the async task completed. This ensures that they don't indefinitely wait during shutdown.
The asynchronous tasks in the RendererGpuVideoDecoderFactories now use a common event to signal completion
and return their results in member variables. This prevents a race between RendererGpuVideoDecoderFactories::Abort
being called and these tasks attempting to copy data to the callers stack which may have unwound at this point.
While debugging this problem, I also found that there are scenarios where the GVD::Reset never completes
thus hanging the renderer. This problem occurs when the GVD is in the kDrainingDecoder state, i.e. waiting
for a Flush to complete. The VRB is waiting for the GVD::Reset operation to complete. The VDA is waiting for
output picture buffers which the VRB is holding on to. Proposed fix for that was to flush out the ready frames
in the VRB::Flush call which unblocks the VDA.
I changed the ReadPixelsCB to take in a const SkBitmap& instead of void* to address the refcount issues with the
SkBitmap.
While running my test case with tip two DCHECK's in VideoFrameStream::OnDecoderStopped fired. The first one
is the case where the decoder is stopped while there is a pending read callback. The second one is for the same
scenario with a pending reset. These fire when the media pipeline is destroyed on the main renderer thread while
these operations are pending. I added code in the GpuVideoDecoder::Stop function to fire these callbacks which
seems like the right thing to do.
The other change in the GpuVideoDecoder::NotifyResetDone function was to remove the check for a NULL vda as there
are scenarios where in the decoder could be destroyed before this callback runs. We need to fire the read and
reset callbacks anyway.
BUG=179551
TEST=The rapid_video_change_test.html file added to media\test\data, when loaded in chrome should hang without
this patch. Needs some more work to get something similar running in the Chrome OS autotest suite.
Review URL: https://codereview.chromium.org/12634011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=175002
TEST=base_unittests
R=brettw@chromium.org
TBR=erikwright@chromium.org,tommi@chromium.org,fischman@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12321062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12217101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12084048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Calling DecoderBuffer::CopyFrom(NULL, 0) is a crashable offense as it's strong evidence that there's a bug in a demuxer generating NULL-containing packets.
BUG=169133
Review URL: https://codereview.chromium.org/11887011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=168891
TBR=scherkus@chromium.org
Review URL: https://codereview.chromium.org/11971019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11830060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=168852,168930
Review URL: https://codereview.chromium.org/11818050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=167811
Review URL: https://codereview.chromium.org/11787009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It's only used in AC3 and ALS decoders, neither of which we use.
Review URL: https://chromiumcodereview.appspot.com/11573010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes various media tools which were using the old
av_register_protocol2() path instead of the new FFmpegGlue
hotness.
Includes:
3d123ab Zero initialize ff_lockmgr_cb.
b694550 Remove custom av_register_protocol2() patch.
c317c1c Use build.ninja to see the user uses GOMA or not.
BUG=146529,118986,159139
TEST=builds.
Review URL: https://codereview.chromium.org/11365050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=155639
TEST=All media_unittests pass.
TBR=xhwang
Review URL: https://codereview.chromium.org/11142003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=150012
TEST=All media_unittests pass.
Review URL: https://codereview.chromium.org/10907271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests that rely on it.
FFmpeg generated the existing file with negative timestamps at the beginning which violates the WebM spec. 26ms had to be added to all the timestamps in the file to make it valid. This slightly shifted the file layout and cluster boundaries so ChunkDemuxer tests needed to be updated.
BUG=122913
Review URL: https://chromiumcodereview.appspot.com/10861030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=122913
TBR=acolwell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
What's new?
========
Output stream is always opened up using the native number of channels and channel configuration.
The user can set a lower number of channels during construction and for this case up-mixing (typically 2 -> 7.1) takes place since the audio source does not deliver sufficient number of channels for this case.
It is still possible to avoid up-mixing simply by creating up the stream using the native channel count (which can be queried before construction).
TODO
====
- Clean up ChannelUpMix().
- Add support for 8-bit and 24-bit audio?
- Add support for 2 -> 1 down-mixing?
- More mixing combinations?
- Add accessors for ChannelCount/Layout.
- Improve usage of channel_factor to detect mixing mode.
BUG=138762
TEST=media_unittests --gtest_filter=WASAPIAudioOutput*
Review URL: https://chromiumcodereview.appspot.com/10823100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136438
TBR=acolwell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=xhwang@chromium.org
BUG=140378
TEST=All media_uinttests pass.
Review URL: https://chromiumcodereview.appspot.com/10828137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=acolwell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122913
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10696182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122913
TEST=None
TBR=acolwell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The files are updated to work with decryptor changes from
crbug.com/119845.
BUG=132801
TEST=media_unittests
Review URL: https://chromiumcodereview.appspot.com/10806046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=132801
TEST=media_unittest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147868
Review URL: https://chromiumcodereview.appspot.com/10800057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=acolwell@chromium.org
BUG=129072
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10539117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows us to remove another patch from FFmpeg relating to using
deprecated features! We're now using the latest and greatest!
FFmpeg side changes here,
https://gerrit.chromium.org/gerrit/24823
BUG=112673
TEST=ffmpeg_regression_tests, webaudio tests.
Review URL: https://chromiumcodereview.appspot.com/10540067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=acolwell@chromium.org
BUG=122913
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10536072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=acolwell@chromium.org
BUG=131265
Review URL: https://chromiumcodereview.appspot.com/10532036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ID3 tag reading is pretty well entrenched in FFmpeg, so we can't
just disable ID3 entirely or we'll fail to identify and parse files
which start with ID3 tags.
This change prevents FFmpeg from attempting to read ID3v1 tags from
the end of the file. As far as I can tell, FFmpeg only supports
ID3v2 tags at the start of the file, so we don't need to worry about
those.
Will require a DEPS roll to update Windows FFmpeg DLLs and add two
new signature entries for avformat_alloc_context() and av_dict_set().
BUG=94285
TEST=Played mp3 from bug, observed no more extraneous requests.
Review URL: http://codereview.chromium.org/10012049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53967
TEST=Ran all layout tests, ffmpeg_unittests, ffmpeg_regression_tests.
Review URL: http://codereview.chromium.org/9700051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus@chromium.org
BUG=117060
TEST=these are test files
Review URL: https://chromiumcodereview.appspot.com/9592036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=acolwell@chromium.org
BUG=116824
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9616018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt 2 at landing http://codereview.chromium.org/9317096/
Same as before except for fixes in checkperms/
However, fixes have landed elsewhere for:
- mp3 decode issue.
- FrameRateNoVsyncCanvasInternalTest.fishbowl/0
BUG=110776
TEST=unittests, layouttests, trybots, perf tests...
Review URL: https://chromiumcodereview.appspot.com/9447029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=this is a test data file
Review URL: https://chromiumcodereview.appspot.com/9456002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and possibly made frame rate tests fail: http://crbug.com/115477. Will revert
the revert if it doesn't help.) - Fix media code to work with new ffmpeg.
Once ffmpeg git, svn are updated to new ffmpeg, will update DEPS
in this CL. Which when committed, should seal the deal for the
ffmpeg roll.
API Changes:
avutil: SampleFormat->AVSampleFormat
avutil: av_get_bits_per_sample_fmt -> av_get_bytes_per_sample
avcodec: avcodec_open -> avcodec_open2(..., NULL)
avcodec: avcodec_decode_video2(... AVPacket ...) -> const AVPacket.
avformat: av_open_input_file -> avformat_open_input
avformat: av_register_protocol2 -> ffurl_register_protocol
avformat: av_close_input_file -> avformat_close_input(&...)
avformat: av_find_stream_info -> avformat_find_stream_info(..., NULL)
URLContext now has a url_open2 method as well, for now I've set this
to NULL.
Also fixes:
- ffmpeg_unittests change threading to mirror ffmpeg_video_decoder. There's
an issue where threading causes the last frames of a no-audio video to be
clipped. It existed before this ffmpeg roll, but because threading was
disabled by default in ffmpeg, we never noticed it.
- ffmpeg_demuxer_tests: GetBitrate_UnsetInContainer_NoFileSize now passes.
- New ffmpeg_unittests passes:
sync0_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync0.ogv"
sync1_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync1.ogv"
sync2_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync2.ogv"
FFmpeg fixups here, https://chromiumcodereview.appspot.com/9325049/
New git repo here: http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=summary
Merge+Patches diff: https://chromiumcodereview.appspot.com/9317107
BUG=110776
TEST=unittests, layouttests, etc. Trybots.
Review URL: https://chromiumcodereview.appspot.com/9317096
TBR=dalecurtis@google.com
Review URL: https://chromiumcodereview.appspot.com/9455018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once ffmpeg git, svn are updated to new ffmpeg, will update DEPS
in this CL. Which when committed, should seal the deal for the
ffmpeg roll.
API Changes:
avutil: SampleFormat->AVSampleFormat
avutil: av_get_bits_per_sample_fmt -> av_get_bytes_per_sample
avcodec: avcodec_open -> avcodec_open2(..., NULL)
avcodec: avcodec_decode_video2(... AVPacket ...) -> const AVPacket.
avformat: av_open_input_file -> avformat_open_input
avformat: av_register_protocol2 -> ffurl_register_protocol
avformat: av_close_input_file -> avformat_close_input(&...)
avformat: av_find_stream_info -> avformat_find_stream_info(..., NULL)
URLContext now has a url_open2 method as well, for now I've set this
to NULL.
Also fixes:
- ffmpeg_unittests change threading to mirror ffmpeg_video_decoder. There's
an issue where threading causes the last frames of a no-audio video to be
clipped. It existed before this ffmpeg roll, but because threading was
disabled by default in ffmpeg, we never noticed it.
- ffmpeg_demuxer_tests: GetBitrate_UnsetInContainer_NoFileSize now passes.
- New ffmpeg_unittests passes:
sync0_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync0.ogv"
sync1_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync1.ogv"
sync2_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync2.ogv"
FFmpeg fixups here, https://chromiumcodereview.appspot.com/9325049/
New git repo here: http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=summary
Merge+Patches diff: https://chromiumcodereview.appspot.com/9317107
BUG=110776
TEST=unittests, layouttests, etc. Trybots.
Review URL: https://chromiumcodereview.appspot.com/9317096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123123 0039d316-1c4b-4281-b951-d872f2087c98
|