summaryrefslogtreecommitdiffstats
path: root/media
Commit message (Collapse)AuthorAgeFilesLines
* Remove statistics reporting from chrome://media-internals and fix event logging.scherkus@chromium.org2012-05-104-67/+6
| | | | | | | | | | | | | Our internals page is for reporting things that are, like, internal. The statistics I'm removing are available from audio/video elements themselves, removing the need for including them on the internals page. They are also really spammy. During the removal I also fixed a bug where we weren't reporting the associated parameters with each event (i.e., the name of the state for a PIPELINE_STATE_CHANGED event). BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10332082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136357 0039d316-1c4b-4281-b951-d872f2087c98
* Android content shell bringup.jrg@chromium.org2012-05-102-7/+23
| | | | | | | | | | | | | | | | | | Build media java files (we weren't). Fix adb_install_content_shell for cases where the app was stuck. Add upstream staging gyp var / #define. Be more consistent about jar output files (all in lib.java). Upstream a bunch of random files (e.g. ppapi). Upstream a bunch of java and native code hit as part of shlib init. Properly package jar files in content shell. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10377059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136219 0039d316-1c4b-4281-b951-d872f2087c98
* Report correct buffered TimeRanges instead of faking a single TimeRange.fischman@chromium.org2012-05-106-47/+290
| | | | | | | | | | BUG=103513 TEST=unittests + manually test seeking & buffering bar behavior is unchanged Review URL: https://chromiumcodereview.appspot.com/10387031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136204 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dropped Play event when there's a pending pause.dalecurtis@chromium.org2012-05-092-2/+55
| | | | | | | | | | | | | | | | If the message queue is built in such a way that DoPlay()->DoPause()->DoPlay() ends up executing before the the first DoPlay()'s PollAndStartIfDataReady() runs, we'll end up dropping the play and keeping the pause. Fixed by ensuring we drop the pause if we receive a play before the pause is consumed by PollAndStartIfDataReady(). BUG=111272 TEST=unittests, test.html test case in bug. Manual seeking in buffered areas. Review URL: https://chromiumcodereview.appspot.com/10386037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136162 0039d316-1c4b-4281-b951-d872f2087c98
* Remove log spam from audio_manager_linux.ccdalecurtis@chromium.org2012-05-091-2/+0
| | | | | | | | | | | | | http://crrev.com/134403 seems to have introduced some accidental log spam. Intended? BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10383092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136153 0039d316-1c4b-4281-b951-d872f2087c98
* Add codecs parameter to sourceAddId() and improve supported codecs detection ↵acolwell@chromium.org2012-05-094-17/+74
| | | | | | | | | | | | in ChunkDemuxer. BUG=122909 TEST= Covered by http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html LayoutTest Review URL: https://chromiumcodereview.appspot.com/10388054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136152 0039d316-1c4b-4281-b951-d872f2087c98
* Kill Pipeline::SetBufferedTime(), since nobody needs/uses it.fischman@chromium.org2012-05-098-93/+1
| | | | | | | | | | BUG=103513 (this is just clearing the cruft out before implementing the enhancement) TEST=none: just removing dead code Review URL: https://chromiumcodereview.appspot.com/10384056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136071 0039d316-1c4b-4281-b951-d872f2087c98
* Replace CHECK by DCHECK, at least for M20.enal@chromium.org2012-05-091-1/+1
| | | | | | | | | | | | Hopefully we'll be able to find out what causes the problem looking at the crashes (if any). BUG=123322 TEST=Crash in media::AudioManagerBase::ShutdownOnAudioThread() should go away. Review URL: https://chromiumcodereview.appspot.com/10383066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136056 0039d316-1c4b-4281-b951-d872f2087c98
* Remove seek prior to WebAudio decode.dalecurtis@google.com2012-05-081-7/+3
| | | | | | | | | | | | | | | | | | Required to fix issues with plink and guitar WebAudio demos. Seek is unnecessary as the stream already starts at the beginning. Additionally seeking to 0 without specifying the right flags can actually move the index forward in the stream. Also allows partial return of data on decode failure to work around a potential issue in FFmpeg w/ mp3s now that the seek has been removed. BUG=none TEST=plink,guitar,crogers Review URL: https://chromiumcodereview.appspot.com/10382043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135786 0039d316-1c4b-4281-b951-d872f2087c98
* [Layout Test Analzyer] show changed test names all the time (even when theimasaki@google.com2012-05-071-3/+6
| | | | | | | | | | | total number of tests does not change from previous ). BUG=126301 TEST=make sure layout test analzyer still runs as before. Review URL: https://chromiumcodereview.appspot.com/10383018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135664 0039d316-1c4b-4281-b951-d872f2087c98
* Roll FFmpeg for M20 (round 2)dalecurtis@google.com2012-05-062-28/+19
| | | | | | | | | | | | | | | | | | | | | | | | Includes the following fixes: 45a7b06 oggvorbis: fix the first 2 packets timestamps matching issue 16db88a vorbis_parser: fix blocksize 441dce2 oggvorbis: move handling of first packets ts from parser to muxer. b18c9f1 oggtheora: Port changes from oggvorbis timestamp handling. fe5c5bc oggvorbisdec: Apply timestamp calculation always when timestamps arent known. 1f95ad4 oggvorbisdec: redesign special handling of first frames timestamp. 63eb01d oggvorbis: Try to fix pts off by 1 issue. 231d32c oggtheora: Fix initial pts ef32fba oggdec: fix off by one error on pos_limit 96fb233 oggdec: reset lastpts so that justins vorbis duration correction is not skiped 5f9f78d oggdec: pass avformat context to ogg_reset() 8b97ae6 avf: fix faulty check in has_duration BUG=124915,126063,124779 TEST=manual matrix pass, asan+valgrind over unittests, trybots. TBR=scherkus Review URL: https://chromiumcodereview.appspot.com/10377028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135596 0039d316-1c4b-4281-b951-d872f2087c98
* Increase socket_timeout values for CNS requests. This timeout caused ↵shadi@chromium.org2012-05-051-5/+5
| | | | | | | | | | | | connections to drop suddenly. BUG=126026 TEST=manual test. Review URL: http://codereview.chromium.org/10353004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135529 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial implementation of SourceBufferStreamvrk@google.com2012-05-045-0/+915
| | | | | | | | | | | | This CL doesn't integrate SourceBufferStream into Chromium yet, but the functionality is tested in the unit test. BUG=125092 TEST=media_unittests Review URL: https://chromiumcodereview.appspot.com/10228017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135441 0039d316-1c4b-4281-b951-d872f2087c98
* Per issue 125757, added more test cases to be monitored in the layout test ↵imasaki@google.com2012-05-043-8/+9
| | | | | | | | | | | anazlyzer. Also, changed CSV format to use double quotations for seperators instead of commas. BUG=125757 TEST=make sure layout analzyer runs with new test cases Review URL: https://chromiumcodereview.appspot.com/10261034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135246 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition caused by r114084.enal@chromium.org2012-05-031-6/+6
| | | | | | | | | | It added base::unretained(this) when scheduling a task, as a result AudioOutputController can be deleted before task run, and it would use junk instead of AudioSource. BUG=124991 Review URL: http://codereview.chromium.org/10261027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few races due to lack of locking in AudioRendererImpl::FillBuffer().scherkus@chromium.org2012-05-032-16/+20
| | | | | | | | | | | | Also switched to using kNoTimestamp() to represent uninitialized timestamps. TBR=timurrrr BUG=109875,112418,122447 TEST=tsan is happy, also run http://mastodon.sea/demos/crbug122447 Review URL: https://chromiumcodereview.appspot.com/10355006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135213 0039d316-1c4b-4281-b951-d872f2087c98
* Fulfill pending GpuVideoDecoder::Read()s during GVD::Reset().fischman@chromium.org2012-05-031-6/+7
| | | | | | | | | This is per the clarified API defined in http://codereview.chromium.org/9724011/ Review URL: http://codereview.chromium.org/10350002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135212 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a few unused media::PipelineStatus codes.scherkus@chromium.org2012-05-033-21/+8
| | | | | | | | | BUG=126070 TEST=none Review URL: https://chromiumcodereview.appspot.com/10316015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135197 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for sourceAbort() & sourceBuffered()acolwell@chromium.org2012-05-032-1/+83
| | | | | | | | | | BUG=122903 TEST=Will be covered by LayoutTests when WebKit changes land. Review URL: http://codereview.chromium.org/10264020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135104 0039d316-1c4b-4281-b951-d872f2087c98
* Remove VideoDecoder from the Filter heirarchy.xhwang@chromium.org2012-05-0321-355/+262
| | | | | | | | | | | This is the second step to move VideoDecoder out of Filter hierarchy (See r128289). VideoDecoder is not a Filter any more and Seek()/Pause()/Play() methods are removed from its definition and all implementations. BUG=108340 TEST=media_unittest,content_unittest,normal html5 video playback Review URL: http://codereview.chromium.org/9724011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135051 0039d316-1c4b-4281-b951-d872f2087c98
* media::SeekableBuffer should use kNoTimestamp() instead of zero.scherkus@chromium.org2012-05-033-15/+26
| | | | | | | | | | | I noticed this while debugging bug 120396 that the reported time remained zero even after appending the initial audio buffer that has a timestamp of zero. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10342005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135050 0039d316-1c4b-4281-b951-d872f2087c98
* Add StreamParserBuffer to ChunkDemuxervrk@google.com2012-05-029-29/+93
| | | | | | | | | | | This will allow SourceBufferStreams to identify keyframes. BUG=125680 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/10269022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134978 0039d316-1c4b-4281-b951-d872f2087c98
* This patch introduces a simplified SourceBuffer that takes ownership of ↵annacc@chromium.org2012-05-025-12/+158
| | | | | | | | | | | | ChunkDemuxer's StreamParser and simply forwards the callbacks back to ChunkDemuxer. Existing functionality should be maintained. BUG=125770 TEST=chunk_demuxer_unittest.cc should still succeed. source_buffer_unittest.cc coming soon. Review URL: http://codereview.chromium.org/10261028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134975 0039d316-1c4b-4281-b951-d872f2087c98
* Only do host()->SetError when there's no PipelineStatus callback pending in ↵xhwang@chromium.org2012-05-022-15/+24
| | | | | | | | | | | | VideoRenderBase. BUG=125802 TEST=added a new test in media_unittests. Review URL: http://codereview.chromium.org/10288008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134940 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test -- we should initialize the buffer, otherwise valgrind/DrMemory reportsenal@chromium.org2012-05-011-6/+13
| | | | | | | | | | | read from uninitialized memory. Mixer reads data from there, even though test does not use mixed output. BUG=125723 Review URL: http://codereview.chromium.org/10268026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134749 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way audio mixer gets "pending bytes" (amount of data currently ↵enal@chromium.org2012-05-013-27/+56
| | | | | | | | | | | | | | | | | | | buffered but not yet played). Underlying code expects per-logical-stream pending bytes, while all mixer gets when called for more data is pending bytes per combined stream. Fix is to keep track of * amount of data in every buffer * buffers for every logical stream and manually calculate per-logical-stream pending bytes. That is last CL in initial audio mixer implementation, after it go through mixer should be ready for full testing. Review URL: http://codereview.chromium.org/10154007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134675 0039d316-1c4b-4281-b951-d872f2087c98
* Fix VideoFrameGenerator so Flush() callback always runs after a pending ↵acolwell@chromium.org2012-04-302-0/+5
| | | | | | | | | | | | Read() callback. BUG=125366 TEST=platform/chromium/media/video-capture-preview.html LayoutTest Review URL: http://codereview.chromium.org/10261012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134573 0039d316-1c4b-4281-b951-d872f2087c98
* Report VideoDecoder status through ReadCB instead of through FilterHost.xhwang@chromium.org2012-04-2810-75/+168
| | | | | | | | | BUG=108340 TEST=media_unittests Review URL: http://codereview.chromium.org/10248002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134435 0039d316-1c4b-4281-b951-d872f2087c98
* Merge VideoCaptureDevice::Capability with media::VideoCaptureCapabilityyujie.mao@intel.com2012-04-2815-81/+91
| | | | | | | | | | | | | | This is a second patch as the follow up of http://codereview.chromium.org/10108009/, just to facilitate code review 1. Move VideoCaptureDevice::Format to VideoCaptureCapability::Format. 2. Fix a code style issue in media_stream_device_settings.h. 3. Remove the TODO comments in media_stream_device_settings.h, since the media stream infobar is already implemented in linux and windows. BUG=123738 TEST=content_unittests, media_unittests Review URL: http://codereview.chromium.org/10035054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134415 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TODO: return name and id as NSArray* instead of QTCaptureDevice*.scherkus@chromium.org2012-04-284-11/+20
| | | | | | | | | | Patch by Jeremy Mao <yujie.mao@intel.com>: http://codereview.chromium.org/10198016/ BUG=NONE TEST=media_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134403 0039d316-1c4b-4281-b951-d872f2087c98
* Don't make checkdeps ignore includes to directories that are brought in via ↵jam@chromium.org2012-04-271-0/+1
| | | | | | | | deps. Most of these are already listed in DEPS files, and it seems that we want to prevent includes on them just like normal directories that are in our tree (otherwise content can depend on native_client, for ex) Review URL: https://chromiumcodereview.appspot.com/10248005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134296 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Roll DEPS for FFmpeg merge. Shuffle testing."scherkus@chromium.org2012-04-272-19/+11
| | | | | | | | | TBR=dalecurtis Review URL: http://codereview.chromium.org/10250005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134221 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a g++ 4.6 compiler issue in media/thestig@chromium.org2012-04-262-7/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/10140013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134166 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow UI/IO thread blocking on any other thread.jam@chromium.org2012-04-261-0/+3
| | | | | | | By design, there's no ScopedAllowWait that is reachable by all code. From experience with ScopedAllowIO, it will be abused. So instead the existing callers (which should all be fixed other than two) are friends with ThreadRestrictions. Review URL: https://chromiumcodereview.appspot.com/10151009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134114 0039d316-1c4b-4281-b951-d872f2087c98
* Fire needkey event when encrypted media is encounted.xhwang@chromium.org2012-04-268-8/+75
| | | | | | | | | | BUG=119843 TEST=Modified media_unittests passes. Also the revised demo page works. Review URL: http://codereview.chromium.org/10223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134068 0039d316-1c4b-4281-b951-d872f2087c98
* Media: Fix an assign-to-self.jhawkins@chromium.org2012-04-261-1/+0
| | | | | | | | | | | | | It had no effect anyway. BUG=none TEST=none R=groby Review URL: http://codereview.chromium.org/10226011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134036 0039d316-1c4b-4281-b951-d872f2087c98
* Replace StreamParserHost interface with callbacks.acolwell@chromium.org2012-04-266-58/+57
| | | | | | | | | | BUG=122909 TEST=Existing ChunkDemuxer tests cover this change. Review URL: http://codereview.chromium.org/10134066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134020 0039d316-1c4b-4281-b951-d872f2087c98
* Fix VideoRendererBase to allow the decoder to be flushed with a pending read.acolwell@chromium.org2012-04-254-18/+58
| | | | | | | | | | BUG=123134 TEST=media_unittests Review URL: http://codereview.chromium.org/10173012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133957 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the skeleton of an android content shell.tedchoc@chromium.org2012-04-253-0/+44
| | | | | | | | | | | | | Many TODOs here that will allow a quicker distribution of work to get the remaining pieces upstreamed. BUG=118591 TEST= Review URL: http://codereview.chromium.org/10035034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133857 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused parameter "stream" from all variants of OnMoreData().enal@chromium.org2012-04-2425-89/+79
| | | | | | | | (Also fixing some minor lint errors...) Review URL: http://codereview.chromium.org/10184011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133726 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring StreamParser & StreamParserHost interfaces.acolwell@chromium.org2012-04-245-92/+104
| | | | | | | | | | | | | | | | | - Moving ByteQueue from ChunkDemuxer into WebMStreamParser to simplify handling multiple StreamParsers. - Replacing OnAudioConfig & OnVideoConfig with a single OnNewConfigs method to make it easier to verify that initialization segments all contain the same number and type of streams. BUG=122909 TEST=Existing ChunkDemuxer tests. Review URL: http://codereview.chromium.org/10205004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133725 0039d316-1c4b-4281-b951-d872f2087c98
* Reset svn:executable bit on scripts that are not executable.maruel@chromium.org2012-04-241-0/+0
| | | | | | | | | | TBR=dalecurtis@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10205016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133696 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of bad line endings.thestig@chromium.org2012-04-241-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133626 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for FFmpeg merge. Shuffle testing.dalecurtis@google.com2012-04-242-11/+19
| | | | | | | | | | | | | | | | | | | | | | | Lands the FFmpeg roll for M20. Manual test pass completed by vendors and myself. ASAN/Valgrind testing on Linux/Mac platforms on ia32/x64. TSAN testing on Windows, no new traces are expected. ffmpeg_revision: http://src.chromium.org/viewvc/chrome?view=rev&revision=133551 ffmpeg_hash: http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=commit;h=f8d71c394e071249f26703669baf1093009620d7 List of remaining diff's from upstream: http://pastebin.com/t5jTbvm9 BUG=49709, 124684 TEST=Video Test Matrix. unittests + asan/valgrind. Review URL: https://chromiumcodereview.appspot.com/10196006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133592 0039d316-1c4b-4281-b951-d872f2087c98
* CNS seek tests for <video>.shadi@chromium.org2012-04-241-5/+15
| | | | | | | | | | | | | | | | We record seek performance using the product of: - Video formats: webm and ogv. - Network constraints: cable, wifi, and no constraints. - Seek cases: long, short, and buffered seeks. - Video location: cached and un-cached videos. BUG=122749 TEST=manual run Review URL: http://codereview.chromium.org/9960063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133585 0039d316-1c4b-4281-b951-d872f2087c98
* Implement sourceAddId() & sourceRemoveId()acolwell@chromium.org2012-04-234-15/+97
| | | | | | | | | | BUG=122897 TEST=Covered by LayoutTests Review URL: http://codereview.chromium.org/10164017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133568 0039d316-1c4b-4281-b951-d872f2087c98
* Set svn:executable bit only on scripts that are executable.maruel@chromium.org2012-04-2312-2/+0
| | | | | | | | | | | | | Removes the svn:executable bit on non-executable python files. R=scherkus@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10176003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133493 0039d316-1c4b-4281-b951-d872f2087c98
* Add a media pipeline status error code for decryption error.xhwang@chromium.org2012-04-234-20/+18
| | | | | | | | | | | | Also fix a bug in FFmpegVideoDecoderTest.DecodeEncryptedFrame_NoKey test that the frame isn't marked as decrypted. BUG=121177 TEST=media_unittests Review URL: http://codereview.chromium.org/10165010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133397 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 133335 - Update MediaSource API implementation to match v0.4 spec. acolwell@chromium.org2012-04-214-99/+14
| | | | | | | | | | | | | | | | | - Adding support for sourceAddId() & sourceRemoveId(). - Adding id parameter to sourceAppend() signature. BUG=122897 TEST=Covered by LayoutTests TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/10166015 TBR=acolwell@chromium.org Review URL: https://chromiumcodereview.appspot.com/10161017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133339 0039d316-1c4b-4281-b951-d872f2087c98
* Update MediaSource API implementation to match v0.4 spec. acolwell@chromium.org2012-04-214-14/+99
| | | | | | | | | | | | | | - Adding support for sourceAddId() & sourceRemoveId(). - Adding id parameter to sourceAppend() signature. BUG=122897 TEST=Covered by LayoutTests TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/10166015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133335 0039d316-1c4b-4281-b951-d872f2087c98