| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
implementation for Linux and Fake
BUG=289494
Review URL: https://codereview.chromium.org/24079003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PictureBuffers (and their backing textures) held in dismissed_picture_buffers_
should not be destroyed until the GpuVideoDecoder is itself destroyed, as
clients to the GpuVideoDecoder may still be using them.
BUG=None
TEST=local build, run on CrOS snow, build on desktop Linux
Review URL: https://codereview.chromium.org/26273007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=307582
Review URL: https://codereview.chromium.org/27171004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Switch to ScopedCoMem pointer for IAMVideoControl::GetFrameRateList()
- Cap frame rate list to 128 items.
- Zero initialize and NULL check values.
- Cleanup duplicate conditionals.
BUG=306237
TEST=capture still works.
Review URL: https://codereview.chromium.org/26603008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Plumb PPAPI PlatformVerification into CDM.h
>
> BUG=270296
> TEST=encrypted media browsertests.
>
> Review URL: https://codereview.chromium.org/23546014
BUG=306241,307662
R=dalecurtis@chromium.org
Review URL: https://codereview.chromium.org/27108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is based on report in crbug.com/267505.
BUG=267505
R=qinmin@chromium.org
Review URL: https://codereview.chromium.org/26356005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
After a seek, we keep decoding the data without rendering it until access unit's timestamp is larger than preroll timestamp.
BUG=261000
Review URL: https://codereview.chromium.org/25789004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since CdmWrapper::Initialize() doesn't report error, GenerateKeyRequest() et al
can be called even if Initialize() failed previously.
For MediaKeys calls, we should fire KeyError when they are called without valid
|cdm_|. For Decryptor calls, we should fire the callback with error code.
Also added EncryptedMediaTest.ExternalClearKeyInitializeCDMFail test to cover
this case. Chrome will claim that the ClearKey CDM supports key system
"org.chromium.externalclearkey.fail". But actually ClearKey CDM will return NULL
for this key system in CreateCdmInstance();
BUG=306241,179570
TEST=Unit tests added.
Review URL: https://codereview.chromium.org/27030007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And fixed associated errors
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228002
Review URL: https://codereview.chromium.org/26486005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MediaCodec is dangerous
internal bug 11173832
Review URL: https://codereview.chromium.org/27017005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks compile on the `All` target on win_x64_rel. Note that this is only
built by default on manually submitted tryjobs. Not CQ or waterfall.
(see bug). For the errors see, e.g.,
http://build.chromium.org/p/tryserver.chromium/builders/win_x64_rel/builds/45000/
BUG=304877
> Enable cast_unittests
> And fixed associated errors
>
> Review URL: https://codereview.chromium.org/26486005
TBR=pwestin@google.com
Review URL: https://codereview.chromium.org/27141002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce an event-driven timeline utility to verify if everything in
test scenarii is happening on the right thread and in the right order,
and add a simple precheck browser test that opens an HTML test page and
verifies that creating a SpeechRecognition object works.
BUG=301906
Review URL: https://codereview.chromium.org/23500011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We use to skip tests when MediaCodecBridge is not available.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/27029005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of one packet per callback. The implementer should
implement the new virtual function SendPackets that send
multiple packets as fast as possible. The purpose is to
minimize the number of IPC messages.
No changes to the actual pacing logic.
In the process also cleaned up the usage of std::set<uint16>
even though the define PacketIdSet existed.
Review URL: https://codereview.chromium.org/26618002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Exceptions could be thrown in start() and/or getOutputBuffers() when we open too many MediaCodec objects and exceed the capacity of a mobile device.
BUG=303419,304956
TEST=This prevents crash in tests that create multiple <video> tags. These tests will still fail due to device limitation.
Review URL: https://codereview.chromium.org/26880004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reorganizes frame counting logic to make it easier to see that it is correct
and reduces the number of calls on the statistics_cb_.
BUG=291731
TEST=All existing unit tests still pass.
Review URL: https://codereview.chromium.org/26592007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
And fixed associated errors
Review URL: https://codereview.chromium.org/26486005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Seek(), Stop(), and OnAudioRendererDisabled() are now pure virtual. SetPlaybackRate() is removed entirely, and moved down to BufferedDataSource.
BUG=304990
Review URL: https://codereview.chromium.org/26492004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
// TODO(pwestin): we can deprecate the timeout argument.
The timeout argument passed to
Framer::GetEncodedVideoFrame and Framer::GetEncodedAudioFrame is removed since is was not used.
// TODO(pwestin): only release if we have a complete frame
VideoReceiver::GetEncodedVideoFrame and AudioReceiver::PlayoutTimeout()
Update logic such that a frame is only checked if it can be released if the incoming packet make a frame complete.
Review URL: https://codereview.chromium.org/26686004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to r221331, MediaCodecBridge::QueueInputBuffer() returned the number of
bytes queued in an attempt to deal with clients that tried to queue inputs
larger than MediaCodec's buffers could hold. That wasn't completely worked
through, though, and doesn't seem to be workable given that MediaCodec's API
deals in "Access Units", not bytes, so it is not permitted to queue half of an
input in one buffer and half in the next. r221331 (silently) replaced this
half-support with a requirement that inputs fit in buffers. This CL turns this
DCHECK requirement into an error-triggering one, and fixes a callsite that r221331 missed
(AndroidVideoDecodeAccelerator), along with a bunch of plumbing that was only
needed while partial-buffer-queueing was possible.
BUG=305421
Review URL: https://codereview.chromium.org/26630002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the DecryptingDemuxerStream is in the waiting-for-a-key state, we should
reset the DecryptingDemxuerStream in VideoFrameStream::Reset(). Otherwise, the
read callback will never fire and VFS::Reset() never finishes.
Also fix DecryptingDemuxerStream that when Reset() is called during a pending
config-change read, we should return kConfigChanged back to the caller rather
than return a kAborted.
BUG=304260, 303835
TEST=Added unittests to cover these cases.
R=scherkus@chromium.org
Review URL: https://codereview.chromium.org/26588003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This disables Widevine key system on Chrome for Android.
- Developer/Tester can use --enable-mediadrm flag to enable MediaDrm manually.
- ClearKey key system still works.
R=ddorwin@chromium.org, qinmin@chromium.org
TBR=jochen@chromium.org
BUG=305422
TEST=Tested on Nexus 10.
Review URL: https://codereview.chromium.org/26708002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
*_unittests is the common name for all other unit test executables.
TBR=hubbe@chromium.org
Review URL: https://codereview.chromium.org/26601006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/25048005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
between encoder and decoder. In addition, adds utility functionality for video testing, such as psnr.
Review URL: https://codereview.chromium.org/24303010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/25124002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When VideoFrameStream::Stop() is called, invalidate all existing weak pointers,
satisfy all pending callbacks and start to stop DecryptingDemuxerStream and/or
VideoDecoder right away.
This also fixes the issue where VideoFrameStream::Stop() is called when
DecryptingDemuxerStream is in kWaitingForKey state.
BUG=304260,304577,303835
TEST=Added a test where VFS::Stop() is called when DDS is waiting for a key.
Review URL: https://codereview.chromium.org/26177002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=270296
TEST=encrypted media browsertests.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227436
R=ddorwin@chromium.org, dmichael@chromium.org
Review URL: https://codereview.chromium.org/23546014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/23500012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
conversions.
BUG=291735
TEST=All existing unit tests still pass.
Review URL: https://codereview.chromium.org/26235006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke chromium os build: media/cdm/ppapi/cdm_wrapper.cc:1326:32: error: narrowing conversion of 'signed_data_var.pp::VarArrayBuffer::ByteLength()' from 'uint32_t {aka unsigned int}' to 'int32_t {aka int}' inside { } is ill-formed in C++11 [-Werror=narrowing]
> Plumb PPAPI PlatformVerification into CDM.h
>
> BUG=270296
> TEST=encrypted media browsertests.
>
> Review URL: https://codereview.chromium.org/23546014
TBR=dalecurtis@chromium.org
Review URL: https://codereview.chromium.org/26448002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=291735
TEST=All unit tests and LayoutTests still pass.
Review URL: https://codereview.chromium.org/26327005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=270296
TEST=encrypted media browsertests.
Review URL: https://codereview.chromium.org/23546014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The autogenerated .h was fixed in r192779 but the .pump file was left untouched.
Review URL: https://codereview.chromium.org/26261005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NeedKey is only fired in the demuxer and we already have
media::Demuxer::NeedKeyCB.
BUG=none
TEST=none
R=ddorwin@chromium.org
Review URL: https://codereview.chromium.org/23904027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We see a lot of crash reports around closing invalid handles. It's
possible these are due to unreported errors that result in unstarted
threads being joined.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/26069003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=304776
TBR=vigneshv@chromium.org
Review URL: https://codereview.chromium.org/26213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When ffmpeg AVFrame objects are freed, the current code calls
avcodec_free_frame(). However, this can cause "use after free"
errors. The correct call is to call avcodec_free_frame().
Also updating the remaining places that use av_free() to free up
an AVFrame to use avcodec_free_frame() instead.
Requires a roll of ffmpeg to pick up avcodec_free_frame().
BUG=303927
TEST=No errors reported by ASAN for repro.
Review URL: https://codereview.chromium.org/26023006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236893
R=sky@chromium.org
Review URL: https://codereview.chromium.org/25770005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a new line at end of file.
TBR=justinlin@chromium.org
Review URL: https://codereview.chromium.org/25993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix warnings with size_t casted to int.
TBR=justinlin@chromium.org
Review URL: https://codereview.chromium.org/26034003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See bug, but in general the API is not implemented in almost any device tested so far.
TBR=wjia@chromium.org
BUG=303507
Review URL: https://codereview.chromium.org/25661003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=These tests work well on Nexus 10.
Review URL: https://codereview.chromium.org/25665009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=hclam@chromium.org
Review URL: https://codereview.chromium.org/25971002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=302562
TEST=Smooth playback!
Review URL: https://codereview.chromium.org/25411007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/25751002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Found by clang's new -Wunused-const-variable.
BUG=290204
TBR=mark, acolwell, agl, alexeypa, markus, brettw
Review URL: https://codereview.chromium.org/25849004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=justinlin@chromium.org
Review URL: https://codereview.chromium.org/25846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Corrupt audio data in a media file can cause a crash if the number of channels
exceeds the limit that Chrome supports. Fix is to return an error if the number
of channels is too large, so that the buffer allocation is not attempted.
BUG=301985
TEST=Video now plays without crashing (there is no sound from the corrupt audio portion)
Review URL: https://codereview.chromium.org/25772003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Disable files that causes warnings for cast_unittest. Also fixed some
integer cast warnings.
R=justinlin@chromium.org
Review URL: https://codereview.chromium.org/25944002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226871 0039d316-1c4b-4281-b951-d872f2087c98
|