| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GYP defines (or EXTRA_BUILD_ARGS for cros).
When enabled, this tool is built into Chrome and makes it log its routine invocations. Every time a routine is called and if it is called for the first time (per each thread), the log is updated with current time and the address of the routine. Later, such logs can be merged (across all threads), symbolized and fed into linker ('order_text_section') so it produces binary with more optimal code layout. This must make code work faster because of better CPU cache utilization.
See more technical details in tools/cygprofile/cygprofile.cc header.
Cyg prefix is taken after the callback names in gcc that we use to hook the code: __cyg_profile_func_enter and __cyg_profile_func_exit.
More info at https://sites.google.com/a/google.com/chrome-msk/dev/boot-speed-up-effort
BUG=chromium-os:20187
TEST=units, build cros with
declare -x EXTRA_BUILD_ARGS="order_profiling=1 linux_use_tcmalloc=0"
run it and check the log at /var/log/chrome/cyglog.*.
Review URL: https://chromiumcodereview.appspot.com/8770054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben,brettw,hclam
Review URL: https://chromiumcodereview.appspot.com/10391121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have much better fix in audio mixer, but we need some fix in M20.
On Mac do not allow starting of audio stream within 50ms of stopping.
BUG=128128
TEST=Crash should go away, or at least become much less frequent.
Review URL: https://chromiumcodereview.appspot.com/10387137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127915
TEST=WebMClusterParserTest.ParseBlockGroup & WebMClusterParserTest.ParseSimpleBlockAndBlockGroupMixture.
Review URL: https://chromiumcodereview.appspot.com/10391091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122909
TEST=ChunkDemuxer.TestAVHeadersWithAudioOnlyType, ChunkDemuxer.TestAVHeadersWithVideoOnlyType
Review URL: https://chromiumcodereview.appspot.com/10389125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the current setup, if you have a header file my_class.h
class BASE_EXPORT MyClass {
public:
void MyInlineMethod() { /* do stuff, inline */ }
};
then every cc file that includes my_class.h will have a public symbol
for MyInlineMethod (because inline methods need to be emitted to
every translation unit, and the linker sorts them out). With the
components build, the linker can't decide to drop these inline methods,
so every .so that uses this header file will have the same public symbol.
With this proposed change, the symbol will only be visible in the target
the header file belongs to, and it will be hidden in all other components.
That's cleaner, and it also prevents accident hidden dependencies (say
target A depends on B, and B depends on C. A accidentally uses an inline
function from a class in C. With this change, that would result in a linker
error, and an explicit dependency from A on C would have to be added).
Also add a missing CHROMEOS_IMPLEMENTATION define which went
unnoticed until now.
BUG=90078
TEST=Things still build.
TBR=ben, tony, viettrungluu, thestig, agl, willchan
Review URL: https://chromiumcodereview.appspot.com/10386108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
My fix didn't take into account that we schedule a task to notify ended, meaning we would continue to execute the time update callback at end of stream.
BUG=126584
TEST=video playback is no longer jerky, http/tests/media/media-source/webm/* pass
Review URL: https://chromiumcodereview.appspot.com/10392071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test demuxing unsupported audio with supported video and vice versa
for Chromium builds. The previous test only works on Chrome builds
and only for the strange case of MP3 ID3 demuxing.
BUG=127692
TEST=these shiny new tests!
Review URL: https://chromiumcodereview.appspot.com/10356132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104040
R=ben@chromium.org
TBR=tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IsLocalSource & IsSeekable from Demuxer/Pipeline.
MockDataSource was completely unused, and Is{LocalSource,Seekable} being in the
Demuxer is leftover craxy from the DataSourceFactory / DemuxerFactory /
DownloadRateMonitor days, may they forever RIP.
BUG=120426
TBR=scherkus
Review URL: https://chromiumcodereview.appspot.com/10392069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from Demuxer/Pipeline.
It broke LayoutTests/http/tests/media/media-source/webm/video-media-source-seek.html
and video-media-source-state-changes.html.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=http%2Ftests%2Fmedia%2Fmedia-source%2Fwebm%2Fvideo-media-source-seek.html%2Chttp%2Ftests%2Fmedia%2Fmedia-source%2Fwebm%2Fvideo-media-source-state-changes.html
Review URL: https://chromiumcodereview.appspot.com/10378100
TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10378119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=run cns tests.
Review URL: https://chromiumcodereview.appspot.com/10356033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=126026
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10387059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MockDataSource was completely unused, and Is{LocalSource,Seekable} being in the
Demuxer is leftover craxy from the DataSourceFactory / DemuxerFactory /
DownloadRateMonitor days, may they forever RIP.
BUG=120426
Review URL: https://chromiumcodereview.appspot.com/10378100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Delete DownloadRateMonitor since it's never worked right.
(and it complicates other things I want to do)
BUG=73609
TBR=scherkus
Review URL: https://chromiumcodereview.appspot.com/10392048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111392
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10332119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SourceBufferStream
BUG=126560
TEST=media_unittests
Review URL: https://chromiumcodereview.appspot.com/10375042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
media::AudioRendererImpl::FillBuffer().
r136410 broke LayoutTests/http/tests/media/media-source/webm/video-media-source-{play,seek}.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=video-media-source-
Review URL: https://chromiumcodereview.appspot.com/10332100
TBR=scherkus@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and it complicates other things I want to do)
LayoutTests/media/video-error-does-not-exist.html crashes by r136486.
BUG=73609
Review URL: https://chromiumcodereview.appspot.com/10382109
TBR=fischman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that FFmpeg passes in ID3 tag data (video, pictures) as an
additional stream, we need to skip if it's unsupported, otherwise
we'll bail out at the decoding stage. Allows partial playback of
unsupported content.
BUG=127692
TEST=mp3 in bug, layout tests, unittests.
Review URL: https://chromiumcodereview.appspot.com/10382117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(and it complicates other things I want to do)
BUG=73609
Review URL: https://chromiumcodereview.appspot.com/10382109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
media::AudioRendererImpl::FillBuffer().
I had misinterpreted what the requirements were for executing the time update callback. It turns out we always want to execute it if we managed to generate a valid current time value otherwise the clock will continue to linearly interpolate time based on system time. The condition to only update time if it advanced creates jerkiness because we end up flip-flopping between interpolated time and audio-driven time as opposed to receiving a constant stream of audio-driven time updates.
BUG=126584
TEST=video playback is no longer jerky
Review URL: https://chromiumcodereview.appspot.com/10332100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our internals page is for reporting things that are, like, internal. The statistics I'm removing are available from audio/video elements themselves, removing the need for including them on the internals page. They are also really spammy.
During the removal I also fixed a bug where we weren't reporting the associated parameters with each event (i.e., the name of the state for a PIPELINE_STATE_CHANGED event).
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10332082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build media java files (we weren't).
Fix adb_install_content_shell for cases where the app was stuck.
Add upstream staging gyp var / #define.
Be more consistent about jar output files (all in lib.java).
Upstream a bunch of random files (e.g. ppapi).
Upstream a bunch of java and native code hit as part of shlib init.
Properly package jar files in content shell.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10377059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103513
TEST=unittests + manually test seeking & buffering bar behavior is unchanged
Review URL: https://chromiumcodereview.appspot.com/10387031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the message queue is built in such a way that DoPlay()->DoPause()->DoPlay()
ends up executing before the the first DoPlay()'s PollAndStartIfDataReady() runs,
we'll end up dropping the play and keeping the pause.
Fixed by ensuring we drop the pause if we receive a play before the pause is
consumed by PollAndStartIfDataReady().
BUG=111272
TEST=unittests, test.html test case in bug. Manual seeking in buffered areas.
Review URL: https://chromiumcodereview.appspot.com/10386037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crrev.com/134403 seems to have introduced some accidental
log spam. Intended?
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10383092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in ChunkDemuxer.
BUG=122909
TEST= Covered by http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html LayoutTest
Review URL: https://chromiumcodereview.appspot.com/10388054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103513 (this is just clearing the cruft out before implementing the enhancement)
TEST=none: just removing dead code
Review URL: https://chromiumcodereview.appspot.com/10384056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hopefully we'll be able to find out what causes the problem looking at
the crashes (if any).
BUG=123322
TEST=Crash in media::AudioManagerBase::ShutdownOnAudioThread() should go away.
Review URL: https://chromiumcodereview.appspot.com/10383066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Required to fix issues with plink and guitar WebAudio demos.
Seek is unnecessary as the stream already starts at the beginning. Additionally
seeking to 0 without specifying the right flags can actually move the index
forward in the stream.
Also allows partial return of data on decode failure to work around a potential
issue in FFmpeg w/ mp3s now that the seek has been removed.
BUG=none
TEST=plink,guitar,crogers
Review URL: https://chromiumcodereview.appspot.com/10382043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
total number of tests does not change from previous ).
BUG=126301
TEST=make sure layout test analzyer still runs as before.
Review URL: https://chromiumcodereview.appspot.com/10383018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes the following fixes:
45a7b06 oggvorbis: fix the first 2 packets timestamps matching issue
16db88a vorbis_parser: fix blocksize
441dce2 oggvorbis: move handling of first packets ts from parser to muxer.
b18c9f1 oggtheora: Port changes from oggvorbis timestamp handling.
fe5c5bc oggvorbisdec: Apply timestamp calculation always when timestamps arent known.
1f95ad4 oggvorbisdec: redesign special handling of first frames timestamp.
63eb01d oggvorbis: Try to fix pts off by 1 issue.
231d32c oggtheora: Fix initial pts
ef32fba oggdec: fix off by one error on pos_limit
96fb233 oggdec: reset lastpts so that justins vorbis duration correction is not skiped
5f9f78d oggdec: pass avformat context to ogg_reset()
8b97ae6 avf: fix faulty check in has_duration
BUG=124915,126063,124779
TEST=manual matrix pass, asan+valgrind over unittests, trybots.
TBR=scherkus
Review URL: https://chromiumcodereview.appspot.com/10377028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
connections to drop suddenly.
BUG=126026
TEST=manual test.
Review URL: http://codereview.chromium.org/10353004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL doesn't integrate SourceBufferStream into Chromium yet, but the
functionality is tested in the unit test.
BUG=125092
TEST=media_unittests
Review URL: https://chromiumcodereview.appspot.com/10228017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
anazlyzer. Also, changed CSV format to use double quotations for seperators instead of commas.
BUG=125757
TEST=make sure layout analzyer runs with new test cases
Review URL: https://chromiumcodereview.appspot.com/10261034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It added base::unretained(this) when scheduling a task, as a result AudioOutputController can be deleted before task run, and it would use junk instead of AudioSource.
BUG=124991
Review URL: http://codereview.chromium.org/10261027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also switched to using kNoTimestamp() to represent uninitialized timestamps.
TBR=timurrrr
BUG=109875,112418,122447
TEST=tsan is happy, also run http://mastodon.sea/demos/crbug122447
Review URL: https://chromiumcodereview.appspot.com/10355006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is per the clarified API defined in http://codereview.chromium.org/9724011/
Review URL: http://codereview.chromium.org/10350002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=126070
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10316015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122903
TEST=Will be covered by LayoutTests when WebKit changes land.
Review URL: http://codereview.chromium.org/10264020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second step to move VideoDecoder out of Filter hierarchy (See r128289). VideoDecoder is not a Filter any more and Seek()/Pause()/Play() methods are removed from its definition and all implementations.
BUG=108340
TEST=media_unittest,content_unittest,normal html5 video playback
Review URL: http://codereview.chromium.org/9724011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I noticed this while debugging bug 120396 that the reported time remained zero even after appending the initial audio buffer that has a timestamp of zero.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10342005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow SourceBufferStreams to identify keyframes.
BUG=125680
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/10269022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChunkDemuxer's StreamParser and simply forwards the callbacks back to ChunkDemuxer. Existing functionality should be maintained.
BUG=125770
TEST=chunk_demuxer_unittest.cc should still succeed. source_buffer_unittest.cc coming soon.
Review URL: http://codereview.chromium.org/10261028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
VideoRenderBase.
BUG=125802
TEST=added a new test in media_unittests.
Review URL: http://codereview.chromium.org/10288008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
read from uninitialized memory. Mixer reads data from there, even though test
does not use mixed output.
BUG=125723
Review URL: http://codereview.chromium.org/10268026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buffered
but not yet played). Underlying code expects per-logical-stream pending bytes,
while all mixer gets when called for more data is pending bytes per combined stream.
Fix is to keep track of
* amount of data in every buffer
* buffers for every logical stream
and manually calculate per-logical-stream pending bytes.
That is last CL in initial audio mixer implementation, after it go through mixer
should be ready for full testing.
Review URL: http://codereview.chromium.org/10154007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134675 0039d316-1c4b-4281-b951-d872f2087c98
|