| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accumulated these while spelunking into the fast-forward issue, but now that's
on hold figured I'd send these out for cleanup.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7726002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7631016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for VideoFrame size
The media_unittests needed to be adjusted to reflect the change made in
the dimensions used to create VideoFrames in FFmpegVideoDecodeEngine.
BUG=91506
TEST=media_unittests
Review URL: http://codereview.chromium.org/7714016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That caused impression that rewind does not work. With that
change small JS program
var a = new Audio("file:///home/enal/temp/click2/click2.wav");
var num_played = 0;
a.addEventListener('canplaythrough', function() {
a.play();
});
a.addEventListener('ended', function() {
num_played ++;
if (num_played < 10) {
a.currentTime = 0;
a.play();
}
});
works correctly, you hear 10 clicks one after another, and it takes
~1.5 seconds to play all 10 sounds (one click is 146ms). Current
Chrome plays only beginnings of the first 9 clicks and then entire
10th click -- 'ended' event fires too early, so rewind stops audio
playback for all clicks but last one.
With that fix you can easily create pool of audio objects -- on 'ended'
event just add audio object to the pool.
Fix consists of 2 parts:
1) When using low-latency code path renderer not only fills the buffer with
data, but also writes length of data at the end of buffer. That allows host
process to pass correct byte counts to renderer. Counter is written at the
endo of buffer, and by default it is set to buffer length, so no changes to
existing clients are necessary.
3) Renderer now keeps track of the earliest time playback can end based on the
number of rendered bytes, and will not call 'ended' callback till that time.
PS. After several comments I changed chrome code to make it much harder for
code to get buffer overrun. I was pointed that native client can write bogus
size of data into buffer, so function in chrome that reads size of data now
has extra argument -- max size of buffer, and returns min(max size of buffer,
size of data reported by client). This way min() is always called.
PPS. That is much scaled down version of the CL, it does not affect lot of
audio code paths...
BUG=http://code.google.com/p/chromium/issues/detail?id=78992
http://codereview.chromium.org/7328030
Review URL: http://codereview.chromium.org/7328030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for VideoFrame size
It appears that "surface" height/width refers to the visible height/width of the frame. FFmpegVideoDecodeEngine should use these dimensions to create VideoFrames rather than the coded width/height.
BUG=91506
TEST=NONE
Review URL: http://codereview.chromium.org/7624055
TBR=vrk@google.com
Review URL: http://codereview.chromium.org/7719005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It appears that "surface" height/width refers to the visible height/width of the frame. FFmpegVideoDecodeEngine should use these dimensions to create VideoFrames rather than the coded width/height.
BUG=91506
TEST=NONE
Review URL: http://codereview.chromium.org/7624055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=92429
TEST=BitstreamConverterTest.*, ChunkDemuxerTest.*, FFmpegDemuxerTest.*, FFmpegGlueTest.*, FFmpegVideoDecoderTest.*, FFmpegH264BitstreamConverterTest.*, FFmpegVideoDecodeEngineTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96974
Review URL: http://codereview.chromium.org/7587012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus@chromium.org
BUG=92429
TEST=None
Review URL: http://codereview.chromium.org/7715004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(this situation can arise b/c VideoRendererBase uses a
base::PlatformThread::Delegate instead of a more-legit base::Thread)
BUG=93821
TEST=trybots
Review URL: http://codereview.chromium.org/7709015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on codereview.chromium.org/7473021: Preliminary PulseAudio Sound Playback on Linux.
PulseAudio has built in swizzling, downmixing, and upmixing. The client (Chrome) just has to give PulseAudio the channel layout of the audio it wants to play in the form of a pa_channel_map.
BUG=55489, 55490
TEST=
Review URL: http://codereview.chromium.org/7650002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
will first try to checkin minimum working code and expand it from there.
Review URL: http://codereview.chromium.org/7671049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7695008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the preliminary implementation of a PulseAudio sound backend for Chrome on Linux. At first, PulseAudio's mainloop, mainloop_api, and context constructs will be used instead of the message loop system used in alsa_output. This will be stereo only at first. Also, at first, PulseAudio will be dynamically linked in media.gyp as opposed to the final solution which will dynamically link PulseAudio in runtime if it is available.
BUG=32757
TEST=
Review URL: http://codereview.chromium.org/7473021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=scherkus
(original code review http://codereview.chromium.org/7646026/)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I considered merging these into ui.dll, but the respective GYP files are pretty
customized, and merging all of the special casing into ui.gyp seemed like it
would just make things messy. Plus, some components only need to link to
surface and not all of ui.
One thing that I'm not entirely sure about is the naming convention. In this
case the modules are named gl, compositor and surface instead of ui_gfx_gl, and
so on. I thought about declaring UI_GFX_GL_EXPORT, but I opted for the shorter
GL_EXPORT instead. I think Ben has been thinking about moving these
directories out of ui/gfx/ anyways since it is a bit odd for them to live there.
R=rvargas
Originally reviewed at http://codereview.chromium.org/7645004
Review URL: http://codereview.chromium.org/7659017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7670016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the project files.
BUG=92102
Review URL: http://codereview.chromium.org/7528010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7587007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I considered merging these into ui.dll, but the respective GYP files are pretty
customized, and merging all of the special casing into ui.gyp seemed like it
would just make things messy. Plus, some components only need to link to
surface and not all of ui.
One thing that I'm not entirely sure about is the naming convention. In this
case the modules are named gl, compositor and surface instead of ui_gfx_gl, and
so on. I thought about declaring UI_GFX_GL_EXPORT, but I opted for the shorter
GL_EXPORT instead. I think Ben has been thinking about moving these
directories out of ui/gfx/ anyways since it is a bit odd for them to live there.
R=rvargas
Review URL: http://codereview.chromium.org/7645004
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7659015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I considered merging these into ui.dll, but the respective GYP files are pretty
customized, and merging all of the special casing into ui.gyp seemed like it
would just make things messy. Plus, some components only need to link to
surface and not all of ui.
One thing that I'm not entirely sure about is the naming convention. In this
case the modules are named gl, compositor and surface instead of ui_gfx_gl, and
so on. I thought about declaring UI_GFX_GL_EXPORT, but I opted for the shorter
GL_EXPORT instead. I think Ben has been thinking about moving these
directories out of ui/gfx/ anyways since it is a bit odd for them to live there.
R=rvargas
Review URL: http://codereview.chromium.org/7645004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=92429
TEST=BitstreamConverterTest.*, ChunkDemuxerTest.*, FFmpegDemuxerTest.*, FFmpegGlueTest.*, FFmpegVideoDecoderTest.*, FFmpegH264BitstreamConverterTest.*, FFmpegVideoDecodeEngineTest.*
Review URL: http://codereview.chromium.org/7587012
TBR=acolwell@chromium.org
Review URL: http://codereview.chromium.org/7658017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92429
TEST=BitstreamConverterTest.*, ChunkDemuxerTest.*, FFmpegDemuxerTest.*, FFmpegGlueTest.*, FFmpegVideoDecoderTest.*, FFmpegH264BitstreamConverterTest.*, FFmpegVideoDecodeEngineTest.*
Review URL: http://codereview.chromium.org/7587012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92429
TEST=None
Review URL: http://codereview.chromium.org/7647022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just fixes a possible typo in RGB->YUV conversion formulae. (If I recall correctly, 'v = 112 * r - 94 * g - 18 * b' as written in <http://en.wikipedia.org/wiki/YUV>.) (I noticed this issue when I implement RGB->YUV conversion in YASM.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7519024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7629007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90214
TEST=PipelineImplTest.*
Review URL: http://codereview.chromium.org/7484054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7584013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7591001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91896
TEST=trybots
Review URL: http://codereview.chromium.org/7584033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/7601002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7572040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements the proxy necessary for out-of-process video decoding and
introduces a shared base class between the PPB_VideoDecoder_Impl and the proxy.
BUG=NONE
TEST=gles2 plugin runs with or without --ppapi-out-of-process flag, no crashes
Review URL: http://codereview.chromium.org/7545014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding 95542. Reverted due to issue caused by 95496.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7480032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7523051
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7491048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ready on all
platforms.
TBR=apatrick
Review URL: http://codereview.chromium.org/7575019
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7583001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser process.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7480032
TBR=scottfr@chromium.org
Review URL: http://codereview.chromium.org/7566054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/7480032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
platforms.
TBR=apatrick
Review URL: http://codereview.chromium.org/7575019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7523051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a variety of error cases exposed by the WebKit LayoutTests I created to test this code. The ChunkDemuxer unit tests were updated to expose these cases as well.
BUG=86536
TEST=ChunkDemuxerTest.*
Review URL: http://codereview.chromium.org/7538027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the ChunkDemuxer to make sure the FFmpegURLProtocol object's lifetime is longer than the lifetime of format_context_. This is necessary because the format_context_ holds a pointer to the protocol deep within its structure and can use it any time during the context's lifetime.
BUG=86536
TEST=ChunkDemuxerTest.*
Review URL: http://codereview.chromium.org/7545025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
analyzer. Previously, analyzer's email shows previous revision author/message.
Updated to show current author/message. Also added some comments and renames variables to avoid confusion. The fix is verified using integration
environment.
Review URL: http://codereview.chromium.org/7552013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Video Capture PPAPI example (in later CL)
Review URL: http://codereview.chromium.org/7537037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
include_other_fields is false, return_list should not include the OTHER_FIELD_NAME.
Review URL: http://codereview.chromium.org/7518038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
All 'low-hanging' platform_canvas.h dependencies have been removed, and replaced with skia-specific includes.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7517020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Originally, these are developed as part of Webkit so it follows Webkit code code convention. Other part of the code for analyzer is coming in the later CRs.
Review URL: http://codereview.chromium.org/7480031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7533020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Decode() calls are now queued for later processing when the decoder is in
RESETTING state.
Also output buffers are queued by OVDA during the Flush() triggered by Reset()
for re-use as soon as the Reset is done.
BUG=none
TEST=ovdatest, gles2, trybots
Review URL: http://codereview.chromium.org/7524032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes:
r94192 Clarify ffmpeg.gyp comments.
r94207 Build ffmpegsumo as a loadable_module, not a shared_library
The latter change causes us to use a new name for ffmpegsumo on Mac.
BUG=74216
Review URL: http://codereview.chromium.org/7470035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=90214
TEST=BufferedDataSourceTest.*, SimpleDataSourceTest.*
Review URL: http://codereview.chromium.org/7461035
TBR=acolwell@chromium.org
Review URL: http://codereview.chromium.org/7482029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94376 0039d316-1c4b-4281-b951-d872f2087c98
|