summaryrefslogtreecommitdiffstats
path: root/media
Commit message (Collapse)AuthorAgeFilesLines
* Add some NULL checks for shared memory and AudioBus creation.dalecurtis@chromium.org2013-03-053-2/+5
| | | | | | | | | | | | | | Seemingly we're getting a NULL ptr inside of the AudioBus used by the AudioOutputDevice. It looks like SharedMemory::Map() fails, so I've added some CHECK()s to validate this case. BUG=179986 TEST=media_unittests Review URL: https://chromiumcodereview.appspot.com/12379089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186074 0039d316-1c4b-4281-b951-d872f2087c98
* Implement "hole" video frame.wonsik@google.com2013-03-042-0/+19
| | | | | | | | | | | | | | | | In order to support out-of-band compositing of protected video content in Chrome, it is necessary to have a transparent hole in Chrome's HTML rendering so that video playing "beneath" the HTML elements can be seen through. To accomplish the scenario stated above, define a "hole" video frame which would clear the region where video would have been composited. In CC, this is done by sending a transparent black SolidColorDrawQuad with blending disabled. Review URL: https://chromiumcodereview.appspot.com/12255032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185841 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MMX support so media can build on Win64 MSVS 2012jschuh@chromium.org2013-03-031-1/+2
| | | | | | | | | BUG=179657 TBR=scherkus@chromium.org R=scherkus@chromium.org Review URL: https://codereview.chromium.org/12381063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185788 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CopyFromCompositingSurfaceToVideoFrame for mac.justinlin@chromium.org2013-03-023-0/+80
| | | | | | | | | | | | Move ComputeLetterboxRegion and add ConvertRGBToVideoFrame to VideoUtil class. Fix intersecting the capture region with unscaled iosurface_size. BUG=175358 TBR=kbr Review URL: https://chromiumcodereview.appspot.com/12326085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185678 0039d316-1c4b-4281-b951-d872f2087c98
* Wait for the renderer even on WASAPI.dalecurtis@google.com2013-03-021-6/+15
| | | | | | | | | | | | | After weeks of investigation, Henrik has been unable find a WASAPI buffer size that works for all users. Many users are still reporting glitches. Thus its time to put the WaitTillDataReady() back. :( BUG=171651 TEST=none Review URL: https://codereview.chromium.org/12380074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185650 0039d316-1c4b-4281-b951-d872f2087c98
* Always fully fill PulseAudio's requested buffer. Allow larger initial requests.dalecurtis@chromium.org2013-03-011-41/+37
| | | | | | | | | | | | | | | | | Instead of forcing PulseAudio to always call us with a buffer size matching our requested size, let it automatically choose its initial buffers and only ask for our requested size in steady state. Doing this requires using a WaitTillDataReady() for those times when we need to fill a larger buffer than we expect. BUG=32757 NOTRY=true TEST=no more PulseAudio glitching when using native sample rate. Review URL: https://chromiumcodereview.appspot.com/12328097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185593 0039d316-1c4b-4281-b951-d872f2087c98
* AndroidVDA using Android's MediaCodec API.dwkang@chromium.org2013-03-014-0/+614
| | | | | | | | | | | | | | | | | | | | | | | | This is part of the effort for HW decoding on WebRTC. This change will not affect the existing media playback because Chrome for Android uses a separate WMP. Also, VDA is disabled on Chrome for Android. The plan is to enable it after connect VDA to WebRTC. TODO: - to make vda unittest work on Android. @ media_codec_bridge* are written by ycheo@ BUG=170345 TEST=visited the follwing sites after turning on Chrome's media stack with a separate change. http://html5example.net/static/html/html5-WebM-VP8-video.html http://www.ioncannon.net/examples/vp8-webm/demo.html http://www.dailymotion.com/html5 http://easyhtml5video.com Review URL: https://chromiumcodereview.appspot.com/11973010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185469 0039d316-1c4b-4281-b951-d872f2087c98
* Delete old RTCVideoDecoder code path.wuchengli@chromium.org2013-03-015-292/+0
| | | | | | | | | | | Remove leftover codepath from the pre-WebMediaPlayerMS days. BUG=chromium:177572 TEST=Try apprtc.appspot.com/?debug=loopback on link. Review URL: https://chromiumcodereview.appspot.com/12320078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185460 0039d316-1c4b-4281-b951-d872f2087c98
* Add lock to AUAudioOutputStream::Start() and Stop().dalecurtis@google.com2013-03-012-11/+31
| | | | | | | | | | | | | Crash reports show a NULL pointer exeception occuring in Render(), which should only occur if Render() is continuing to execute before Start() or after Stop(). Lock and check to avoid crashing. BUG=178765 TEST=none Review URL: https://codereview.chromium.org/12384003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185379 0039d316-1c4b-4281-b951-d872f2087c98
* Remove one video frame copying in video capture.wjia@chromium.org2013-02-2814-69/+52
| | | | | | | | On Android, the captured frame might need to be rotated. By moving the rotation code into VideoCaptureController, one video frame copying is reduced. On Nexus 4, the frame copying from intermedia buffer to shared memory takes about 0.1 ms per frame for VGA YV12. Review URL: https://codereview.chromium.org/12378007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185339 0039d316-1c4b-4281-b951-d872f2087c98
* Use a bool to track whether VideoRendererBase has seen end of stream.scherkus@chromium.org2013-02-282-35/+34
| | | | | | | | | | | Not only does this follow what AudioRendererImpl does, but it also makes VideoFrame lifetime tracking easier to accomplish if VideoRendererBase::ready_frames_ only contains actual frames. BUG=177730 Review URL: https://chromiumcodereview.appspot.com/12377005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185335 0039d316-1c4b-4281-b951-d872f2087c98
* Remove VideoRendererBase::prerolling_delayed_frame_.scherkus@chromium.org2013-02-282-14/+8
| | | | | | | | | | VideoFrame lifetime tracking is easier to accomplish if all VideoFrames live inside VideoRendererBase::ready_frames_. BUG=177730 Review URL: https://codereview.chromium.org/12335148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185282 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some methods in media::VideoRendererBase.scherkus@chromium.org2013-02-282-16/+12
| | | | | | | | | | | Minor prep work before landing the real fix for VideoFrame lifetime tracking. BUG=177730 Review URL: https://chromiumcodereview.appspot.com/12383005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185164 0039d316-1c4b-4281-b951-d872f2087c98
* Add xians, henrika to media/audio/OWNERSdalecurtis@chromium.org2013-02-281-0/+6
| | | | | | | | | | | | | By our power combined... BUG=none TEST=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12374005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185102 0039d316-1c4b-4281-b951-d872f2087c98
* More AudioMessageFilter cleanup. Fix crash.dalecurtis@google.com2013-02-272-9/+7
| | | | | | | | | | | | | | | | | Removes the |lock_| used by AudioMessageFilter for adding and removing delegates in favor of ensuring those calls happen on the IO thread. Also, currently message filters are expected to take care of cleaning up delegates when the IPC closes unexpectedly. I broke this in my last patch set, http://crrev.com/184478 BUG=178499 TEST=|delegates_| is empty after OnChannelClosing() completes. |stream_id_| is correctly associated on various audio pathways. Review URL: https://codereview.chromium.org/12342029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185073 0039d316-1c4b-4281-b951-d872f2087c98
* add a use_alsa gyp settingmostynb@opera.com2013-02-271-8/+15
| | | | | | | | | | | | | | By adding a gyp setting, we can explicitly disable alsa on various unix targets that don't include alsa. BUG= TEST=Build with use_alsa=0 then run ldd on output binaries to verify libasound is not listed (and is listed if built with use_alsa=1 or unspecified). Review URL: https://chromiumcodereview.appspot.com/12316049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185011 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix build with disabled libpvx support in media.phajdan.jr@chromium.org2013-02-271-10/+15
| | | | | | | | | | | | | | - rename gyp variables use_libvpx, use_ffmpeg to media_use_libvpx, media_use_ffmpeg so that their scope is clear (matter of hygiene) - fix build with media_use_libvpx=0 - it excluded some files from the build but other files were still referring to it Not using e.g. compile_test.py because explicit is better than implicit. compile_test.py was designed for a very specific use case and is a last resort, also not to be used as part of Google Chrome build process. Here it is fixing an existing build option. BUG=174287 Review URL: https://codereview.chromium.org/12320041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184981 0039d316-1c4b-4281-b951-d872f2087c98
* Remove browser-wide audio mirroring and --force-audio-mirroring flag.miu@chromium.org2013-02-278-287/+113
| | | | | | | | | BUG=176700 TEST=Ran media_unittests, content_unittests; and manually ran tab mirroring sessions in the browser to confirm no breakage. Review URL: https://chromiumcodereview.appspot.com/12298003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184882 0039d316-1c4b-4281-b951-d872f2087c98
* This patch changes GetVolume() to be asynchronous when being called by pulse ↵xians@chromium.org2013-02-262-7/+31
| | | | | | | | | | | | | | thread. Pulseaudio does not allow calling pa_threaded_mainloop_lock() and pa_threaded_mainloop_wait() in its callback thread. So the GetVolume() has to be asynchronous when being called in the pulse thread, and synchronous when being called by other threads. BUG=178057 TEST=enable pulse, and make a call using https://webrtc-demos.appspot.com/html/pc1.html Review URL: https://codereview.chromium.org/12310102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184629 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use division in ScreenCapturerLinux::SlowBlit().alexeypa@chromium.org2013-02-263-40/+51
| | | | | | | | | BUG=174381 Review URL: https://chromiumcodereview.appspot.com/12315088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184553 0039d316-1c4b-4281-b951-d872f2087c98
* Re-register refresh and move callbacks when the screen mode changes.jamiewalch@chromium.org2013-02-261-18/+39
| | | | | | | | | | | | Occasionally these callbacks stop being called after the screen mode changes. There seem to be no ill effects from re-registering them in this case. BUG=176414 Review URL: https://chromiumcodereview.appspot.com/12318028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184535 0039d316-1c4b-4281-b951-d872f2087c98
* Remove forwarding include for base/files/file_path except for MTPD.brettw@chromium.org2013-02-241-1/+1
| | | | | | | | | | | Fix up remaining/new uses of base/file_path.h MTPD must be updated in a separate pass due to a circular dependency. BUG= Review URL: https://codereview.chromium.org/12316090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184358 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move MemoryMappedFile out of file_util.h and into its own header file.tfarina@chromium.org2013-02-244-5/+8
| | | | | | | | | | | BUG=175002 TEST=base_unittests R=brettw@chromium.org TBR=erikwright@chromium.org,tommi@chromium.org,fischman@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/12321062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184356 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-2418-22/+22
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* ffmpeg_unittests should depend on use_ffmpeg==1mostynb@opera.com2013-02-231-3/+1
| | | | | | | | | This target currently makes assumptions based on the platform, even though there's an explicit variable that was previously set for this purpose. Review URL: https://chromiumcodereview.appspot.com/12334037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184320 0039d316-1c4b-4281-b951-d872f2087c98
* Allow ChunkDemuxer to accept audio object types with leading zeros.acolwell@chromium.org2013-02-232-24/+67
| | | | | | | | | | BUG=177354 TEST=ChunkDemuxerTest.TestCodecIDsThatAreNotRFC6381Compliant Review URL: https://chromiumcodereview.appspot.com/12321034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184269 0039d316-1c4b-4281-b951-d872f2087c98
* Fix buffer leak in Wave In/Out implementation.dalecurtis@chromium.org2013-02-232-12/+15
| | | | | | | | | | | | | | |waveout_| and |wavein_| are NULL when we call FreeBuffers() in their respective implementations, which means the unprepareheader calls never succeed. BUG=145725 TEST=none Review URL: https://chromiumcodereview.appspot.com/12330063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184238 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Make content_shell_apk and chromium_testshell components friendly.yfriedman@chromium.org2013-02-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | This includes the remaining changes to atleast _compile_ the above targets. More work is needed for starting up the apps and running. Inclues: - Misc EXPORT additions (I assume I can TBR these) - Introduce a ShellDialogs JNI registrar since it's now a separate component and ui can't depend on it. - Random gyp tweaks that are needed to fully specify dependencies - Change from using NPN_MemAlloc to just plain malloc for the java bridge. For some reason the NPN_MemAlloc symbol cannot be found in the component build, but regardless all our implementations end up calling straight throught to malloc. BUG=158821 TBR=wjia@chromium.org,willchan@chromium.org,jcivelli@chromium.org Review URL: https://chromiumcodereview.appspot.com/12281017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184173 0039d316-1c4b-4281-b951-d872f2087c98
* Adding pulseaudio input support to chrome.xians@chromium.org2013-02-2214-169/+1116
| | | | | | | | | | | This input implementation also support device enumeration and volume APIs. BUG=172259,169075,175393,164361 TEST=content_unittests and media_unittests, manual test with https://webrtc-demos.appspot.com/html/pc1.html Review URL: https://chromiumcodereview.appspot.com/10952024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184122 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in VideoRendererBase::ThreadMain().scherkus@chromium.org2013-02-223-6/+57
| | | | | | | | | | | | | The interleaving of VideoRendererBase::Stop() with outstanding asynchronous calls to a VideoDecoder would result in continuing to execute code (e.g., starting up a thread) on a stopped VideoRendererBase. The most common manifestation of the bug was crashing in ThreadMain() as VideoRendererBase was being destroyed. The CHECK()s added to ~VideoRendererBase() in r180573 will stay there as they've proven useful. BUG=174150 Review URL: https://chromiumcodereview.appspot.com/12324005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184048 0039d316-1c4b-4281-b951-d872f2087c98
* Unflake time between callbacks test.dalecurtis@chromium.org2013-02-221-2/+2
| | | | | | | | | | | | | | | Due to the small window, ~2-3ms, between callbacks, its possible for more callbacks to get through than we expect. This is okay, we just need to keep it in mind when calculating the time between callbacks. BUG=177599 TEST=unit test --repeat 100 Review URL: https://chromiumcodereview.appspot.com/12321067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184012 0039d316-1c4b-4281-b951-d872f2087c98
* Use microseconds instead of milliseconds for integer audio math.dalecurtis@google.com2013-02-223-18/+16
| | | | | | | | | | | | When dealing with values where +/- 1ms is an enormous amount of error, we should be using microseconds. BUG=none TEST=none Review URL: https://codereview.chromium.org/12330038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183978 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanup: const char* -> const char ... [].dalecurtis@chromium.org2013-02-229-12/+12
| | | | | | | | | | BUG=none TEST=compiles Review URL: https://chromiumcodereview.appspot.com/12328025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183972 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Clock and TickClock interface for mocking out timeakalin@chromium.org2013-02-216-40/+28
| | | | | | | | | | | | | | Add DefaultClock and DefaultTickClock implementations. Add SimpleTestClock and SimpleTestTickClock implementations for test. Port some classes in sync/ and media/ to use SimpleTest{,Tick}Clock. BUG=166469 Review URL: https://codereview.chromium.org/11607003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183865 0039d316-1c4b-4281-b951-d872f2087c98
* Ensures that the volume level and muting state for a rendering session are ↵henrika@chromium.org2013-02-211-1/+6
| | | | | | | | | | | | | persistent across system restarts on Windows. The volume level and muting state for a capture session are never persistent. TBR=tommi BUG=132764 TEST=manual tests on Windows 7 using different audio clients. Review URL: https://codereview.chromium.org/12320036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183806 0039d316-1c4b-4281-b951-d872f2087c98
* [MIPS] Use BlockDifference_C for MIPSpetarj@mips.com2013-02-211-2/+2
| | | | | | | | | | | Use C version for block difference. Fixes a build break for MIPS. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Review URL: https://chromiumcodereview.appspot.com/12326024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect truncation of audio data during partial interleave.dalecurtis@chromium.org2013-02-202-2/+2
| | | | | | | | | | | | | | Loop should run from [start_frame, start_frame + frames), not [start_frame, frames). As luck would have it, we even have a unit test for this... but it was also wrong for a different reason :x BUG=176624 TEST=fixed unitest. Review URL: https://chromiumcodereview.appspot.com/12317027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183656 0039d316-1c4b-4281-b951-d872f2087c98
* Use _target_name instead of package_name for java*.gypicjhopman@chromium.org2013-02-201-1/+0
| | | | | | | | | | | | | | | We were using package_name as a unique name for naming output files and directories. package_name was typically the same as _target_name or a variation of it (like dropping _apk). Using _target_name instead means we need to specify one less thing and it is (maybe?) guaranteed to be unique. TBR=brettw,joi,jar,fischman,zea,sky BUG= Review URL: https://chromiumcodereview.appspot.com/11308030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183639 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land AudioManagerCras change after rebase.dgreid@chromium.org2013-02-2011-91/+223
| | | | | | | | | | | | | | | | | | The original commit (183140) by xians broke the build because CanShowAudioInputSettings() had been removed from the base class. But it was otherwise totally fine. This is that commit rebased onto top of tree and re-tested on Snow. BUG=148661 TEST=build and run on Snow, check that youtube playback and youtube.com/my_webcam work. Signed-off-by: Dylan Reid <dgreid@chromium.org> Review URL: https://chromiumcodereview.appspot.com/12300030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183483 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use callback after Stop().dalecurtis@chromium.org2013-02-201-6/+6
| | | | | | | | | | | | | | Fixes a crash where HandleError() attempts to notify the callback after it has been set to NULL. Also forces a waveInReset() prior to every waveInClose() in case Start() was never called. BUG=176550 TEST=none Review URL: https://chromiumcodereview.appspot.com/12282006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183472 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Chromium style checker cleanuprsleevi@chromium.org2013-02-201-3/+3
| | | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=brettw, scherkus Review URL: https://chromiumcodereview.appspot.com/12279015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183469 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add a tool and code to make use_system_ffmpeg option more compatiblephajdan.jr@chromium.org2013-02-202-0/+22
| | | | | | | | | | | | | | | | This introduces a compile-time detection of ffmpeg configuration (which codecs are available). See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/fm5Oe_AC3Sc/qkbmC7txaSkJ for more context. No functional change for Google Chrome. BUG=none Review URL: https://codereview.chromium.org/12302029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183463 0039d316-1c4b-4281-b951-d872f2087c98
* Make all media tests build on Win64 jschuh@chromium.org2013-02-202-2/+10
| | | | | | | | | | | | Trivial compile fixes and c4267 warning suppressions. BUG=166496 BUG=167187 BUG=176178 R=scherkus@chromium.org Review URL: https://codereview.chromium.org/12300013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183413 0039d316-1c4b-4281-b951-d872f2087c98
* Add audio mirroring-related OWNERS.miu@chromium.org2013-02-191-0/+4
| | | | | | | | | 1. Added miu@ to content/browser/renderer_host/media/OWNERS for audio* files (author and/or massive changes). 2. Added justinlin@ and miu@ to media/audio/OWNERS for authoring virtual_audio* and massive changes in others. Review URL: https://codereview.chromium.org/12298004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183332 0039d316-1c4b-4281-b951-d872f2087c98
* Satsify pending reads in media::GpuVideoDecoder before resetting.scherkus@chromium.org2013-02-191-4/+4
| | | | | | | | | | r171854 introduced a bug where pending_reset_cb_ was set prior to calling EnqueueFrameAndTriggerFrameDelivery(), resulting in nothing happening instead of running pending_read_cb_ as intended. BUG=175613 Review URL: https://codereview.chromium.org/12285014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183299 0039d316-1c4b-4281-b951-d872f2087c98
* Add test for RotatePlaneByPixels.wjia@chromium.org2013-02-194-98/+365
| | | | | | | | | This is a follow-up patch for https://codereview.chromium.org/11860002/ BUG=161417 Review URL: https://codereview.chromium.org/12207190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183257 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 183140nkostylev@chromium.org2013-02-1911-228/+91
| | | | | | | | | | | | | | | | | | | | This change breaks chromeos asan buildbots: http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28amd64%29%20ASAN/builds/2186 http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%29%20ASAN/builds/2182 > Break down AudioManagerLinux cras code to AudioManagerCras to remove the if-statements and if-def checks. > > > > BUG=148661 > TEST=compile > > Review URL: https://chromiumcodereview.appspot.com/12226111 TBR=xians@chromium.org Review URL: https://codereview.chromium.org/12300019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183199 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to heal the cros asan botsthakis@chromium.org2013-02-192-2/+2
| | | | | | | | | BUG=176923 TBR=xians Review URL: https://codereview.chromium.org/12302022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183194 0039d316-1c4b-4281-b951-d872f2087c98
* Break down AudioManagerLinux cras code to AudioManagerCras to remove the ↵xians@chromium.org2013-02-1811-91/+228
| | | | | | | | | | | if-statements and if-def checks. BUG=148661 TEST=compile Review URL: https://chromiumcodereview.appspot.com/12226111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183140 0039d316-1c4b-4281-b951-d872f2087c98
* Replace FilePath with base::FilePath.brettw@chromium.org2013-02-173-3/+3
| | | | | | | | This is im preparation for removing the 'using" in file_path.h Review URL: https://codereview.chromium.org/12286020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183021 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-07-07 15:55:45 +0000