| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attribute (media://...).
The raw video pipeline graph only has two filters - one pass-thru decoder filter and one renderer filter.
Contributed by ronghuawu@google.com
Original code reviews:
http://codereview.chromium.org/6658001/ (pipeline changes)
http://codereview.chromium.org/6621049/ (pass-thru filter)
BUG=none
TEST=media_unittests
Review URL: http://codereview.chromium.org/6726006
TBR=acolwell@chromium.org
Review URL: http://codereview.chromium.org/6722031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(media://...).
The raw video pipeline graph only has two filters - one pass-thru decoder filter and one renderer filter.
Contributed by ronghuawu@google.com
Original code reviews:
http://codereview.chromium.org/6658001/ (pipeline changes)
http://codereview.chromium.org/6621049/ (pass-thru filter)
BUG=none
TEST=media_unittests
Review URL: http://codereview.chromium.org/6726006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6721015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sample-rate
BUG=none
TEST=none
(tested locally on Mac OS X to verify that hardware sample-rate is correctly retrieved)
Review URL: http://codereview.chromium.org/6721001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change Demuxer's interface looked as if it could return multiple
streams for a given type, but the implementations all assume/need at most a
single stream per type. This change should make the (soon to be written)
AdaptiveDemuxer{,Stream} less confusing.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6685122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6537022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=media_unittests under valgrind stops complaining about leaked memory in PipelineStatusNotification's tests.
TBR=acolwell
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PipelineError was a poor naming choice because most of the time variables of
that type held the value PIPELINE_OK meaning there was in fact no error.
Replaced the idiom of [0-ary callback + GetError()] with
[1-ary callback taking PipelineStatus argument] which makes the Pipeline API
cleaner and less error-prone. Before, consumers of the API had to make sure to
call GetError() at the top of each callback, or risk missing state transitions
in the pipeline. Now each callback gets an explicit parameter holding the
pipeline status at the moment the callback was invoked so failing to handle
error conditions should be more apparent in the code.
BUG=none
TEST=media_unittests + trybots: {mac,linux,win}{_layout,}, linux_rel, linux_clang (all pass or fail with unrelated errors)
Review URL: http://codereview.chromium.org/6686061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PipelineImpl no longer knows about DataSources, with DemuxerFactory taking a
DataSourceFactory when appropriate (i.e. for FFmpegDemuxerFactory).
This diff is relative to patchset 8 of issue 6480050, which must be submitted
first.
BUG=none
TEST=media_unittests pass; chrome plays videos; trybots passed: mac,linux,linux_clang,win_layout; trybots with only unrelated-looking failures: win,{mac,linux}_layout
Review URL: http://codereview.chromium.org/6648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72485
TEST=None for now. Existing unit tests cover this code.
Review URL: http://codereview.chromium.org/6480050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6686011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First step of many towards removing DemuxerStream::QueryInterface, AVStreamProvider, and MediaFormat.
This time without memory leaks!
BUG=28206
TEST=media_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This frequently fails in various builders because the machines may be overloaded
when the tests run, so I see no point in such a timing test.
BUG=49497
TEST=none
Review URL: http://codereview.chromium.org/6673022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change seems to have caused Linux Heapcheck bot redness.
http://build.chromium.org/p/chromium.memory/builders/Linux%20Heapcheck/builds/4846
First step of many towards removing DemuxerStream::QueryInterface, AVStreamProvider, and MediaFormat.
BUG=28206
TEST=media_unittests
Review URL: http://codereview.chromium.org/6624062
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/6665020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
First step of many towards removing DemuxerStream::QueryInterface, AVStreamProvider, and MediaFormat.
BUG=28206
TEST=media_unittests
Review URL: http://codereview.chromium.org/6624062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was one of the first things I checked into Chromium and I've been wanting to remove it for a long, long time now.
BUG=28206
TEST=media_unittests
Review URL: http://codereview.chromium.org/6623087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Updated unit tests as well.
BUG=none
TEST=media_unittests
Review URL: http://codereview.chromium.org/6624068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were using a mix of both (and sometimes even static functions *inside* anonymous namespaces!) so we decided to stick to using static.
Also moved static/test code into media namespace and removed media:: prefixes.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6628020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=carnitas
TEST=compiles
Review URL: http://codereview.chromium.org/6609008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6624022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=media_unittests --gtest_filter=ClockTest.*
Review URL: http://codereview.chromium.org/6609035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used in a future CL by the speech input feature.
BUG=69886
TEST=none
Review URL: http://codereview.chromium.org/6602012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, set expectations for statistics callback mock in unittests the lack of which caused "uninteresting calls" turds in the mock output. This mock was introduced in the original patch for media statistics (http://codereview.chromium.org/6246091/).
BUG=71255, 73464
TEST=media_unittests
Review URL: http://codereview.chromium.org/6549030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A tool for using tiles to render an image.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6542045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously tests had to manually call MockFFmpeg::set() during test setup and teardown. Now that operation is handled automatically via scoping.
BUG=72933
TEST=media_unittests
Review URL: http://codereview.chromium.org/6539021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously tests had to manually call MockFFmpeg::set() during test setup and teardown. Now that operation is handled automatically via scoping.
BUG=72933
TEST=media_unittests
Review URL: http://codereview.chromium.org/6539021
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/6541037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previously tests had to manually call MockFFmpeg::set() during test setup and teardown. Now that operation is handled automatically via scoping.
BUG=72933
TEST=media_unittests
Review URL: http://codereview.chromium.org/6539021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6532008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch by sjl@chromium.org:
http://codereview.chromium.org/6519024/
BUG=73132
TEST=media_unittests under heapcheck and valgrind to make sure the new leak has gone.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize() could acquire lock_ and launch a new thread_ while Stop() had
un-lock_'d and was joining the old thread. If that happened then Stop() would
silently leak the new thread when it re-acquired lock_ and set thread_ to NULL.
This also removes a cheap but unnecessary lock/unlock pair and clarifies the
function a bit.
Tested: built & ran media_unittests.
Patch by fischman@chromium.org:
http://codereview.chromium.org/6531012/
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- s/scoped_ptr/scoped_array/ for new[]'d memory; this fixes a bug valgrind found
and which can cause memory corruption (as delete was being called instead of
delete[] before, which can confuse the allocator).
- Fix memory leak where AlsaPcmInputStreams would fail to be deleted.
Patch by fischman@chromium.org:
http://codereview.chromium.org/6523027/
BUG=none
TEST=valgrind media_unittests stops complaining about leaking the AIS and using delete instead of delete[].
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements the chromium side of the webkit media statistics
feature.
A followup cl (in webkit) will wire the two sides together.
Patch by sjl@chromium.org:
http://codereview.chromium.org/6246091/
BUG=71255
TEST=media_unittests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I discovered there's average and shuffle instructions which simplify the
calculations of UV components. Also the extract instruction was very useful.
In terms of the algorithm I rearranged the memory reads to be sequential.
Overall this gives about 10% improvement on 64-bits machine.
On 32-bits machine this gives 20% improvement. If compiled as 32-bits code this is
quite slow compared to 64-bits, about 2x slow down. So working on MMX code will
be a direction for improvement.
BUG=None
TEST=I tried it, it looks right.
Review URL: http://codereview.chromium.org/6488014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6473021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6487024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashes on Windows in release.
BUG=72718
TEST=none
Review URL: http://codereview.chromium.org/6489032
TBR=maruel@chromium.org
Review URL: http://codereview.chromium.org/6513007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Exclude test cases on windows.
BUG=72790
TEST=Windows bots are green
Review URL: http://codereview.chromium.org/6507013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to see if it fixes the gmock crashes we've been seeing since the
change has been made.
The original change was split between r74660, r74168, r74059
Review URL: http://codereview.chromium.org/6473006
TBR=nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to see if it fixes the gmock crashes we've been seeing since the
change has been made.
The original change was split between r74660, r74168, r74059
Review URL: http://codereview.chromium.org/6473006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the SSE2 block differ code back in.
TBR=dhollowa
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6501005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6485015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Real bugs:
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:310:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::HttpProxyClientSocketPool>' requested here
CaptureGroupNameHttpProxySocketPool::CaptureGroupNameSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:10:
./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:316:1: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SSLClientSocketPool>' requested here
CaptureGroupNameSSLSocketPool::CaptureGroupNameSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:12:
./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:5511:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::TCPClientSocketPool>' requested here
new CaptureGroupNameTCPSocketPool(NULL, NULL);
^
In file included from ./net/socket/socket_test_util.h:34:
./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:273:16:error: 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_network_transaction_unittest.cc:5630:13: note: in instantiation of template class 'net::CaptureGroupNameSocketPool<net::SOCKSClientSocketPool>' requested here
new CaptureGroupNameSOCKSSocketPool(NULL, NULL);
^
In file included from ./net/http/http_network_session_peer.h:11:
./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
CXX(target) out/Debug/obj.target/net_unittests/net/http/http_response_body_drainer_unittest.o
4 errors generated.
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:170:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::HttpProxyClientSocketPool>' requested here
CapturePreconnectsHttpProxySocketPool::CapturePreconnectsSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:10:
./net/http/http_proxy_client_socket_pool.h:200:16: note: hidden overloaded virtual function 'net::HttpProxyClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:176:1: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SSLClientSocketPool>' requested here
CapturePreconnectsSSLSocketPool::CapturePreconnectsSocketPool(
^
In file included from ./net/http/http_network_session_peer.h:12:
./net/socket/ssl_client_socket_pool.h:208:16: note: hidden overloaded virtual function 'net::SSLClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:188:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::TCPClientSocketPool>' requested here
new CapturePreconnectsTCPSocketPool(
^
In file included from ./net/socket/socket_test_util.h:34:
./net/socket/tcp_client_socket_pool.h:134:16: note: hidden overloaded virtual function 'net::TCPClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:126:16:error: 'net::<anonymous namespace>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>::ReleaseSocket' hides overloaded virtual function [-Woverloaded-virtual]
virtual void ReleaseSocket(const std::string& group_name,
^
net/http/http_stream_factory_unittest.cc:237:13: note: in instantiation of template class 'net::<anonymous>::CapturePreconnectsSocketPool<net::SOCKSClientSocketPool>' requested here
new CapturePreconnectsSOCKSSocketPool(
^
In file included from net/http/http_stream_factory_unittest.cc:17:
In file included from ./net/http/http_network_session_peer.h:11:
./net/socket/socks_client_socket_pool.h:133:16: note: hidden overloaded virtual function 'net::SOCKSClientSocketPool::ReleaseSocket' declared here
virtual void ReleaseSocket(const std::string& group_name,
^
CXX(target) out/Debug/obj.target/net_unittests/net/http/http_vary_data_unittest.o
4 errors generated.
make: *** [out/Debug/obj.target/net_unittests/net/http/http_stream_factory_unittest.o] Error 1
media/audio/linux/alsa_output_unittest.cc:83:3:error: 'MockAudioManagerLinux::MakeAudioInputStream' hides overloaded virtual function [-Woverloaded-virtual]
MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*(
^
In file included from media/audio/linux/alsa_output_unittest.cc:12:
In file included from ./testing/gmock/include/gmock/gmock.h:61:
testing/gmock/include/gmock/gmock-generated-function-mockers.h:632:28: note: instantiated from:
^
media/audio/linux/alsa_output_unittest.cc:83:3: note: instantiated from:
MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*(
^
media/audio/linux/alsa_output_unittest.cc:83:16: note: instantiated from:
MOCK_METHOD5(MakeAudioInputStream, AudioInputStream*(
^
In file included from media/audio/linux/alsa_output_unittest.cc:9:
./media/audio/linux/audio_manager_linux.h:30:29: note: hidden overloaded virtual function 'AudioManagerLinux::MakeAudioInputStream' declared here
virtual AudioInputStream* MakeAudioInputStream(AudioParameters params);
^
CXX(target) out/Debug/obj.target/media_unittests/media/base/data_buffer_unittest.o
CXX(target) out/Debug/obj.target/media_unittests/media/base/djb2_unittest.o
1 error generated.
No bug, just confusing:
In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5:
./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual]
void HandleEvent(int event_index);
^
In file included from webkit/plugins/npapi/test/plugin_schedule_timer_test.cc:5:
In file included from ./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:9:
./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here
virtual int16 HandleEvent(void* event);
^
1 error generated.
make: *** [out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_schedule_timer_test.o] Error 1
CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_private_test.o
CXX(target) out/Debug/obj.target/npapi_test_plugin/webkit/plugins/npapi/test/plugin_test_factory.o
In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:17:
./webkit/plugins/npapi/test/plugin_schedule_timer_test.h:59:8:error: 'NPAPIClient::ScheduleTimerTest::HandleEvent' hides overloaded virtual function [-Woverloaded-virtual]
void HandleEvent(int event_index);
^
In file included from webkit/plugins/npapi/test/plugin_test_factory.cc:7:
In file included from ./webkit/plugins/npapi/test/plugin_arguments_test.h:8:
./webkit/plugins/npapi/test/plugin_test.h:43:19: note: hidden overloaded virtual function 'NPAPIClient::PluginTest::HandleEvent' declared here
virtual int16 HandleEvent(void* event);
^
1 error generated.
BUG=72205
TEST=none
Review URL: http://codereview.chromium.org/6503001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
A number of Windows bots have gone red in media_tests on the waterfall:
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%281%29
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%281%29/builds/501/steps/media_unittests/logs/stdio
This seems to be related to r74571. So am reverting to see.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/6502002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in release.
BUG=72718
TEST=none
Review URL: http://codereview.chromium.org/6489032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Quick test to see if it is the cause of crashes in media_unittests)
(Test showed this CL is not to blame)
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/6488023
TBR=finnur@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Quick test to see if it is the cause of crashes in media_unittests)
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/6488023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72577
TEST=None
Review URL: http://codereview.chromium.org/6487008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=disables crashing test
BUG=49497
Review URL: http://codereview.chromium.org/6480012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6413036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74168 0039d316-1c4b-4281-b951-d872f2087c98
|