| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove RunLoop::Run/Quit usage throughout examples/tests.
Add ApplicationImpl::WaitForInitialize for App init.
Use WaitForIncomingMethodCall in other cases.
Add a simple test of direct InterfaceImpl interaction.
Expose ExampleClientImpl::Pong. Minor related cleanup.
TODO: Destroy the ambient RunLoop before running tests.
BUG=392646
TEST=mojo_example_apptests passes (previously crashed)
R=viettrungluu@chromium.org,davemoore@chromium.org
Review URL: https://codereview.chromium.org/561013002
Cr-Commit-Position: refs/heads/master@{#298559}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't remove SetContents yet. There is one consumer that needs to
converted. I'll do that separately.
BUG=none
TEST=none
R=ben@chromium.org, jamesr@chromium.org
Review URL: https://codereview.chromium.org/618073005
Cr-Commit-Position: refs/heads/master@{#298546}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mojo::Get() is too easy to conflict with.
BUG=none
TEST=none
R=davemoore@chromium.org
TBR=keybuk@chromium.org
Review URL: https://codereview.chromium.org/629523003
Cr-Commit-Position: refs/heads/master@{#298288}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command buffer mojom is used as part of the public service
interfaces of various things. It should live in m/s/public. It is not
intended to be used directly, it's intended to be used with the help
of a client lib, but that's true of other interfaces as well.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/628843002
Cr-Commit-Position: refs/heads/master@{#298193}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Applications can retrieve the configuration arguments with the ApplicationImpl args() method (see https://codereview.chromium.org/568173003).
A Mojo application can be specified with a URL followed by one or more arguments, so long as the entire expression is within quotes:
mojo_shell 'mojo://mojo_wget http://www.google.com'
The "args-for" switch can be used to specify arguments for Mojo applications that are started by the specified app:
mojo_shell args-for='mojo:mojo_native_viewport_service foo bar' mojo:mojo_surfaces_app
The args-for switch can be used repeatedly to specify arguments for multiple Mojo apps.
BUG=418797
Review URL: https://codereview.chromium.org/617943002
Cr-Commit-Position: refs/heads/master@{#297924}
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: https://codereview.chromium.org/623573002
Cr-Commit-Position: refs/heads/master@{#297703}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As an experiment some time ago, I added a mechanism to allow
mojo_shell to connect to apps over DBus. We went in a different
direction, so this code is not needed.
BUG=None
TEST=build with gyp and gn
R=jamesr
Review URL: https://codereview.chromium.org/619123002
Cr-Commit-Position: refs/heads/master@{#297694}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- surfaces_app:bindings needs to explicitly depend on :surface_id
as it refers to it in child.mojom
- the dependencies on gles2:bindings seem redundant
BUG=417289
Review URL: https://codereview.chromium.org/613133002
Cr-Commit-Position: refs/heads/master@{#297647}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. MoveToFront/Back triggered a DCHECK. Made them early out if view
already in position.
. Called WindowManagerApp::InitFocus so that we don't crash when
WM::SetFocus is called.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/615233003
Cr-Commit-Position: refs/heads/master@{#297559}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep MOJO_OVERRIDE around very temporarily, since there are a few users
of it outside of mojo/.
(The change was clang-format'ed.)
R=sky@chromium.org
Review URL: https://codereview.chromium.org/617503003
Cr-Commit-Position: refs/heads/master@{#297252}
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/599213002
Cr-Commit-Position: refs/heads/master@{#297245}
|
|
|
|
|
|
|
|
|
|
|
|
| |
And replaces with a callback. Also renames SetBounds to SetSize.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/607233002
Cr-Commit-Position: refs/heads/master@{#297187}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On the Blink side:
The clamping method used by computeScaleAndScrollForBlockRect now
uses a new method PinchViewport::clampDocumentOffsetAtScale to clamp
the requested viewport offset taking into account the inner and outer
viewports.
Also added an overload of applyViewportDeltas, called in virtual
viewport mode only, that applies the inner and outer deltas along
page scale in one shot. This makes the viewport layers a special case
again in that their scroll offsets are set through this call, rather
than the standard 'did_scroll' callback of most layers. This is needed
since the scroll offsets may be invalid until the page scale is
applied so this is handled in one method to prevent unintended
clamping.
On the Compositor side:
Calls the appropriate applyViewportDeltas based on which pinch mode
we're running in. The page scale animation now prefers to scroll the
inner viewport first, scrolling the outer only when the inner has
reached its scroll extent.
Blink-side: https://codereview.chromium.org/584833003
BUG=364106
Review URL: https://codereview.chromium.org/585063002
Cr-Commit-Position: refs/heads/master@{#297167}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts the gles2 thunks target in a more reasonable location, stops abusing
static_library to hide dependency issues, and stop the view manager client side
library from pretending to know which sort of gles2 to link against. It uses
the gles2 headers but depending on whether the lib is being linked into an
application or linked into a target that links in the shell lib (as is done in
unit tests) it needs a different implementation. This also deletes the unused
//mojo/public/gles2/gles2_interface.h file - if we want this we can pull it
back but since nobody is using it now it's kind of a waste of space. If we do
want it, it should go in //mojo/public/cpp/gles2 since it's a C++ wrapper.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/604223002
Cr-Commit-Position: refs/heads/master@{#297040}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes up various dependency bugs that prevent mojo_demo_launcher +
mojo_html_viewer from working.
Once we are gn check clean this should be easy to enforce with a script,
but for now it's manual testing.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/608023002
Cr-Commit-Position: refs/heads/master@{#297023}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of making Android CompositorImpl use cc's scheduler and not
post its own composite calls manually, cc needs to be able to handle
asynchronous output surface creation.
This change modifies CreateOutputSurface to instead be
RequestNewOutputSurface, which the LayerTreeHostClient must respond to
and call SetOutputSurface on the host with the new output surface once
it is ready.
Because the LayerTreeHostClient must now talk to the host as a part of
output surface creation, a bunch of unit test code needed to be
refactored to handle this.
BUG=none
Review URL: https://codereview.chromium.org/348093004
Cr-Commit-Position: refs/heads/master@{#296780}
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=aa@chromium.org
Review URL: https://codereview.chromium.org/600153002
Cr-Commit-Position: refs/heads/master@{#296542}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it so that the plugin can not use blocking completion callbacks while servicing HandleBlockingMessage. This is to discourage leaving JavaScript hung while doing long-running things (e.g. file IO).
(Of course, the plugin can get around this by bouncing to another thread; but I think this adds a useful guideline/deterrent.)
BUG=415351
Review URL: https://codereview.chromium.org/600553002
Cr-Commit-Position: refs/heads/master@{#296422}
|
|
|
|
|
|
|
|
|
|
|
| |
ViewManager::Embed() to offer the same API exposed via View::Embed()
R=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/591633002
Cr-Commit-Position: refs/heads/master@{#296087}
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid a crash caused by dereferencing an iterator after
erasing it.
BUG=415816
Review URL: https://codereview.chromium.org/580353002
Cr-Commit-Position: refs/heads/master@{#295718}
|
|
|
|
|
|
|
|
|
|
| |
Also, remove myself from a bunch of other stuff I'm no longer involved in (search/instant, pepper, bookmarks)
TBR=jam
Review URL: https://codereview.chromium.org/573333003
Cr-Commit-Position: refs/heads/master@{#295399}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PNaCl ABI does not work in general with passing structs by-value.
Rather than add more complication to the shim, this changes
HandleBlockingMessage's parameter to a const-pointer param, and the return
to an out-param by pointer.
Note I wanted to pass PP_Var by const-pointer, while its "default" is
by value. So I added a new "constptr_in" param style.
(Maybe I should invert that and add a byvalue instead?)
Verified backwards compat with manual testing.
BUG=384539
R=asvitkine@chromium.org, binji@chromium.org, teravest@chromium.org
Review URL: https://codereview.chromium.org/564573002
Cr-Commit-Position: refs/heads/master@{#295341}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many targets in mojo need to depend on different targets depending on if
they are building in the static or component build. In gyp, this is done
with variables (since that's the only thing you have) and the GN build
initially copied these variables into //mojo/system.gni. This worked, but
is not very idomatic in GN. This replaces the variables with groups that
forward to the correct depenedency depending on the build type and
target type (encoded in the target name).
R=brettw@chromium.org, viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/554363005
Cr-Commit-Position: refs/heads/master@{#295137}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gles2_interface.h defines a pure virtual interface; targets which use it should
depend on it, but not necessarily on an implementation target. Consequently,
a //gpu/command_buffer/client:gles2_interface target was created to reflect the
dependency on this interface without linking a particular implementation.
This resolves an issue with //cc trying to use this header without having a
dependency on a target which includes it.
Review URL: https://codereview.chromium.org/464153002
Cr-Commit-Position: refs/heads/master@{#294956}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DisplayManager wasn't handling multiply nested things correctly and the
client library wasn't handling uploading to multiple views from the same
application. This fixes those. There's still some z-ordering issues that
show up pretty visibly. This hacks up texture alpha so you can see
partially through views to try to debug.
BUG=
Review URL: https://codereview.chromium.org/555953007
Cr-Commit-Position: refs/heads/master@{#294866}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds GN rules for everything in mojo except for python bindings
targets and the android packaging rules. The group //mojo builds all
targets in the subdir, just like the gyp 'mojo' target.
R=brettw@chromium.org
TBR=acolwell@chromium.org for //media/build/BUILD.gn
Review URL: https://codereview.chromium.org/563953003
Cr-Commit-Position: refs/heads/master@{#294788}
|
|
|
|
|
|
|
|
|
| |
We shouldn't have dependencies on chromium types and whatnot in
mojo/public/
Review URL: https://codereview.chromium.org/565323002
Cr-Commit-Position: refs/heads/master@{#294725}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes:
. a bug in NVVM where the WTH is reset. It's also reset by the NWA it subclasses, resulting in a UAF.
. needed some more schedulepaints in display manager to handle the window being removed. I am running into what looks like a bug/misunderstanding w/schedule paint, but I decided not to worry about it since this code is getting blown up once james lands.
R=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/549883003
Cr-Commit-Position: refs/heads/master@{#294528}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This converts the view manager protocol over to specify view contents via
surfaces instead of shuffling a bitmap. To ease the transition, this provides a
wrapper in the client library that accepts an SkBitmap and uploads it into a
texture wrapped in a surface so existing code still works. Next I'll port the
clients over to providing surfaces themselves and remove this shim.
BUG=
Review URL: https://codereview.chromium.org/534843002
Cr-Commit-Position: refs/heads/master@{#294501}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/549273002
Cr-Commit-Position: refs/heads/master@{#294342}
|
|
|
|
|
|
|
|
|
|
| |
together, it may cause memory leak, and then run out of memory. The problem is because the Compositor API uses sync point to sync texture producer and the Chrome compositor, it does not need any IPC, so the PpapiCommandBufferProxy::last_state_[1] will not get updated, so the client does not known when the GPU process finishes accessing the memory, and then the memory can not be reused forever. This change add a shared state in PpapiCommandBufferProxy. It allows PpapiCommandBufferProxy updating state from a shared memory without an IPC. It fix this issue.
BUG=411004
Review URL: https://codereview.chromium.org/547733002
Cr-Commit-Position: refs/heads/master@{#294012}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added all the plumbing to make Blink aware of the top controls position
and how its viewport has been resized as a result. This CL adds all the
machinery and plumbing but does not yet connect main-thread scrolls to
the top controls. This is needed to support scrolling the top controls
during slow-scrolls as well as correct viewport behavior in the virtual
viewport pinch-to-zoom.
The machinery for top controls now includes two values:
top_controls_layout_height: The amount that the viewport was shrunk to
accommodate the top controls. This is updated only during a layout that
causes a viewport resize (i.e. RenderWidget::OnResize). The compositor
needs this to know how much the viewport layer has already been resized
by Blink.
top_controls_content_offset: The amount that the top controls are showing.
This will be the same as top_controls_layout_height right after a viewport
resize, but will diverge since the top controls will move without
immediately causing a RenderWidget resize.
Blink now keeps track of the top controls "content offset", which is the
distance the content is offset from the top of the screen due to top
controls. It receives updates to this value from the Impl thread during
a commit and echos them back to the compositor.
On the compositor side, the top controls layout height is moved into the
LayerTreeImpl. This is necessary since a commit will change the viewport
layer's size on the pending tree. Keeping it in LayerTreeHostImpl meant
that, until the pending tree was activated, the top controls layout height
corresponded to the viewport bounds in the pending tree. This was causing
flickering as the viewport container was the incorrect size for a short
time. The compositor also keeps track of the top controls content offset
value. The top controls offset uses the same model as page scale, keeping
an offset (the value as known by the main thread), a delta from the main
thread's value, and a sent_delta to keep track of what has been sent to
the main thread.
See https://codereview.chromium.org/513053003 for Blink-side patch.
BUG=333143
Review URL: https://codereview.chromium.org/511253003
Cr-Commit-Position: refs/heads/master@{#294003}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support CDM_6, make the following changes:
- add SetServerCertificate
- add GetUsableKeyIds
- rename ReleaseSession to CloseSession
- add RemoveSession
- add SessionKeysChange event
- add SessionExpirationChange event
Includes changes to cdm_adapter for the new functionality. Changes to
use these new interfaces in blink in a future CL.
BUG=358271
TEST=existing EME tests still pass + manual testing
Review URL: https://codereview.chromium.org/496143002
Cr-Commit-Position: refs/heads/master@{#293672}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/537843002
Cr-Commit-Position: refs/heads/master@{#293469}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This required ripping out the old concept of app navigation,
since it is no longer compatible with how apps get connected
to.
BUG=
Review URL: https://codereview.chromium.org/514063003
Cr-Commit-Position: refs/heads/master@{#293452}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These ended up having different bugs in different apps. In the
mojo_sample_app, we didn't pass a glResizeCHROMIUM() call on resize. In
mojo_demo_launcher, we weren't plumbing events from the aura window
hierarchy to the ServerView correctly.
BUG=393244
Review URL: https://codereview.chromium.org/536153002
Cr-Commit-Position: refs/heads/master@{#293378}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert method.
Also added a ConvertTo<X> helper function.
Also changed it from class to struct, since every method was public.
BUG=406492
Review URL: https://codereview.chromium.org/507173003
Cr-Commit-Position: refs/heads/master@{#293027}
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/533933002
Cr-Commit-Position: refs/heads/master@{#293026}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. ICU may be initialized twice: once by the test suite, secondly by
the app.
. window_mamanger_app_.host_ may be deleted by the time we get to the
destructor to try and remove something. Add check for this.
BUG=none
TEST=none
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/516523004
Cr-Commit-Position: refs/heads/master@{#292929}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This teaches the native viewport service to accept a surface id from its
client and draw it into the native viewport. This won't work if the
client also tries to bind an onscreen context to the native viewport's
view id, so the surface initialization is lazy and only happens when
the client specifies a surface id. If a client does both it'll blow up.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/510553002
Cr-Commit-Position: refs/heads/master@{#292548}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. URLLoaders can't be reused, so we need to construct one
per-load. This became too gnarly to handle with callbacks
so I put it back to having a loader object that owns the
URLLoader.
2. The relevant URLLoader needs to be passed to
ContentHandler::OnConnect() so that it stays alive long
enough to read the entire response.
BUG=
Review URL: https://codereview.chromium.org/513573002
Cr-Commit-Position: refs/heads/master@{#292460}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While looking at mojom files I'm nominally the owner of, I realized
that one had become redundant. So, I just deleted it and checked the
other to make sure it had the right 'nullability' on the method args.
Also moved around code to build against the de-duped mojom file.
BUG=407673
TEST=build with gyp and gn
Review URL: https://codereview.chromium.org/503363004
Cr-Commit-Position: refs/heads/master@{#292054}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The purpose is to make those APIs have the same semantics as before. And
then we can selectively turn fields into non-nullable.
Mojom files that are not included in this change:
- surface-related files: the owner (jamesr) has landed some non-nullable
fixes. It is possible that he has fully reviewed them. (I will confirm
with him.)
- test files: have been examined.
BUG=324170
TEST=None
Review URL: https://codereview.chromium.org/502853002
Cr-Commit-Position: refs/heads/master@{#291862}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/502573006
Cr-Commit-Position: refs/heads/master@{#291766}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides a SurfacesService that can provide SurfacePtr and id
namespaces in one call, since both are needed to do anything useful. This
also updates the mojo/cc/ bindings to get closer to binding a cc using
client (like html_viewer) with surfaces, although it's not 100% there.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/504443002
Cr-Commit-Position: refs/heads/master@{#291759}
|
|
|
|
|
|
|
|
| |
It broke in r291039.
Review URL: https://codereview.chromium.org/500593002
Cr-Commit-Position: refs/heads/master@{#291710}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move RenderPass::Id out of RenderPass and make it an isolated class
called RenderPassId, so RenderPassDrawQuad and AppendQuadsData will not
need to depend on entire RenderPass class.
BUG=344962
Review URL: https://codereview.chromium.org/404563005
Cr-Commit-Position: refs/heads/master@{#291403}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Adds ApplicationRunner{Chromium} to house common code.
* Makes 'application_{chromium, standalone}' target depend on the appropriate
environment target. Since application_{c,s} house different Runner types
altogether, linking against the wrong application lib would yield unresolved
externals. linking against a {wrong} environment lib would now result in
duplicately defined symbols. So these changes help crbug.com/334543.
BUG=334543
Review URL: https://codereview.chromium.org/441853002
Cr-Commit-Position: refs/heads/master@{#291039}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=danakj@chromium.org for DEPS file shuffle that moves a "+ui/gfx"
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290157
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290431
Review URL: https://codereview.chromium.org/451753003
Cr-Commit-Position: refs/heads/master@{#290859}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes mojo_shell, mojo_shell_tests and the wget, sample_app and
surfaces_app samples work along with their dependent services.
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/485523004
Cr-Commit-Position: refs/heads/master@{#290689}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290689 0039d316-1c4b-4281-b951-d872f2087c98
|