| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=None
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1410053006
Cr-Commit-Position: refs/heads/master@{#359461}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL move //mojo/public and //mojo/edk to live in the following locations:
- //third_party/mojo/src/mojo/public
- //third_party/mojo/src/mojo/edk
It moves the related gypfiles from //mojo to //third_party/mojo and updates
them as necessary to account for the file moves. It also updates clients of the
mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK
and EDK build systems are maintained in the Mojo repo and designed to be
flexible wrt the location of the SDK/EDK in a client repo, so no changes are
needed.
This CL does not update include paths to the code being moved to limit the
number of moving parts, instead relying on the include_dirs that the SDK and
EDK targets supply to their direct dependents to ensure that include paths
continue to resolve correctly.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/814543006
Cr-Commit-Position: refs/heads/master@{#312129}
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=jamesr@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/830593003
Cr-Commit-Position: refs/heads/master@{#311784}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes diff from comment #6 at
https://codereview.chromium.org/803173009
BUG=None
TBR=darin@chromium.org
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/835253002
Cr-Commit-Position: refs/heads/master@{#310049}
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=jamesr@chromium.org
TBR=jbudorick@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/795593004
Cr-Commit-Position: refs/heads/master@{#309785}
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=jamesr@chromium.org for mojo
Review URL: https://codereview.chromium.org/799113004
Cr-Commit-Position: refs/heads/master@{#308479}
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=digit@chromium.org for ashmem dep
TBR=darin@chromium.org for toplevel
Review URL: https://codereview.chromium.org/782693004
Cr-Commit-Position: refs/heads/master@{#307427}
|
|
|
|
|
|
|
|
|
|
| |
BUG=435144
TBR=jamesr@chromium.org
TBR=dalecurtis@chromium.org for media test update
Review URL: https://codereview.chromium.org/769753003
Cr-Commit-Position: refs/heads/master@{#306367}
|
|
|
|
|
|
|
|
| |
BUG=433814
Review URL: https://codereview.chromium.org/748113004
Cr-Commit-Position: refs/heads/master@{#305339}
|
|
|
|
|
|
|
|
|
|
|
| |
Most changes are updates to the mojom syntax for modules.
R=viettrungluu@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/698883005
Cr-Commit-Position: refs/heads/master@{#302542}
|
|
|
|
|
|
|
|
|
|
| |
This relands https://codereview.chromium.org/683583002/
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/695583002
Cr-Commit-Position: refs/heads/master@{#302203}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #6 id:120001 of https://codereview.chromium.org/683583002/)
Reason for revert:
Suspected to cause android bot failures:
New warnings.
Please fix, or perhaps add to /b/build/slave/Android_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt
--------------------------------------------------------------------------------
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.imported.ImportedInterface_Internal$ImportedInterfaceDoSomethingParams.equals(Object) At ImportedInterface_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.math.Calculator_Internal$CalculatorClearParams.equals(Object) At Calculator_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.mojo.IntegrationTestInterface2_Internal$IntegrationTestInterface2Method0Params.equals(Object) At IntegrationTestInterface2_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.EmptyStruct.equals(Object) At EmptyStruct.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.sample.NamedObject_Internal$NamedObjectGetNameParams.equals(Object) At NamedObject_Internal.java
M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.test_structs.EmptyStruct.equals(Object) At EmptyStruct.java
--------------------------------------------------------------------------------
*** 9 FindBugs warnings! ***
*** 9: new ***
Original issue's description:
> Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444
>
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/37273cab357d03ad9d2bcfa4ae467567ce93e2c4
> Cr-Commit-Position: refs/heads/master@{#302038}
TBR=jamesr@chromium.org,aa@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/694463002
Cr-Commit-Position: refs/heads/master@{#302066}
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/683583002
Cr-Commit-Position: refs/heads/master@{#302038}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the following directories:
mojo/public
mojo/edk
mojo/services/public
from the mojo repository's master branch at commit
3b54eded8dadb36548934c09c5100e9e645ec328, plus git cl format
for a few cpp files that weren't formatted in mojo land.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/672693003
Cr-Commit-Position: refs/heads/master@{#300922}
|
|
|
|
|
|
|
|
|
|
| |
Currently there's only a limited test for the new type. More complete testing to come in a followup patch.
BUG=423017
Review URL: https://codereview.chromium.org/654843005
Cr-Commit-Position: refs/heads/master@{#299992}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, types like the following are allowed:
- array<array<int8, 1>, 2>
- array<array<int8, 1>>
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/644033002
Cr-Commit-Position: refs/heads/master@{#299721}
|
|
|
|
|
|
|
|
|
|
|
| |
This fix the C++ and python generation to allow circular dependencies
between structs.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/622593002
Cr-Commit-Position: refs/heads/master@{#299079}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an incremental step towards the goals listed in crbug.com/419160
The Mojo JS bindings now export an object for each interface. The object itemizes the interface values needed at runtime. Here's an example:
exports.Service = {
name: 'sample::Service',
proxyClass: ServiceProxy,
stubClass: ServiceStub,
validateRequest: validateServiceRequest,
validateResponse: null,
};
I've removed the individual exports of the proxy and stub class names as well as the interface "NAME_" property that was added to proxy and stub classes.
When possible, the object for an interface's client is added. For example:
exports.Service.client = exports.ServiceClient;
The next step (next patch) will automatically create a stub client object that delegates to a user supplied object.
BUG=419160
Review URL: https://codereview.chromium.org/628763002
Cr-Commit-Position: refs/heads/master@{#298509}
|
|
|
|
|
|
|
|
|
|
| |
This makes precedence clearer in the case of nested arrays.
BUG=none
Review URL: https://codereview.chromium.org/610983003
Cr-Commit-Position: refs/heads/master@{#297989}
|
|
|
|
|
|
|
|
|
|
|
| |
Fix issue with method with empty response.
Fix issue with local variable shadowing user parameters.
R=ppi@chromium.org
Review URL: https://codereview.chromium.org/607933002
Cr-Commit-Position: refs/heads/master@{#297176}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The big changes here are:
1) Allow injecting of a target toolchain via args for os==chromeos.
2) For ARM builds, allow injecting -mtune and -mfloat-abi settings.
3) Allow injecting a pkg-config wrapper that correctly handles the
CrOS build environment. This is how pkg-config is handled for
all other packages in the build.
4) Create libmojo_sdk target, a static library of public Mojo code
suitable for distribution.
5) Added testonly = true to a few targets under mojo/ that are not
meant to be used in production.
BUG=388412
TEST=Create a target that builds //mojo/public, build with os==chromeos
Review URL: https://codereview.chromium.org/549453004
Cr-Commit-Position: refs/heads/master@{#296849}
|
|
|
|
|
|
|
|
|
|
| |
fields whose type is string? should be initialized to null, not "".
BUG=417039
Review URL: https://codereview.chromium.org/605443002
Cr-Commit-Position: refs/heads/master@{#296612}
|
|
|
|
|
|
|
|
| |
R=pkl@chromium.org,cmasone@chromium.org
Review URL: https://codereview.chromium.org/545433002
Cr-Commit-Position: refs/heads/master@{#294144}
|
|
|
|
|
|
|
|
|
|
| |
Also move backward compatibility test into its own suite, as backward compatibility is implemented in Java and the test is passing.
R=ppi@chromium.org
Review URL: https://codereview.chromium.org/522353003
Cr-Commit-Position: refs/heads/master@{#293282}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds nullability validation of handles and
pointers upon struct serialization in the Java bindings.
BUG=324170
Review URL: https://codereview.chromium.org/524703004
Cr-Commit-Position: refs/heads/master@{#293120}
|
|
|
|
|
|
|
|
|
|
| |
With this change, it is possible to assign INFINITY, NEGATIVE_INFINITY or NAN as a default value for any double or float field.
BUG=402216
Review URL: https://codereview.chromium.org/474063002
Cr-Commit-Position: refs/heads/master@{#291864}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The JS bindings generator maps '.mojom' files - not Mojo
modules - to JS modules. Struct names that can be used
without qualification in separate '.mojom' files (because
both files specify the same Mojo module) must be JS-module
qualified in the JS bindings.
BUG=404788
Review URL: https://codereview.chromium.org/486203003
Cr-Commit-Position: refs/heads/master@{#290919}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=324170
TEST=All tests pass
Review URL: https://codereview.chromium.org/472083003
Cr-Commit-Position: refs/heads/master@{#290792}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL (1) handles the case that Array<>'s element number or total size exceeds what we can represent in Mojo messages; (2) makes the validation code of the num_bytes field doesn't rely on sizeof(size_t) > sizeof(uint32_t).
The newly-added test passes with/without this CL. But I think it is good to have such a test.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/486313004
Cr-Commit-Position: refs/heads/master@{#290718}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=404873
R=ppi@chromium.org
Review URL: https://codereview.chromium.org/484983003
Cr-Commit-Position: refs/heads/master@{#290579}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A fatal-level message is logged if:
- a fixed-size array has wrong number of elements;
- a non-nullable field is set to null (or invalid handle).
BUG=324170
TEST=SerializationWarningTest.*
Review URL: https://codereview.chromium.org/469393004
Cr-Commit-Position: refs/heads/master@{#290487}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL only turns on the non-nullable check for validation tests.
There will be separate CLs for:
- add DCHECK at the sending side.
- make the existing APIs pass the non-nullable check and turn on the check everywhere.
BUG=324170
TEST=New and revised validation tests.
Review URL: https://codereview.chromium.org/466613002
Cr-Commit-Position: refs/heads/master@{#290002}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=394186
Review URL: https://codereview.chromium.org/396063006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds U suffixes to literals for unsigned int types in C++. For
Java, because integer literals >= 2 ** 63 are not allowed, such values
are transformed to the equivalent 64 bit signed value.
BUG=375522
Review URL: https://codereview.chromium.org/397453004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change the following mojom input
enum Shape {
CIRCLE,
};
will generate the following C++:
enum Shape {
SHAPE_CIRCLE,
};
instead of
enum Shape {
CIRCLE,
};
This also changes expressions of the form Shape.SHAPE_CIRCLE to
Shape.CIRCLE in the Java and JS bindings.
BUG=343981
Review URL: https://codereview.chromium.org/389613007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=392693
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282555
Review URL: https://codereview.chromium.org/376383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert:
location: interface
org.chromium.mojo.bindings.test.mojom.imported.ImportedInterface
result.obj = decoder0.readServiceInterface(24,
org.chromium.mojo.bindings.test.mojom.imported.ImportedInterface.BUILDER);
^
../out/Release/java_mojo/mojo_public_test_interfaces/src/org/chromium/mojo/bindings/test/mojom/sample/Request.java:59:
cannot
find
symbol
> Mojo: Add support for InterfacePtr as a struct member
>
> BUG=392693
>
> Review URL: https://codereview.chromium.org/376383002
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/383083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=392693
Review URL: https://codereview.chromium.org/376383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=390949
Review URL: https://codereview.chromium.org/377713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Object has a special meaning in Java and Javascript.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/357683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces bindings for struct. It only generates fields and not
serialization/deserialization methods.
R=rmcilroy@chromium.org, viettrungluu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279677
Review URL: https://codereview.chromium.org/306893010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the Linux x64 build http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/66839/steps/compile/logs/stdio
> Generate java bindings for structs.
>
> This CL introduces bindings for struct. It only generates fields and not
> serialization/deserialization methods.
>
> R=rmcilroy@chromium.org, viettrungluu@chromium.org
>
> Review URL: https://codereview.chromium.org/306893010
TBR=qsr@chromium.org
Review URL: https://codereview.chromium.org/354833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces bindings for struct. It only generates fields and not
serialization/deserialization methods.
R=rmcilroy@chromium.org, viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/306893010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds support for the syntax:
typename[20] name;
in mojom files to specify an array of 'typename' containing exactly 20
entries. The serialization is the same as 'typename[] name' and the length
of the array is checked at message validation time.
This implementation does not support nested fixed arrays as in:
typename[3][4] name;
but does handle fixed size arrays inside structs, etc.
Review URL: https://codereview.chromium.org/340663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, we use wrong storage type for nested arrays. For example, the storage
type of the outer array of int8[][] is
StructPointer<Array_Data<int8_t>>. After this CL it will be
ArrayPointer<int8_t>.
The current code works because StructPointer happens to be of the same
size as ArrayPointer.
(The newly-added tests pass with/without this CL. But I think it is good
to have them.)
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/340223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/327323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests for encoded handles in Mojo messages will be in a separate CL, since the
input format needs to be extended to specify the number of handles with the
message data.
BUG=None
TEST=ValidationTest.Conformance
Review URL: https://codereview.chromium.org/324363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
conformance tests.
More conformance tests will come in a separate CL.
BUG=None
TEST=ValidationTest.*; ValidationIntegrationTest.*
R=darin@chromium.org
Review URL: https://codereview.chromium.org/322003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Previously, the namespace was omitted for interface and interface
request arguments imported from another module.
Review URL: https://codereview.chromium.org/332653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=darin@chromium.org
Review URL: https://codereview.chromium.org/318123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275831 0039d316-1c4b-4281-b951-d872f2087c98
|