| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/1216023006/)
Reason for revert:
This caused
../../third_party/mojo/src/mojo/public/cpp/system/tests/macros_unittest.cc(133,1)
: error: 'selectany' can only be applied to data items with external linkage
MOJO_STATIC_CONST_MEMBER_DEFINITION
^
../../third_party/mojo/src\mojo/public/cpp/system/macros.h(65,56) : note:
expanded from macro 'MOJO_STATIC_CONST_MEMBER_DEFINITION'
#define MOJO_STATIC_CONST_MEMBER_DEFINITION __declspec(selectany)
^
on the clang/win bots. This is caused by
https://github.com/domokit/mojo/commit/6fb90aaf1c21dfefc526a0e589d54cb59511322d
which uses MOJO_STATIC_CONST_MEMBER_DEFINITION in an unnamed namespace,
and declspec(selectany) doesn't have any effect on internal symbols. Since it requires
a deps change to fix, reverting this roll for now. It should be easy to fix and reroll.
Original issue's description:
> Update mojo sdk to rev a05bfef8096006056b2fff78092faf14d1319782
>
> BUG=None
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/8de6daffb831795171ab2c9d4220d5bf63574833
> Cr-Commit-Position: refs/heads/master@{#337551}
TBR=jam@chromium.org,rockot@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1219933003
Cr-Commit-Position: refs/heads/master@{#337601}
|
