| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we don't mark the failures as unexpected, the result-reading
logic on the bots views the failures as expected and hence
ignores them, leading us to let bad changes through :(.
TBR=ojan@chromium.org, viettrungluu@chromium.org, tonyg@chromium.org, grt@chromium.org
BUG=264859, 323212, 398027
Review URL: https://codereview.chromium.org/430933004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands 286504, which should not have been reverted.
The actual cause of the failure was 286505, reverted in 286586.
> Revert 286504 "Fix typos in num_failures_by_type for json results."
>
> Suspected cause of results_viewer_unittest.testBasic timeout:
>
> http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%282%29/builds/44045
> TimeoutException: Timed out while waiting 120s for IsJavaScriptExpressionTrue.
>
> > Fix typos in num_failures_by_type for json results.
> >
> > This changes a few occurrences of "Failure" -> "FAIL" and "Pass" -> "PASS"
> > to conform to the doc format. The existing data is not actually being
> > used yet, but the flakiness dashboard needs the correct values.
> >
> > Also fix a typo in run_mojo_python_tests that was preventing us from
> > running individual tests on the command line.
> >
> > R=ojan@chromium.org, viettrungluu@chromium.org, grt@chromium.org
> >
> > Review URL: https://codereview.chromium.org/429013004
>
> TBR=dpranke@chromium.org
>
> Review URL: https://codereview.chromium.org/430913003
TBR=skobes@chromium.org
Review URL: https://codereview.chromium.org/428343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suspected cause of results_viewer_unittest.testBasic timeout:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%282%29/builds/44045
TimeoutException: Timed out while waiting 120s for IsJavaScriptExpressionTrue.
> Fix typos in num_failures_by_type for json results.
>
> This changes a few occurrences of "Failure" -> "FAIL" and "Pass" -> "PASS"
> to conform to the doc format. The existing data is not actually being
> used yet, but the flakiness dashboard needs the correct values.
>
> Also fix a typo in run_mojo_python_tests that was preventing us from
> running individual tests on the command line.
>
> R=ojan@chromium.org, viettrungluu@chromium.org, grt@chromium.org
>
> Review URL: https://codereview.chromium.org/429013004
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/430913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes a few occurrences of "Failure" -> "FAIL" and "Pass" -> "PASS"
to conform to the doc format. The existing data is not actually being
used yet, but the flakiness dashboard needs the correct values.
Also fix a typo in run_mojo_python_tests that was preventing us from
running individual tests on the command line.
R=ojan@chromium.org, viettrungluu@chromium.org, grt@chromium.org
Review URL: https://codereview.chromium.org/429013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code to convert unittest results into a flakiness-compatible format
is duplicated across telemetry and mojo at the moment. This change merges
some fixes from the telemetry version into the mojo version.
R=dtu@chromium.org, vtl@chromium.org
Review URL: https://codereview.chromium.org/414873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This list is only used by the manually-run mojob.sh tool.)
TBR=jamesr@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/374753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specify the include root directory (now that we use absolute import
paths).
R=hansmuller@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/364483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds type converters for the mojom types in the surfaces API. Most
are idiomatic TypeConverter<> uses, but a few are done by hand as the
chromium type needs to be heap allocated and not copied for one reason or
another.
Review URL: https://codereview.chromium.org/349383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the ability to record the results of a test run into
a JSON file that can be uploaded to the flakiness dashboard.
R=viettrungluu@chromium.org, phajdan.jr@chromium.org, ojan@chromium.org, szager@chromium.org
BUG=364709
Review URL: https://codereview.chromium.org/344233008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "gyp" subcommand only runs gyp on mojo.gyp. This is convenient when
working on stuff in mojo, since it's much faster than gyp-ing
everything.
However, sometimes I want to run gyp on everything. Having a mojob
subcommand to do so is convenient, since it'll set the gyp defines in
the same way as the "gyp" subcommand.
R=sky@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/355653004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There should be exactly one newline at EOF and no more. This is the bane
of my existence.
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/332033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
Review URL: https://codereview.chromium.org/328483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mojo interfaces are asynchronous. This CL adds generic callback
functions that will be used to define vase interface for return parameters to method calls.
R=viettrungluu@chromium.org,rmcilroy@chromium.org
Review URL: https://codereview.chromium.org/310783004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, it'll typically only get flushed after the newline is output
(i.e., after the test has completed), which is annoying when a test
hangs.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/309543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
Review URL: https://codereview.chromium.org/292353003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
current one.
Maybe one day I'll consider checking in golden files and making it a
proper (automated) test ... but in the meanwhile it's still useful for
refactoring the bindings generator code.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/288943005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The expectation is that clients sending changes to the server always
increment the value. The server only accepts changes if the ids
match, otherwise the change is rejected. This puts the onus on the
client as to how to resolve out of order changes.
BUG=365012
TEST=covered by tests
R=ben@chromium.org
Review URL: https://codereview.chromium.org/277563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to best run a suite of tests on the bots, we need to support
printing out the list of tests that failed in an easily-machine-readable
manner, and also support running just a subset of tests.
This patch adds the --unexpected-failures flag to run_mojo_python_tests
to write out, one test name per line, a list of failures (full details
are listed in the usage for the script).
It also adds the ability to just run a subset of tests.
If we add any more complexity to this script we really need to write tests
for it.
R=sky@chromium.org
BUG=364709
Review URL: https://codereview.chromium.org/257103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a base class for errors, so that the top-level doesn't have to know
about different kinds of errors. (Still to do: Factor out ProcessFile(),
so that it can throw appropriate errors too. This will make it properly
unit-test-able.)
There are two reasons to move the unit tests:
* Relative imports: It's very convenient to be able to do "python
foo_unittests.py". I want to be able to use a relative import (i.e.,
from parser.py, do "from ..error import Error"), but this only works
if Python thinks I'm in a package (which it won't, if
parser_unittests.py lives right beside parser.py, and is just doing
"import parser").
* "Hygiene": Probably, if one were foolish enough to install the mojom
package in a "global" location, one wouldn't want to install the
tests. (Moreover, one probably doesn't typically want to import unit
tests.)
Note that Python unittests (using the unittest package) have to be
importable, so it's natural that they live under pylib.
Also fix/suppress various pylint warnings. (Note: generate/ still has
some nontrivial pylint warnings, which need more attention.)
R=darin@chromium.org
Review URL: https://codereview.chromium.org/247933004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ViewManager is now in terms of nodes. I'll add views next. I've also
changed ids so that they are uint16 and uint32. I'm a bit worried this
is going to be easy to get wrong (harder with a struct), but we'll try
this for now.
BUG=365012
TEST=covered by tests
R=ben@chromium.org
Review URL: https://codereview.chromium.org/246413007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bots would strongly prefer to call python directly rather than route
through the mojob.sh shell script.
R=viettrungluu@chromium.org, sky@chromium.org
BUG=364709
Review URL: https://codereview.chromium.org/241713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we've sorted out the build issues on all platforms it can be
removed.
BUG=353602
TEST=none
R=jam@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/226213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
Review URL: https://codereview.chromium.org/225403010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The plan with this is to use the generator to create binary test
files. We'll write bindings tests that read these files and verify
everything is sane.
BUG=none
TEST=none
R=darin@chromium.org
Review URL: https://codereview.chromium.org/191293018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It works for me on my Linux box. It only supports binary tests, not
Python. :/
R=darin@chromium.org
Review URL: https://codereview.chromium.org/217043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, this makes sure that it gets killed even if you press ^C
to kill mojo_shell.
R=sky@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/203223009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=353602
NOTRY=true
Review URL: https://codereview.chromium.org/195813021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Otherwise I have to look up instructions every time.
R=ben@chromium.org
Review URL: https://codereview.chromium.org/200513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=viettrungluu@chromium.org, vtl@chromium.org
Review URL: https://codereview.chromium.org/193403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: https://codereview.chromium.org/186663009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Existing
TBR=darin
Review URL: https://codereview.chromium.org/180243020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes:
o BindingsSupport is gone:
- mojo/public/bindings/lib depends on mojo/public/environment/,
which is also a static library.
- mojo/public/environment provides a default implementation of
MojoAsyncWaiter (replacing the AsyncWait functionality of
BindingsSupport).
- mojo/public/environment provides TLS support for storing the
current Buffer* (replacing the Set/GetCurrentBuffer functionality
of BindingsSupport).
- mojo/public/environment provides the Environment class, formerly
part of mojo/public/utility/
- The standalone implementation of mojo/public/environment/ depends
on mojo/public/utility/ and assumes clients will be instantiating
RunLoops on their threads.
- The chromium-specific implementation of mojo/public/environment/
depends on mojo/common/ and assumes clients will be instantiating
MessageLoops on their threads.
- The chromium-specific implementation of mojo/public/environment/
is divided into two targets: mojo_environment_chromium and
mojo_environment_chromium_impl. The former is a static library and
the latter is a component. (This way all of the state--TLS keys--
associated with the environment is kept in a DSO when using a
component build.)
o RemotePtr and Connector may optionally be parameterized with a
MojoAsyncWaiter*, allowing users to customize how AsyncWait is
implemented for a particular usage of bindings. This is needed by
the GL library so that it can schedule work on an application
defined run loop.
o RunLoop gains a RunUntilIdle method to support tests. This allows us
to delete SimpleBindingsSupport instead of converting it over to an
implementation of MojoAsyncWaiter.
Review URL: https://codereview.chromium.org/134253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move sample service test to be with the rest of the bindings tests, and change it to not echo output by default.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/134823005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also separated out the dynamic service loader from the ServiceManager file, to remove the dependency of the ServiceManager on the shell's context. This made testing cleaner.
BUG=None
R=viettrungluu@chromium.org, viettrungluu
Review URL: https://codereview.chromium.org/122173004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also sort the unit tests in alphabetical order so it is easier to add
new targets.
BUG=None
TEST=./mojo/tools/mojob.sh test, verifies it also runs
mojo_utility_unittests
TBR=darin@chromium.org,viettrungluu@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/115573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This target does not exist so do not attempt to run it from mojob.sh:
$ ./mojo/tools/mojob.sh test
...
./mojo/tools/mojob.sh: line 55: out/Debug/mojo_shell_unittests: No such
file or directory
BUG=None
TEST=see above
TBR=darin@chromium.org,viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102403006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Because we need hooks to do a bunch of things.
R=ben@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/103123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the implementation of Mojo's JavaScript bindings out of the
"public" directory. The public directory is intended to be free of dependencies
on other parts of Chromium, but the JavaScript bindings depend on V8 and base.
Now, the bindings are just a subdirectory of mojo/apps/js, which is their only
client. This makes mojo.js more of a self-contained app.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/100573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Now that the mojom compiler works, we can delete our manual checked-in
copies of the generated code for sample_service. The checked-in copies are
just going to get stale.
2) Now that sample_test.cc uses gtest, I've renamed the file to
sample_service_unittests.cc to match the normal naming conventions for
unittests.
3) I've restructured the GYP targets for sample_service so that we compile
sample_service.mojom into a static library that can be linked into both the
mojo_bindings_unittests and the mojo_js_bindings_unittests target.
R=darin@chromium.org, davemoore@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/86053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScopedMessagePipe is now mostly unneeded with ScopedMessagePipeHandle (and I
can't imagine many "real" uses for it, except in tests). Begin converting stuff
in mojo/common over to the new C++ wrappers -- though there's lots more to do.
R=sky@chromium.org, sky
Review URL: https://codereview.chromium.org/83073007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle different "configuration" options in a more reasonable way. Add the
ability to make shared_library component builds (and make that the default).
(Also set use_aura=1 unconditionally.)
R=darin
NOTRY=True
Review URL: https://codereview.chromium.org/82193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=darin
NOTRY=True
Review URL: https://codereview.chromium.org/56973010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
R=darin@chromium.org, darin
NOTRY=True
Review URL: https://codereview.chromium.org/45113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232737 0039d316-1c4b-4281-b951-d872f2087c98
|