| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
mojo::Callback (like base::Callback) has a null state but no way to test
for it. This adds is_null() to test if a callback is still in its unset
state.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/368743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Adds several shell integration tests that connect multiple services and applications together.
* Adds ToyMonitoringService and associated standalone application. Used to collect data about various services that connect with it and provide a report (e.g to the shell) for test verification purposes.
BUG=378155
Review URL: https://codereview.chromium.org/349303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is much easier to manage for clients using surfaces in an
asynchronous way (i.e. over a mojo pipe or chromium IPC). The code
translating from the IPC layer to SurfaceFactory can validate that the
namespace of SurfaceIds matches the logical connection it is managing.
Review URL: https://codereview.chromium.org/358003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We don't have a "char" type, and it's unclear what a character is (a
Unicode codepoint?) and what validation should be done.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/363533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I accidentally changed it to "READABLE" (in a mass renaming). Then
jochen removed the duplicate. Oops.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/365683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Be slightly more helpful (in debug builds), in case you forget to have
an Environment.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/366433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specify the include root directory (now that we use absolute import
paths).
R=hansmuller@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/364483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Followup to https://codereview.chromium.org/359733002/
BUG=none
Review URL: https://codereview.chromium.org/361943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=rmcilroy@chromium.org, viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/324903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
You can't have duplicate properties on js templates
BUG=none
TBR=abarth@chromium.org
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/364593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Those classes are utility class to handle mojo messages.
R=viettrungluu@chromium.org,rmcilroy@chromium.org
Review URL: https://codereview.chromium.org/311363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/367443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If InsertFutureSyncPoint() is used (this is only allowed from the browser process), the sync point will not be retired automatically but can be retired later manually with RetireSyncPoint. Any command buffer that waits on it before it's retired can wait indefinitely.
BUG=365454
Review URL: https://codereview.chromium.org/284233008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds type converters for the mojom types in the surfaces API. Most
are idiomatic TypeConverter<> uses, but a few are done by hand as the
chromium type needs to be heap allocated and not copied for one reason or
another.
Review URL: https://codereview.chromium.org/349383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/359733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/330873005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/343383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/358743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
Review URL: https://codereview.chromium.org/332263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed for ozone build.
TBRing as mostly trivial change.
BUG=none
TEST=none
TBR=ben@chromium.org,spang@chromium.org
R=ben@chromium.org
Review URL: https://codereview.chromium.org/339083004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/358963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=386485
R=darin@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280069
Review URL: https://codereview.chromium.org/341193006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mojo_view_manager_lib export node.h which depends on a generated file
from the mojo_view_manager_bindings, which is a hard dependency. To
ensures that mojo_view_manager_bindings is compiled before anything that
uses node.h, making sure that mojo_view_manager_lib export
mojo_view_manager_bindings as a dependent_settings.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/352333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=386877
Review URL: https://codereview.chromium.org/355143003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/358953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=ben@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/354083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=387172
Review URL: https://codereview.chromium.org/358843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also refactor tests to ease closing handles.
R=viettrungluu@chromium.org,rmcilroy@chromium.org
Review URL: https://codereview.chromium.org/325953006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=sky@chromium.org
Review URL: https://codereview.chromium.org/359613005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
Review URL: https://codereview.chromium.org/353683009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently, on some platforms (compilers/libraries), our build will fail
if we ignore the return value of fwrite().
R=sky@chromium.org
Review URL: https://codereview.chromium.org/351303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move that feature to a button in the panel since it (kinda) shows
push-state style navigation.
BUG=
R=sky@chromium.org
Review URL: https://codereview.chromium.org/356943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=378153
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/337263006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Before it was just loading via URLLoader. Now window_manager is in the loop and knows about URL changes and can choose where to perform the nav.
BUG=387216
R=darin@chromium.org
Review URL: https://codereview.chromium.org/346343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=ncbray@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/354023005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also implements the control API for the PNG viewer.
BUG=378153
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/350243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of demo functionality.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/334633009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/341193006/)
Reason for revert:
ASan build failed with mojo in the callstack, and the implicated call ReadAllAvailableMessages was introduced in this CL.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4229/steps/browser_tests/logs/stdio
==32447==ERROR: AddressSanitizer: heap-use-after-free on address 0x611000024ae8 at pc 0x64ea589 bp 0x7fffc974d810 sp 0x7fffc974d808
READ of size 1 at 0x611000024ae8 thread T0 (browser_tests)
#0 0x64ea588 in mojo::internal::Connector::ReadAllAvailableMessages() mojo/public/cpp/bindings/lib/connector.cc:165
#1 0xe30a3ee in Run base/callback.h:441
#2 0xe30a3ee in mojo::common::HandleWatcher::State::OnHandleReady(int) mojo/common/handle_watcher.cc:278
#3 0x38890c8 in Run base/callback.h:441
#4 0x38890c8 in MakeItSo base/bind_internal.h:871
Original issue's description:
> Adding WaitForIncomingMethodCall for InterfacePtr
>
> BUG=386485
> R=darin@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280069
TBR=darin@chromium.org,yzshen@chromium.org,qsr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=386485
Review URL: https://codereview.chromium.org/341993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=386485
R=darin@chromium.org
Review URL: https://codereview.chromium.org/341193006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL start implementing mojo interface in java. It only generated
interfaces with declared methods.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/315113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing this correctly requires integration with the IME, and access to
native events. However, we can hack this good enough for demo time at
the end of the week.
You can now type into text boxes. Right now, we aren't rendering a text box on the Google homepage, but if you click the doodle, you can edit the text in the box.
BUG=387172
Review URL: https://codereview.chromium.org/357843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes almost fill width (there's a weird bug where if I make it fill
the width white strips are seen on both sides, will chase that down
separately).
Only shows keyboard when you touch on the screen.
BUG=384433
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/349923011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the ability to record the results of a test run into
a JSON file that can be uploaded to the flakiness dashboard.
R=viettrungluu@chromium.org, phajdan.jr@chromium.org, ojan@chromium.org, szager@chromium.org
BUG=364709
Review URL: https://codereview.chromium.org/344233008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=darin@chromium.org, qsr@chromium.org
Review URL: https://codereview.chromium.org/347333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp uses the rule name to name files in the output directory. For that
reason, we should avoid spaces (and some other things, but definitely
spaces) in rule names.
I've moved the rule name to the message, and made the rule_name
something filename-friendly.
Review URL: https://codereview.chromium.org/349293005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lots still to do:
. never hides.
. some buttons show nothing (backspace, enter...).
BUG=384433
TEST=none
R=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279769
Review URL: https://codereview.chromium.org/330883007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently no tests, nor notification. Will do that separately.
BUG=384433
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/335903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Initial version of keyboard
>
> Lots still to do:
> . never hides.
> . some buttons show nothing (backspace, enter...).
>
> BUG=384433
> TEST=none
> R=ben@chromium.org
>
> Review URL: https://codereview.chromium.org/330883007
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/352823007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lots still to do:
. never hides.
. some buttons show nothing (backspace, enter...).
BUG=384433
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/330883007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Object has a special meaning in Java and Javascript.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/357683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279766 0039d316-1c4b-4281-b951-d872f2087c98
|