summaryrefslogtreecommitdiffstats
path: root/mojo
Commit message (Collapse)AuthorAgeFilesLines
* Support [handles] in validation test input format and add handle-related tests.yzshen@chromium.org2014-06-1616-51/+303
| | | | | | | | | BUG=None TEST=None Review URL: https://codereview.chromium.org/327323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277344 0039d316-1c4b-4281-b951-d872f2087c98
* Add more test cases for Mojo message validation.yzshen@chromium.org2014-06-1575-8/+594
| | | | | | | | | | | | | Tests for encoded handles in Mojo messages will be in a separate CL, since the input format needs to be extended to specify the number of handles with the message data. BUG=None TEST=ValidationTest.Conformance Review URL: https://codereview.chromium.org/324363004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277336 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo message validation tests: add integration tests and move existing ↵yzshen@chromium.org2014-06-1529-56/+306
| | | | | | | | | | | | | | conformance tests. More conformance tests will come in a separate CL. BUG=None TEST=ValidationTest.*; ValidationIntegrationTest.* R=darin@chromium.org Review URL: https://codereview.chromium.org/322003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277334 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: nuke EnvironmentDatadarin@chromium.org2014-06-1419-182/+24
| | | | | | | | | | | | | | | | | | With this change, Mojo applications that link against mojo_environment_chromium do not need to instantiate mojo::Environment. We rely on AtExitManager for all finalization of singleton objects. This frees us up to use the familiar base::Singleton and base::LazyInstance for any such state. Tests can use ShadowingAtExitManager to clean the environment between test runs. It becomes a link error to use mojo::Environment if you are not linking against mojo_environment_standalone. I plan to follow this up with a change that buries mojo::Environment for the case where you are linking against mojo_environment_standalone. Ideally, this means no one will ever need to think about mojo::Environment again. Review URL: https://codereview.chromium.org/281353005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277265 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Allow InterfacePtr<> to be deleted during a client method call.darin@chromium.org2014-06-145-8/+109
| | | | | | | | BUG=383917 Review URL: https://codereview.chromium.org/332943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277251 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Remove extraneous end-of-file newlines.viettrungluu@chromium.org2014-06-1413-14/+1
| | | | | | | | | | | There should be exactly one newline at EOF and no more. This is the bane of my existence. TBR=sky@chromium.org Review URL: https://codereview.chromium.org/332033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277199 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Add basic logging facilities to environment.viettrungluu@chromium.org2014-06-149-0/+213
| | | | | | | | | | | | | | | I'll add nicer logging macros separately. Also to do: We should also build mojo_public_environment_unittests against mojo_environment_chromium (to test the "chromium" implementation). I tried this manually (on a shared library build), and the LoggerTests pass but the AsyncWaiterTests blow up. R=darin@chromium.org Review URL: https://codereview.chromium.org/330933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277189 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Make |MojoAsyncWaiter|s const and remove the MojoAsyncWaiter* argument ↵viettrungluu@chromium.org2014-06-1427-80/+59
| | | | | | | | | | | | | to AsyncWait/CancelWait. The struct returned by GetDefaultAsyncWaiter() shouldn't be changed, and the MojoAsyncWaiter* argument isn't interested or needed. R=darin@chromium.org Review URL: https://codereview.chromium.org/337813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277188 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: ~0 -> ~0u, since the compiler on Linux Trusty doesn't like the conversion.viettrungluu@chromium.org2014-06-141-4/+3
| | | | | | | | | | | | | | | | | | From the FYI bots: FAILED: c++ -MMD -MF obj/mojo/system/mojo_system_unittests.shared_buffer_dispatcher_unittest.o.d [...] ../../mojo/system/shared_buffer_dispatcher_unittest.cc: In member function ‘virtual void mojo::system::{anonymous}::SharedBufferDispatcherTest_DuplicateBufferHandleOptionsValid_Test::TestBody()’: ../../mojo/system/shared_buffer_dispatcher_unittest.cc:183:3: error: narrowing conversion of ‘-1’ from ‘int’ to ‘MojoDuplicateBufferHandleOptionsFlags {aka unsigned int}’ inside { } is ill-formed in C++11 [-Werror=narrowing] }; ^ As a drive-by, eliminate a couple of static_casts that no one wants. R=darin@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/333803012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277186 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Trim #includes in mojo/public/c.viettrungluu@chromium.org2014-06-142-2/+2
| | | | | | | | | | Include mojo/public/c/system/types.h instead of .../core.h. TBR=darin@chromium.org Review URL: https://codereview.chromium.org/335923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277147 0039d316-1c4b-4281-b951-d872f2087c98
* Add more mojo targets to the GN build.brettw@chromium.org2014-06-135-0/+224
| | | | | | | | | | | These are the targets required by content/app BUG= R=darin@chromium.org Review URL: https://codereview.chromium.org/334983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277121 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Update Waiter::Wait() to not put the context into the return value.viettrungluu@chromium.org2014-06-1315-236/+380
| | | | | | | | | | | | (Instead, it puts it into an out parameter.) Also reverse the order of the arguments to Waiter::Awake(). R=davemoore@chromium.org Review URL: https://codereview.chromium.org/337803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277119 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Remove (unused) mojo/environment/async_waiter_impl.{cc,h}.viettrungluu@chromium.org2014-06-132-70/+0
| | | | | | | | | | | | I assume these were accidentally added in r244739. We use .../default_async_waiter_impl.* (which are basically identical to .../async_waiter_impl.*, which have never even been compiled AFAICT). R=darin@chromium.org Review URL: https://codereview.chromium.org/331853006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277097 0039d316-1c4b-4281-b951-d872f2087c98
* Only change the spinning cube color on right click.aa@chromium.org2014-06-131-9/+15
| | | | | | | | | | | | | This makes it so that changing color doesn't prevent rotation. It also means that you can't change color on touch devices, but that can be a fix for another day. BUG= R=davemoore@chromium.org Review URL: https://codereview.chromium.org/330673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277086 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a parameter to Launchable that is a ViewTreeNode to render in. Adds an ↵ben@chromium.org2014-06-1317-37/+376
| | | | | | | | | | | image viewer app that decodes the provided data stream as PNG and renders it in a View associated with the supplied node. R=aa@chromium.org, sky@chromium.org http://crbug.com/378151 Review URL: https://codereview.chromium.org/331563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277084 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Rename/replace the wait (MojoResult) "wake result" with a (uint32_t) ↵viettrungluu@chromium.org2014-06-1328-108/+122
| | | | | | | | | | | | | | | "context" (part 1). The plan is to separate the context from the wake result; the context will be the handle index (in MojoWaitMany()). Currently, we abuse the wake result (returning the index on success, and an error code on failure -- losing the index). R=sky@chromium.org Review URL: https://codereview.chromium.org/332893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276988 0039d316-1c4b-4281-b951-d872f2087c98
* Launcher flowben@chromium.org2014-06-139-2/+321
| | | | | | | | R=sky@chromium.org Review URL: https://codereview.chromium.org/337563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276892 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce internal::ServiceRegistry to prepare for ServiceProvider split.davemoore@chromium.org2014-06-138-105/+179
| | | | | | | | | | | | This is to get ready to split ServiceProvider into Shell and Application. It makes the existing Application no longer subclass internal::ServiceConnectorBase::Owner. Instead it puts that functionality in the new class internal::ServiceRegistry and Application uses that by composition. The validation in this cl is meant to be consistent with what's currently in the tree. I'll redo the cl that adds the ability to add a service with a specific validator after the split is done. BUG= Review URL: https://codereview.chromium.org/337533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276859 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Remove old form of WaiterList::AwakeWaitersForStateChange().viettrungluu@chromium.org2014-06-122-15/+0
| | | | | | | | | | I forgot to do this in r276708. R=sky@chromium.org Review URL: https://codereview.chromium.org/334663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276837 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Make the TestService quit when there are no more connections.viettrungluu@chromium.org2014-06-125-17/+81
| | | | | | | | | | (This makes mojo_shell_tests not hang.) R=sky@chromium.org Review URL: https://codereview.chromium.org/336483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276806 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the view manager notify the client of new roots correctlysky@chromium.org2014-06-122-3/+10
| | | | | | | | | | | | | | | | | | Prior to this patch the server would not notify the client of a new root if the client already knew about the root. Now it always notifies. Here's an example of this case: two nodes, A and B with B a child of A and A the root for the client. If B is added as a root then previously I would not send B in OnRootsAdded. Now I do. BUG=365012 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/323413003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276803 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Plumb wait flags state through ↵viettrungluu@chromium.org2014-06-122-18/+21
| | | | | | | | | | | | DataPipe::Awake...WaitersForStateChangeNoLock(). This reduces redundant state calculations. R=yzshen@chromium.org Review URL: https://codereview.chromium.org/333713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276791 0039d316-1c4b-4281-b951-d872f2087c98
* Implement reordering of nodes.ben@chromium.org2014-06-1221-40/+693
| | | | | | | | | | | Note that this doesn't apply to roots. If an app is embedded and its root node is reordered, there is no notification to the app. I figure this is up to the window manager to expose an API for this type of thing. R=sky@chromium.org http://crbug.com/365012 Review URL: https://codereview.chromium.org/327073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276768 0039d316-1c4b-4281-b951-d872f2087c98
* mojo: handle WM_DELETE_WINDOW in native_viewport_x11tim@chromium.org2014-06-121-1/+1
| | | | | | | | | BUG=none R=darin@chromium.org Review URL: https://codereview.chromium.org/324823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276745 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Wrap the satisfied/unsatisfied wait flags state in a single object.viettrungluu@chromium.org2014-06-1219-165/+216
| | | | | | | | | | | | | | | | | | | First, add a struct (MojoWaitFlagsState) to the public C API. We'll use this to report additional (e.g., per-handle) information in MojoWait()/MojoWaitMany(). Second, make a subclass struct (mojo::system::WaitFlagsState) that adds a constructor and some simple methods for convenience (but adding no overhead). Third, convert our various separate handling of satisfied/satisfiable state to use the new combined struct. R=sky@chromium.org, darin@chromium.org Review URL: https://codereview.chromium.org/325213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276708 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Plumb MojoCreateMessagePipeOptions through to the C++ wrappers.viettrungluu@chromium.org2014-06-127-15/+23
| | | | | | | | R=yzshen@chromium.org Review URL: https://codereview.chromium.org/328753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276707 0039d316-1c4b-4281-b951-d872f2087c98
* Fix text input.ben@chromium.org2014-06-121-41/+5
| | | | | | | | | | | The mock input method wasn't filtering WM_CHARs. R=sky@chromium.org http://crbug.com/365012 Review URL: https://codereview.chromium.org/329803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276700 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Fix the C++ bindings generator for methods taking imported interfaces.sammc@chromium.org2014-06-125-6/+28
| | | | | | | | | Previously, the namespace was omitted for interface and interface request arguments imported from another module. Review URL: https://codereview.chromium.org/332653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276598 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Expose service names in the JS bindings.sammc@chromium.org2014-06-122-0/+6
| | | | | | Review URL: https://codereview.chromium.org/326303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276588 0039d316-1c4b-4281-b951-d872f2087c98
* More clear comment for ValidateStructHeader.yzshen@chromium.org2014-06-122-0/+3
| | | | | | | | | | BUG=None TEST=None R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/328183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276546 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce very beginning of navigation.aa@chromium.org2014-06-129-40/+205
| | | | | | | | | | | | Add an interface to allow embedders to navigate embedded views. This only supports local/pushState-style navigation right now. BUG= R=darin@chromium.org, davemoore@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/327523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276521 0039d316-1c4b-4281-b951-d872f2087c98
* Renames view manager Connect methods to Embedsky@chromium.org2014-06-1112-93/+88
| | | | | | | | | | | | Specifically: IViewManagerInit::Connect->EmbedRoot IViewManager::Connect->Embed R=ben@chromium.org Review URL: https://codereview.chromium.org/328873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276411 0039d316-1c4b-4281-b951-d872f2087c98
* Pass embedding app identity through at embed timeben@chromium.org2014-06-1112-10/+59
| | | | | | | | | R=sky@chromium.org http://crbug.com/365012 Review URL: https://codereview.chromium.org/322923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276409 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Add the IInterfaceProvider interface.sammc@chromium.org2014-06-113-0/+38
| | | | | | Review URL: https://codereview.chromium.org/325093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276339 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Add resize and push_back to Array.sammc@chromium.org2014-06-113-0/+271
| | | | | | Review URL: https://codereview.chromium.org/311273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276336 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of TransactionType. Not needed anymore.ben@chromium.org2014-06-111-34/+11
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/365012 Review URL: https://codereview.chromium.org/323203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276300 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: move DeleteFile call to ~NetworkLoaderdarin@chromium.org2014-06-113-8/+5
| | | | | | | | This avoids deleting files loaded via the LocalLoader. The DeleteFile calls are only needed to clean up after the temporary files created as a result of downloading app code over the network. Review URL: https://codereview.chromium.org/323103005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276283 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes warn_unused_result of fwrite.mukai@chromium.org2014-06-111-2/+2
| | | | | | | | | | BUG=382975 R=darin@chromium.org TEST=None Review URL: https://codereview.chromium.org/324813007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276213 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Use the MessagePipe creation helper whenever possible/reasonable in tests.viettrungluu@chromium.org2014-06-104-35/+23
| | | | | | | | | | | (This is mostly so that I don't have to update those call sites to specify NULL for options, after I add options to CreateMessagePipe.) R=sky@chromium.org Review URL: https://codereview.chromium.org/328713004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276135 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Add a MojoCreateMessagePipeOptions struct parameter to ↵viettrungluu@chromium.org2014-06-1020-63/+175
| | | | | | | | | | | | | | | MojoCreateMessagePipe. I still need to plumb it through to various other languages. (Also, as a drive-by, use SharedBufferDispatcher::kDefaultCreateOptions in a few tests, which I previously missed.) R=darin@chromium.org Review URL: https://codereview.chromium.org/324783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276134 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Deflakiy mojo_shell_tests.viettrungluu@chromium.org2014-06-101-2/+24
| | | | | | | | | | | | The shell may quit the message loop before it processes the message pipe error. So if we don't see an error recorded, run the message loop until an error is processed. R=sky@chromium.org Review URL: https://codereview.chromium.org/324093004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276132 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up necessary pieces to use views with view_managersky@chromium.org2014-06-1019-1/+612
| | | | | | | | | | | | | The browser side obviously has to change rather extensively, but the rest work on both linux and windows. BUG=365012 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/321043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276070 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: cleanup redirect handling for network service.darin@chromium.org2014-06-105-15/+60
| | | | | | | | | | | | | | | Eliminate redirects field. Leave it up to clients to log the redirect chain if so desired. It is not worth sending this list over the pipe each time we see a redirect. Add support for "follow_redirects" request parameter. Rename it with an "auto_" suffix for greater clarity. R=davemoore@chromium.org Review URL: https://codereview.chromium.org/324023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276051 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Use network service to load non-local Mojo Apps.darin@chromium.org2014-06-1032-623/+405
| | | | | | | | R=davemoore@chromium.org Review URL: https://codereview.chromium.org/323593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276047 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ownership bug with ViewObserver::OnViewInputEventsky@chromium.org2014-06-105-8/+8
| | | | | | | | | | | | | It needs to take a const EventPtr& otherwise the first observer owns the event and all others get NULL. BUG=365012 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/324753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276012 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Fix mojo_test_service.viettrungluu@chromium.org2014-06-102-6/+9
| | | | | | | | | | | | | | | | It should depend on mojo_system, not mojo_system_impl, since it's a proper external app. (For some reason, this didn't cause failures for me on Linux or Windows ... probably because they were component=shared_library builds. I think I'm still using a static library build on Mac....) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275934 Review URL: https://codereview.chromium.org/321503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275949 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 275934 "Mojo: Fix mojo_test_service."viettrungluu@chromium.org2014-06-102-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | FAILED: if [ ! -e lib/libmojo_test_service.so -o ! -e lib/libmojo_test_service.so.TOC ]; then /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -B/b/build/slave/Linux_Clang__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -m64 -Wl,--icf=none -Wl,--gdb-index -o lib/libmojo_test_service.so -Wl,-soname=libmojo_test_service.so @lib/libmojo_test_service.so.rsp && { readelf -d lib/libmojo_test_service.so | grep SONAME ; nm -gD -f p lib/libmojo_test_service.so | cut -f1-2 -d' '; } > lib/libmojo_test_service.so.TOC; else /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -B/b/build/slave/Linux_Clang__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -m64 -Wl,--icf=none -Wl,--gdb-index -o lib/libmojo_test_service.so -Wl,-soname=libmojo_test_service.so @lib/libmojo_test_service.so.rsp && { readelf -d lib/libmojo_test_service.so | grep SONAME ; nm -gD -f p lib/libmojo_test_service.so | cut -f1-2 -d' '; } > lib/libmojo_test_service.so.tmp && if ! cmp -s lib/libmojo_test_service.so.tmp lib/libmojo_test_service.so.TOC; then mv lib/libmojo_test_service.so.tmp lib/libmojo_test_service.so.TOC ; fi; fi /b/build/slave/Linux_Clang__dbg_/build/src/third_party/binutils/Linux_x64/Release/bin/ld: warning: hidden symbol 'MojoClose' in obj/mojo/libmojo_system.a(obj/mojo/public/platform/native/mojo_system.system_thunks.o) is referenced by DSO lib/libmojo_common_lib.so (etc.) > Mojo: Fix mojo_test_service. > > It should depend on mojo_system, not mojo_system_impl, since it's a > proper external app. (For some reason, this didn't cause failures for me > on Linux or Windows ... probably because they were > component=shared_library builds. I think I'm still using a static > library build on Mac....) > > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/321503004 TBR=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/328623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275941 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Fix mojo_test_service.viettrungluu@chromium.org2014-06-102-5/+9
| | | | | | | | | | | | | | It should depend on mojo_system, not mojo_system_impl, since it's a proper external app. (For some reason, this didn't cause failures for me on Linux or Windows ... probably because they were component=shared_library builds. I think I'm still using a static library build on Mac....) R=sky@chromium.org Review URL: https://codereview.chromium.org/321503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275934 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Make the trivial shell service-loading test more carefully detect ↵viettrungluu@chromium.org2014-06-101-2/+35
| | | | | | | | | | | | | | | | failures. * Actually make sure that the callback ran. * And that there's no error recorded. * Also add a test for the failure case (trying to load a nonexistent service) -- the callback shouldn't run and there should be an error recorded. R=sky@chromium.org Review URL: https://codereview.chromium.org/327663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275927 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Remove redundant verification of Options pointers.viettrungluu@chromium.org2014-06-101-28/+10
| | | | | | | | | | I somehow forgot to do this in r274973. R=sky@chromium.org Review URL: https://codereview.chromium.org/320263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275926 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 13:11:10 +0000