| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=76997
TEST=NONE
Review URL: http://codereview.chromium.org/6969077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Prepare the cookie monster for MAC cookies. According to the perftests in this
patch, the change to the cookie monster has a small but measurable effect
(83.963ms => 88.299ms).
Review URL: http://codereview.chromium.org/6901147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first patch towards implementing
https://github.com/hueniverse/draft-hammer-http-mac/raw/master/draft-hammer-oauth-v2-mac-token.txt
Parse MAC-Key and MAC-Algorithm from Set-Cookie and store the values in
memory. Future patches will use these values to sign requests.
Review URL: http://codereview.chromium.org/6883253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also took the opportunity to clarify the flow of CreateMonsterFromStoreForGC by
dropping one of the `for` loops.
BUG=79723
TEST=Compile, run tests, hope nothing breaks.
Review URL: http://codereview.chromium.org/6882007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make all histogram macros thread safe, and fast by again
using statics to achieve performance.
...at the cost of:
Leak all histograms to avoid races at shutdown.
Also included leak suppression for valgrind.
r=rtenneti
BUG=78207
Review URL: http://codereview.chromium.org/6780035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74585
TEST=net_unittests, try bots.
Review URL: http://codereview.chromium.org/6783020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77298
TEST=browser_tests
Review URL: http://codereview.chromium.org/6730049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it simpler for developers to deal with the release/set event pair generated by setting a cookie that already exists, and gives them more information about general cookie removal (e.g. that the cookie wasn't "removed" actively but expired).
BUG=70101
TEST=net_unittests
Review URL: http://codereview.chromium.org/6698023
Patch from Mike West <mkwst@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) On Windows when the corruption is detected, prompts the user asking them to report it on http://crbug.com/74585.
This message is NOT internationalized, it is english only. But hopefully we will get some feedback from it.
(2) Before crashing, we do some additional checks in the map to see:
- how many pointers were NULL
- how many entries the map had
- dereference all the non-NULL values in the map to make sure they aren't garbage memory.
BUG=74585
Review URL: http://codereview.chromium.org/6693009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/6626071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the |cookies_| map is malformed.
These checks will slow things down when there are lots of cookies, and will hopefully just be temporary.
BUG=74585
Review URL: http://codereview.chromium.org/6676017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
+ ValidateMap() from DeleteAll() calling location in TabSpecificContentSettings.
+ Boolean to assert if ValidateMap() is called after destruction.
+ Hack to figure out if pre-rendering is happening in crashes.
BUG=74585
TEST=Try bots, running net_unittests CookieMonsterTest and unit_tests TabSpecificContentSettingsTest.
Review URL: http://codereview.chromium.org/6658039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original author is rdsmith (http://codereview.chromium.org/6660014/) -- I am just checking this in so gets picked up in time for canary build tommorow.
BUG=74585
TEST=Try bots, Cookie monster unit tests that have checker added, tab_specific_contents unit tests.
Review URL: http://codereview.chromium.org/6659029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cookie.
BUG=63662
TEST=see repro steps in bug report, including expected result
Review URL: http://codereview.chromium.org/6524024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the base namespace. Fix several files including lock.h unnecessarily.
BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68682
TEST=compiles
Review URL: http://codereview.chromium.org/6186005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flushes cookies to disk immediately, rather than waiting for
the 30-second timer. It takes an optional completion callback.
Patch from husky@google.com.
BUG=None
TEST=CookieMonsterTest, Additional SQLitePersistentCookieStore tests.
Review URL: http://codereview.chromium.org/5365010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for in the future.)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5574006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63663
TEST=unit tests
Review URL: http://codereview.chromium.org/5318002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the static call of SQLitePersistantCookieStore::ClearLocalState to
a call of a virtual method PersistantCookieStore::ClearLocalState from
inside the destruction sequence of the owning UrlRequestContext.
Thus the code will now work with any other persistancy implementation and
allow for better parallelism.
To test. Enable deleting of cookies and user data on shutdown and check if
the Cookies file in the profile directory has been deleted.
BUG=64920
TEST=Manual.
Review URL: http://codereview.chromium.org/5430004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
...so it can be forward declared
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5462002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The interface to CookieMonster::GarbageCollectDeleteList() was
signalling "delete all cookies in list" by specifying "delete all
cookies in list with last access time before Now()". This was failing
to work properly when the system clock wasn't updated frequently
enough (== flaky test) and is also vulnerable to changes in systems
clocks. That semantic is now explicitly signalled by a null time.
BUG=58197
TEST=net_unittests CookieMonsterTest.* on Win/Linux and CookieMonsterTest.TestHostGarbageCollection (flaky test) repeatedly on Windows.
Review URL: http://codereview.chromium.org/3780004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes changes to code in webkit/ that broke chrome_frame. Will debug that portion later.
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3563004
Review URL: http://codereview.chromium.org/3621003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 27ea47d65cf8767f350113d5ad9e25170efde811 (r61237).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of cookies to match Firefox in keeping around cookies that have been
accessed within the last 30 days.
More detailed summary of changes:
* Key scheme specification expanded to include expiry scheme (old vs. new).
* GC code refactored to make stats collection and variations in GC simpler.
* New tests written for probing GC.
BUG=8850
TEST=All known cookie tests. Several new tests written for this change.
Review URL: http://codereview.chromium.org/3323025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3412016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=eroman
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches FireFox behavior and is for denial of service protection
when we go to FireFox expiry behavior (keeping cookies around
indefinitely if they don't have a max-age and are being used); see
issue (8850) for details.
BUG=8850
TEST=net_unittests/net_perftests on Linux with CookieMonsterTest.* filter
Review URL: http://codereview.chromium.org/3122013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Affected interfaces:
* GetCookiesWithOptions (used by HTTP requests)
* GetAllCookiesForURL (used by extensions and Cookies UI)
* GetAllCookies (used by Cookies UI).
BUG=8850 (indirectly)
TEST=Standard cookie monster tests, unit_tests::CookiesTreeModelTest.OriginOrdering, browser_tests::ExtensionApiTest.Cookies
Review URL: http://codereview.chromium.org/3170034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Simplify DeleteCookie(CanonicalCookie) API
* Get rid of KeyedCanonicalCookie type; not needed.
BUG=8850
TEST=Try bots, net_unittest --gtest_filter=CookieMonsterTest.* (refactor, so tests should all keep passing.)
Review URL: http://codereview.chromium.org/3095002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=44549
Review URL: http://codereview.chromium.org/3053024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make sure we don't import cookies with identical creation times.
* DCHECK that duplicate cookie list insertion succeeds (it
silently didn't when there were not unique creation times.)
* Confirm that we eliminate all the duplicats we find on cookie
import.
* Make Methods allowing setting of creation time private.
* Create performance test for import (involved refactoring
backing store mock.)
This change does increase the performance cost on import, and hence adds
to startup time. However, the increase for importing 15000 cookies was only
5 ms, so I think that's acceptable to prevent crashes.
rdsmith-macbookpro:~/tmp $ perfparse base_perf_import.txt new_perf_import.txt
base_perf_import.txt new_perf_import.txt
CookieMonsterTest.TestImport
Cookie_monster_import_from_store 26.36 +/- 0.88 31.38 +/- 1.1
BUG=43188
TEST=net_unittest --gtest_filter=CookieMonsterTest.* (including two new tests.), Linux & Windows
Review URL: http://codereview.chromium.org/3070001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two classes of refactoring in this submission:
* Enabled by moving domain->CanonicalCookie. This is mostly just
eliminating domain from various argument lists.
* Combination of code that will make the next CL easier. This is
rewriting GetAllCookiesForURL in terms of FindCookiesForHostAndDomain
and nuking FindRawCookies; it'll allow me to change the basic
algorithm for probing the cookie map in a single place.
BUG=8850
TEST=Linux, net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.*
Review URL: http://codereview.chromium.org/2904006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, it was a vector of pair<domain_string, CanonicalCookie>.
TEST=Refactor; all relevant unit tests should still pass.
BUG=8850
Review URL: http://codereview.chromium.org/2799057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids racing on the initialization of the statics usually declared
when doing histogram accumulation.
BUG=49142
TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.* (to confirm I didn't break anyting; this doesn't reproduce the race.)
Review URL: http://codereview.chromium.org/2832061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added perftest for getters in nested subdomains.
BUG=8850
TEST=[Linux] net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.*, net_perftests --gtest_filter=CookieMonsterTest.*
Review URL: http://codereview.chromium.org/2847046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
identified by Darin after commit.
BUG=none
TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.*
Review URL: http://codereview.chromium.org/2844043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookies related to URL (found by inspection.) Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.
BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51544
Review URL: http://codereview.chromium.org/2857029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change is responsible for the XP tests (dbg)(4) browser_tests going
red, and we're heading into a long weekend. I'll revert, and resubmit
next week if it turns out that it wasn't my problem.
Original description:
Fix bug in DeleteAllForURL; deletes entire store instead of just
cookies related to URL (found by inspection.) Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.
BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)
Review URL: http://codereview.chromium.org/2857029
TBR=rdsmith@google.com
Review URL: http://codereview.chromium.org/2858046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cookies related to URL (found by inspection.) Also changed name
and semantics to more closely reflect usage of primary caller (extension
data deleter), and added test for that set of semantics.
BUG=none
TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost)
Review URL: http://codereview.chromium.org/2857029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically:
* Number of cookies, recorded every ten minutes of active browsing (i.e. cookies being requested from CookieMonster)
* Last access time, recorded when cookie accessed.
* Last access time for evicted cookies, recorded on eviction
* Time until cookie expires, recorded on insertion.
* Reason for a cookie being removed from store, recorded when removed.
* Size of batch update to persistent cookie store and whether it succeeded or failed, recorded at success/failure.
BUG=4005
TEST=net_unittests CookieMonster.* on Linux
Review URL: http://codereview.chromium.org/2718011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made ExtensionFunction RefCountedThreadSafe so it can be posted to different threads.
Used WaitableEvent in AutomationProvider.
BUG=44083
Review URL: http://codereview.chromium.org/2756003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/2860012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Made ExtensionFunction RefCountedThreadSafe so it can be posted to different threads.
Used WaitableEvent in AutomationProvider.
BUG=44083
Review URL: http://codereview.chromium.org/2756003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44476
TEST=Linux CookieMonster.SetCookieableSchemes (as modified)
Review URL: http://codereview.chromium.org/2869002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactors/extracts some methods for reuse in setting cookies programatically,
and in parsing cookie attribute tokens and values.
BUG=38398
TEST=none
Review URL: http://codereview.chromium.org/1566052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
gets uninstalled.
BUG=27938,39177
TEST=Unittest in extension_service_unitttest.cc
Review URL: http://codereview.chromium.org/1257005
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42611 0039d316-1c4b-4281-b951-d872f2087c98
|