summaryrefslogtreecommitdiffstats
path: root/net/base/mime_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* Shuffle media-related WebMimeRegistry code from webkit/ to content/.scherkus@chromium.org2013-06-221-24/+15
| | | | | | | | | | TestShellWebMimeRegistryImpl has been replaced in lieu of content_shell calling net::RemoveProprietaryMediaTypesAndCodecsForTests(). BUG=251306 Review URL: https://chromiumcodereview.appspot.com/17447011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208045 0039d316-1c4b-4281-b951-d872f2087c98
* media: Remove VP9 flag, and enable VP9 support by default.tomfinegan@chromium.org2013-06-151-1/+2
| | | | | | | | | BUG=180280 TEST=VP9 pipeline integration tests pass Review URL: https://chromiumcodereview.appspot.com/16830004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206530 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base/hash_tables to base/containers/hash_tables.brettw@chromium.org2013-06-111-4/+3
| | | | | | | | | | | Remove forwarding header BUG= R=avi@chromium.org Review URL: https://codereview.chromium.org/16667019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205584 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in net/android/, net/base/, ↵avi@chromium.org2013-06-111-1/+1
| | | | | | | | | | | | net/cert/, net/cookies/. BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15942015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205483 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in net/.avi@chromium.org2013-06-071-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15995039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204876 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up ifdef around FilePath creation(webkit)mrunal.kapade@intel.com2013-05-291-5/+2
| | | | | | | | | | | Splitting from the original patch here, crrev.com/14942008 to only include 'webkit' specific changes BUG=102853 Review URL: https://chromiumcodereview.appspot.com/14680012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203002 0039d316-1c4b-4281-b951-d872f2087c98
* Move AddMultipartValueForUpload to net/base/mime_util.h/cc.grunell@chromium.org2013-05-161-0/+25
| | | | | | | | | | | Moved from cloud print since it is used from several places. This was triggered by https://chromiumcodereview.appspot.com/14329020/ were there also is a discussion about this move. BUG=229829 R=scottbyer@chromium.org, sky@chromium.org, wtc@chromium.org Review URL: https://codereview.chromium.org/15076008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200521 0039d316-1c4b-4281-b951-d872f2087c98
* Minor mimetype list cleanup according to various RFCs.zvorygin@google.com2013-04-181-2/+2
| | | | | | Review URL: https://codereview.chromium.org/14046015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194867 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-1/+1
| | | | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020 Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Rewrite std::string("") to std::string(), Linux edition."dcheng@chromium.org2013-04-091-1/+1
| | | | | | | | | | | | | | This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6. Revert "Fix build after r193020." This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a. Revert "Really fix build after r193020." This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite std::string("") to std::string(), Linux edition.dcheng@chromium.org2013-04-091-1/+1
| | | | | | | | | | | | | | | | | This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
* Add black-listed text types to the list if unsupported MIME types.asanka@chromium.org2013-03-291-0/+2
| | | | | | | | | | | | | | | text/ofx and text/vnd.sun.s2me.app-descriptor are text/* MIME types that shouldn't be rendered in the browser. Add them to the list of unsupported text MIME types. By default, if not blacklisted, a text/* MIME type is considered displayable. BUG=162238 BUG=176450 Review URL: https://chromiumcodereview.appspot.com/12851018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191259 0039d316-1c4b-4281-b951-d872f2087c98
* src/: Update the remaining include paths of string_split.h to its new location.tfarina@chromium.org2013-03-061-1/+1
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add missing "image/vnd.microsoft.icon" MIME typehashimoto@chromium.org2013-02-221-0/+3
| | | | | | | | | | BUG=70360 TEST=icon is displayed instead of downloaded when accessing an icon resource with "image/vnd.microsoft.icon" MIME type Review URL: https://chromiumcodereview.appspot.com/12303021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184050 0039d316-1c4b-4281-b951-d872f2087c98
* Opus extension to mimetype map so files with .opus play instead of download, ↵fbarchard@chromium.org2013-02-121-1/+1
| | | | | | | | | | if enabled with --enable-opus-playback. BUG=174280 TESTED=try bots Review URL: https://codereview.chromium.org/12221108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182061 0039d316-1c4b-4281-b951-d872f2087c98
* Replace FilePath with base::FilePath in net.brettw@chromium.org2013-02-081-26/+30
| | | | | | Review URL: https://codereview.chromium.org/12218081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181543 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused code in mimeutil.eroman@chromium.org2013-01-051-23/+0
| | | | | | | | | BUG=168200 Review URL: https://chromiumcodereview.appspot.com/11775005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix certificate and keychain installation on Android.digit@chromium.org2012-12-111-1/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch is necessary to allow Chrome on Android to properly install CA certificates and PKCS#12 keychains. This feature is not supported on other platforms, but necessary on mobile. It does modify the content client API to deal with the new file types, i.e. the AddNewCertificate() method is renamed AddCryptoFile(), and its signature changed to receive the file data directly (along with a file type enum). It is now the reponsability of the browser / content embedder to perform certificate verification. More specifically: - Modify net/base/mime_util.h to provide two new functions: * IsSupportedCertificateMimeType(), which returns true iff a mime type corresponds to a supported crypto file (only "application/x-x509-user-cert" is supported, except on Android, which adds ".../x-x509-ca-cert" and ".../x-pkcs12"). * GetCertificateMimeTypeForMimeType() which translates a mime type string into an enum value that is also understood from Java (see below), describing the type of file. Note that "net/base/mime_util_certificate_list.h" is used to hold the list of certificate mime type constants, both for C++ and Java (i.e. it is used to auto-generate org.chromium.net.CertificateMimeType.java at build time, under out/$BUILDTYPE/gen/template/). - Rename X509UserCertResourceHandler to CertificateResourceHandler under content/browser/loader/ in order to deal with all certificate mime types. Modify buffered_resource_handler.cc appropriately. - Add net::android::StoreCertificate(), and the Java org.chromium.net.AndroidNetworkLibrary.storeCertificate() method to send the certificate data for installation through the system's CertInstaller activity. - Add chrome::SSLAddCertificate() to implement the platform-specific code that used to be in content::ContentBrowserClient::AddNewCertificate(). - Rename content::ContentBrowserClient::AddNewCertificate() to ::AddCertificate(), and change its signature to accept resource file bytes directly and a net::CertificateMimeType (was an X509Certificate pointer). This change shall not modify the behaviour of Chromium on other platforms. BUG=149306 TEST=Manual test with ChromiumTestShell, see internal b/6668254 for details. Review URL: https://chromiumcodereview.appspot.com/11266008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172350 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GetExtensionsForMimeType() function.kmadhusu@chromium.org2012-11-081-1/+1
| | | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11358081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166645 0039d316-1c4b-4281-b951-d872f2087c98
* Apply a few missing const qualifiers in net/digit@chromium.org2012-10-261-5/+5
| | | | | | | | | | | | | This patch just adds a few missing 'const' qualifiers for some constant tables found under net/ BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/11263039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164346 0039d316-1c4b-4281-b951-d872f2087c98
* Update mime type matching to handle parameters.gbillock@chromium.org2012-10-261-16/+62
| | | | | | | | | | R=rvargas@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11193023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164256 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use web intents for rss feeds.gbillock@chromium.org2012-10-121-0/+2
| | | | | | | | | | R=jhawkins@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11048039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161675 0039d316-1c4b-4281-b951-d872f2087c98
* Don't render CSV or TSV files inline.torne@chromium.org2012-10-021-0/+4
| | | | | | | | | | | | | | Add comma and tab separated values to the list of text MIME types that will not be rendered inline. These are hard to read as a straight textual rendering and the user almost certainly intends to open them in a spreadsheet program or import them into some other app. BUG=152911 Review URL: https://chromiumcodereview.appspot.com/11022006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159673 0039d316-1c4b-4281-b951-d872f2087c98
* Allows GetExtensionsForMimeType to support mime types like "foo/*"thorogood@chromium.org2012-09-101-34/+49
| | | | | | | | | | | Additionally, removes the prescriptive methods Get{Image,Audio,Video}Extension methods: it's less specific to just support "image/*", "audio/*", and "video/*", respectively. BUG=145112 Review URL: https://chromiumcodereview.appspot.com/10908006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155673 0039d316-1c4b-4281-b951-d872f2087c98
* Support for extracting IANA media type.smckay@chromium.org2012-08-281-0/+30
| | | | | | | | | BUG=143998 Review URL: https://chromiumcodereview.appspot.com/10829468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153713 0039d316-1c4b-4281-b951-d872f2087c98
* Offload disk accesses to WorkerPool in ExtensionProtocolHandlerpaivanof@gmail.com2012-07-231-1/+3
| | | | | | | | | | | | | | | | | and URLRequestResourceBundleJob. To achieve that URLRequestSimpleJob::GetData() signature changed to allow async operation finishing. All places implementing GetData() are updated. Patch from Pavel Ivanov <paivanof@gmail.com> BUG=59849,90207 Review URL: https://chromiumcodereview.appspot.com/10696135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147869 0039d316-1c4b-4281-b951-d872f2087c98
* Allow any text/* mime type to be rendered inline.torne@chromium.org2012-07-231-1/+34
| | | | | | | | | | | | | | | | | | | Instead of only allowing text/plain, text/css, and various other specific MIME types to be rendered inline, allow any MIME type that starts with text/ with the exception of certain types that don't render in a human-readable form despite technically being textual. The list of excepted types is the same as the list in WebKit. WebKit renders all these as plain, preformatted text, which should be safe. Users can still save the file to disk with "Save Page As" if they didn't want it rendered, and downloading can still be forced with Content-Disposition. BUG=68648 Review URL: https://chromiumcodereview.appspot.com/10694020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147845 0039d316-1c4b-4281-b951-d872f2087c98
* Tests handling in DNS RRResolver; cosmetic cleanuparuslan@chromium.org2012-06-231-0/+2
| | | | | | | | | | BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10636013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143766 0039d316-1c4b-4281-b951-d872f2087c98
* Move function for classifying a string as a mime type into MimeUtilgbillock@chromium.org2012-06-061-0/+49
| | | | | | | | | | | R=rvargas@chromium.org BUG=None TEST=MimeUtilTest.* Review URL: https://chromiumcodereview.appspot.com/10448109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140657 0039d316-1c4b-4281-b951-d872f2087c98
* Get file extension synonyms from the OS, fix so that if one synonym is safe ↵avi@chromium.org2012-05-081-6/+4
| | | | | | | | | | | they all are. BUG=126088 TEST=as in bug Review URL: https://chromiumcodereview.appspot.com/10379011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135925 0039d316-1c4b-4281-b951-d872f2087c98
* Change resource handling policy to allow feed types to download so they can ↵gbillock@chromium.org2012-04-231-2/+0
| | | | | | | | | | | | be handled by web intents. BUG=105732 TEST=None Review URL: http://codereview.chromium.org/10079012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133456 0039d316-1c4b-4281-b951-d872f2087c98
* Changed TestShellWebMimeRegistryImpl to blacklist rather than whitelist ↵ddorwin@chromium.org2012-04-161-14/+55
| | | | | | | | | | | | | | containers and codecs. New expected results for four tests need to be committed in WebKit. BUG=119667 TEST=WebM tests in LayoutTests/media/W3C/video/canPlayType/ now say "probably" or "maybe". Review URL: http://codereview.chromium.org/9969061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132463 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r129998: When input is "" (or " " with trim_whitespace true), ↵pkasting@chromium.org2012-04-031-74/+74
| | | | | | | | | | | | | | | | SplitString() should return an empty vector, not a vector of one empty string. Brett and I discussed this for a while and felt this would be wise, whereas dropping all empty segments entirely (e.g. converting "a,,b" to a vector of two elements instead of three) was probably unwise. This also simplifies the code some. Fixing this also required changing the code in mime_util.cc to handle empty vectors to "are codecs valid" oracle functions (in which case we return false). I also fixed some style issues there. It also required avoiding passing the empty string in a test in extension_api_unittest.cc; Aaron assures me that this code is not expected to be defensive against such inputs, but at his suggestion I also added some CHECK()s to the API. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9958076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130285 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r12998 - it broke some media/mime-related layout tests.dpranke@chromium.org2012-03-311-39/+32
| | | | | | | | TBR=pkasting@chromium.org, scherkus@chromium.org Review URL: https://chromiumcodereview.appspot.com/9950039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130011 0039d316-1c4b-4281-b951-d872f2087c98
* When input is "" (or " " with trim_whitespace true), SplitString() should ↵pkasting@chromium.org2012-03-301-32/+39
| | | | | | | | | | | | | | | | return an empty vector, not a vector of one empty string. Brett and I discussed this for a while and felt this would be wise, whereas dropping all empty segments entirely (e.g. converting "a,,b" to a vector of two elements instead of three) was probably unwise. This also simplifies the code some. Fixing this also required changing the code in mime_util.cc to handle empty vectors to "are codecs valid" oracle functions (in which case we return false). I also fixed some style issues there. It also required avoiding passing the empty string in a test in extension_api_unittest.cc; Aaron assures me that this code is not expected to be defensive against such inputs, but at his suggestion I also added some CHECK()s to the API. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9960004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129998 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support of ogg/vorbis audio for androidqinmin@chromium.org2012-03-151-2/+2
| | | | | | | | | | | | Android should support ogg/vorbis audio, not ogg/theora video BUG= TEST= Review URL: http://codereview.chromium.org/9361067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126993 0039d316-1c4b-4281-b951-d872f2087c98
* [uber page] Squelch font type warnings.dbeam@chromium.org2012-02-281-1/+1
| | | | | | | | | | | | | http://trac.webkit.org/browser/trunk/Source/WebCore/inspector/front-end/Resource.js?rev=108509#L34 R=estade@chromium.org,rsleevi@chromium.org BUG=None TEST=No warnings about wrong type. Review URL: http://codereview.chromium.org/9475033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123911 0039d316-1c4b-4281-b951-d872f2087c98
* [uber page] make references to chrome_shared2.css relativeestade@chromium.org2012-01-201-1/+2
| | | | | | | | | | | otherwise open_sans.woff doesn't get loaded (not sure why) BUG=none TEST=open sans is used Review URL: https://chromiumcodereview.appspot.com/9254001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118402 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-1/+1
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* Add link to RFC2361 for WAV codecs as I always have a hard time finding said ↵scherkus@chromium.org2011-08-171-1/+4
| | | | | | | | spec. Review URL: http://codereview.chromium.org/7658020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97061 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android net related code (part3)michaelbai@google.com2011-07-111-0/+6
| | | | | | | | | | | Moved from http://codereview.chromium.org/7277057/ BUG= TEST= Review URL: http://codereview.chromium.org/7328025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92069 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetWellKnowMimeTypeFromExtension() to limit the search to a fixed set of ↵michaeln@google.com2011-06-211-9/+32
| | | | | | | | | | well-known types without consulting the OS/registry. BUG=86108 TESTS=none Review URL: http://codereview.chromium.org/7204036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89773 0039d316-1c4b-4281-b951-d872f2087c98
* Add mime types for application/pkcs7-mime and application/pkcs7-signature.mattm@chromium.org2011-06-161-1/+3
| | | | | | | | | | | | (Media types and file extensions from RFC 5751 Section 3.2.1.) BUG=70095 TEST=manual Review URL: http://codereview.chromium.org/7152003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89416 0039d316-1c4b-4281-b951-d872f2087c98
* Promoting the MHTML file extension to primary mappings.jcivelli@chromium.org2011-06-141-3/+3
| | | | | | | | | | | | | | | This CL promotes the MHTML file extensions to the MIME primary mappings. This is to to make MHTML work on Windows. Windows associates the message/rfc822 MIME type with MHTML files, and we use the less mail specific multipart/related on the WebKit side. BUG=83833 TEST=MHTML layout tests should pass on Windows. Review URL: http://codereview.chromium.org/7077014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88959 0039d316-1c4b-4281-b951-d872f2087c98
* Remove useless compile assert.abarth@chromium.org2011-05-251-2/+0
| | | | | | Review URL: http://codereview.chromium.org/6979014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86697 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling MHTML.jcivelli@chromium.org2011-05-251-3/+5
| | | | | | | | | | | | | | Enabling MHTML reading on the Chrome side now that the WebKit patch adding support for MHTML landed in WebKit. That is necessary for the MHTML layout tests to pass. BUG=83804 TEST=MHTML layout tests should pass. Review URL: http://codereview.chromium.org/7064044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86560 0039d316-1c4b-4281-b951-d872f2087c98
* Replacing outdated DCHECK(a == b) with DCHECK_EQ(a, b).david.mike.futcher@gmail.com2011-04-181-2/+2
| | | | | | | | | | | | | This is my first attempt at contributing, so please tell me where I'm going wrong. BUG=58409 TEST= Review URL: http://codereview.chromium.org/6851016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81988 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most unnecessary uses of "net::" in net/base/.adamk@chromium.org2011-03-251-3/+3
| | | | | | | | | | Also removes several empty and unused gtest test fixtures. R=willchan@chromium.org Review URL: http://codereview.chromium.org/6676134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79411 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-141-20/+19
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-111-19/+20
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 11:46:24 +0000