summaryrefslogtreecommitdiffstats
path: root/net/base/net_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* split port_util.h off of net_util.heroman2015-07-211-171/+1
| | | | | | | | | BUG=488531 TBR=nick@chromium.org,msw@chromium.org Review URL: https://codereview.chromium.org/1230313005 Cr-Commit-Position: refs/heads/master@{#339612}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-2/+2
| | | | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071}
* Revert of Remove some legacy versions of StartsWith and EndsWith. (patchset ↵yosin2015-07-161-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:100001 of https://codereview.chromium.org/1239493005/) Reason for revert: Compilation error on Windows: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c ..\..\chrome\installer\gcapi\gcapi.cc /Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C3083: 'StartsWith': the symbol to the left of a '::' must be a type c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base' c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2065: 'INSENSITIVE_ASCII' : undeclared identifier ninja: build stopped: subcommand failed. Original issue's description: > Remove some legacy versions of StartsWith and EndsWith. > > This just replaces > true -> base::CompareCase::SENSITIVE > false -> base::CompareCase::INSENSITIVE_ASCII > > I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. > > extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. > > BUG=506255 > TBR=jam > > Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56 > Cr-Commit-Position: refs/heads/master@{#338996} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506255 Review URL: https://codereview.chromium.org/1233453011 Cr-Commit-Position: refs/heads/master@{#338998}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-2/+2
| | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996}
* Remove unused method from net_util.mmenke2015-07-151-31/+0
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1223083004 Cr-Commit-Position: refs/heads/master@{#338904}
* Fix some case-insensitive cases for StartsWith.brettw2015-07-011-1/+2
| | | | | | | | | | | | | | | | | | This is not all callers so the old function is not deleted. Most calls are replaced with either StartsWith with the enum, or StartsWith(base::i18n::ToLower(...) for cases that need truely-internationalized case comparison (or when I wasn't sure). The most interesting case is chrome/installer/util which can't depend on base/i18n and it wants Unicode case-insensitive compares. I replaced these with a call to the Win32 function CompareString Add a missing protobuf dependency in components/storage_monitor that a try run turned up. In a few cases there is some related cleanup when I touched code: SplitString calls in experiment_labels.cc (which I've been doing patches to update), for loop in gcapi_omaha_experiment.cc, In some cases, a ToLower call was pulled out of a loop as in autofill_agent.cc. From this file I also removed a redundant comparison since the code checked it if was equal or a prefix, and a prefix returns true if it's equal. BUG=506255 Review URL: https://codereview.chromium.org/1220653002 Cr-Commit-Position: refs/heads/master@{#337093}
* Move more string_util functions to base namespace.brettw2015-06-241-1/+1
| | | | | | | | | | | | | | Rename IsWhitespace to IsUnicodeWhitespace (to contrast it to the already-existing IsAsciiWhitespace). De-inline HexDigitToInt. This is only used in a few places and I don't think it's necessary to inline. Remove some redundant base:: qualifications in base. TBR=sky Review URL: https://codereview.chromium.org/1200053004 Cr-Commit-Position: refs/heads/master@{#335827}
* Resolve RFC 6761 localhost names to loopbackestark2015-06-201-18/+55
| | | | | | | | | | | | | | | | Per section 6.3, HostResolverImpl should recognize localhost names as special and resolve as loopback without sending the query over the network. This CL also modifies IsLocalhost() to allow trailing dots (bug 460331), so that IsLocalhost() can be used to detect localhost names that should resolve to loopback. BUG=496479,460331 Review URL: https://codereview.chromium.org/1177933002 Cr-Commit-Position: refs/heads/master@{#335402}
* Move EndsWith to base namespace.brettw2015-06-121-1/+1
| | | | | | | | TBR=jschuh@chromium.org Review URL: https://codereview.chromium.org/1182183003 Cr-Commit-Position: refs/heads/master@{#334284}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-121-1/+1
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* Make FTP EPSV/PASV and PepperWebSocketHost support port override list.mmenke2015-06-111-55/+51
| | | | | | | | | | | | | | | All other callers of IsPortAllowedForScheme respect it. We should respect the user-configured override list everywhere. Also remove the option from IsPortAllowedForScheme() to ignore the override list, and defrag net_util functions related to which ports may be used. BUG=497865 Review URL: https://codereview.chromium.org/1168193002 Cr-Commit-Position: refs/heads/master@{#334035}
* Move LowerCaseEqualsASCII to base namespacebrettw2015-06-091-1/+1
| | | | | | | | Remove url:: variants. Add the 4-element version from url:: to base:: Review URL: https://codereview.chromium.org/1172753003 Cr-Commit-Position: refs/heads/master@{#333597}
* Unify code to deal with restricted ports.mmenke2015-06-081-19/+27
| | | | | | | | | | | | | | Replace IsPortAllowedByDefault(), IsPortAllowedByFtp(), and IsPortAllowedByOverride() with IsPortAllowedForScheme(). Previously, consumers had to wrangle their way through the methods. One method makes things simpler, and consumers now have to explicitly opt into or out of the override option. BUG=475766 Review URL: https://codereview.chromium.org/1163463004 Cr-Commit-Position: refs/heads/master@{#333305}
* Use the exact-width integer types defined in <stdint.h> rather thanwtc2015-06-041-13/+13
| | | | | | | | | | | | "base/basictypes.h" in net/android, net/base, and net/cert. R=eroman@chromium.org BUG=488550 TEST=none Review URL: https://codereview.chromium.org/1158923005 Cr-Commit-Position: refs/heads/master@{#332742}
* Stop including ip_address_number.h from net_util.heroman2015-06-031-0/+1
| | | | | | | | | | | Required duplicating the typedef for IPAddressNumber, and fixing a number of missing includes from consumers. BUG=488531 TBR=jam@chromium.org,rpaquay@chromium.org,keybuk@chromium.org, Review URL: https://codereview.chromium.org/1162973005 Cr-Commit-Position: refs/heads/master@{#332708}
* Split network_interfaces.h off of net_utils.h.eroman2015-06-031-26/+0
| | | | | | | | | | | This includes the network interface enumeration functions, and wifi information that was previously lumped under net_utils. BUG=488531 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1154323007 Cr-Commit-Position: refs/heads/master@{#332644}
* Split ip_address_number.h off of net_util.heroman2015-06-031-274/+0
| | | | | | | | BUG=488531 Review URL: https://codereview.chromium.org/1167493004 Cr-Commit-Position: refs/heads/master@{#332501}
* url: Fix the TODO in url_parse.h header.tfarina2015-05-261-4/+4
| | | | | | | | | | | | this removes url/url_parse.h header, since it was just a pass through for url/third_party/mozilla/url_parse.h, and update the call sites. BUG=None R=brettw@chromium.org Review URL: https://codereview.chromium.org/1152373003 Cr-Commit-Position: refs/heads/master@{#331390}
* Relax the canonical host requirements yet further.pkasting2015-05-061-14/+7
| | | | | | | | | | | Apparently there are sites using "_" as a standalone host component. Ugh. BUG=324310 TEST=Type "_.bjb.io" (no quotes) into the address bar and check that the default action is to navigate Review URL: https://codereview.chromium.org/1119173004 Cr-Commit-Position: refs/heads/master@{#328600}
* QUIC - Collect performance stats for QUIC vs non-QUIC when googlertenneti2015-04-281-0/+23
| | | | | | | | | | | properties are accessed. R=rch@chromium.org, asvitkine@chromium.org BUG=481618 Review URL: https://codereview.chromium.org/1096783005 Cr-Commit-Position: refs/heads/master@{#327335}
* Always treat .localhost as loopbackestark2015-03-261-4/+21
| | | | | | | | | | | This means that .localhost is always redirected to localhost in DNS lookups, and |net::IsLocalhost| returns true for .localhost hostnames. BUG=455825 Review URL: https://codereview.chromium.org/938093003 Cr-Commit-Position: refs/heads/master@{#322452}
* Revert of Block port 443 for all protocols other than HTTPS or WSS. ↵lgarron2014-12-081-29/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #7 id:120001 of https://codereview.chromium.org/770343003/) Reason for revert: Unfortunately, this fix didn't do enough to mitigate the original problem (it's easy to tell if a site has been visited). It's also incomplete on its own (i.e. it needs further changes to prevent the HSTS redirect). See https://crbug.com/436451#c30 Original issue's description: > Block port 443 for all protocols other than HTTPS or WSS. > > This addresses the history leak (on non-preloaded HSTS sites) from https://crbug.com/436451: > > "If we ask Chrome to load http://example.com:443, it will definitely fail, because Chrome will make plain-text HTTP request to port 443 of the server. However, if example.com is a Known HSTS Host of Chrome (meaning either the user has visited https://example.com before, or it is on the HSTS preload list), it will send request to https://example.com:443, and the request will succeed. We can use JavaScript to differentiate the two cases, since in the first case, onerror event is triggered, while in the second case, onload event is triggered. > > Therefore, a malicious website can include well-chosen cross-domain images and use this trick to brute-force a list of domains that users have visited. Note that the list could only contain HSTS-enabled but not preloaded websites." > > BUG=436451 > > Committed: https://crrev.com/b6cf19c7b9dd536405c3c4f80876411733c9d5a5 > Cr-Commit-Position: refs/heads/master@{#306959} TBR=davidben@chromium.org,phistuck@gmail.com,mmenke@chromium.org NOTREECHECKS=true NOTRY=true BUG=436451 Review URL: https://codereview.chromium.org/780943003 Cr-Commit-Position: refs/heads/master@{#307340}
* Block port 443 for all protocols other than HTTPS or WSS.lgarron2014-12-051-0/+29
| | | | | | | | | | | | | | This addresses the history leak (on non-preloaded HSTS sites) from https://crbug.com/436451: "If we ask Chrome to load http://example.com:443, it will definitely fail, because Chrome will make plain-text HTTP request to port 443 of the server. However, if example.com is a Known HSTS Host of Chrome (meaning either the user has visited https://example.com before, or it is on the HSTS preload list), it will send request to https://example.com:443, and the request will succeed. We can use JavaScript to differentiate the two cases, since in the first case, onerror event is triggered, while in the second case, onload event is triggered. Therefore, a malicious website can include well-chosen cross-domain images and use this trick to brute-force a list of domains that users have visited. Note that the list could only contain HSTS-enabled but not preloaded websites." BUG=436451 Review URL: https://codereview.chromium.org/770343003 Cr-Commit-Position: refs/heads/master@{#306959}
* Rename network_prefix to prefix_length in NetworkInterface structure.guoweis2014-11-201-4/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/730623002 Cr-Commit-Position: refs/heads/master@{#305017}
* Use uint16 for port numbers more pervasively.pkasting2014-11-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | We currently use a mixture of ints and uint16s for port numbers. This triggers a variety of "value possibly truncated" warnings on MSVC (currently disabled) wherever we implicitly truncate. Fix this by using uint16 consistently through more functions. (Using int consistently would be more problematic as the majority of third-party/system APIs that use port numbers use 16-bit types for them.) By far the majority of these changes are fallout from changing IPEndPoint, which is widely used; it'd be difficult to split this CL up into smaller pieces :( Note that I didn't use uint16_t to avoid introducing inconsistencies between existing uint16 usage and new uint16_t usage. Conversion of everything to uint16_t can happen later. This CL was reviewed and approved in pieces in the following CLs: https://codereview.chromium.org/716223002/ https://codereview.chromium.org/717263003/ https://codereview.chromium.org/717373002/ https://codereview.chromium.org/718273002/ https://codereview.chromium.org/722503002/ Committing as TBR to the original reviewers. BUG=81439 TEST=none TBR=gunsch,cpu,jhawkins,davidben,jyasskin,mmenke Review URL: https://codereview.chromium.org/655063002 Cr-Commit-Position: refs/heads/master@{#304961}
* Make HostPortPair::FromString reject strings with invalid ports.mmenke2014-11-171-0/+5
| | | | | | | | | | | | | | | | | | Previously, HostPortPair would reject (Return an empty HostPortPair) strings that didn't contain <host>:int, but then just DCHECKed int wasn't too large to be a valid port. This is a little weird - in general, methods should either require input be valid, or be robust enough to handle invalid input. Since this method is now also run on command line input, it seems like handling bad ports makes the most sense, so this CL makes it return empty HostPortPairs in that case. BUG=433895 Review URL: https://codereview.chromium.org/736493002 Cr-Commit-Position: refs/heads/master@{#304485}
* Fix crash due to checkfailure in AutocompleteInput::Parse().pkasting2014-10-071-4/+2
| | | | | | | | | | | | | | | | | | | | I hadn't meant to check this in, but I'm glad I did, as it helped me understand the code here better. I made a number of changes to how Parse() works in the aim of simpler code and more consistent behavior; the primary change is that we use the host from the fixed-up, canonicalized URL as much as possible. This change touches a lot of files, because I made two API changes: (1) CanonicalizeHost() no longer takes a desired TLD. (2) AutocompleteInput takes the desired TLD as a std::string() instead of a base::string16(). BUG=420010 TEST=Paste the text in https://code.google.com/p/chromium/issues/detail?id=420010#c3 into the omnibox and verify Chrome doesn't crash TBR=sky, pauljensen Review URL: https://codereview.chromium.org/633673002 Cr-Commit-Position: refs/heads/master@{#298594}
* Change ParseHostAndPort() to not include brackets around IPv6 literals.eroman2014-09-241-0/+17
| | | | | | | | | | There were several consumers assuming that the returned hosts had no brackets. BUG=417417 Review URL: https://codereview.chromium.org/602973002 Cr-Commit-Position: refs/heads/master@{#296569}
* Cast: Allow extension to control wifi options on windowshubbe2014-09-231-0/+3
| | | | | | | | | | | | | This allows the cast extension to turn off wifi scan while streaming is in progress, and also set the "media streaming mode" further experimentation is need to see if these options are actually useful. BUG=410500 Review URL: https://codereview.chromium.org/566243005 Cr-Commit-Position: refs/heads/master@{#296253}
* Interface change for net_util.h for WebRTC IPv6 support.guoweis2014-09-221-2/+4
| | | | | | | | Migrated from https://codereview.chromium.org/538243003/ as it was created under wrong identity. Review URL: https://codereview.chromium.org/580283002 Cr-Commit-Position: refs/heads/master@{#296068}
* IpcNetworkManager in renderer/p2p didn't specify the right network prefix,guoweis2014-09-151-1/+1
| | | | | | | | | | | | | which prevent grouping mechanism in MergeNetworkList from working. The end result is that each Network after MergeNetworkList contains only 1 ip address. With this change, the grouping will happen correctly. WebRTC has logic to only retrieve single IP from each network for connectivity check already. This CL is a dup of https://codereview.chromium.org/536133003/ which was created under the wrong identity. BUG= Review URL: https://codereview.chromium.org/565773003 Cr-Commit-Position: refs/heads/master@{#294912}
* Use a qualified path for grit/net_resources.hthakis@chromium.org2014-08-181-1/+1
| | | | | | | | | | | BUG=401588 R=thestig@chromium.org TBR=darin Review URL: https://codereview.chromium.org/483703004 Cr-Commit-Position: refs/heads/master@{#290382} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290382 0039d316-1c4b-4281-b951-d872f2087c98
* Wire 'blink::Platform::isHostnameReservedIPAddress()' to ↵mkwst@chromium.org2014-08-081-0/+22
| | | | | | | | | | | | | | 'net::IsReservedIPAddress()'. This is a fairly straightforward patch which wires up the Blink platform API over to the network stack. BUG=378566 Review URL: https://codereview.chromium.org/430193002 Cr-Commit-Position: refs/heads/master@{#288327} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288327 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor tcp socket.byungchul@chromium.org2014-07-091-0/+13
| | | | | | | | | | | | | | | | This is a pre-requisite for http server refactoring, https://codereview.chromium.org/296053012/. 1) Introduce SocketLibevent for tcp and unix domain sockets. 2) TCPSocketLibevent utilizes SocketLibevent. 3) For backward compatibility, TCPSocketLibevent::AdoptConnectedSocket() allows the empty address. BUG=371906 Review URL: https://codereview.chromium.org/348803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282121 0039d316-1c4b-4281-b951-d872f2087c98
* Adding code to detect network interface type on Windows. This information is ↵mallinath@chromium.org2014-05-011-2/+2
| | | | | | | | | | | | | | | provided to clients of net::GetNetworkList. Windows API which provides these details are exposed via IP_ADAPTER_UNICAST_ADDRESS. (http://msdn.microsoft.com/en-us/library/windows/desktop/aa366058(v=vs.85).aspx) BUG=361791 R=pauljensen@chromium.org TBR=justinlin@chromium.org,vitalybuka@chromium.org Review URL: https://codereview.chromium.org/232343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267586 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed namespaces in src/net.vitalybuka@chromium.org2014-04-301-30/+28
| | | | | | | | | | | | url_util -> url url_parse -> url url_canon -> url BUG=364747 Review URL: https://codereview.chromium.org/255333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267185 0039d316-1c4b-4281-b951-d872f2087c98
* win: Implement Bluetooth server.xiyuan@chromium.org2014-04-291-1/+16
| | | | | | | | BUG=333979 Review URL: https://codereview.chromium.org/236203018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266831 0039d316-1c4b-4281-b951-d872f2087c98
* Make FormatUrl Keep Track of Full Transformationmpearson@chromium.org2014-04-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The omnibox providers usually search for matches in the formatted text (i.e., the escaped characters in the URL are unescaped before searching). This makes it difficult to highlight matches in URL because the location of the matched positions does not match the location of the matched text in the original URL spec. The code to adjust offsets doesn't help here because it adjusts offsets that with respect to the original URL spec, not offsets with respect to the formatted URL. In effect, we need to be able to reverse the transformation that FormatUrl() does in order to get the original offsets back (if possible) from the transformed offsets we have. The easiest and most efficient way to compute this reverse mapping is to keep track of the full original mapping, then reverse it later and apply the reversed mapping to the match offsets we have where the offsets are with respect to the formatted string. This change include the necessary parts to keep track of the full transformation. In a follow-up change, I will make HistoryQuick provider use the transformation information. In the process of that change, I will remove the "WithOffsets" function from net_util. BUG=252630 Review URL: https://codereview.chromium.org/196103008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264850 0039d316-1c4b-4281-b951-d872f2087c98
* net: Fix compilation errors in net_util.cctfarina@chromium.org2014-04-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | ../../net/base/net_util.cc:615:16: error: use of undeclared identifier 'gethostname'; did you mean 'gethostbyname2'? int result = gethostname(buffer, sizeof(buffer)); ^~~~~~~~~~~ gethostbyname2 /usr/include/netdb.h:156:24: note: 'gethostbyname2' declared here extern struct hostent *gethostbyname2 (__const char *__name, int __af); ^ I think this might have started after https://codereview.chromium.org/220253002/ - which touched net_util.cc recently. BUG=None TEST=projects links again R=eroman@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/236303014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264140 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow certain files in net to depend on icu.mmenke@chromium.org2014-04-151-850/+0
| | | | | | | | | | | | | | | Also split out functions that depend on icu from net_util.cc. This is a first step in allowing net/ to be build without icu, using platform functions instead, to get binary site down when used as a library on mobile. BUG=362608 R=mef@chromium.org Review URL: https://codereview.chromium.org/235373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263850 0039d316-1c4b-4281-b951-d872f2087c98
* Compile src/net for PNaClsergeyu@chromium.org2014-04-101-11/+22
| | | | | | | | | | | | The new net_nacl target builds net code for PNaCl. It will be used for remoting client, and so it excludes parts that are not used in the remoting, e.g. net/disk_cache, net/proxy, net/spdy, net/quic. BUG=276739 Review URL: https://codereview.chromium.org/188873004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263069 0039d316-1c4b-4281-b951-d872f2087c98
* Defined a enum for network interface types and added a field tomallinath@chromium.org2014-04-091-1/+5
| | | | | | | | | | | | | | | | net::NetworkInterface. This CL doesn't attempt to find network interface type, all are initialized to UNKNOWN type. Subsequence CL's will have platform specific code which will gather network interface type information. BUG= R=agl@chromium.org TBR=gene@chromium.org, justinlin@chromium.org Review URL: https://codereview.chromium.org/231973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262851 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/base/filename_util.h.sergeyu@chromium.org2014-04-091-409/+3
| | | | | | | | | | | | | | | Moved some filename-related functions from net_util.h to the new filename_util.h . BUG=276739 R=piman@chromium.org, rsleevi@chromium.org TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262487 Review URL: https://codereview.chromium.org/220253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262609 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 262487 "Add net/base/filename_util.h."sergeyu@chromium.org2014-04-081-3/+409
| | | | | | | | | | | | | | | | | | | > Add net/base/filename_util.h. > > Moved some filename-related functions from net_util.h to the new > filename_util.h . > > BUG=276739 > R=piman@chromium.org, rsleevi@chromium.org > TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/220253002 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/228763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262498 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/base/filename_util.h.sergeyu@chromium.org2014-04-081-409/+3
| | | | | | | | | | | | | Moved some filename-related functions from net_util.h to the new filename_util.h . BUG=276739 R=piman@chromium.org, rsleevi@chromium.org TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/220253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262487 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 257524 "Move IsStringASCII/UTF8 to base namespace."brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | | | | | | | | > Move IsStringASCII/UTF8 to base namespace. > > Use StringPiece for IsStringUTF8. > > TBR=sky > > Review URL: https://codereview.chromium.org/196793010 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/198163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257533 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsStringASCII/UTF8 to base namespace.brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | | Use StringPiece for IsStringUTF8. TBR=sky Review URL: https://codereview.chromium.org/196793010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257524 0039d316-1c4b-4281-b951-d872f2087c98
* Improve network interface name on Win for WebRTC logs.grunell@chromium.org2014-03-051-0/+2
| | | | | | | | | | | | | | - Add |friendly_name| member to NetworkInterface struct. This will be the same as |name| on non-Windows. On Windows it will be FriendlyName in IP_ADAPTER_ADDRESSES. - Use |friendly_name| in WebRTC logs. - Add simple test in unit test for |friendly_name| not empty. TBR=justinlin@chromium.org (trivial update in dial_service_unittest.cc) BUG=347541 Review URL: https://codereview.chromium.org/185533006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255031 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-3/+4
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* Support relative file paths in FilePathToFileURL().mstensho@opera.com2014-01-221-0/+6
| | | | | | | | | | | This makes it possible for content_shell to resolve relative file paths on the command line and turn them into proper startup URLs. BUG=336416 Review URL: https://codereview.chromium.org/137233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246278 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-10 07:39:55 +0000