summaryrefslogtreecommitdiffstats
path: root/net/base
Commit message (Collapse)AuthorAgeFilesLines
* Change histogram names because collected data is somewhat different.vandebo@chromium.org2010-03-031-2/+2
| | | | | | | | | | | | Net.HadConnectionType3 Each bucket is a boolean (0 or 1) indicating whether the user has had a successful connection of that type during the session. The bucket indexes are defined in "net/base/connection_type_histograms.h". 0 = Any connection (SSL or not); 1 = An SSL connection; 2 = An SSL connection with an MD5 certificate in the certificate chain (excluding root); 3 = An SSL connection with an MD2 certificate in the certificate chain (excluding root); 4 = An SSL connection with an MD4 certificate in the certificate chain (excluding root); 5 = An SSL connection with an MD5 CA certificate in the certificate chain (excluding root); 6 = An SSL connection with an MD2 CA certificate in the certificate chain (excluding root); 7 = A HTTP connection. 8 = A SPDY connection. BUG=none TEST=none Review URL: http://codereview.chromium.org/661409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40545 0039d316-1c4b-4281-b951-d872f2087c98
* Remark the KeyHandler test as flakey, and make it not run under Valgrind ↵jam@chromium.org2010-03-031-1/+1
| | | | | | | | instead. Review URL: http://codereview.chromium.org/660430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40481 0039d316-1c4b-4281-b951-d872f2087c98
* Handle CreateFile() trimming trailing dots and spaces in downloads.jschuh@google.com2010-03-031-0/+10
| | | | | | | | | BUG=37007 TEST=unit_tests --gtest_filter=DownloadManagerTest.* Review URL: http://codereview.chromium.org/660297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40479 0039d316-1c4b-4281-b951-d872f2087c98
* Disable KeyHandler test because it's hanging the Mac valgrind bots.jam@chromium.org2010-03-031-1/+1
| | | | | | | TBR=snej Review URL: http://codereview.chromium.org/660428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40473 0039d316-1c4b-4281-b951-d872f2087c98
* Use CHECK_* in netwillchan@chromium.org2010-03-025-17/+16
| | | | | | Review URL: http://codereview.chromium.org/660404 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40453 0039d316-1c4b-4281-b951-d872f2087c98
* Remove connection failed histograms.vandebo@chromium.org2010-03-022-9/+4
| | | | | | | | | BUG=none - not used and blocks refactoring for bug 30357 TEST=unit tests Review URL: http://codereview.chromium.org/661318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40397 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Fix build by marking new Keygen test as flaky.snej@chromium.org2010-03-021-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40389 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement <keygen> support, including adding generated cert to the ↵snej@chromium.org2010-03-0211-96/+422
| | | | | | | | | | | Keychain. BUG=34607 TEST=KeygenHandlerTest.SmokeTest Review URL: http://codereview.chromium.org/652137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40387 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix the case where the browser livelocks if we cannot open a file."agl@chromium.org2010-03-017-193/+66
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40291 0039d316-1c4b-4281-b951-d872f2087c98
* Work around 3rd party problem causing bug 27870.vandebo@chromium.org2010-02-271-0/+4
| | | | | | | | | | | | Check that we report that we wrote no more than we requested to write. Remove some debugging. BUG=27870 TEST=none Review URL: http://codereview.chromium.org/660194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-267-66/+193
| | | | | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. (Land attempt three: first in r39446, reverted in r39448. Second in r39899, reverted in r39901.) http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40146 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 40099 - Revert 39998 Revert 39996 Refine IPv6 probe to require that ↵jar@chromium.org2010-02-264-88/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the client has an IPv6 address on an interface It is indeed causing a perf regression in startup on Linux... I'll need to rearchitect to do the probes asynchronously, and get off the startup-critical-path. This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is still relatively low latency, and we *may* need to eventually move to an high latency test, such as a DNS resolution, or an actual test connection. If we move in that direction, then we'll need to post a task to perform the work, rather than immediately returning. BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/652072 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/660073 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/661164 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/660165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40101 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39998 - Revert 39996 Refine IPv6 probe to require that the client ↵jar@chromium.org2010-02-264-21/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | has an IPv6 address on an interface This is a second attempt to land a reviewed change. It was reverted because the tree got very red (for other reasons), and it was plausible that this change was causing startup latency in Mac and Linux (causing both perf bots to go red). If this landing turns those perf-bots red (tonight) I'll need to revert. (... and I'll need to rearchitect to do the probes asynchronously, and get off the startup-critical-path. This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is still relatively low latency, and we *may* need to eventually move to an high latency test, such as a DNS resolution, or an actual test connection. If we move in that direction, then we'll need to post a task to perform the work, rather than immediately returning. BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/652072 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/660073 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/661164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40099 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a new type of cache (APP_CACHE) so that we can tellrvargas@google.com2010-02-261-0/+1
| | | | | | | | | | | appart an AppCache from a regular cache. BUG=none TEST=none Review URL: http://codereview.chromium.org/661037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40091 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the TLS no_renegotiation alert message.wtc@chromium.org2010-02-251-0/+3
| | | | | | | | | | | R=agl BUG=36835 TEST=Visit https://ssltls.de:1445/otherciphers/ffs.jpg on Windows. The error page should display the error code ERR_SSL_NO_RENEGOTIATION instead of ERR_FAILED. Review URL: http://codereview.chromium.org/652007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40067 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39996 - Refine IPv6 probe to require that the client has an IPv6 ↵jar@chromium.org2010-02-254-88/+21
| | | | | | | | | | | | | | | | | | | | | | | | address on an interface This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is still relatively low latency, and we *may* need to eventually move to an high latency test, such as a DNS resolution, or an actual test connection. If we move in that direction, then we'll need to post a task to perform the work, rather than immediately returning. BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/652072 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/660073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39998 0039d316-1c4b-4281-b951-d872f2087c98
* Refine IPv6 probe to require that the client has an IPv6 address on an interfacejar@chromium.org2010-02-254-21/+88
| | | | | | | | | | | | | | | | | | | This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is still relatively low latency, and we *may* need to eventually move to an high latency test, such as a DNS resolution, or an actual test connection. If we move in that direction, then we'll need to post a task to perform the work, rather than immediately returning. BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/652072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39996 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 39942 - Switch NetworkChangeNotifier implementations to use ObserverList.willchan@chromium.org2010-02-257-104/+28
| | | | | | | | | Fixed build problem with database_tracker.(cc|h). BUG=36590 Review URL: http://codereview.chromium.org/660039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39983 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39942 - Switch NetworkChangeNotifier implementations to use ObserverList.willchan@chromium.org2010-02-247-28/+104
| | | | | | | | | | | | | Fix up observer list so we can use FOR_EACH_OBSERVER when check_empty is set. Clean up the ObserverList API a bit, replacing GetElementAt() with HasObserver() and Clear(). BUG=36590 Review URL: http://codereview.chromium.org/652205 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/661029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39945 0039d316-1c4b-4281-b951-d872f2087c98
* Switch NetworkChangeNotifier implementations to use ObserverList.willchan@chromium.org2010-02-247-104/+28
| | | | | | | | | | Fix up observer list so we can use FOR_EACH_OBSERVER when check_empty is set. Clean up the ObserverList API a bit, replacing GetElementAt() with HasObserver() and Clear(). BUG=36590 Review URL: http://codereview.chromium.org/652205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39942 0039d316-1c4b-4281-b951-d872f2087c98
* Mac client-side SSL cert improvements.snej@chromium.org2010-02-242-26/+56
| | | | | | | | | | | Allow Netscape-style client certs. Remember which identity the user chooses for a domain, and put it at the top of the list next time. BUG=36316,36446 TEST=none Review URL: http://codereview.chromium.org/651090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39904 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix the case where the browser livelocks if we cannot open a file."agl@chromium.org2010-02-247-191/+65
| | | | | | (Still breaks Mac net_unittests. Damm you Mac.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39901 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-247-65/+191
| | | | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. (Land attempt two: first in r39446, reverted in r39448) http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39899 0039d316-1c4b-4281-b951-d872f2087c98
* Request the szOID_PKIX_KP_SERVER_AUTH usage when constructingwtc@chromium.org2010-02-241-7/+16
| | | | | | | | | | | | | | | | | | the certificate chain so that we reject a root CA certificate whose "Server Authentication" certificate purpose has been disabled. R=rvargas BUG=34231 TEST=On Windows, run certmgr.msc as Administrator. Under "Trusted Root Certification Authorities", open the Properties for the root CA certificate with the friendly name "VeriSign Class 3 Public Primary CA" and disable its "Server Authentication" certificate purpose. Visit https://www.google.com/. Chrome should display the "Invalid Server Certificate" error page. Review URL: http://codereview.chromium.org/652181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39851 0039d316-1c4b-4281-b951-d872f2087c98
* Add ERR_END_OF_STREAMvandebo@google.com2010-02-241-0/+3
| | | | | | | | | | | | Add new error code "END_OF_STREAM" and use it in HttpStreamParser. Update a test to expect failure instead of success on an incomplete stream. BUG=25032 TEST=updated unittests Review URL: http://codereview.chromium.org/650190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39822 0039d316-1c4b-4281-b951-d872f2087c98
* Disable IPv6 address change notifications on Linux.willchan@chromium.org2010-02-231-2/+1
| | | | | | | | BUG=36591 Review URL: http://codereview.chromium.org/652146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39775 0039d316-1c4b-4281-b951-d872f2087c98
* Tie the lifetime of persisted transport-security metatdata to clearing cookies,cevans@chromium.org2010-02-233-7/+99
| | | | | | | | | | | | | | | | thus giving the user control over it. This involved adding in a "creation" date to the metadata so we can respect the user's choice of how far back to go when deleting browsing data. Care is taken to handle older metadata without the creation date set. Also fix a bug whereby we weren't making sure to persist the removed metadata when it expires. BUG=33445 TEST=TransportSecurityStateTest.DeleteSince, TransportSecurityStateTest.SerializeOld Review URL: http://codereview.chromium.org/652035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39684 0039d316-1c4b-4281-b951-d872f2087c98
* Really connect to the same server in FTP network transaction.phajdan.jr@chromium.org2010-02-205-20/+113
| | | | | | | | | | | | Also create necessary infrastructure to know the address a client socket is connected to. TEST=Covered by net_unittests. BUG=35670 Review URL: http://codereview.chromium.org/598071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39559 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error reporting for FTP passive connection failures.wtc@chromium.org2010-02-191-0/+5
| | | | | | | | | | | Allocate the -6xx block to FTP errors. R=phajdan.jr BUG=32945 TEST=None Review URL: http://codereview.chromium.org/650006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39510 0039d316-1c4b-4281-b951-d872f2087c98
* Make MappedHostResolver display its internals on the about:net-internals ↵eroman@chromium.org2010-02-194-5/+11
| | | | | | | | | | | page (so use of the --host-resolver-rules flag doesn't limit features), and run through the Shutdown() method on exit. This reworks the "IsHostResolverImpl()" hack to be a bit more general. BUG=36053 Review URL: http://codereview.chromium.org/646003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39488 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a TODO I've already done.willchan@chromium.org2010-02-191-1/+0
| | | | | | Review URL: http://codereview.chromium.org/650057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39478 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands r39417: "Implement NetworkChangeNotifierLinux."willchan@chromium.org2010-02-194-4/+222
| | | | | | | | The change broke certain linux buildbots due to netlink.h forward declaring struct net, which conflicts with the net namespace. The fix is to move the netlink code into a separate file which is not in the net namespace. Review URL: http://codereview.chromium.org/650009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39465 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r39446: "Fix the case where the browser livelocks if we cannot open a ↵agl@chromium.org2010-02-197-191/+67
| | | | | | | | file." This somehow broke net_unittests on the Mac. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-197-67/+191
| | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39446 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-196-7/+14
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r39417: "Implement NetworkChangeNotifierLinux."willchan@chromium.org2010-02-192-182/+4
| | | | | | | | | It broke the chromium arm build. BUG=26156 Review URL: http://codereview.chromium.org/651006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39418 0039d316-1c4b-4281-b951-d872f2087c98
* Implement NetworkChangeNotifierLinux.willchan@chromium.org2010-02-192-4/+182
| | | | | | | | | BUG=26156 TEST=Browse a bit. Observe about:net-internals/hostresolver.hostcache to note that the cache is populated with data. sudo /sbin/ifconfig lo down; sudo /sbin/ifconfig lo up. Observe about:net-internals/hostresolver.hostcache to note that the cache should now be empty (or almost empty, since other host resolutions may have happened in the meanwhile). Review URL: http://codereview.chromium.org/645001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39417 0039d316-1c4b-4281-b951-d872f2087c98
* Client-side SSL cert support for Mac.snej@chromium.org2010-02-182-20/+194
| | | | | | | | | | This includes sending an existing identity cert, and asking the user which cert to use. Doesn't yet handle SSL renegotiation, or key-gen. BUG=16831 TEST=none Review URL: http://codereview.chromium.org/604067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39389 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command-line flag to remap hostnames based on patterns.eroman@chromium.org2010-02-186-87/+345
| | | | | | | | | | | This is a generalization of the --testing-fixed-server flag. BUG=36053 TEST=MappedHostResolverTest.* Review URL: http://codereview.chromium.org/647001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39342 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid showing the user a garbage path attribute when the cookie doesn't have andarin@chromium.org2010-02-122-1/+16
| | | | | | | | | | | | | | | | explicit path set. This CL also ensures that we set the expiry info properly. This means using CanonPath and CanonExpiration from cookie_monster.cc. Instead of exposing those methods, I just expose a CanonicalCookie constructor that takes a ParsedCookie. R=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/597031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38984 0039d316-1c4b-4281-b951-d872f2087c98
* Update effective TLD (registry-controlled domain) data to latest file from ↵pam@chromium.org2010-02-123-9837/+9696
| | | | | | | | | | | | | | Mozilla. This corresponds to their patch ec019978e8dc, from 2010-02-11 13:39 +0000. Also update instructions for updating this file. BUG=27523 TEST=none Review URL: http://codereview.chromium.org/600077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38946 0039d316-1c4b-4281-b951-d872f2087c98
* Recover from inconsistent cookie database.eroman@chromium.org2010-02-123-14/+277
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In particular, if the database has multiple cookies defined for the same (host, cookie name, cookie path), we will delete all but the most recently created cookie. This step happens right after loading the cookie database. I don't expect this to have any real impact on startup performance, since the cookie database is small, and compared to the cost of reading the DB from disk, should be cheap. This CL also includes two other related changes: (1) Added a histogram "Net.NumDuplicateCookiesInDb" that measures how common the need to remove duplicates is. (2) If the in-memory store is ever found to contain duplicates after initializion, fail hard (crash). The effect of this change will be users that had a bad database will get it fixed, and will no longer be sending duplicate cookies to servers. ----------------------- Background: ----------------------- Ok, so why does the corruption happen in the first place? From what I can tell, the problem stems from how the interface between CookieMonster and the PersistentCookieStore is defined. Notably: * It implements overwrites as "delete" + "insert" operations. * It doesn't define the behavior when a "delete" or "insert" operation fails. The steps that CookieMonster() runs through to overwrite a cookie is: (a) Find the existing cookie, |old_cookie|, in the in-memory store. (b) Delete |old_cookie| from the in-memory store. (c) Ask the persistent cookie backing store to delete |old_cookie| (keyed by its creation time) (d) Insert |new_cookie| into the in-memory store. (e) Ask the persistent backing store to insert |new_cookie|. This ordering assumes that no failures can happen during steps (c) and (e). However in actuality, SQLitePersistentCookieStore swallows any errors it encounters writing to the DB, and does not attempt retries. Here is one sequence of steps that could lead to your database getting hosed: (1) Your cookie database becomes temporarily unwritable (maybe your home directory is network mounted and your kerberose ticket just expired). (2) The browser gets a set-cookie to overwrite an existing cookie (perhaps a ping-back from gmail, which happen often). Clearly steps (c) and (e) will now fail, since the database is offline. So the in-memory store will get changed, but the on-disk one won't. (3) Now your cookie database becomes writable again (maybe you renewed the ticket). (4) Another cookie update is received. This time, the update will cause us to insert a duplicate into the cookie database. This happens because in step (c) the on-disk database is asked to delete the previous (at least according to the in-memory store) cookie. Well, the on-disk DB never wrote that value, so this has no effect, and the actual previous value remains. Next we insert the new value, kaboom. A next step will be to re-work the PersistentCookieStore interface so SQLitePersistentCookieStore isn't as fragile to errors while overwriting. BUG=17855 TEST=CookieMonsterTest.DontImportDuplicateCookies Review URL: http://codereview.chromium.org/602029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38880 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the parent directory always comes first when listing directories.estade@chromium.org2010-02-112-15/+14
| | | | | | | | | BUG=35288 TEST=see bug Review URL: http://codereview.chromium.org/596054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38854 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the revert... This has the cumulative effect of relanding 38694.eroman@chromium.org2010-02-114-57/+226
| | | | | | | | | | | | | | | | The chrome frame failure appears to be unrelated. Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/604012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38728 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Add a load log to the DoomEntry operation.rvargas@google.com2010-02-111-0/+3
| | | | | | | | | | BUG=26729 TEST=unittest Review URL: http://codereview.chromium.org/603011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38713 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38694 - For some reason this seems to be hanging chrome frame tests, ↵eroman@chromium.org2010-02-104-226/+57
| | | | | | | | | | | | | even though this should be a strictly no-op change... Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38707 0039d316-1c4b-4281-b951-d872f2087c98
* Add some tests to CookieMonster for overwriting persistent cookies, and ↵eroman@chromium.org2010-02-104-57/+226
| | | | | | | | checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38694 0039d316-1c4b-4281-b951-d872f2087c98
* Wait a second before initializing the Mac notifier thread.willchan@chromium.org2010-02-102-9/+32
| | | | | | | | | This should prevent slowing down Mac startup. BUG=34926 Review URL: http://codereview.chromium.org/593039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38679 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NetworkChangeNotifierMac's helper thread.willchan@chromium.org2010-02-091-6/+8
| | | | | | | | | | | | This is so I can determine if r38052 caused the mac startup test regression. This will disable the Mac implementation of NetworkChangeNotifier, which was implemented in January and is used by the ClientSocketPool to flush idle sockets on a network change. r38052 added it to the HostResolver to flush the HostCache on a network change, which required instantiating NetworkChangeNotifierMac earlier in startup. This change will prevent the initialization of the helper thread, which will turn off network change notifications on OS X. This is a relatively new feature, so it's fine to turn this off. I'll let this change sit overnight and check on the startup graphs tomorrow. BUG=34926 Review URL: http://codereview.chromium.org/583015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38418 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ClientSocketPoolBaseHelper to maintain order properly.willchan@chromium.org2010-02-082-6/+16
| | | | | | | | | It used to be the case that when a disconnected socket is released, it would pop the front of the queue, and since it was a disconnected socket, would kick off another ConnectJob and then append the request to the back to the queue. While doing this, I cleaned up the TYPE_SOCKET_WAITING_IN_QUEUE since it doesn't make sense. You're always waiting in a queue, unless the request gets fulfilled immediately. I've added strings to the LoadLog to distinguish this situation and also identify when the socket has been reused. Review URL: http://codereview.chromium.org/583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38408 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 19:16:19 +0000