| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Required making SyncHostResolverBridge not use RefCountedThreadSafe. I refactored the innards to have a thread safe refcounted Core implementation.
BUG=45298
Review URL: http://codereview.chromium.org/2122015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest).
Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams).
Some of the particular changes to the event streams:
* ConnectJobs now create their own source stream internally.
* Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event).
* The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used).
* ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events.
* ConnectJobs log the net error they failed with.
* Removed the SOCKET_BACKUP_TIMER_EXTENDED event.
Review URL: http://codereview.chromium.org/2363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2486004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
especially helps when the scheme has also been stripped, as it makes the hostname look less unbalanced. We're careful to avoid stripping the slash when doing so would confuse the omnibox.
This also moves to more aggressive stripping and/or unescaping in several places. In general, it seems like we should be as aggressive as is feasible.
BUG=43587
TEST=Visit google.com. There should be no slash in the address bar.
Review URL: http://codereview.chromium.org/2389002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSLClientSocketMac. Specify the --use-nss-for-ssl command-line
option to use SSLClientSocketNSS.
The nss.gyp in src/net/third_party/nss is renamed ssl.gyp to avoid
a naming conflict with the nss.gyp in src/third_party/nss. The
GYP generator for Xcode project files disallows same-named .gyp files.
SSL client authentication doesn't work yet.
R=mark
BUG=30689
TEST=No build and test failures on Mac and Windows.
Review URL: http://codereview.chromium.org/2322008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
net::HTTPSProber belongs into the net library, where also it's only user
net::URLRequest is living. This fixes undefined references in net_base caused
by net::HTTPSProber when not linking against net.
BUG=45493
TEST=Building hresolv with the plain ld linker in shared library configuration should not generate undefined references.
Review URL: http://codereview.chromium.org/2441001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36890
Review URL: http://codereview.chromium.org/2340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Waiting for proxy tunnel..."
Add a message for waiting for the SSL Handshake to complete:
"Establishing secure connection..."
Also make the waiting messages work for SPDY connections.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2262003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98.
Revert "Missed a file as part of checkin for r48186"
This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b.
Revert "Enable warning 4389 as an error on windows builds. This will make"
This reverts commit c78936bcfc65b98edf288191d927a495b0364621.
TBR=mbelshe
Review URL: http://codereview.chromium.org/2253001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
states in the state machine for proxy tunnel establishment.
Original work from svandebo.
BUG=none
TEST=existing
Review URL: http://codereview.chromium.org/2101014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NetLog::Source.
Review URL: http://codereview.chromium.org/2131024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and any OS errors that attempts failed with (windows implementation)
Note that this change is the same as r47764, but for the windows implementation.
BUG=44488
Review URL: http://codereview.chromium.org/2127011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically:
* Added assertions in most private methods of CookieMonster that the instance lock is held.
* Refactored locking out of FindCookiesForHostAndDomain and into
DeleteCookie(url,cookie_name) and GetCookiesWithOptions (its callers)
to protect DeleteCookie's call to InternalDeleteCookie.
* Protected SetCookieableSchemes() (public method that modifies
internal state directly).
* Shifted calls to HasCookieableScheme() around so that they were protected by the instance lock.
BUG=43188
TEST=Windows net_unittests ParsedCookieTest.*:CookieMonsterTest.* (Inserted assertions, confirmed crash in CookieMonsterTest.DeleteCookieByName, refactored, confirmed no failure). Windows net_perftests ParsedCookieTest.*:CookieMonsterTest.* run before and after change; noted minimal (but non-zero) performance degradation.
Review URL: http://codereview.chromium.org/2131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and any OS errors that attempts failed with. This is only for the libevent implementation so far.
BUG=44488
Review URL: http://codereview.chromium.org/2077012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patches by Frank Galligan (fgalligan@google.com), Tom Finegan (tomfinegan@google.com) and James Zern (jzern@google.com).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2093007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
based on sprewell's patch
Review URL: http://codereview.chromium.org/2069009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here are some examples showing what it looks like now (the stuff in parenthesis is new):
--> load_flags = 8240 (DISABLE_CACHE | DISABLE_INTERCEPT | DO_NOT_SAVE_COOKIES)
--> net_error = -105 (NAME_NOT_RESOLVED)
BUG=37421
Review URL: http://codereview.chromium.org/2115007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
might not be a perfect solution right now, but its a simple stopgap.
BUG=chromium-os:3242
TEST=none
Review URL: http://codereview.chromium.org/2077006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have found a server (www.virginia.edu) which fails at DEFLATE
support in a new way: it returns a Bad MAC alert. Thus we add Bad MAC
to the list of triggers for falling back to SSLv3.
BUG=44251
http://codereview.chromium.org/2086008/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CertGetCertificateChain Function.
R=rvargas
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2035010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement several flavors of TCP/IP speculative preconnection
under a command line flag (not yet on by default).
The first area of preconnection takes place when a user types
a query into the omnibox, as we preconnect to the search service
when the omnibox suggests it is going to do a search.
The second area involves subresources, such as images.
When a navigation takes place, and we've seen navigations
to that domain/port before, and the history-based
probabability that we'll need to make a connection to
a second site (host/port) is sufficiently large, then we
preconnect to that second site while we are still connecting
to the primary site (and before we've gotten content from
the primary site.
We also fall-back to mere DNS pre-resolution of subresource
hostnames when the probability of a connection to the
subresource is not high enough.
BUG=42694
r=pkasting,willchan,mbelshe
Review URL: http://codereview.chromium.org/1585029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(It was possible to get unmatched start/end before).
Also renamed the event to URL_REQUEST_START_JOB, since it is really a superset of URLRequest::Start().
Review URL: http://codereview.chromium.org/2091009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Display it on the about:net-internals page
- Collect it in the histogram Net.OSErrorsForGetAddrinfo.
Review URL: http://codereview.chromium.org/2134004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the merge issue this time. Also fixes a TODO in another change that was blocked on this one.
Support SpdySession as a new NetLog source type. Start logging some more SPDY control frames.
Original code review: http://codereview.chromium.org/2102003/show
BUG=43237
Review URL: http://codereview.chromium.org/2114003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
For streams that already have delegates, they have their own NetLogs so use those.
For streams that don't have delegates, just write out to the session's NetLog.
TODO(willchan): Use a different event type once the SpdySession NetLog tracker is landed.
Review URL: http://codereview.chromium.org/2101003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logging some more SPDY control frames.
BUG=43237
Review URL: http://codereview.chromium.org/2102003
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/2118003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SPDY control frames.
BUG=43237
Review URL: http://codereview.chromium.org/2102003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/2108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(The "extra" was redundant. And "params" is a well understood abbreviation of "parameters").
Review URL: http://codereview.chromium.org/2110001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43237
Review URL: http://codereview.chromium.org/2004010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The format for --host-rules is identical to --host-resolver-rules.
The difference is that --host-rules affects the endpoint of the HttpNetworkTransaction, not just the host resolver. So, this means the host passed to the host resolver and the TCP connect(), the tunnel CONNECT, and the SOCKS connect will be different.
Review URL: http://codereview.chromium.org/2057007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43812
Review URL: http://codereview.chromium.org/2015011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
last patch.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1989011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We need to convert the file name back to server encoding.
BUG=38016
TEST=see bug
Review URL: http://codereview.chromium.org/1857002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
these to be useful, and they just add noise to the log.
Review URL: http://codereview.chromium.org/2033008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43812
Review URL: http://codereview.chromium.org/2035013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43812
Review URL: http://codereview.chromium.org/2010009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(DNS request tracing is the only feature lost in this transition; it needs to be added back under the new framework).
BUG=37421
Review URL: http://codereview.chromium.org/2008007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to enable MP4 and MP3 support on tegra2 boards. This change will let us enable this support via a flag in make.conf.
Patch by jneddo@nvidia.com:
http://codereview.chromium.org/1942003/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2001004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid using wall clock time, which can be changed by the user,
or impacted by Daylight Savings transitions etc.
BUG=14193
r=eroman
Review URL: http://codereview.chromium.org/1253005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code did not handle cancellation properly, and DCHECKs
were firing. Recrafted code to avoid checking for runs
"on origin_thread" after a cancellation (which destroys
the record of the orgin_thread_).
BUG=43600
r=willchan
Review URL: http://codereview.chromium.org/2050002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and WorkerPool.
Also add a warning for users of WorkerPool that they need to be
very careful about subtle issues.
Also see discussion in http://codereview.chromium.org/1834002/show
TEST=none
BUG=30177
Review URL: http://codereview.chromium.org/2033001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
better use of CryptoAPI.
Contributed by Ryan Sleevi <ryan.sleevi@gmail.com>.
Original review URL: http://codereview.chromium.org/1934001
R=wtc
BUG=148
TEST=Keygenhandler.SmokeTest
Review URL: http://codereview.chromium.org/2021003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/1748015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Confirmed by asking the requestor to add STS headers to the website.
http://codereview.chromium.org/1973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OS_WIN macro.
R=willchan
BUG=43142
TEST=No compilation error.
Review URL: http://codereview.chromium.org/1929005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=agl,willchan
BUG=43142
TEST=All unit tests should pass on Windows.
Review URL: http://codereview.chromium.org/1942002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should prevent us from crashing in getaddrinfo() in shutdown after Winsock has already been deleted, since we'll always hold onto a reference.
BUG=42117
Review URL: http://codereview.chromium.org/1888002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46319 0039d316-1c4b-4281-b951-d872f2087c98
|