| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
style fixes (function arguments on one line, remove braces on some single-line loop bodies). Remove some code to count how many cookies we garbage collected, since we never do anything with those numbers. Remove some TODOs that we shouldn't do (per deanm).
This is a by-product of my in-progress cookie fixes.
Review URL: http://codereview.chromium.org/8683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
cleanup timer from 5 seconds to 10 seconds.
http://code.google.com/p/chromium/issues/detail?id=3574
Review URL: http://codereview.chromium.org/8124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
"actual, expected").
This is a by-product of my in-progress cookie fixes.
Review URL: http://codereview.chromium.org/8852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed some files from test_files because scons complains (warns)
when a file is both in test_files and input_files. So the files removed from
test_files also exist in input_files and at some pointed will be ported anyway.
I also made some linking stubs.
BUG=3674
Review URL: http://codereview.chromium.org/7974
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7995
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I have a separate change list coming to support predictive DNS resolutions,
so I pulled out a pile of mechanical changes (with no semantic changes
intendend).
r=mbelshe
Review URL: http://codereview.chromium.org/8624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Centralize translation functions (text of "Content-Encoding" to enum)
in filter.cc
Centralize error recovery (for damaged content encoding headers) in filter.cc
Error recovery includes a loss of SDCH encoding headers, plus handling
of Apache server bug with gzip files are tagged as also being gzip encoded.
Centralize and add a pile of unit tests to this filter code.
r=openvcdiff,huanr
Review URL: http://codereview.chromium.org/8018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=b/1305245
TEST=none
Review URL: http://codereview.chromium.org/8132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=dank
Review URL: http://codereview.chromium.org/6372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- net/base/dns_resolution_observer.cc
- net/http/http_network_transaction.cc
- net/url_request/url_request_filter.cc
Add to net library the above and:
- net/base/dns_resolution_observer.cc
- net/base/upload_data_stream.cc
- net/http/http_network_layer.cc
- net/proxy/proxy_resolver_fixed.cc
- net/proxy/proxy_service.cc
- net/url_request/url_request_job_manager.cc
Add to net_unittests:
- net/http/http_network_transaction_unittest.cc
- net/http/http_transaction_unittest.cc
- net/http/http_util_unittest.cc
Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3654
Review URL: http://codereview.chromium.org/7882
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7855
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Passes tests (once you enable them by removing DISABLED_).
Probably want to add a mock https server so we can leave those tests enabled when we check in.
Had to add full duplex support to TCPClientSocket on Linux
to avoid kludgy plumbing issues.
Also had to add dummy implementation of
X509Certificate::~X509Certificate to prevent link error.
Rediffed to current trunk, addressed all review issues.
Review URL: http://codereview.chromium.org/4049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scoped_ptr<>.
Review URL: http://codereview.chromium.org/7532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with WinHTTP, which doesn't report this error. We need this
temporary workaround because our SSL UI tests aren't expecting
this error.
R=rvargas
BUG=3004
Review URL: http://codereview.chromium.org/8022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ERR_SSL_RENEGOTIATION_REQUESTED error code for when we
received a renegotiation request from a server.
Support the completion of an SSL handshake after we write
something. (This happens in a session resumption
handshake.)
Use the SSL configuration settings to turn on or turn off
various versions of the SSL protocol and server certificate
revocation checking.
Report all the errors of a certificate and whether revocation
checking was done in in the server_cert_status_ bitmask.
Create a new scoped_cert_chain_context.h header for the
ScopedCertChainContext class that used to be in
x509_certificate_win.cc, and use it to fix a leak of
chain_context on error paths in
SSLClientSocketWin::VerifyServerCert.
R=rvargas
BUG=3002,3003,3004
Review URL: http://codereview.chromium.org/7505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=openvcdiff, pinkerton
Review URL: http://codereview.chromium.org/7510
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the response to be truncated.
BUG=3521
Review URL: http://codereview.chromium.org/7610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Using a XMLHttpRequest benchmark to download 3MB files, this
change contributed ~30% performance boost.
Review URL: http://codereview.chromium.org/7426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
introduced with the Linux/NSS implementation of SSL.
Review URL: http://codereview.chromium.org/7090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
not-reached cases.
Review URL: http://codereview.chromium.org/7362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a) Do meta-refresh (and partially disable sdch) when we have an sdch decode
error early on (due to lack of dictionary).
b) Gracefully handle proxy removal of "gzip" in "content-encoding: sdch,gzip".
c) Recover from completely stripped content encoding (in response to a
request for which we advertised an SDCH dictionary) by using a filter
that can optionally decode sdch with an optional gzip as well.
Some field tests have shown problems with this protocol's
transit across the ether. The general approach we've adopted
is to stop using SDCH on the problematic site when we have problems. This
will prevent a malicious site from shutting down all use of SDCH.
r=kmixter,openvcdiff,huanr
Review URL: http://codereview.chromium.org/6433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a double free bug.
R=rvargas
Review URL: http://codereview.chromium.org/6806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original ssl_client_socket.{h,cc} are renamed
ssl_client_socket_win.{h,cc}.
The new ssl_client_socket.h defines the SSLClientSocket
interface, which simply extends the ClientSocket interface
with a new GetSSLInfo method.
ClientSocketFactory::CreateSSLClientSocket returns
SSLClientSocket* instead of ClientSocket*.
Replace the SSL protocol version mask parameter to the
constructor and factory method by a SSLConfig parameter.
R=darin
Review URL: http://codereview.chromium.org/7304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
client authentication.
R=rvargas
BUG=166
Review URL: http://codereview.chromium.org/7291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AES cipher suites) to be TLS only, and won't allow
them to be used in SSL 3.0. If an SSL 3.0 server
picks such a cipher suite, we need to handle it as
if it were TLS intolerant by turning off TLS and
retrying.
R=darin
BUG=3203,3001
Review URL: http://codereview.chromium.org/7242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
contributed by Rob Stradling <rob@comodo.com> of
Comodo CA Limited.
R=ian
BUG=2170
Review URL: http://codereview.chromium.org/3173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed over 50% of the heuristics while returning the same result 99.996% of
the time. Each heuristic we remove reduces the attack surface that honest sites
have to worry about when the serve third-party content.
(with typo fix this time)
R=darin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Add unique error code for when origin server returns 407.
Review URL: http://codereview.chromium.org/4334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It is fixed in mac build now -- problem was bad format string to StringPrintf, where passed string instead of char*.
Review URL: http://codereview.chromium.org/6359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Update callers to use this method.
Review URL: http://codereview.chromium.org/5641
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests, but continue to use WinHTTP by default in the
test shell and chrome.
The mapping of CRYPT_E_NO_REVOCATION_CHECK to
ERR_CERT_NO_REVOCATION_MECHANISM (a certificate error
code) is necessary to make the HTTPSTestServer's start
and shutdown GET commands work. (The TestDelegate
ignores all certificate errors.)
R=darin
Review URL: http://codereview.chromium.org/6472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
turned off.
R=darin
BUG=3001
Review URL: http://codereview.chromium.org/5617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6583
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed over 50% of the heuristics while returning the same result 99.996% of
the time. Each heuristic we remove reduces the attack surface that honest sites
have to worry about when the serve third-party content.
Patch by Adam Barth
R=darin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
- Work around buggy third party hooks that can overwrite LastErrorValue during delay load binding.
Review URL: http://codereview.chromium.org/6483
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instances.
Review URL: http://codereview.chromium.org/6486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
captured values for generating a config.h file.
Builds base/sdch_{filter,manager}.cc on all platforms and links
the 'sdch' library.
Add sdch to the SCons configuration loaded on Mac and Linux.
Removes platform #ifs in net/base/filter.cc initialization code
(reverting r2740).
B=2662
Review URL: http://codereview.chromium.org/5204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I can't include all the svn deletions (all of sdch/open_vcdiff/*) in this
change list, as it will break reitveld. I'll do them piecemeal after a get
an LGTM.
Also, by temporarilly leaving in the old subtree, I can support mac until
the move to use this new sub-tree.
r=nsylvain,sgk
Review URL: http://codereview.chromium.org/5402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestFileJob portable.
file_input_stream_posix.cc is not implemented in this CL. That is saved for a follow-up.
R=mark
Review URL: http://codereview.chromium.org/4101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code did not end up needing the use of interlocked operations.
All the initialization is called on one thread (the main thread).
bug=1311434
r=deanm
Review URL: http://codereview.chromium.org/4076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
General design:
- class HttpAuth -- utility class for http-auth logic.
- class HttpAuth::ChallengeTokenizer -- parsing of www-Authenticate headers.
- class HttpAuthHandler -- base class for authentication schemes (inspired by nsIHttpAuthenticator)
- class HttpAuthHandlerBasic : HttpAuthHandler -- logic for basic auth.
- class HttpAuthHandlerDigest : HttpAuthHandler -- logic for digest auth.
- The auth integration in HttpNetworkTransaction mimics that of HttpTransactionWinHttp:
+ HttpNetworkTransaction::ApplyAuth() -- set the authorization headers.
+ HttpNetworkTransaction::PopulateAuthChallenge() -- process the challenges.
BUG=2346
Review URL: http://codereview.chromium.org/4063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2628 0039d316-1c4b-4281-b951-d872f2087c98
|