summaryrefslogtreecommitdiffstats
path: root/net/base
Commit message (Collapse)AuthorAgeFilesLines
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-019-104/+104
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Cert Manager: Disable delete button on readonly certs.mattm@chromium.org2010-10-292-0/+8
| | | | | | | | | | BUG=19991 BUG=chromium-os:7946 TEST=delete button should be disabled on built-in certs, and enabled on user-imported certs Review URL: http://codereview.chromium.org/4130002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64473 0039d316-1c4b-4281-b951-d872f2087c98
* Put some thought into appropriate verbosity level for cookie DVLOGS.rdsmith@google.com2010-10-291-14/+25
| | | | | | | | | BUG=None TEST=None (trybots). Review URL: http://codereview.chromium.org/4196001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64459 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use last_access_time vs. Now() comparison to mean "all cookies".rdsmith@google.com2010-10-292-3/+2
| | | | | | | | | BUG=60015 TEST=net_unittests CookieMonsterTest.* (flakiness was rare enough that the only real test will be committing and seeing if the problem is fixed). Review URL: http://codereview.chromium.org/4131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64453 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict total parallel DNS resolutionsjar@chromium.org2010-10-291-3/+5
| | | | | | | | | | | | | | | | | | | A/B tests suggest that large numbers of parallel resolutions may cause the DNS failure rate (re: ratio of "host not found" to "found") to rise. To stay safely away from that threshold, this change lowers the maximum parallel resolutions to 8, and restricts the speculative resolutions to 3. We are also running A/B tests which will look at the impact of modulating either of these values. BUG=3041 r=eroman Review URL: http://codereview.chromium.org/4111004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64369 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-282-7/+9
| | | | | | | | | BUG=60149 TEST=None Review URL: http://codereview.chromium.org/4216001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64271 0039d316-1c4b-4281-b951-d872f2087c98
* net: use SSL_PeerCertificateChain for getting server certsagl@chromium.org2010-10-281-54/+0
| | | | | | | | | | | | | | Now that we have SSL_PeerCertificateChain, we can remove uses of CERT_GetCertChainFromCert. The latter would return a constructed certificate chain rather than the actual chain returned from the server. Thus we can also remove the Comodo cert workaround. BUG=none TEST=net_unittests http://codereview.chromium.org/4185001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64262 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64202 - Initial support for built-in DNS resolver/cache.yusukes@chromium.org2010-10-282-9/+7
| | | | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 TBR=agayev@chromium.org Review URL: http://codereview.chromium.org/4208002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64204 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-282-7/+9
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64202 0039d316-1c4b-4281-b951-d872f2087c98
* Report the SSL protocol version in ssl_info.connection_status.wtc@chromium.org2010-10-275-3/+54
| | | | | | | | | | | | | | Refactor SSLClientSocketNSS::GetSSLInfo -- the code that sets ssl_info->connection_status is moved to a new UpdateConnectionStatus method, and CheckSecureRenegotiation is subsumed by UpdateConnectionStatus. R=agl,finnur BUG=53659 TEST=none Review URL: http://codereview.chromium.org/4198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64178 0039d316-1c4b-4281-b951-d872f2087c98
* net: add (*.)internap.com to the False Start blacklistagl@chromium.org2010-10-271-0/+1
| | | | | | | BUG=60672 TEST=Navigate to https://customers.internap.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64071 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes net_unittests for OpenSSL.bulach@chromium.org2010-10-273-23/+45
| | | | | | | | | | | | | IntermediateCARequireExplicitPolicy uses a DER-encoded (rather than PEM) certificate. HTTPSRequestTest.HTTPSExpiredTest however uses a PEM certificate, so we need to try both formats in LoadTemporaryRootCert(). BUG=none TEST=X509CertificateTest.IntermediateCARequireExplicitPolicy Review URL: http://codereview.chromium.org/4047002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64068 0039d316-1c4b-4281-b951-d872f2087c98
* Minor improvement to ParseDate: check parsed values are in valid range ↵joth@chromium.org2010-10-262-25/+33
| | | | | | | | | | | | | before converting to Time. Also refactors the code to be a bit easier on the eye, and avoid a string copy. BUG=None TEST=built with use_openssl, net_unittests Review URL: http://codereview.chromium.org/4005007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63898 0039d316-1c4b-4281-b951-d872f2087c98
* net: move importing a DER certificate chain into X509Certificate.agl@chromium.org2010-10-263-10/+143
| | | | | | | | | | | | | | | | | | This is a prelude to having SSLHostInfo be able to kick off certificate validations. The vector of intermediate certificates is added on Linux because, otherwise, nothing is holding a reference to them. Previously, the nss_fd_ was holding a reference. However, without the vector holding references, CreateFromDERChain deletes them all at the end and NSS has to AIA chase up the chain. BUG=none TEST=net_unittests http://codereview.chromium.org/3920001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63881 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-2/+3
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* More UI-related OpenSSL support.bulach@chromium.org2010-10-253-82/+162
| | | | | | | | | | | | | Refactors a few functions from nsNSSCertHelper into common. (no functional change when using NSS). Implements some of the x509_certificate_model functions for OpenSSL. BUG=none TEST=Compile w/ use_openssl=1, check that the fields in certificate viewer are displayed. Review URL: http://codereview.chromium.org/3815012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63723 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DestructionObserver for NetworkConfigWatcherMac.willchan@chromium.org2010-10-232-48/+55
| | | | | | | | | | | Subclass base::Thread so we can control initialization and shutdown for the helper thread. BUG=59630 TEST=none Review URL: http://codereview.chromium.org/3986004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63650 0039d316-1c4b-4281-b951-d872f2087c98
* Update code that previously constructed strings from string iterators only ↵erikwright@chromium.org2010-10-223-10/+19
| | | | | | | | | | to use StringToInt. These usages now pass the iterators directly to the new StringToInt overloads. BUG=None TEST=All Review URL: http://codereview.chromium.org/3968001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63515 0039d316-1c4b-4281-b951-d872f2087c98
* Make USE_OPENSSL and USE_NSS mutually exclusivejoth@chromium.org2010-10-222-2/+2
| | | | | | | | | | | | | | | | | | - that is, defining use_openssl=1 will now remove all dependency on NSS. This does not impact any of the standard, non-openssl builds. Adds stub implementations of several files that need to be fully implemented in follow up patchs. Firefox import code will need some more substatial refactoring, as it makes little sense to be attempting a firefox import without NSS libraries to hand, however the UI etc has numerous assumption about the presence of this importer. BUG=None TEST=None Review URL: http://codereview.chromium.org/3855004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63506 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor to avoid using DestructionObserver in NetworkChangeNotifierLinux.willchan@chromium.org2010-10-212-93/+87
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3879003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63413 0039d316-1c4b-4281-b951-d872f2087c98
* Use scoped objects to simplify crypto routines. Also do lots of other ↵pkasting@chromium.org2010-10-211-60/+64
| | | | | | | | | | simplification. BUG=none TEST=none Review URL: http://codereview.chromium.org/3888002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63305 0039d316-1c4b-4281-b951-d872f2087c98
* A/B test of parelellism limits on DNS resolutionsjar@chromium.org2010-10-201-2/+14
| | | | | | | | | | | | | | | | Current default is a max of 50 parallel resolutions. This test tries to set limits at 6, 8, 10, 14, and 20. Stats gathered include the number of successful resolutions, and well as the number of failed resolutions. We're looking to see if the ratio changes as a function of the parallelism limit. BUG=3041 r=eroman Review URL: http://codereview.chromium.org/4010002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63297 0039d316-1c4b-4281-b951-d872f2087c98
* Mark CookieMonsterTest.GarbageCollectionTriggers as FLAKY.eroman@chromium.org2010-10-201-1/+2
| | | | | | | BUG=60015 Review URL: http://codereview.chromium.org/4016001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63279 0039d316-1c4b-4281-b951-d872f2087c98
* net: move SSL host info serialisation into SSLHostInfoagl@chromium.org2010-10-203-76/+0
| | | | | | | | | | | | | | | | | This is a prelude to SSLHostInfo being able to kick off certificate validation based on predicted certificates. In order for that to happen, SSLHostInfo has to be able to parse the contents of the saved data, therefore the serialisation/deserialisation is moved into SSLHostInfo and we use a protocol buffer to clean things up. TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/3915001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63221 0039d316-1c4b-4281-b951-d872f2087c98
* Fix loading of a temporary root certificate for OpenSSLrsleevi@chromium.org2010-10-201-9/+26
| | | | | | | | | BUG=None TEST=Build with use_openssl=1, HTTPSRequestTest.HTTPSExpiredTest Review URL: http://codereview.chromium.org/3678001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63189 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revert 62918 - net: clean up SSLHostInfo construction."agl@chromium.org2010-10-193-11/+24
| | | | | | | Was reverted in r62922 due to a change landing between the try run and the commit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63046 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize data members in constructor.kmadhusu@chromium.org2010-10-182-1/+3
| | | | | | | | | | CID=1634, 11587, 5007, 13234, 13398, 9295, 8294, 8285 BUG=none TEST=none Review URL: http://codereview.chromium.org/3817007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62945 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on "access_time < Time::Now()" to indicate "all cookies".rdsmith@google.com2010-10-183-11/+6
| | | | | | | | | | | | | | | | The interface to CookieMonster::GarbageCollectDeleteList() was signalling "delete all cookies in list" by specifying "delete all cookies in list with last access time before Now()". This was failing to work properly when the system clock wasn't updated frequently enough (== flaky test) and is also vulnerable to changes in systems clocks. That semantic is now explicitly signalled by a null time. BUG=58197 TEST=net_unittests CookieMonsterTest.* on Win/Linux and CookieMonsterTest.TestHostGarbageCollection (flaky test) repeatedly on Windows. Review URL: http://codereview.chromium.org/3780004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62943 0039d316-1c4b-4281-b951-d872f2087c98
* Fix poorly performancing implementation of MockSimplePersistentCookieStorerdsmith@google.com2010-10-181-25/+18
| | | | | | | | | BUG=57686 TEST=net_unittests CookieMonsterTest.* on Linux, running original valgrind test and confirming that it completed. Review URL: http://codereview.chromium.org/3752004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62942 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang warning about local types being used as template parameters.thakis@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | clang would complain /Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:557:5: error: template argument uses local type 'net::HostResolverImpl::Job::Category' [-Wlocal-type-template-args] DCHECK_LT(category, RESOLVE_MAX); // Be sure it was set. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:5: In file included from ../net/base/host_resolver_impl.h:18: In file included from ../net/base/network_change_notifier.h:10: In file included from ../base/observer_list_threadsafe.h:14: ../base/logging.h:662:31: note: instantiated from: #define DCHECK_LT(val1, val2) DCHECK_OP(LT, < , val1, val2) ^ ../base/logging.h:635:9: note: instantiated from: logging::Check##name##Impl((val1), (val2), \ ^~~~~~~ This seems to be a new warning. Since it only affects this file, we might as well fix the problem instead of disabling the warning. BUG=None TEST=clang/mac waterfall stays green after clobber build. Review URL: http://codereview.chromium.org/3816009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62934 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructor cleanup: RRResolverHandle::Run does not need to be virtual.cbentzel@chromium.org2010-10-181-2/+2
| | | | | | | | BUG=45135 TEST=Build works. Review URL: http://codereview.chromium.org/3747008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62927 0039d316-1c4b-4281-b951-d872f2087c98
* Caches DER data in X509 certificate for OpenSSL.bulach@chromium.org2010-10-181-26/+94
| | | | | | | | | BUG=none TEST=net_unittests --gtest_filter=*X509* Review URL: http://codereview.chromium.org/3785001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62925 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62918 - net: clean up SSLHostInfo construction.agl@chromium.org2010-10-183-24/+11
| | | | | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/3846005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98
* net: clean up SSLHostInfo construction.agl@chromium.org2010-10-183-11/+24
| | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62918 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-172-6/+7
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_cftyperef from base to base/mac, use the new namespace, and name itbrettw@chromium.org2010-10-178-42/+49
| | | | | | | | | | properly (scoped_cftyperef -> ScopedCFTypeRef). TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3855001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62887 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bad merge.eroman@chromium.org2010-10-161-1/+1
| | | | | | | | | | The check-in r62746 clobbered the changes I made in r62689 to host_resolver_impl.cc. I believe that was an accident since r62746 moved code within the file. TBR=jar Review URL: http://codereview.chromium.org/3828008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62879 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61897 - Do not use Alternate-Protocol for establishing new SpdySessions.mbelshe@chromium.org2010-10-161-3/+0
| | | | | | | | | | | | | | | | | | | | | Only use Alternate-Protocol for latching onto existing SpdySessions. This is a temporary change until SSL improvements are made, so we can begin sending http over spdy when available. Note that we have to do proxy resolution one time to figure out how to check for the appropriate existing SpdySession. If no SpdySession exists, we fallback again and have to redo proxy resolution (since the alternate protocol of npn-spdy requires rewriting the URI from http:// to https://). So we may end up doing two proxy resolutions in the fallback case. I had to disable all the tests that test establishing a new SpdySession for http:// URIs, since we don't do that for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/3573013 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3751009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62873 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - net/.pkasting@chromium.org2010-10-169-45/+33
| | | | | | | | | | Also converts COOKIE_DLOG (since VLOG can be toggled on a granular basis), removes some unneeded "endl"s and {}s, aligns "<<"s per style guide, and changes KeygenHandler::GenKeyAndSignChallenge() to avoid using "goto". BUG=none TEST=none Review URL: http://codereview.chromium.org/3846001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62831 0039d316-1c4b-4281-b951-d872f2087c98
* Add performance histograms to resolver, asong with A/B testjar@chromium.org2010-10-151-13/+61
| | | | | | | | | | | | | | | | | | | | | | I'm doing tests to see what the impact of changing the speculative resolution system parameters is on resolution time. By default, the speculative system limits itself to no more than 8 pending resolutions at any time, and this test looks at 6, 4, and 2 as limits. It also modulates the speculative congestion avoidance system, which purges the speculative queue when there is too much resolution latency, and tries various durations of time. (the latter was less important... but was already part of this existing A/B test.) I also pushed the test rates up to 10% for each case, so that we'd get data from the canary and/or dev builds. r=eroman Review URL: http://codereview.chromium.org/3762006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62746 0039d316-1c4b-4281-b951-d872f2087c98
* Return a distinct error from ERR_NAME_NOT_RESOLVED when the call to ↵eroman@chromium.org2010-10-153-5/+19
| | | | | | | | | | | | | | | getaddrinfo() has unexpectedly failed. For example when the system returns WSA_NOT_ENOUGH_MEMORY, we will now show ERR_NAME_RESOLUTION_FAILED rather than ERR_NAME_NOT_RESOLVED. This allows propagating the error to the user, rather than simply showing them say the linkdoctor page as if the domain they entered was incorrect. The data shows that a small number of users are getting these sorts of unexpected failures, and I want to get more visibility into it. By having a separate error code we can track how often this actually floats up onto an error page (as opposed to just errors on non-essential background requests). On Linux we also see EAI_AGAIN with some frequency. My theory is that these occur when you DNS resolve immediately after the network change notification was broadcast (since I can repro this 100% on my laptop). If this is in fact the major cause, then once I land this new error we should NOT see an influx of ERR_NAME_RESOLUTION_FAILED in Net.ErrorCodesForMainFrame. Review URL: http://codereview.chromium.org/3781005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62705 0039d316-1c4b-4281-b951-d872f2087c98
* Rename OSErrorForGetAddrinfo to include a suffix for the particular platform.eroman@chromium.org2010-10-151-1/+15
| | | | | | | This makes it easier to display the symbolic names of each error code on the server side, since we specify a mapping per histogram name. Review URL: http://codereview.chromium.org/3771005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62689 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "Use SSL 3.0" and "Use TLS 1.0" checkboxes towtc@chromium.org2010-10-143-4/+49
| | | | | | | | | | | | the Options menu ("Under the Hood" tab) on Windows. R=mattm BUG=59125 TEST=net_unittests.exe --gtest_filter=SSLConfigServiceWinTest.SetTest. Manually verify the Options menu has the two new checkboxes. Review URL: http://codereview.chromium.org/3779003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62634 0039d316-1c4b-4281-b951-d872f2087c98
* Add actual bytes sent/received to net-internals.mmenke@chromium.org2010-10-145-6/+22
| | | | | | | | | BUG=54745 TEST=manual Review URL: http://codereview.chromium.org/3582007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62627 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62605 - Make Run methods non-virtual on RRResolverWorker.cbentzel@chromium.org2010-10-141-2/+2
| | | | | | | | | | | | | | | | | | I don't think this needs to be reverted, but git cl dcommit went a bit wacky and I'm being conservative. The goal is to turn on -Wnon-virtual-dtor warning for gcc. In this case, the virtual Run()'s do not appear necessary, especially since they are private. If intended to be derived from, there is a "delete this" in the base class which would point to requiring a virtual destructor. BUG=45135 TEST=Target builds, validated that there are no derived classes of RRResolverWorker. Review URL: http://codereview.chromium.org/3824002 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62611 0039d316-1c4b-4281-b951-d872f2087c98
* Make Run methods non-virtual on RRResolverWorker.cbentzel@chromium.org2010-10-141-2/+2
| | | | | | | | | | | | | The goal is to turn on -Wnon-virtual-dtor warning for gcc. In this case, the virtual Run()'s do not appear necessary, especially since they are private. If intended to be derived from, there is a "delete this" in the base class which would point to requiring a virtual destructor. BUG=45135 TEST=Target builds, validated that there are no derived classes of RRResolverWorker. Review URL: http://codereview.chromium.org/3824002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62605 0039d316-1c4b-4281-b951-d872f2087c98
* SSLConfig struct CertAndStatus is not initializing all its members.finnur@chromium.org2010-10-141-2/+2
| | | | | | | | | | | BUG=None TEST=None CID=13288 Review URL: http://codereview.chromium.org/3781002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62532 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-1413-61/+63
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-143-3/+3
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate the SpdyProxyClientSocket into the HttpStreamRequestrch@chromium.org2010-10-131-1/+4
| | | | | | | | | | | to support fetching HTTPS URLS over a SPDY Proxy. BUG=29625 TEST=HttpNetworkTransactionTest.HttpsProxySpdyConnect Review URL: http://codereview.chromium.org/3417010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62468 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 07:21:59 +0000