| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
value of WaitForSingleObject and the error code.
R=eroman
BUG=6500
Review URL: http://codereview.chromium.org/18182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data is generated and included in the .pak file, we need to add
a dependency in the SCons build. Making the corresponding
changes to mac/win is harder, so punting for now.
Review URL: http://codereview.chromium.org/18127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
signaled, so we need to reset the event object. Otherwise,
the event object will be left in the wrong state when we
write the request headers.
Remove the unnecessary forward declaration of HostResolver.
R=eroman
BUG=6331
Review URL: http://codereview.chromium.org/18119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=6079
R=darin
Review URL: http://codereview.chromium.org/18086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also moves AuthCache::HttpKey() --> GetSignonRealmKey().
Review URL: http://codereview.chromium.org/18218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
intermediate CA certificates containing MD5 signatures.
Change copyright year of new files to 2009.
R=jar
BUG=6102
Review URL: http://codereview.chromium.org/18063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a dummy unused bucket at the end of histograms to allow
seamless future expansion.
R=jar
BUG=6102
Review URL: http://codereview.chromium.org/18036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix typo in listen_socket.h include guard
I would have liked to use scoped_refptr for
listen_sock_ and connected_sock_, but that
crashes on the mac (possibly because
the sockets need to be closed before
TCPClientSocketTest is destroyed;
that will be easier once ListenSocket is
refactored, but that's beyond the scope of
this change).
Review URL: http://codereview.chromium.org/18001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a boolean to indicate if the request_time_ was
set via a call to Now(), vs unpickling from the
cache, so that cached results can be excluded from
latency measurements.
bug=1561947
r=darin,rvargas
Review URL: http://codereview.chromium.org/17371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
certificates.
R=jar
BUG=6102
Review URL: http://codereview.chromium.org/17471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes one bug where a cookie like:
A="BBB" ;
Would be "BBB"; in all other browser, but
"BBB" ; in Chrome. Additionally it fixes creating unintentional (but harmless) empty attributes.
We had previously tried to match Firefox, but after long discussions we decided it makes more sense to match Internet Explorer and Safari. This means not explicitly handling quoted-string as proposed in the newer RFCs.
Before: A="B;C"; -> A="B;C";
After: A="B;C"; -> A="B;
Review URL: http://codereview.chromium.org/17045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with a grd file that generates the same thing. We want to do
this so on linux, we will have grit generate the .h file and
a platform specific resource file.
There's some munging going on to be able to get the
effective_tld_names_clean.dat file included in the rc.
This works in visual studio and scons. I need to update
chrome_kjs.sln and the webkit*.sln files and the mac build before committing.
Review URL: http://codereview.chromium.org/16565
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(lgtm already in codereview 13237)
Review URL: http://codereview.chromium.org/16589
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16563
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(As Darin requested in review 16207, I now do this with
a helper class rather than by trying to directly support it.)
Review URL: http://codereview.chromium.org/16549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sample/histogram the sizes of the "final" block of SDCH compressed data.
Try to understand why there is a long tail in current distribution.
bug=1561947
r=huanr,kenmixter,openvcdiff
Review URL: http://codereview.chromium.org/17006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tcp_client_socket_libevent.cc.
This was broken out from a larger cl 16027,
it's the part you LGTM'd on Dec 23rd.
(Should I have just checked this in without a separate review?)
Review URL: http://codereview.chromium.org/16467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
HostResolver class. It's not being compiled yet.
R=eroman
BUG=3592
Review URL: http://codereview.chromium.org/14868
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=openvcdiff,huanr
Review URL: http://codereview.chromium.org/14802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestAddCookieOnManyHosts would fail due to SetCookie() returning false when
true was expected. Cause of the failed cookie insert was due to httponly
cookie being used in the test. Removed httponly from cookie.
Patch by jroesslein@gmail.com
R=darin
-This line, and those below, will be ignored--
M AUTHORS
M net/base/cookie_monster_perftest.cc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
false UMR reports from Purify due to asynchronous filling of memory from the
socket.
BUG=5297
TEST=run test_shell.exe http://localhost:8080/multipart/invalid-image-data-standalone.html
in Purify, see no UMRs in net code. Or watch the layout-test Purify
buildbot running http/tests/invalid-image-data{-standalone}.html
Review URL: http://codereview.chromium.org/13331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Unify WatchSocket & WatchFileHandle.
* Better encapsulate libevent.
* Fix a bug with blocking writes in ipc_posix.cc
Review URL: http://codereview.chromium.org/13757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Unify WatchSocket & WatchFileHandle.
* Better encapsulate libevent.
* Fix a bug with blocking writes in ipc_posix.cc
Review URL: http://codereview.chromium.org/13757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/13703
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scripts.This object will be owned by ProxyService. It will be used to manage the fetching of PAC scripts (on the IO thread, using the primary URLRequestContext).BUG=74,2764 (partial)
Review URL: http://codereview.chromium.org/13251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc@chromium.org
Review URL: http://codereview.chromium.org/13335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a bit of Linux SSL code.
Review URL: http://codereview.chromium.org/13649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix part of http://code.google.com/p/chromium/issues/detail?id=4510
and improve https support in test shell on linux.
This is the same as the earlier ssl cert cl
(see http://codereview.chromium.org/11249),
but with the certs moved so net can use them without
reaching over into chrome's pants and causing
test failure on the 'modules' Windows build server,
which is set up to test net and base but not chrome.
For this to pass, we will need to install
the certs on the windows module and try servers.
(And make sure tlslite is present.)
(A later CL will finish implementing SSLInfo for Linux,
and probably reference net/base/ssl_test_util.cc
from all three vcproj files that need it,
even though that's ugly, because that's less ugly
that referencing it from net.lib's vcproj.)
Review URL: http://codereview.chromium.org/12930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the only response to a SDCH encoding proposal (including a statement of
an Avail-Dict) is a gzip response, the filtering infrastructure needs to
add in a missing "sdch" sniffing filter. This filter should enter into
pass-through mode if the content does not have a valid SDCH header. This
functionality is critical to the latency experiment, which will signal
the fact that a session is in the control group by doing exactly the
above pattern (only using gzip, despite the dictionary).
This is a blocker for the Chrome SDCH latency experiment.
bug = 1520081
reviewers= huanr,openvcdiff,kmixter
Review URL: http://codereview.chromium.org/12964
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
FilePaths. Re-enable relevant posix unit tests.
Review URL: http://codereview.chromium.org/12893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
net depending on chrome
Review URL: http://codereview.chromium.org/13059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract some UI SSL test code into new class SSLTestUtil to avoid duplication.
Point nss at root certs so test_shell can talk to mail.google.com without warnings.
Support ciphers needed to talk to testserver.py.
Load temporary testing cert needed to run unit tests.
Implement part of GetSSLInfo.
Change URL in developer error message to point to chromium.org.
Re-enable url_request_unittest.cc, which seems to have been disabled by mistake.
Later changesets will implement x509 certificates for nss,
finish GetSSLInfo support, and update chrome/browser/ssl_uitest.cc to use SSLTestUtil.
Earlier version was committed as r6063, but was rolled back.
Review URL: http://codereview.chromium.org/11249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
* Add support for "Debug On Start" switch to MultiprocessTest::SpawnChild
Review URL: http://codereview.chromium.org/13052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a connection fails without EINPROGRESS then we don't close the socket
right away, but wait until the destructor calls Disconnect(). However,
Disconnect assumes that we managed to setup the libevent handle, which
is that case we didn't, and crashes on an assert.
Review URL: http://codereview.chromium.org/12648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=huanr,kmixter,openvcdiff
Review URL: http://codereview.chromium.org/12699
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
warnings.
(gmail.com's certificate is for mail.google.com, which doesn't match gmail.com,
so on some distros, test_shell will now refuse to talk with gmail.com.)
Support ciphers needed to talk to testserver.py.
Load temporary testing cert needed to run unit tests (can't
do it manually like on Windows, since we don't use a writable cert database in the filesystem.)
Implement part of GetSSLInfo.
Re-enable url_request_unittest.cc, which seems to have been removed from the list of files to compile by mistake.
Addresses part of http://code.google.com/p/chromium/issues/detail?id=4510
Later changesets will implement x509 certificates for nss,
finish GetSSLInfo support, and update chrome/browser/ssl_uitest.cc
to use SSLTestUtil.
Review URL: http://codereview.chromium.org/11249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by phajdan.jr@gmail.com
R=darin
Review URL: http://codereview.chromium.org/12647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TLD data from the resource into a std::string, we can just always refer into the resource data. This saves ~40k or something meaningless.
Also use StringPiece to replace StringSegment, and other minor cleanup.
Review URL: http://codereview.chromium.org/11310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=openvcdiff,huanr
Review URL: http://codereview.chromium.org/11810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directories.
This is a revision of r5725. It doesn't break mac build.
Review URL: http://codereview.chromium.org/11507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
returning from the Disconnect method. This allows the caller
to destroy the read or write buffer safely when the destructor
(which calls Disconnect) returns.
R=eroman,rvargas
BUG=4449
Review URL: http://codereview.chromium.org/11299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around.
Review URL: http://codereview.chromium.org/11506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5740 0039d316-1c4b-4281-b951-d872f2087c98
|