| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through HTTPS Proxies. This also changes the mechanism used
to restart HttpProxyClientSocket requests with auth. Previously
the transport socket would be Disconnected, and then re-Connected
(which was not implemented for SSLClientSockets). However, the
approach was problematic in the face of, for example, ipv6. The
new approach is to close the HttpProxyClientSocket, and request
a new socket from the pool.
Initially was http://codereview.chromium.org/8502024
which turned out to have problems with NTLM auth.
Review URL: http://codereview.chromium.org/9148011
TBR=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310101
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=112328
TBR=agl@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316081
git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This function is a trap. It's a quick-and-dirty parser that has many nutty
quirks. There's only one caller left, and that callers should really be using
a Content-Type-specific parser anyway.
Review URL: http://codereview.chromium.org/9296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few more uses of the old Sleep(int ms) and PostDelayedTask()
interfaces slipped through since my last round of updates. Can you review
these?
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9104014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9159035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
introducing static initializers.
Member variables can stay TLS::Slots and their behavior doesn't change.
Static instances use TLS::StaticSlot instead.
Kind of like http://codereview.chromium.org/8491043 but for TLS.
BUG=none
TEST=none
TBR=agl
Review URL: https://chromiumcodereview.appspot.com/9297010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
X509CertificateTest.PublicKeyHashes.
This change disables a couple of tests that fails due ot an expired certificate.
TBR=agl
BUG=111893
TEST=make the "XP Tests (dbg)(2)" bot green.
Review URL: https://chromiumcodereview.appspot.com/9225052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chains.
NSS bug 721288 causes CERT_PKIXVerifyCert to continue extending the
certificate chain after it has reached a root certificate. Detect that
bug and ignore such extraneous root certificates in certificate chains
when checking for weak signature algorithms.
R=rsleevi@chromium.org
BUG=108514
TEST=a new unit test (to be added) that uses the certificate chain sent
by https://images.etrade.wallst.com/ during SSL handshake.
Review URL: http://codereview.chromium.org/9271060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
after the certificate expires.
R=rsleevi@chromium.org
BUG=111742
TEST=net_unittests should pass
Review URL: http://codereview.chromium.org/9232067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9190027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ide0e496c6919282ee707847c4d11db8a182eeac2
BUG=24403
TEST=Add a certificate. Ensure that it shows up when adding Wifi or VPN networks. Remove the certificate. Make sure it is no longer available when adding Wifi or VPN networks. Also, see issue.
Review URL: http://codereview.chromium.org/9280014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9235084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous, we were using GetHeaderParamValue to parse the Content-Disposition
header, which describes itself as a "quick and dirty implementation." After
this patch, we use more of our normal HTTP parsing machinery, making our
parsing much less quirky and better aligned with RFC 6266.
Some notes:
1) Many of the test cases for parsing the Content-Disposition header included
the string "Content-Disposition: " in the input. I've looked through all
of the callers of these functions, and that seems to be completely bogus.
The old parser wasn't careful enough to see that as a problem, but the new
one follows the spec more closely. I've updated the test cases to remove
this string.
2) After this patch, there's a bunch of code in net_util.cc that really should
be moved to http_content_disposition.cc. I didn't move that code in this
patch because I didn't want this path to be too large. I'll move it in a
future patch.
3) In a future patch, I'll audit the codebase for callers of
GetHeaderParamValue. With any luck, we'll be able to remove them all and
delete this less-than-amazing function.
BUG=65423
Review URL: http://codereview.chromium.org/9234055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This API wasn't tested at all.
BUG=72001
TEST=net_unittests
Review URL: http://codereview.chromium.org/9169091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting
new users.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9117038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9288034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsClient::Request ==> DnsTransaction
DnsTransaction ==> DnsTransactionImpl
DnsClient ==> DnsTransactionFactory
BUG=109949
TEST=net_unittests --gtest_filter=Dns*
Review URL: http://codereview.chromium.org/9190031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107056
TEST="Delete cookies and other site and plug-in data" option in Clear
Browsing Data dialog should clear origin bound certs.
Review URL: https://chromiumcodereview.appspot.com/9120001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(broke in r108543).
Refactor test DB code so that nss_util owns the test DB dir.
Keeping the test DB dir until exit prevents later tests that would use the test DB from failing. The dir will still be deleted by the LazyInstance atexit handler.
BUG=108748
TEST=see bug
Review URL: http://codereview.chromium.org/9255034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through HTTPS Proxies. This also changes the mechanism used
to restart HttpProxyClientSocket requests with auth. Previously
the transport socket would be Disconnected, and then re-Connected
(which was not implemented for SSLClientSockets). However, the
approach was problematic in the face of, for example, ipv6. The
new approach is to close the HttpProxyClientSocket, and request
a new socket from the pool.
Initially was http://codereview.chromium.org/8502024
which turned out to have problems with NTLM auth.
Review URL: http://codereview.chromium.org/9148011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up patch based on wtc's comments on the earlier patch:
http://codereview.chromium.org/9270030/
BUG=72001
TEST=no logic change
Review URL: http://codereview.chromium.org/9284033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many variable names in the code are misleading or not descriptive.
In particular, next_element_* are misleading as these are referring
to the current element currently being read.
Along the way, add some comments, and clean up some pieces of code.
BUG=72001
TEST=run tests via try bots
Review URL: http://codereview.chromium.org/9212015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Microsoft are providing a similar policy option and it looks like some
groups
may need it while their proxies are updated.
It's rather unfortunate that the underlying SSLConfigService member is
called
enable_false_start, but I don't want to conflate a clean up of that with
this
CL.
BUG=107728
TEST=none
http://codereview.chromium.org/9131012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UploadDataStream::MarkConsumedAndFillBuffer() may touch the file
system if the body data comes from a file.
BUG=72001,107966
TEST=added tests.
Review URL: http://codereview.chromium.org/9270030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converted the first 20 or so hits for LeakyLazyInstanceTraits on codesearch to
demonstrate the benefit at callsites. The real change is base/lazy_instance.h;
everything else is example.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9192024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
BUG=111029
TEST=CertDatabaseNSSTest.ImportCACertHierarchyTree
Review URL: https://chromiumcodereview.appspot.com/9200012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-lands r118489 but with static initializers removed.
BUG=25472, 107880
TEST=net_unittests
R=mmenke
Review URL: http://codereview.chromium.org/9226035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic is meaty enough to be factored out.
Add unit tests along the way.
The original patch (crrev.com/118265) was reverted as it introduced
a new static initializer. This version fixed that problem by defining
the constant in the .h file. To be extra careful, replaced
kChunkBufferSize with a member variable chunk_buffer_size_.
BUG=72001
TEST=add unit tests. run tools/linux/dump-static-initializers.py locally to confirm that new static initializers are not introduced.
Review URL: http://codereview.chromium.org/9176009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"""
Adds custom ttl argument to HostCache::Set.
BUG=25472,107880
TEST=net_unittests
Review URL: http://codereview.chromium.org/9197009
TBR=szym@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9138039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=25472,107880
TEST=net_unittests
Review URL: http://codereview.chromium.org/9197009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
splitting.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
otherwise open_sans.woff doesn't get loaded (not sure why)
BUG=none
TEST=open sans is used
Review URL: https://chromiumcodereview.appspot.com/9254001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Factor out chunk encoding logic into HttpStreamParser::EncodeChunk().
The logic is meaty enough to be factored out.
Add unit tests along the way.
BUG=72001
TEST=add unit tests.
Review URL: http://codereview.chromium.org/9242018
TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9264010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic is meaty enough to be factored out.
Add unit tests along the way.
BUG=72001
TEST=add unit tests.
Review URL: http://codereview.chromium.org/9242018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9221030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
canceled/completed/killed.
With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks.
Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled.
Both cases could happen in rare race conditions.
BUG=108968
TEST=no
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117342
Review URL: http://codereview.chromium.org/9147018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out the test passes OK (given access to java side pieces, failure of which this bug masks)
BUG=109783
TEST=
Review URL: http://codereview.chromium.org/9187007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
canceled/completed/killed.
With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks.
Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled.
Both cases could happen in rare race conditions.
BUG=108968
TEST=no
Review URL: http://codereview.chromium.org/9147018
TBR=battre@chromium.org
Review URL: http://codereview.chromium.org/9173005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for reworking UploadDataStream.
We'll make more changes in the upcoming patches.
BUG=72001
TEST=try bots
Review URL: http://codereview.chromium.org/9187021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequest::AppendFileToUpload() is no longer used
as now file uploads are done with UploadData.
TEST=chrome and tests build as before.
BUG=72001
Review URL: http://codereview.chromium.org/9148016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
canceled/completed/killed.
With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks.
Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled.
Both cases could happen in rare race conditions.
BUG=108968
TEST=no
Review URL: http://codereview.chromium.org/9147018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(There aren't any XP/Vista trybots any more.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(We don't have trybots any longer for those platforms.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/9152019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/9153014
TBR=agl@chromium.org
Review URL: http://codereview.chromium.org/9186009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=net_unittests
Review URL: http://codereview.chromium.org/9153014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117225 0039d316-1c4b-4281-b951-d872f2087c98
|