summaryrefslogtreecommitdiffstats
path: root/net/base
Commit message (Collapse)AuthorAgeFilesLines
* Revert 118950 - Allow chrome to handle 407 auth challenges to CONNECT requestsrch@chromium.org2012-02-041-4/+1
| | | | | | | | | | | | | | | | | | | | through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Initially was http://codereview.chromium.org/8502024 which turned out to have problems with NTLM auth. Review URL: http://codereview.chromium.org/9148011 TBR=rch@chromium.org Review URL: https://chromiumcodereview.appspot.com/9310101 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120443 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 120088 - net: add thepayplace.com to SSL blacklistagl@chromium.org2012-02-022-0/+2
| | | | | | | | | BUG=112328 TBR=agl@chromium.org Review URL: https://chromiumcodereview.appspot.com/9316081 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@120252 0039d316-1c4b-4281-b951-d872f2087c98
* Delete net::GetHeaderParamValueabarth@chromium.org2012-01-313-124/+0
| | | | | | | | | | This function is a trap. It's a quick-and-dirty parser that has many nutty quirks. There's only one caller left, and that callers should really be using a Content-Type-specific parser anyway. Review URL: http://codereview.chromium.org/9296005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119790 0039d316-1c4b-4281-b951-d872f2087c98
* Update a few more function calls to use TimeDeltas instead of int ms.tedvessenes@gmail.com2012-01-301-1/+1
| | | | | | | | | | | | | | | A few more uses of the old Sleep(int ms) and PostDelayedTask() interfaces slipped through since my last round of updates. Can you review these? R=jar@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9104014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119743 0039d316-1c4b-4281-b951-d872f2087c98
* OSSTATUS_LOG: Address review comments following r119511.mark@chromium.org2012-01-302-2/+2
| | | | | | Review URL: https://chromiumcodereview.appspot.com/9159035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119729 0039d316-1c4b-4281-b951-d872f2087c98
* Make it possible to use ThreadLocalStorage::Slot as a static withoutthakis@chromium.org2012-01-301-3/+2
| | | | | | | | | | | | | | | | | introducing static initializers. Member variables can stay TLS::Slots and their behavior doesn't change. Static instances use TLS::StaticSlot instead. Kind of like http://codereview.chromium.org/8491043 but for TLS. BUG=none TEST=none TBR=agl Review URL: https://chromiumcodereview.appspot.com/9297010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119679 0039d316-1c4b-4281-b951-d872f2087c98
* Disable X509CertificateTest.TestKnownRoot and ↵hbono@chromium.org2012-01-301-2/+4
| | | | | | | | | | | | | X509CertificateTest.PublicKeyHashes. This change disables a couple of tests that fails due ot an expired certificate. TBR=agl BUG=111893 TEST=make the "XP Tests (dbg)(2)" bot green. Review URL: https://chromiumcodereview.appspot.com/9225052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119648 0039d316-1c4b-4281-b951-d872f2087c98
* Check cert->isRoot to skip extraneous root certificates in certificatewtc@chromium.org2012-01-282-0/+61
| | | | | | | | | | | | | | | | | | chains. NSS bug 721288 causes CERT_PKIXVerifyCert to continue extending the certificate chain after it has reached a root certificate. Detect that bug and ignore such extraneous root certificates in certificate chains when checking for weak signature algorithms. R=rsleevi@chromium.org BUG=108514 TEST=a new unit test (to be added) that uses the certificate chain sent by https://images.etrade.wallst.com/ during SSL handshake. Review URL: http://codereview.chromium.org/9271060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119595 0039d316-1c4b-4281-b951-d872f2087c98
* Allow X509CertificateTest.IntermediateCARequireExplicitPolicy to passwtc@chromium.org2012-01-281-3/+9
| | | | | | | | | | | | after the certificate expires. R=rsleevi@chromium.org BUG=111742 TEST=net_unittests should pass Review URL: http://codereview.chromium.org/9232067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119592 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by jar.tedvessenes@gmail.com2012-01-283-9/+14
| | | | | | | | | | | R=jar@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9190027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119547 0039d316-1c4b-4281-b951-d872f2087c98
* Add OnUserCertRemoved to CertDatabase::Observerstevenjb@chromium.org2012-01-284-6/+27
| | | | | | | | | | | | Change-Id: Ide0e496c6919282ee707847c4d11db8a182eeac2 BUG=24403 TEST=Add a certificate. Ensure that it shows up when adding Wifi or VPN networks. Remove the certificate. Make sure it is no longer available when adding Wifi or VPN networks. Also, see issue. Review URL: http://codereview.chromium.org/9280014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119536 0039d316-1c4b-4281-b951-d872f2087c98
* Add OSSTATUS_LOG API.mark@chromium.org2012-01-274-27/+23
| | | | | | Review URL: https://chromiumcodereview.appspot.com/9235084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119511 0039d316-1c4b-4281-b951-d872f2087c98
* Improve parsing of the Content-Disposition headerabarth@chromium.org2012-01-273-354/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous, we were using GetHeaderParamValue to parse the Content-Disposition header, which describes itself as a "quick and dirty implementation." After this patch, we use more of our normal HTTP parsing machinery, making our parsing much less quirky and better aligned with RFC 6266. Some notes: 1) Many of the test cases for parsing the Content-Disposition header included the string "Content-Disposition: " in the input. I've looked through all of the callers of these functions, and that seems to be completely bogus. The old parser wasn't careful enough to see that as a problem, but the new one follows the spec more closely. I've updated the test cases to remove this string. 2) After this patch, there's a bunch of code in net_util.cc that really should be moved to http_content_disposition.cc. I didn't move that code in this patch because I didn't want this path to be too large. I'll move it in a future patch. 3) In a future patch, I'll audit the codebase for callers of GetHeaderParamValue. With any luck, we'll be able to remove them all and delete this less-than-amazing function. BUG=65423 Review URL: http://codereview.chromium.org/9234055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119378 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add tests for UploadDataStream::position().satorux@chromium.org2012-01-271-7/+17
| | | | | | | | | | | | This API wasn't tested at all. BUG=72001 TEST=net_unittests Review URL: http://codereview.chromium.org/9169091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119363 0039d316-1c4b-4281-b951-d872f2087c98
* Don't force groups.google.com to HTTPS.agl@chromium.org2012-01-262-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119250 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all remaining explicit LeakyLazyInstanceTraits users to ::Leakyfischman@chromium.org2012-01-264-11/+6
| | | | | | | | | | | | | and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting new users. BUG=none TEST=none Review URL: http://codereview.chromium.org/9117038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
* Fix warnings (which are now errors) in the Android build.jrg@chromium.org2012-01-263-6/+9
| | | | | | | | | | BUG=None TEST= Review URL: http://codereview.chromium.org/9288034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119155 0039d316-1c4b-4281-b951-d872f2087c98
* DnsClient refactoring + features (timeout, suffix search, server rotation).szym@chromium.org2012-01-262-11/+34
| | | | | | | | | | | | | | DnsClient::Request ==> DnsTransaction DnsTransaction ==> DnsTransactionImpl DnsClient ==> DnsTransactionFactory BUG=109949 TEST=net_unittests --gtest_filter=Dns* Review URL: http://codereview.chromium.org/9190031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119146 0039d316-1c4b-4281-b951-d872f2087c98
* Add origin bound certs to BrowsingDataRemover and extensions clear API.mattm@chromium.org2012-01-258-36/+115
| | | | | | | | | | BUG=107056 TEST="Delete cookies and other site and plug-in data" option in Clear Browsing Data dialog should clear origin bound certs. Review URL: https://chromiumcodereview.appspot.com/9120001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119084 0039d316-1c4b-4281-b951-d872f2087c98
* CertDatabaseNSSTest: Don't delete test DB dir since we don't close the DB ↵mattm@chromium.org2012-01-251-16/+5
| | | | | | | | | | | | | | | | (broke in r108543). Refactor test DB code so that nss_util owns the test DB dir. Keeping the test DB dir until exit prevents later tests that would use the test DB from failing. The dir will still be deleted by the LazyInstance atexit handler. BUG=108748 TEST=see bug Review URL: http://codereview.chromium.org/9255034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119003 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chrome to handle 407 auth challenges to CONNECT requestsrch@chromium.org2012-01-251-1/+4
| | | | | | | | | | | | | | | | | through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Initially was http://codereview.chromium.org/8502024 which turned out to have problems with NTLM auth. Review URL: http://codereview.chromium.org/9148011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118950 0039d316-1c4b-4281-b951-d872f2087c98
* net: Give more descriptive names for code around the request merging logic.satorux@chromium.org2012-01-241-1/+5
| | | | | | | | | | | | | This is a follow-up patch based on wtc's comments on the earlier patch: http://codereview.chromium.org/9270030/ BUG=72001 TEST=no logic change Review URL: http://codereview.chromium.org/9284033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118942 0039d316-1c4b-4281-b951-d872f2087c98
* Improve readability of UploadDataStream.satorux@chromium.org2012-01-242-80/+114
| | | | | | | | | | | | | | | | Many variable names in the code are misleading or not descriptive. In particular, next_element_* are misleading as these are referring to the current element currently being read. Along the way, add some comments, and clean up some pieces of code. BUG=72001 TEST=run tests via try bots Review URL: http://codereview.chromium.org/9212015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118854 0039d316-1c4b-4281-b951-d872f2087c98
* net: add a policy option: DisableSSLRecordSplittingagl@chromium.org2012-01-242-18/+3
| | | | | | | | | | | | | | | | | | | Microsoft are providing a similar policy option and it looks like some groups may need it while their proxies are updated. It's rather unfortunate that the underlying SSLConfigService member is called enable_false_start, but I don't want to conflate a clean up of that with this CL. BUG=107728 TEST=none http://codereview.chromium.org/9131012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118833 0039d316-1c4b-4281-b951-d872f2087c98
* net: Don't merge HTTP headers and body if the body is not in memory.satorux@chromium.org2012-01-245-0/+84
| | | | | | | | | | | | | UploadDataStream::MarkConsumedAndFillBuffer() may touch the file system if the body data comes from a file. BUG=72001,107966 TEST=added tests. Review URL: http://codereview.chromium.org/9270030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118769 0039d316-1c4b-4281-b951-d872f2087c98
* Add a convenience typedef LazyInstance<T>::Leaky to avoid repeating T.fischman@chromium.org2012-01-234-12/+7
| | | | | | | | | | | | | Converted the first 20 or so hits for LeakyLazyInstanceTraits on codesearch to demonstrate the benefit at callsites. The real change is base/lazy_instance.h; everything else is example. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9192024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118754 0039d316-1c4b-4281-b951-d872f2087c98
* Remove expired certificate from CertDatabaseNSSTest.ImportCACertHierarchyTree.joaodasilva@chromium.org2012-01-231-5/+10
| | | | | | | | | | TBR=eroman@chromium.org BUG=111029 TEST=CertDatabaseNSSTest.ImportCACertHierarchyTree Review URL: https://chromiumcodereview.appspot.com/9200012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118669 0039d316-1c4b-4281-b951-d872f2087c98
* Adds TTL argument to HostCache::Set.szym@chromium.org2012-01-215-100/+104
| | | | | | | | | | | | | Re-lands r118489 but with static initializers removed. BUG=25472, 107880 TEST=net_unittests R=mmenke Review URL: http://codereview.chromium.org/9226035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118574 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out chunk encoding logic into HttpStreamParser::EncodeChunk().satorux@chromium.org2012-01-212-9/+18
| | | | | | | | | | | | | | | | | | The logic is meaty enough to be factored out. Add unit tests along the way. The original patch (crrev.com/118265) was reverted as it introduced a new static initializer. This version fixed that problem by defining the constant in the .h file. To be extra careful, replaced kChunkBufferSize with a member variable chunk_buffer_size_. BUG=72001 TEST=add unit tests. run tools/linux/dump-static-initializers.py locally to confirm that new static initializers are not introduced. Review URL: http://codereview.chromium.org/9176009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118566 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118489 since it seems to regress linux-sizes.sadrul@chromium.org2012-01-205-103/+100
| | | | | | | | | | | | | | | | """ Adds custom ttl argument to HostCache::Set. BUG=25472,107880 TEST=net_unittests Review URL: http://codereview.chromium.org/9197009 TBR=szym@chromium.org Review URL: https://chromiumcodereview.appspot.com/9138039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118512 0039d316-1c4b-4281-b951-d872f2087c98
* Adds custom ttl argument to HostCache::Set.szym@chromium.org2012-01-205-100/+103
| | | | | | | | | | BUG=25472,107880 TEST=net_unittests Review URL: http://codereview.chromium.org/9197009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118489 0039d316-1c4b-4281-b951-d872f2087c98
* net: remove SSL blacklisted hosts that were included because of record ↵agl@chromium.org2012-01-201-28/+0
| | | | | | splitting. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118473 0039d316-1c4b-4281-b951-d872f2087c98
* [uber page] make references to chrome_shared2.css relativeestade@chromium.org2012-01-201-1/+2
| | | | | | | | | | | otherwise open_sans.woff doesn't get loaded (not sure why) BUG=none TEST=open sans is used Review URL: https://chromiumcodereview.appspot.com/9254001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118402 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118265 (added a static initializer on linux)thakis@chromium.org2012-01-192-9/+8
| | | | | | | | | | | | | | | | | | - Factor out chunk encoding logic into HttpStreamParser::EncodeChunk(). The logic is meaty enough to be factored out. Add unit tests along the way. BUG=72001 TEST=add unit tests. Review URL: http://codereview.chromium.org/9242018 TBR=satorux@chromium.org Review URL: https://chromiumcodereview.appspot.com/9264010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118295 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out chunk encoding logic into HttpStreamParser::EncodeChunk().satorux@chromium.org2012-01-192-8/+9
| | | | | | | | | | | | | The logic is meaty enough to be factored out. Add unit tests along the way. BUG=72001 TEST=add unit tests. Review URL: http://codereview.chromium.org/9242018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118265 0039d316-1c4b-4281-b951-d872f2087c98
* net/base: remove some wstringsevan@chromium.org2012-01-182-5/+5
| | | | | | Review URL: http://codereview.chromium.org/9221030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118024 0039d316-1c4b-4281-b951-d872f2087c98
* net: randomly remove 10% of the SSL blacklist.agl@chromium.org2012-01-171-233/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117969 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent callbacks after URLRequest/URLRequestJob have been ↵battre@chromium.org2012-01-132-7/+16
| | | | | | | | | | | | | | | | | | | | canceled/completed/killed. With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks. Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled. Both cases could happen in rare race conditions. BUG=108968 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117342 Review URL: http://codereview.chromium.org/9147018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117685 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect constant used in status bitmaskjoth@chromium.org2012-01-131-2/+2
| | | | | | | | | | | | Turns out the test passes OK (given access to java side pieces, failure of which this bug masks) BUG=109783 TEST= Review URL: http://codereview.chromium.org/9187007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117632 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117342 - Prevent callbacks after URLRequest/URLRequestJob have been ↵battre@chromium.org2012-01-131-9/+2
| | | | | | | | | | | | | | | | | | | | | canceled/completed/killed. With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks. Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled. Both cases could happen in rare race conditions. BUG=108968 TEST=no Review URL: http://codereview.chromium.org/9147018 TBR=battre@chromium.org Review URL: http://codereview.chromium.org/9173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117620 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup for UploadDataStream's constructor.satorux@chromium.org2012-01-132-2/+5
| | | | | | | | | | | | | This is in preparation for reworking UploadDataStream. We'll make more changes in the upcoming patches. BUG=72001 TEST=try bots Review URL: http://codereview.chromium.org/9187021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117588 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup after debugging with the XP builder.agl@chromium.org2012-01-122-23/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117437 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code from UploadData and URLRequest.satorux@chromium.org2012-01-122-10/+2
| | | | | | | | | | | | | URLRequest::AppendFileToUpload() is no longer used as now file uploads are done with UploadData. TEST=chrome and tests build as before. BUG=72001 Review URL: http://codereview.chromium.org/9148016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117357 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent callbacks after URLRequest/URLRequestJob have been ↵battre@chromium.org2012-01-121-2/+9
| | | | | | | | | | | | | | | | | | canceled/completed/killed. With this CL, URLRequestJobs notify their NetworkDelegate when they are being destroyed to insure that the NetworkDelegate does not access any of their variables or call callbacks. Also the WebRequest API does not execute any callbacks if they URLRequest has informed the API that the Request has been completed or canceled. Both cases could happen in rare race conditions. BUG=108968 TEST=no Review URL: http://codereview.chromium.org/9147018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117342 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing to debug via the builders since there's no XP trybot.agl@chromium.org2012-01-111-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117310 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing to debug with the XP builders.agl@chromium.org2012-01-111-0/+10
| | | | | | (There aren't any XP/Vista trybots any more.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117298 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugging to trace down a problem on WinXP/Vista.agl@chromium.org2012-01-112-5/+80
| | | | | | (We don't have trybots any longer for those platforms.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117265 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CRLSet checking on Mac.agl@chromium.org2012-01-112-3/+63
| | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9152019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117225 - Implement CRLSet checking on Windows.flackr@chromium.org2012-01-112-67/+3
| | | | | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9153014 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/9186009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117236 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CRLSet checking on Windows.agl@chromium.org2012-01-112-3/+67
| | | | | | | | | BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/9153014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117225 0039d316-1c4b-4281-b951-d872f2087c98