summaryrefslogtreecommitdiffstats
path: root/net/base
Commit message (Collapse)AuthorAgeFilesLines
* Coverity: Initialize data members in constructor.kmadhusu@chromium.org2010-10-182-1/+3
| | | | | | | | | | CID=1634, 11587, 5007, 13234, 13398, 9295, 8294, 8285 BUG=none TEST=none Review URL: http://codereview.chromium.org/3817007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62945 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on "access_time < Time::Now()" to indicate "all cookies".rdsmith@google.com2010-10-183-11/+6
| | | | | | | | | | | | | | | | The interface to CookieMonster::GarbageCollectDeleteList() was signalling "delete all cookies in list" by specifying "delete all cookies in list with last access time before Now()". This was failing to work properly when the system clock wasn't updated frequently enough (== flaky test) and is also vulnerable to changes in systems clocks. That semantic is now explicitly signalled by a null time. BUG=58197 TEST=net_unittests CookieMonsterTest.* on Win/Linux and CookieMonsterTest.TestHostGarbageCollection (flaky test) repeatedly on Windows. Review URL: http://codereview.chromium.org/3780004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62943 0039d316-1c4b-4281-b951-d872f2087c98
* Fix poorly performancing implementation of MockSimplePersistentCookieStorerdsmith@google.com2010-10-181-25/+18
| | | | | | | | | BUG=57686 TEST=net_unittests CookieMonsterTest.* on Linux, running original valgrind test and confirming that it completed. Review URL: http://codereview.chromium.org/3752004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62942 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang warning about local types being used as template parameters.thakis@chromium.org2010-10-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | clang would complain /Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:557:5: error: template argument uses local type 'net::HostResolverImpl::Job::Category' [-Wlocal-type-template-args] DCHECK_LT(category, RESOLVE_MAX); // Be sure it was set. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Users/thakis/src/chrome-git/src/net/base/host_resolver_impl.cc:5: In file included from ../net/base/host_resolver_impl.h:18: In file included from ../net/base/network_change_notifier.h:10: In file included from ../base/observer_list_threadsafe.h:14: ../base/logging.h:662:31: note: instantiated from: #define DCHECK_LT(val1, val2) DCHECK_OP(LT, < , val1, val2) ^ ../base/logging.h:635:9: note: instantiated from: logging::Check##name##Impl((val1), (val2), \ ^~~~~~~ This seems to be a new warning. Since it only affects this file, we might as well fix the problem instead of disabling the warning. BUG=None TEST=clang/mac waterfall stays green after clobber build. Review URL: http://codereview.chromium.org/3816009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62934 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructor cleanup: RRResolverHandle::Run does not need to be virtual.cbentzel@chromium.org2010-10-181-2/+2
| | | | | | | | BUG=45135 TEST=Build works. Review URL: http://codereview.chromium.org/3747008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62927 0039d316-1c4b-4281-b951-d872f2087c98
* Caches DER data in X509 certificate for OpenSSL.bulach@chromium.org2010-10-181-26/+94
| | | | | | | | | BUG=none TEST=net_unittests --gtest_filter=*X509* Review URL: http://codereview.chromium.org/3785001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62925 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62918 - net: clean up SSLHostInfo construction.agl@chromium.org2010-10-183-24/+11
| | | | | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/3846005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98
* net: clean up SSLHostInfo construction.agl@chromium.org2010-10-183-11/+24
| | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62918 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-172-6/+7
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_cftyperef from base to base/mac, use the new namespace, and name itbrettw@chromium.org2010-10-178-42/+49
| | | | | | | | | | properly (scoped_cftyperef -> ScopedCFTypeRef). TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3855001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62887 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bad merge.eroman@chromium.org2010-10-161-1/+1
| | | | | | | | | | The check-in r62746 clobbered the changes I made in r62689 to host_resolver_impl.cc. I believe that was an accident since r62746 moved code within the file. TBR=jar Review URL: http://codereview.chromium.org/3828008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62879 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61897 - Do not use Alternate-Protocol for establishing new SpdySessions.mbelshe@chromium.org2010-10-161-3/+0
| | | | | | | | | | | | | | | | | | | | | Only use Alternate-Protocol for latching onto existing SpdySessions. This is a temporary change until SSL improvements are made, so we can begin sending http over spdy when available. Note that we have to do proxy resolution one time to figure out how to check for the appropriate existing SpdySession. If no SpdySession exists, we fallback again and have to redo proxy resolution (since the alternate protocol of npn-spdy requires rewriting the URI from http:// to https://). So we may end up doing two proxy resolutions in the fallback case. I had to disable all the tests that test establishing a new SpdySession for http:// URIs, since we don't do that for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/3573013 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/3751009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62873 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - net/.pkasting@chromium.org2010-10-169-45/+33
| | | | | | | | | | Also converts COOKIE_DLOG (since VLOG can be toggled on a granular basis), removes some unneeded "endl"s and {}s, aligns "<<"s per style guide, and changes KeygenHandler::GenKeyAndSignChallenge() to avoid using "goto". BUG=none TEST=none Review URL: http://codereview.chromium.org/3846001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62831 0039d316-1c4b-4281-b951-d872f2087c98
* Add performance histograms to resolver, asong with A/B testjar@chromium.org2010-10-151-13/+61
| | | | | | | | | | | | | | | | | | | | | | I'm doing tests to see what the impact of changing the speculative resolution system parameters is on resolution time. By default, the speculative system limits itself to no more than 8 pending resolutions at any time, and this test looks at 6, 4, and 2 as limits. It also modulates the speculative congestion avoidance system, which purges the speculative queue when there is too much resolution latency, and tries various durations of time. (the latter was less important... but was already part of this existing A/B test.) I also pushed the test rates up to 10% for each case, so that we'd get data from the canary and/or dev builds. r=eroman Review URL: http://codereview.chromium.org/3762006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62746 0039d316-1c4b-4281-b951-d872f2087c98
* Return a distinct error from ERR_NAME_NOT_RESOLVED when the call to ↵eroman@chromium.org2010-10-153-5/+19
| | | | | | | | | | | | | | | getaddrinfo() has unexpectedly failed. For example when the system returns WSA_NOT_ENOUGH_MEMORY, we will now show ERR_NAME_RESOLUTION_FAILED rather than ERR_NAME_NOT_RESOLVED. This allows propagating the error to the user, rather than simply showing them say the linkdoctor page as if the domain they entered was incorrect. The data shows that a small number of users are getting these sorts of unexpected failures, and I want to get more visibility into it. By having a separate error code we can track how often this actually floats up onto an error page (as opposed to just errors on non-essential background requests). On Linux we also see EAI_AGAIN with some frequency. My theory is that these occur when you DNS resolve immediately after the network change notification was broadcast (since I can repro this 100% on my laptop). If this is in fact the major cause, then once I land this new error we should NOT see an influx of ERR_NAME_RESOLUTION_FAILED in Net.ErrorCodesForMainFrame. Review URL: http://codereview.chromium.org/3781005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62705 0039d316-1c4b-4281-b951-d872f2087c98
* Rename OSErrorForGetAddrinfo to include a suffix for the particular platform.eroman@chromium.org2010-10-151-1/+15
| | | | | | | This makes it easier to display the symbolic names of each error code on the server side, since we specify a mapping per histogram name. Review URL: http://codereview.chromium.org/3771005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62689 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "Use SSL 3.0" and "Use TLS 1.0" checkboxes towtc@chromium.org2010-10-143-4/+49
| | | | | | | | | | | | the Options menu ("Under the Hood" tab) on Windows. R=mattm BUG=59125 TEST=net_unittests.exe --gtest_filter=SSLConfigServiceWinTest.SetTest. Manually verify the Options menu has the two new checkboxes. Review URL: http://codereview.chromium.org/3779003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62634 0039d316-1c4b-4281-b951-d872f2087c98
* Add actual bytes sent/received to net-internals.mmenke@chromium.org2010-10-145-6/+22
| | | | | | | | | BUG=54745 TEST=manual Review URL: http://codereview.chromium.org/3582007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62627 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62605 - Make Run methods non-virtual on RRResolverWorker.cbentzel@chromium.org2010-10-141-2/+2
| | | | | | | | | | | | | | | | | | I don't think this needs to be reverted, but git cl dcommit went a bit wacky and I'm being conservative. The goal is to turn on -Wnon-virtual-dtor warning for gcc. In this case, the virtual Run()'s do not appear necessary, especially since they are private. If intended to be derived from, there is a "delete this" in the base class which would point to requiring a virtual destructor. BUG=45135 TEST=Target builds, validated that there are no derived classes of RRResolverWorker. Review URL: http://codereview.chromium.org/3824002 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62611 0039d316-1c4b-4281-b951-d872f2087c98
* Make Run methods non-virtual on RRResolverWorker.cbentzel@chromium.org2010-10-141-2/+2
| | | | | | | | | | | | | The goal is to turn on -Wnon-virtual-dtor warning for gcc. In this case, the virtual Run()'s do not appear necessary, especially since they are private. If intended to be derived from, there is a "delete this" in the base class which would point to requiring a virtual destructor. BUG=45135 TEST=Target builds, validated that there are no derived classes of RRResolverWorker. Review URL: http://codereview.chromium.org/3824002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62605 0039d316-1c4b-4281-b951-d872f2087c98
* SSLConfig struct CertAndStatus is not initializing all its members.finnur@chromium.org2010-10-141-2/+2
| | | | | | | | | | | BUG=None TEST=None CID=13288 Review URL: http://codereview.chromium.org/3781002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62532 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-1413-61/+63
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-143-3/+3
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate the SpdyProxyClientSocket into the HttpStreamRequestrch@chromium.org2010-10-131-1/+4
| | | | | | | | | | | to support fetching HTTPS URLS over a SPDY Proxy. BUG=29625 TEST=HttpNetworkTransactionTest.HttpsProxySpdyConnect Review URL: http://codereview.chromium.org/3417010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62468 0039d316-1c4b-4281-b951-d872f2087c98
* Add ClientSocketPoolBaseHelper support for preconnect.willchan@chromium.org2010-10-131-0/+14
| | | | | | | | | | | | | | | | | | | Adds a RequestSockets() API to ClientSocketPool interface. - no RequestPriority param, all requests default to LOWEST. - adds a |num_sockets| param to control how many sockets to try to ensure are connected. Adds an implementation for said function in ClientSocketPoolBaseHelper. Adds a new ClientSocketPoolBaseHelper::Flag type to modify socket request behavior. In this case, we bypass idle sockets. Adds a preconnect concept to ConnectJob. This lets normal requests hijack preconnect jobs. Modifies all ClientSocketPool subclasses to support new RequestSockets API(). Adds new tests. No client actually uses this API yet. We need to plumb it up to the preconnect system. BUG=54450 TEST=new tests in ClientSocketPoolBaseTest Review URL: http://codereview.chromium.org/3689004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62365 0039d316-1c4b-4281-b951-d872f2087c98
* Remove non-internationalized SDCH warning message.jar@chromium.org2010-10-121-1/+5
| | | | | | | | BUG=33185 r=kmixter Review URL: http://codereview.chromium.org/3702005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62353 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI cert manager: Add CA cert import.mattm@chromium.org2010-10-122-2/+2
| | | | | | | | | | | Minor cleanup of CertificateManagerModel by removing some wrappers of CertDatabase readonly functions. BUG=19991 TEST=manual Review URL: http://codereview.chromium.org/3516023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62348 0039d316-1c4b-4281-b951-d872f2087c98
* Report AcquireCredentialsHandle errors. This requireswtc@chromium.org2010-10-121-0/+6
| | | | | | | | | | | | | | changing GetCredHandle to return 'int' (the error code). Add ERR_SSL_CLIENT_AUTH_PRIVATE_KEY_ACCESS_DENIED and ERR_SSL_CLIENT_AUTH_CERT_NO_PRIVATE_KEY. R=eroman BUG=55678 TEST=none Review URL: http://codereview.chromium.org/3696006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62336 0039d316-1c4b-4281-b951-d872f2087c98
* Render SpdySessionPools on the Data tab and on a newmmenke@chromium.org2010-10-122-4/+11
| | | | | | | | | | | | | | net-internals tab, with links to the corresponding sources on the events tab. Includes a minor cleanup or two relating to unneeded/unused code/headers for the rendering of SocketPools. BUG=58034 TEST=manual Review URL: http://codereview.chromium.org/3565015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62329 0039d316-1c4b-4281-b951-d872f2087c98
* net: fix small leak in DnsRRResolveragl@chromium.org2010-10-121-6/+5
| | | | | | | BUG=57456 TEST=valgrind net_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62323 0039d316-1c4b-4281-b951-d872f2087c98
* Rename SSLNonSensitiveHostInfo to SSLHostInfo.agl@chromium.org2010-10-123-68/+12
| | | | | | | | | | | No effective code change. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3728002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62295 0039d316-1c4b-4281-b951-d872f2087c98
* net: replicate r62288 in DnsRRResolveragl@chromium.org2010-10-121-1/+5
| | | | | | | | | | | | | When _res is uninitialized, res_nclose may end up closing fd 0. Test whether it's initialized before closing. Patch by Jim Deng. TBR=evanm Original review URL: http://codereview.chromium.org/3717002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62292 0039d316-1c4b-4281-b951-d872f2087c98
* linux: avoid closing uninitialized resolverevan@chromium.org2010-10-121-1/+5
| | | | | | | | | | | | | When _res is uninitialized, res_nclose may end up closing fd 0. Test whether it's initialized before closing. Patch by Jim Deng <jdeng@google.com>. TEST=chrome without a net connection doesn't crash on startup Review URL: http://codereview.chromium.org/3717002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62288 0039d316-1c4b-4281-b951-d872f2087c98
* net:: comment fixes onlyrsleevi@chromium.org2010-10-121-0/+8
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62240 0039d316-1c4b-4281-b951-d872f2087c98
* CertDatabase: Add ImportServerCerts method.mattm@chromium.org2010-10-124-0/+90
| | | | | | | | | BUG=19991 TEST=net_unittests Review URL: http://codereview.chromium.org/3576016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62228 0039d316-1c4b-4281-b951-d872f2087c98
* net: detect and error out with ESET HTTPS interception + False Startagl@chromium.org2010-10-111-4/+14
| | | | | | | | | | | | | | ESET products (anti-virus) and NetNanny can intercept HTTPS connections. However, they're False Start intolerant. Rather than have connections hang forever, we detect them by the leaf certificate's issuer common name and give a helpful error message. BUG=58152 TEST=Install ESET anti-virus. Configure to intercept HTTPS connections. Goto https://mail.google.com. Confirm that a helpful error page appears. Review URL: http://codereview.chromium.org/3723001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62209 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 58162: Mixed Content False Positive for intranet hostname certificatesfinnur@chromium.org2010-10-112-5/+9
| | | | | | | | | | | Previously, we lumped the intranet host warning in with mixed content warning. This calls it out as a separate warning. BUG=58162 TEST=None Review URL: http://codereview.chromium.org/3536019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62178 0039d316-1c4b-4281-b951-d872f2087c98
* net: ssl_non_sensitive_host_info.h => ssl_host_info.hagl@chromium.org2010-10-111-0/+56
| | | | | | | | | | | | This is a prelim commit for renaming SSLNonSensitiveHostInfo to SSLHostInfo. No code change. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62174 0039d316-1c4b-4281-b951-d872f2087c98
* Have OpenSSL simply increment the ref-count, rather than copy and reparse ↵rsleevi@chromium.org2010-10-091-1/+4
| | | | | | | | | | | | the entire certificate R=wtc BUG=None TEST=Build with use_openssl=1, X509Certificate* tests continue to work Review URL: http://codereview.chromium.org/3677001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62091 0039d316-1c4b-4281-b951-d872f2087c98
* Return ERR_INTERNET_DISCONNECTED in place of ERR_NAME_NOT_RESOLVED and ↵eroman@chromium.org2010-10-099-5/+176
| | | | | | | | | | | | ERR_ADDRESS_UNREACHABLE, when the user is in offline mode. This initial changelist includes the implementation just for Windows. BUG=53473 TEST=unplug network cable, try to connect to www.google.com --> should get the error ERR_INTERNET_DISCONNECTED. Next, try connecting directly to an IP address --> should get the error ERR_INTERNET_DISCONNECTED. Review URL: http://codereview.chromium.org/3634002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62050 0039d316-1c4b-4281-b951-d872f2087c98
* Remove log for errors opening files. It's the client's responsibility to log ↵pinkerton@chromium.org2010-10-081-2/+0
| | | | | | | | | | if it's really an error BUG=56681 TEST=none Review URL: http://codereview.chromium.org/3620015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61965 0039d316-1c4b-4281-b951-d872f2087c98
* Connect up OpenSSL socket to use the OpenSSL X509Certificate.joth@chromium.org2010-10-083-7/+45
| | | | | | | | | | | | | Also adds SSL_CTX to the OpenSSLInitSingleton to make initialization thread-safe. Note this depends on http://codereview.chromium.org/3529008 BUG=None TEST=build with use_openssl=1, open some https pages Review URL: http://codereview.chromium.org/3591015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61963 0039d316-1c4b-4281-b951-d872f2087c98
* Adds X509 certificates for OpenSSL.bulach@chromium.org2010-10-0812-42/+675
| | | | | | | | | | Depends on http://codereview.chromium.org/3565006/show TEST=Existing *X509* tests should pass. Review URL: http://codereview.chromium.org/3529008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61955 0039d316-1c4b-4281-b951-d872f2087c98
* Decouples certificates viewers from NSS to prepare support for OpenSSL.bulach@chromium.org2010-10-082-17/+31
| | | | | | | | | | | | This change is a pre-requisite for http://codereview.chromium.org/3529008/show There are no functional changes, it's only refactoring existing code. BUG=None TEST=Go to an https:// page and check the certificate info. Review URL: http://codereview.chromium.org/3565006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61944 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use Alternate-Protocol for establishing new SpdySessions.willchan@chromium.org2010-10-081-0/+3
| | | | | | | | | | | | | | | | | | Only use Alternate-Protocol for latching onto existing SpdySessions. This is a temporary change until SSL improvements are made, so we can begin sending http over spdy when available. Note that we have to do proxy resolution one time to figure out how to check for the appropriate existing SpdySession. If no SpdySession exists, we fallback again and have to redo proxy resolution (since the alternate protocol of npn-spdy requires rewriting the URI from http:// to https://). So we may end up doing two proxy resolutions in the fallback case. I had to disable all the tests that test establishing a new SpdySession for http:// URIs, since we don't do that for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/3573013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61897 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Cert Manager: Edit CA cert trust.mattm@chromium.org2010-10-082-2/+2
| | | | | | | | | BUG=19991 TEST=manual Review URL: http://codereview.chromium.org/3549020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61895 0039d316-1c4b-4281-b951-d872f2087c98
* Shows the default_address_family on both the DNS tab and in log dumps,mmenke@chromium.org2010-10-073-0/+8
| | | | | | | | | | | | | | | and adds an extra note emphasizing when IPv6 has been disabled to both pages. Also adds a button to enable IPv6 when it's been disabled, and maps address family values on the DNS tab to their symbolic names. BUG=55007,55005 TEST=manual Review URL: http://codereview.chromium.org/3387007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61795 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete TODOs. The referred bug has been closed for a while.jeanluc@google.com2010-10-071-6/+0
| | | | | | | | | TEST=None BUG=0 Review URL: http://codereview.chromium.org/3604010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61748 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Certificate Manager: Backup and restore PKCS #12 files. Export certs. ↵mattm@chromium.org2010-10-062-2/+3
| | | | | | | | | | | Delete certs. BUG=19991 TEST=manual Review URL: http://codereview.chromium.org/3556007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61701 0039d316-1c4b-4281-b951-d872f2087c98
* CookieMonsterTest.TestHostGarbageCollection fails net_unittests on Modules XPdhollowa@chromium.org2010-10-061-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding FLAKY designation to this test. http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP/builds/35620/steps/net_unittests/logs/stdio [ OK ] CookieMonsterTest.TestLastAccess (219 ms) [ RUN ] CookieMonsterTest.TestHostGarbageCollection .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 181 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 183 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 185 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 187 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 189 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 191 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 193 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 195 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 197 vs 180 .\base\cookie_monster_unittest.cc(1080): error: Expected: ((CountInString(cookies_general, '=') + CountInString(cookies_specific, '='))) <= (domain_max_cookies), actual: 199 vs 180 [ FAILED ] CookieMonsterTest.TestHostGarbageCollection (219 ms) [ RUN ] CookieMonsterTest.NetUtilCookieTest BUG=58197 TEST=CookieMonsterTest.MAYBE_TestHostGarbageCollection TBR=rdsmith@chromium.org Review URL: http://codereview.chromium.org/3610014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61699 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 21:57:07 +0000