summaryrefslogtreecommitdiffstats
path: root/net/base
Commit message (Collapse)AuthorAgeFilesLines
* FBTF: Remove unneeded headers from base/ (part 10)thestig@chromium.org2010-11-301-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5139006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67662 0039d316-1c4b-4281-b951-d872f2087c98
* Implement exponential back-off mechanism.joi@chromium.org2010-11-251-0/+3
| | | | | | | | | | | | | | | | | | | | | | | Contributed by yzshen@google.com, original review http://codereview.chromium.org/4194001/ Implement exponential back-off mechanism. Enforce it at the URLRequestHttpJob level for all outgoing HTTP requests. The reason why to make this change is that we need back-off logic at a lower enough level to manage all outgoing HTTP traffic, so that the browser won't cause any DDoS attack. This change: 1) patches http://codereview.chromium.org/2487001/show, which is the exponential back-off implementation. 2) resolves conflicts with URLFetcher, by removing its own back-off logic: -- removes url_fetcher_protect.{h,cc}; -- integrates the sliding window mechanism of URLFetcherProtectEntry into RequestThrottlerEntry. 3) resolves conflicts with CloudPrintURLFetcher. 4) makes unit tests of CloudPrintURLFetcher, URLFetcher and URLRequest work. BUG=none TEST=pass all existing tests and also the newly-added request_throttler_unittest.cc Review URL: http://codereview.chromium.org/5276007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67375 0039d316-1c4b-4281-b951-d872f2087c98
* Fix shutdown crash in CertVerifier by using a MessageLoopProxy.willchan@chromium.org2010-11-231-16/+19
| | | | | | | | | | | The CertVerifier is not getting Cancel()'d because something which owns it is getting leaked, most likely a URLRequestJob. Therefore, we can end up accessing a deleted MessageLoop on shutdown. MessageLoopProxy prevents accessing a deleted MessageLoop on shutdown, instead it just deletes the task, which isn't great, but it's better than crashing. We should fix the root cause eventually, which is a leak of the URLRequestJob. BUG=42275,chromium-os:8179 TEST=none Review URL: http://codereview.chromium.org/5347001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67172 0039d316-1c4b-4281-b951-d872f2087c98
* Make NetLog::EventParameters RefCountedThreadSafe.mmenke@chromium.org2010-11-231-1/+1
| | | | | | | | | | | | | This avoids a potential race condition in events logged on other threads and then passed to the IO thread by a ForwardingNetLog (Such as ProxyResolvers do). BUG=64188 TEST=none Review URL: http://codereview.chromium.org/5354001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67142 0039d316-1c4b-4281-b951-d872f2087c98
* Add delay when resuming load when network connection is restured.oshima@chromium.org2010-11-221-5/+5
| | | | | | | | | | | | | | | | | Without delay, chrome silently fails to load the page. This is a wordaround and should be remoevd once the root cause is fixed. * Different delays for secure and non secure connection as secure connection needs longer delay. * I simply shortened proxy resolution as this may hit the same issue, and short enough that the page load happens after proxy resolution. BUG=chromium-os:8285 TEST=see the bug description for repro steps. Review URL: http://codereview.chromium.org/5156007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66990 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up style issues in net:: related to X.509 data-types, eliminating ↵rsleevi@chromium.org2010-11-229-199/+148
| | | | | | | | | | | | | unnecessary includes and marking platform-specific implementations as such. Also clearly document that CertPrincipal::Matches() is not suitable for security-relevant name checks. In addition, because x509_cert_types.h no longer includes base/singleton.h, fix all the classes that broke because they weren't including what they used. BUG=none TEST=existing Review URL: http://codereview.chromium.org/5162001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66941 0039d316-1c4b-4281-b951-d872f2087c98
* Remember if a user declines to provide a server with a client certificatersleevi@chromium.org2010-11-223-23/+99
| | | | | | | | | | | | | | | | | When an SSL/TLS server requests a client certificate, the user may opt to not send any certificate. This will work if the server does not require a client certificate to be sent in order to load the resource - for example, to fall-back to forms-based authentication or when client certificates are configured as optional. If the user declines to provide a client certificate, remember that choice in the SSLClientAuthCache so that they will not be repeatedly prompted to select a certificate (declining each time) for every sub-resource that loads, similar to how the SSLClientAuthCache remembers an explicit certificate selected by a user. If the server requires a client certificate, it is expected that it will abort the TLS handshake with an appropriate TLS error code. When the server aborts and the error code is processed, the existing cached selection will be removed, and the user will be re-prompted to select a certificate on their next connection to that server. If the server requires a client certificate to continue, but does not use the TLS stack to indicate that requirement - for example, to return a "friendlier" error page or an HTTP error code like 403, the selection will not be evicted from the cache, and the user must restart the browser before they will be prompted again for a certificate from that server. This is the same lifetime and behaviour as would happen if the user actively selected a certificate, rather than declined to provide one. BUG=56177 TEST=SSLClientAuthCacheTest.LookupNullPreference . Also see the Apache configuration in http://crbug.com/56177. Access a site that requests, but does not require, client authentication, which will attempt to load multiple sub-resources, and which does not permit HTTP KeepAlives. Review URL: http://codereview.chromium.org/4568002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66931 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 9)thestig@chromium.org2010-11-201-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5091005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66873 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 66791 (change was innocent)willchan@chromium.org2010-11-197-45/+64
| | | | | | | | | | | | | | | | | | | Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread. Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5206005 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5242002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66808 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread.willchan@chromium.org2010-11-197-64/+45
| | | | | | | | | | | | | | Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5206005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66791 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a dispatcher for prerender requestsgavinp@chromium.org2010-11-191-0/+5
| | | | | | | | | | | | | | | | | | | This CL provides a dispatcher that can feed the prerender system with HTML type requests that were prefetched. One thing is missing though: this sends all requests in, and doesn't tag the origin request. Unfortunately referer information is often tossed out in resource_dispatcher_host... Is there a private place it's sent along to for this type of use? I left that undone right now but I'm open to suggestions about a good way to do it. BUG=none TEST=none Review URL: http://codereview.chromium.org/4655004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix openssl build to work with AllowSingleton changesjoth@chromium.org2010-11-191-3/+9
| | | | | | | | | BUG=61585 TEST=net & base unit tests; start & quit browser Review URL: http://codereview.chromium.org/5102006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66772 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r65996. Disallows Singletons on non-joinable thread.willchan@chromium.org2010-11-197-45/+64
| | | | | | | | | | | Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66719 0039d316-1c4b-4281-b951-d872f2087c98
* Implements Signature Creator & Verifier for openssljoth@chromium.org2010-11-181-1/+1
| | | | | | | | | | | Also adds a little more infrastructure to assist in openssl error handling. BUG=None TEST=base_unittests RSA* and Sign* Review URL: http://codereview.chromium.org/5105003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66622 0039d316-1c4b-4281-b951-d872f2087c98
* Add shared macros for stringizing and converting ANSI string constantsjoi@chromium.org2010-11-181-3/+2
| | | | | | | | | | | | | | | | | | | | | (in particular defined by macros) to wide string constants. Convert existing locally-defined stringizing to use the shared macros. Unit tests for the shared macros. This also fixes a minor bug in ceee_module_util.cc where I accidentally quoted a string constant I only meant to convert to wide (this caused no bug, but was unintended, so the change in semantics in that file in the current change is intentional). BUG=none TEST=automated tests Review URL: http://codereview.chromium.org/5103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66579 0039d316-1c4b-4281-b951-d872f2087c98
* Original change: http://codereview.chromium.org/4856003/bulach@chromium.org2010-11-171-2/+2
| | | | | | | | | | | | | | | | (landing on behalf of kristianm) Suppress Android warnings Android generates warnings for comparing signed and unsigned numbers. The ones in this CL should be safe. BUG=62949 TEST=None Review URL: http://codereview.chromium.org/5035002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66420 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor EnsureOpenSSLInit and openssl_util into basejoth@chromium.org2010-11-175-167/+43
| | | | | | | | | | | | This allows the base/crypto methods to call EnsureOpenSSLInit. Also factors out the SSL_CTX and X509_STORE to be more closely associated with their consumers (ssl socket and X509Certificate resp.) rather than process wide globals. BUG=None TEST=None Review URL: http://codereview.chromium.org/4963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66413 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure a cookie can be deleted, even when forced to session only.jochen@chromium.org2010-11-163-7/+48
| | | | | | | | | BUG=63258 TEST=net_unittests --gtest_filter=CookieMonsterTest.ForceSessionOnly Review URL: http://codereview.chromium.org/4967004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66281 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for certificate name checkingjoth@chromium.org2010-11-164-3/+230
| | | | | | | | | | | There's nothing OpenSSL specific about this implementation, other than this is the only platform that does not already supply an implementation of this method. BUG=60719 TEST=net_unittests --gtest_filter=X509CertificateCertificateNameVerifyTest.* Review URL: http://codereview.chromium.org/4184004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66263 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65996 (test breakage) - Disallow Singleton and LazyInstance on ↵willchan@chromium.org2010-11-137-63/+44
| | | | | | | | | | | | | | | | non-joinable threads. Fix all known instances or explicitly allow them. Usually the fix involves switching from Default traits to Lazy traits. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/4635012 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/4980001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66071 0039d316-1c4b-4281-b951-d872f2087c98
* Disallow Singleton and LazyInstance on non-joinable threads.willchan@chromium.org2010-11-127-44/+63
| | | | | | | | | | | Fix all known instances or explicitly allow them. Usually the fix involves switching from Default traits to Lazy traits. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/4635012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65996 0039d316-1c4b-4281-b951-d872f2087c98
* Use DCHECK instead of CHECK to assert that policy_oids_ iswtc@chromium.org2010-11-121-1/+1
| | | | | | | | | | | in ascending order. R=rvargas BUG=41267 TEST=none Review URL: http://codereview.chromium.org/4871001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65964 0039d316-1c4b-4281-b951-d872f2087c98
* net: add mit.edu to False Start blacklist.agl@chromium.org2010-11-111-0/+1
| | | | | | Based on private communication with davidben. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65808 0039d316-1c4b-4281-b951-d872f2087c98
* openssl build fixes, and tidy the build filesjoth@chromium.org2010-11-111-2/+4
| | | | | | | | | | | Split out of http://codereview.chromium.org/4691003/ BUG=None TEST=builds... Review URL: http://codereview.chromium.org/4696004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65801 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for restricting the cipher suites that SSLClientSocket(Mac,NSS) ↵rsleevi@chromium.org2010-11-113-0/+28
| | | | | | | | | | | | use. Restricting SSLClientSocketWin is handled by the existing Windows system policy (which deals in algorithms, not cipher suites). R=wtc BUG=58831 TEST=SSLClientSocketTest.CipherSuiteDisables Review URL: http://codereview.chromium.org/3845005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65773 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind fix.agl@chromium.org2010-11-101-0/+1
| | | | | | | | | I forgot to init a member in r65677. BUG=none TEST=valgrind git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65724 0039d316-1c4b-4281-b951-d872f2087c98
* net: assorted changes needed for Snap Start tests.agl@chromium.org2010-11-103-1/+8
| | | | | | | | | | | | | | | | | | | | In IsAllowedBadCert, the pointer compare doesn't always work. Creating a certificate by X509Certificate::CreateFromBytes and putting it in the allowed bad list doesn't match the same certificate from a server. InvalidateSessionIfBadCertificate: I'm sure that there's history here that I don't know, so please review carefully. In order to test resumption against a server with a test certificate we need to avoid destroying the session. ClearSessionCache, AdoptSocket: only for testing BUG=none TEST=none http://codereview.chromium.org/4558004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65713 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using DestructionObserver in OCSP code. Explicilty cancel all URLRequests.willchan@chromium.org2010-11-091-0/+6
| | | | | | | | | BUG=59630 TEST=none Review URL: http://codereview.chromium.org/4119020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65479 0039d316-1c4b-4281-b951-d872f2087c98
* net: update False Start blacklist with latest results.agl@chromium.org2010-11-081-1/+4442
| | | | | | | | | | | | | | (Reland of r65385, reverted in r65387. r65402 and r65421 should have fixed the issues.) (details of the contents given privately.) BUG=none TEST=net_unittests http://codereview.chromium.org/4598003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65448 0039d316-1c4b-4281-b951-d872f2087c98
* net: update False Start blacklist processing for \r\nagl@chromium.org2010-11-081-9/+18
| | | | | | | | | | | | | | | | | | | | | | | | | It's not clear what's happening because I don't have a Windows machine and this was all done via try server runs: I think the problem is that the new False Start blacklist is larger than fread on Windows will read in one lump. That was causing the processing to fail on Windows. However, the simple fix of calling fread until its done didn't work because it never reads enough bytes. What's happening is that ftell is returning the true size of the file, but fread was converting \r\n to \n so the reported number of bytes read was too small. Why that wasn't happening before I'm not sure. I suspect that the file on disk on the Windows builders is \n and it's patch on the tryserver which is writing the file out with the extra \r bytes. Either way, this hopefully makes everything work. BUG=none TEST=net_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65421 0039d316-1c4b-4281-b951-d872f2087c98
* net: use a char array for the False Start blacklist.agl@chromium.org2010-11-081-12/+5
| | | | | | | | | | | Windows fails to build if any strings are > 64K long. Since the next blacklist update breaks this limit, we have to switch the blacklist to being a char array. BUG=none TEST=net_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65402 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "net: update False Start blacklist with latest results."agl@chromium.org2010-11-081-4442/+1
| | | | | | | | This reverts commit r65385 VC: "string exceeds 65535 bytes in length" git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65387 0039d316-1c4b-4281-b951-d872f2087c98
* net: update False Start blacklist with latest results.agl@chromium.org2010-11-081-1/+4442
| | | | | | | | | | | (details given privately.) BUG=none TEST=net_unittests http://codereview.chromium.org/4598003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65385 0039d316-1c4b-4281-b951-d872f2087c98
* net: update False Start blacklist for 32-bit indexes.agl@chromium.org2010-11-083-14/+13
| | | | | | | | | | | (Needed for the next list update.) BUG=none TEST=net_unittests http://codereview.chromium.org/4599002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65376 0039d316-1c4b-4281-b951-d872f2087c98
* net: add neg9.org to the HSTS Preloaded list.agl@chromium.org2010-11-082-0/+4
| | | | | | | | | Requested by Ian Gallagher. BUG=none TEST=net_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65375 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65349 - Update CertVerifier to watch for the origin loop's ↵skerner@chromium.org2010-11-081-17/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | destruction, so that it doesn't crash if the SSLClientSocket is leaked. BUG=chromium-os:8179 TEST=None Linux browser tests are consistently failing. Example stack: SSLUITest.TestDisplaysInsecureContentTwoTabs: [11279:11279:1107/212311:929558354690:WARNING:chrome/installer/util/master_preferences.cc(56)] Failed to read master prefs file. [11279:11279:1107/212311:929558354814:ERROR:chrome/installer/util/master_preferences.cc(137)] Failed to parse /mnt/data/build/slave/Linux_Builder__Views_dbg_/build/src/out/Debug/master_preferences [11279:11279:1107/212311:929558672237:WARNING:views/widget/widget_gtk.cc(293)] compositing not supported; allowing anyway LEAK: 4 WebCoreNode [11279:11291:1107/212312:929559555051:FATAL:base/message_loop.cc(200)] Check failed: this == current(). Backtrace: base::debug::StackTrace::StackTrace() [0x124edb6] logging::LogMessage::~LogMessage() [0x126455b] MessageLoop::RemoveDestructionObserver() [0x126695d] net::CertVerifier::Request::Cancel() [0x1944eb5] net::CertVerifier::Request::~Request() [0x194505a] base::RefCountedThreadSafe<>::DeleteInternal() [0x194544c] base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x1945420] base::RefCountedThreadSafe<>::Release() [0x19452ec] RunnableMethodTraits<>::ReleaseCallee() [0x1945628] RunnableMethod<>::ReleaseCallee() [0x194559c] RunnableMethod<>::~RunnableMethod() [0x19454ce] (anonymous namespace)::WorkerThread::ThreadMain() [0x12c904f] ThreadFunc() [0x12860bf] start_thread [0x2afc1af6d9ca] 0x2afc1d5156fd [11279:11291:1107/212312:929559555051:FATAL:base/message_loop.cc(200)] Check failed: this == current(). Backtrace: base::debug::StackTrace::StackTrace() [0x124edb6] logging::LogMessage::~LogMessage() [0x126455b] MessageLoop::RemoveDestructionObserver() [0x126695d] net::CertVerifier::Request::Cancel() [0x1944eb5] net::CertVerifier::Request::~Request() [0x194505a] base::RefCountedThreadSafe<>::DeleteInternal() [0x194544c] base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x1945420] base::RefCountedThreadSafe<>::Release() [0x19452ec] RunnableMethodTraits<>::ReleaseCallee() [0x1945628] RunnableMethod<>::ReleaseCallee() [0x194559c] RunnableMethod<>::~RunnableMethod() [0x19454ce] (anonymous namespace)::WorkerThread::ThreadMain() [0x12c904f] ThreadFunc() [0x12860bf] start_thread [0x2afc1af6d9ca] 0x2afc1d5156fd Killed (timed out). Review URL: http://codereview.chromium.org/4299001 TBR=zork@chromium.org Review URL: http://codereview.chromium.org/4669003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65372 0039d316-1c4b-4281-b951-d872f2087c98
* Update CertVerifier to watch for the origin loop's destruction, so thatzork@chromium.org2010-11-081-2/+17
| | | | | | | | | | | it doesn't crash if the SSLClientSocket is leaked. BUG=chromium-os:8179 TEST=None Review URL: http://codereview.chromium.org/4299001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65349 0039d316-1c4b-4281-b951-d872f2087c98
* net: Silently disable False Start when NetNanny is detected.agl@chromium.org2010-11-051-4/+1
| | | | | | | | | | | | | | | | | | In r62209 we added code to detect ESET and NetNanny and to give users instructions for disabling their HTTPS scanning. This was because these products intercept Chrome's HTTPS connections and break because of False Start. NetNanny has been responsive to the issue and is rolling out a fix. In the mean time, we silently disable False Start when NetNanny is detected to give them time to update their users etc. BUG=59798 TEST=Navigate to https://www.paypal.com on Windows with NetNanny installed. http://codereview.chromium.org/4449003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65199 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, merge X509Certificate::VerifyEV intowtc@chromium.org2010-11-045-83/+163
| | | | | | | | | | | | | | | | X509Certificate::Verify, so that we call the Windows CertGetCertificateChain function only once in the common case. This allows us to do EV verification, with little overhead, even if the caller doesn't ask for it. This requires adding new methods to the EVRootCAMetadata class. R=rvargas BUG=41267 TEST=none Review URL: http://codereview.chromium.org/4124012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65139 0039d316-1c4b-4281-b951-d872f2087c98
* net: add certificate provenance checking.agl@chromium.org2010-11-042-0/+19
| | | | | | | | | BUG=none TEST=none http://codereview.chromium.org/4448001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65116 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-041-0/+8
| | | | | | | | | BUG=60211 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for the extended header parameter syntax in Content-Disposition ↵jshin@chromium.org2010-11-033-24/+204
| | | | | | | | | | | | | | | | | | | | | | header (RFC 5987). It's not generic, but is only used for 'filename' param. The CL is originally by James Simonsen I reviewed at http://codereview.chromium.org/4254001/show I added a check for ASCIIness for RFC 5987 extended header and a few tests to NetUti*.GetFileNameFromCD (net_unittests) and I*.ConvertCo*Norma* (base_unittests). I also replaced '\uxxxx' notation with the corresponding UTF-8 byte sequence because Visual Studio does not understand it yet. BUG=57830 TEST="net_unittests --gtest_filter=NetU*.GetFil*", "base_unittests --gtest_filter=I*.Conver*Norm*" and tests at http://greenbytes.de/tech/tc2231/ Original CL / Review: By James Simonsen; at http://codereview.chromium.org/4254001/show Review URL: http://codereview.chromium.org/4435001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64987 0039d316-1c4b-4281-b951-d872f2087c98
* net: Make Snap Start check cert verification and add metricsagl@chromium.org2010-11-031-0/+11
| | | | | | | | | | | | | | | | This CL causes Snap Start to only trigger if the certificate verification has completed by the time we are ready to send out the handshake message. It also adds a couple of NetLog entries and histograms around the Snap Start code. BUG=none TEST=none http://codereview.chromium.org/4408001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64986 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64960 - Turn on file access checks on Win.rafaelw@chromium.org2010-11-031-8/+0
| | | | | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/4431001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on file access checks on Win.jam@chromium.org2010-11-031-0/+8
| | | | | | | BUG=60211 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move CaseInsensitiveCompare traits into the base namespace.tfarina@chromium.org2010-11-031-2/+2
| | | | | | | | | | | | | | | This should fix conflicts like: 2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope 2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare' Reported-by: Jeff Timanus <twiz@google.com> BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4366001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Cert Manager: merge email certs into other certs tab.mattm@chromium.org2010-11-032-7/+4
| | | | | | | | | BUG=19991 TEST=cert manager no longer has a "people" tab, any certs that were there are now in "other" tab. Review URL: http://codereview.chromium.org/4310004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64866 0039d316-1c4b-4281-b951-d872f2087c98
* A follow-up of r64178.wtc@chromium.org2010-11-021-4/+12
| | | | | | | | | | | | | | | | | | | | Check for TLS 1.1 and TLS 1.2 (not yet supported) version numbers to be future-proof. Avoid a null pointer dereference when SSL client authentication is used with SSL 2.0. This will be removed when we remove SSL 2.0 support. Define the SSL_CONNECTION_VERSION_xxx enum constants separately so we can assert their values are in range at compile time. R=eroman BUG=53659 TEST=none Review URL: http://codereview.chromium.org/4211006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64814 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 2thakis@chromium.org2010-11-021-6/+10
| | | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041 I then did quite a bit of manual editing to fix style issues. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4291001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64798 0039d316-1c4b-4281-b951-d872f2087c98
* Add webp mime type for omniboxfbarchard@chromium.org2010-11-021-1/+3
| | | | | | | | | BUG=61488 TEST=d:\mediatests\still.webp Review URL: http://codereview.chromium.org/4232003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64758 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 03:46:16 +0000